Re: [PATCH 00/86] replace prefixcmp() with has_prefix()

2013-11-17 Thread Christian Couder
From: Jeff King > > On Wed, Nov 13, 2013 at 07:47:03AM +0100, Christian Couder wrote: > >> My preference is: >> >> 1) with an "s" >> 2) "start" >> 3) underscore >> >> so that gives: starts_with() and ends_with() > > FWIW, that looks good to me, too. Whether there is confusion over the > meanin

Re: [RFC PATCH] commit -v: strip diffs and submodule shortlogs from the commit message

2013-11-17 Thread Jeff King
On Sat, Nov 16, 2013 at 07:22:29PM -0500, Eric Sunshine wrote: > > /* Truncate the message just before the diff, if any. */ > > if (verbose) { > > - p = strstr(sb.buf, "\ndiff --git "); > > - if (p != NULL) > > - strbuf_setlen(&sb,

[PATCH v4 2/2] Rename suffixcmp() to ends_with() and invert its result

2013-11-17 Thread Christian Couder
Now ends_with() returns 1 when the suffix is present and 0 otherwise. The old name followed the pattern anything-cmp(), which suggests a general comparison function suitable for e.g. sorting objects. But this was not the case for suffixcmp(). Some popular programming languages have functions or m

[PATCH v4 1/2] builtin/remote: remove postfixcmp() and use suffixcmp() instead

2013-11-17 Thread Christian Couder
Commit 8cc5b290 (git merge -X, 25 Nov 2009) introduced suffixcmp() with nearly the same implementation as postfixcmp() that already existed since commit 211c8968 (Make git-remote a builtin, 29 Feb 2008). The only difference between the two implementations is that, when the string is smaller than t

Re: [RFC PATCH] commit -v: strip diffs and submodule shortlogs from the commit message

2013-11-17 Thread Jeff King
> diff --git a/builtin/commit.c b/builtin/commit.c > index 6ab4605..091a6e7 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -1602,9 +1602,9 @@ int cmd_commit(int argc, const char **argv, const char > *prefix) > > /* Truncate the message just before the diff, if any. */ >

Re: Possibly a bug

2013-11-17 Thread Jeff King
On Sun, Nov 17, 2013 at 04:59:20AM +0200, Jiergir Ogoerg wrote: > As suggested by the git book/tutorial I cloned "simplegit-progit" to > learn using git. > The issue: > git log --since=5.years > yields 2 commits, while > git log --since=6.years > yields 3 commits, despite the "Date" in both cases

Re: Symbolic refs break ref advertisement on 1.8.4.3+

2013-11-17 Thread Jeff King
On Sun, Nov 17, 2013 at 01:39:52AM +1100, Bryan Turner wrote: > Aphrael:example bturner$ for ((i=1;i<21;i++)); do git symbolic-ref > refs/heads/syms/$i refs/heads/master; done > Aphrael:example bturner$ git ls-remote . > fatal: protocol error: impossibly long line > fatal: Could not read from remo

Re: [RFC PATCH] commit -v: strip diffs and submodule shortlogs from the commit message

2013-11-17 Thread Jens Lehmann
Am 17.11.2013 10:09, schrieb Jeff King: > >> diff --git a/builtin/commit.c b/builtin/commit.c >> index 6ab4605..091a6e7 100644 >> --- a/builtin/commit.c >> +++ b/builtin/commit.c >> @@ -1602,9 +1602,9 @@ int cmd_commit(int argc, const char **argv, const char >> *prefix) >> >> /* Truncate the

Git clone from ftp issue

2013-11-17 Thread Zachary Rodriguez
Hello. I am having trouble setting up a git repository on an ftp server. The repository is bare and has had several commits made before being moved to the ftp server. I am attempting to clone from my ftp server, but git fails with the ftp error code 550. Inspection of the ftp packets via wireshark

Git -> fossil bridging?

2013-11-17 Thread Tim Chase
Has there been any development on git<->fossil bridging? I know one can spew fastimports between the two for an initial synchronization, but I'd like to have a continuous bridge; something like git-svn. I have fossil on one machine (mostly a public machine, for bug-tracking, wiki, etc that fossil

Re: Fwd: Error with git-svn pushing a rename

2013-11-17 Thread Andreas Stricker
Hi Jonathan > Can you give an exact sequence of steps (including "Upgrade Subversion > at this step") to reproduce the problem? That would help immensely > --- if at all possible, I would very much like to keep existing > git-svn repos working on upgrade. Of course. I've attached a text file wit

Re: Git -> fossil bridging?

2013-11-17 Thread Tim Chase
On 2013-11-17 14:43, Kyle J. McKay wrote: > Sounds like you want to write a 'git-remote-fossil' helper so you > can do something like: > >git clone fossil::http://sqlite.org/src Pretty much. Or at least something akin to git-svn where one would do git fossil clone http://some.fossil.url/p

[PATCH v3 4/9] test-bzr.sh, test-hg.sh: prepare for change to push.default=simple

2013-11-17 Thread Richard Hansen
Change 'git push ' to 'git push ' in one of the test-bzr.sh tests to ensure that the test continues to pass when the default value of push.default changes to simple. Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- contrib/remote-helpers/test-bzr.sh | 2 +- 1 file changed, 1 ins

[PATCH v3 8/9] test-hg.sh: help user correlate verbose output with email test

2013-11-17 Thread Richard Hansen
It's hard to tell which author conversion test failed when the email addresses look similar. Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- contrib/remote-helpers/test-hg.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contrib/remot

[PATCH v3 7/9] test-hg.sh: fix duplicate content strings in author tests

2013-11-17 Thread Richard Hansen
"beta" was used twice. Change the second copy to "gamma" and increment the remaining content strings. Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- contrib/remote-helpers/test-hg.sh | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/contrib

[PATCH v3 0/9] remote-hg, remote-bzr fixes

2013-11-17 Thread Richard Hansen
A handful of fixes for the git-remote-hg and git-remote-bzr remote helpers and their unit tests. Changes from v2: * changed the author on the following patches to Felipe Contreras: - [2/9] test-lib.sh: convert $TEST_DIRECTORY to an absolute path - [3/9] test-bzr.sh, test-hg.sh: allow run

[PATCH v3 1/9] remote-hg: don't decode UTF-8 paths into Unicode objects

2013-11-17 Thread Richard Hansen
The internal mercurial API expects ordinary 8-bit string objects, not Unicode string objects. With this change, the test-hg.sh unit tests pass again. Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v3 9/9] remote-bzr, remote-hg: fix email address regular expression

2013-11-17 Thread Richard Hansen
Before, strings like "foo@example.com" would be converted to "foo. " when they should be "unknown ". Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- contrib/remote-helpers/git-remote-bzr | 7 +++ contrib/remote-helpers/git-remote-hg | 7 +++ contrib/remote-helpers/t

[PATCH v3 3/9] test-bzr.sh, test-hg.sh: allow running from any dir

2013-11-17 Thread Richard Hansen
From: Felipe Contreras Set TEST_DIRECTORY to the t/ directory (if TEST_DIRECTORY is not already set) so that the user doesn't already have to be in the test directory to run these test scripts. Signed-off-by: Felipe Contreras Based-on-patch-by: Richard Hansen Reviewed-by: Richard Hansen Signe

[PATCH v3 5/9] test-hg.sh: eliminate 'local' bashism

2013-11-17 Thread Richard Hansen
Unlike bash, POSIX shell does not specify a 'local' command for declaring function-local variable scope. Except for IFS, the variable names are not used anywhere else in the script so simply remove the 'local'. For IFS, move the assignment to the 'read' command to prevent it from affecting code o

[PATCH v3 2/9] test-lib.sh: convert $TEST_DIRECTORY to an absolute path

2013-11-17 Thread Richard Hansen
From: Felipe Contreras If $TEST_DIRECTORY is specified in the environment, convert the value to an absolute path to ensure that it remains valid even when 'cd' is used. Signed-off-by: Felipe Contreras Reviewed-by: Richard Hansen Signed-off-by: Richard Hansen --- t/test-lib.sh | 4 1 fil

[PATCH v3 6/9] test-hg.sh: avoid obsolete 'test' syntax

2013-11-17 Thread Richard Hansen
The POSIX spec says that the '-a', '-o', and parentheses operands to the 'test' utility are obsolete extensions due to the potential for ambiguity. Replace '-o' with '|| test' to avoid unspecified behavior. Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- contrib/remote-helpers/

[PATCH v3] remote-bzr: support the new 'force' option

2013-11-17 Thread Richard Hansen
Signed-off-by: Richard Hansen Reviewed-by: Felipe Contreras --- This is a reroll of: http://article.gmane.org/gmane.comp.version-control.git/237699 based on feedback from Felipe: http://article.gmane.org/gmane.comp.version-control.git/237756 This patch is an optional extension to Felipe's "

Re: Git -> fossil bridging?

2013-11-17 Thread Johan Herland
On Mon, Nov 18, 2013 at 1:26 AM, Tim Chase wrote: > On 2013-11-17 14:43, Kyle J. McKay wrote: >> Sounds like you want to write a 'git-remote-fossil' helper so you >> can do something like: >> >>git clone fossil::http://sqlite.org/src > > Pretty much. Or at least something akin to git-svn wher

Re: Problem while cloning a git repo

2013-11-17 Thread ycollette . nospam
When I clone a git repo from github (via https), I've no problems. It looks like that the problem is only related to my "special" repo with big zip commited inside. YC - Mail original - De: "Yann COLLETTE" À: git@vger.kernel.org Envoyé: Jeudi 14 Novembre 2013 09:20:51 Objet: Re: Problem

Re: Add a bugzilla website

2013-11-17 Thread ycollette . nospam
On most linux distro bugzilla website, there are some people dedicated to triaging bugs (finding duplicated bugs, asking for more informations, closing old and / or resolved bugs). To have an efficient bugtracking tool needs to have some people dedicated to this. But for the user, it's a better