Re: [PATCH] bash prompt: add option to disable for a repository

2013-11-26 Thread Thomas Rast
Heikki Hokkanen h...@users.sf.net writes: On Sat, Nov 23, 2013 at 4:42 PM, Johannes Sixt j...@kdbg.org wrote: Gah! This adds a fork+exec each time the prompt is shown. Not good, particularly on Windows. Since your intent is to disable the prompt in the home directory, wouldn't that mean

[PATCH] gitweb: Add an option for adding more branch refs

2013-11-26 Thread Krzesimir Nowak
Overriding an @additional_branch_refs configuration variable with value ('wip') will make gitweb to show branches that appear in refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for gerrit setups where user branches are not stored under refs/heads/. Signed-off-by: Krzesimir

Re: [PATCH] gitweb: Make showing branches configurable

2013-11-26 Thread Krzesimir Nowak
On Mon, 2013-11-25 at 11:32 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: Running 'make GITWEB_WANTED_REFS=heads wip gitweb.cgi' will create a

Re: [PATCHv3] transport: Catch non positive --depth option value

2013-11-26 Thread Andrés G. Aragoneses
On 26/11/13 04:06, Duy Nguyen wrote: On Tue, Nov 26, 2013 at 6:34 AM, Andrés G. Aragoneses kno...@gmail.com wrote: On 22/11/13 02:18, Duy Nguyen wrote: On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano gits...@pobox.com wrote: Have you run the tests with this patch? It seems that it breaks

Re: [PATCHv3] transport: Catch non positive --depth option value

2013-11-26 Thread Duy Nguyen
On Tue, Nov 26, 2013 at 5:43 PM, Andrés G. Aragoneses kno...@gmail.com wrote: On 26/11/13 04:06, Duy Nguyen wrote: On Tue, Nov 26, 2013 at 6:34 AM, Andrés G. Aragoneses kno...@gmail.com wrote: On 22/11/13 02:18, Duy Nguyen wrote: On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano

[PATCHv4] transport: Catch non positive --depth option value

2013-11-26 Thread Andrés G. Aragoneses
From 4f3b24379090b7b69046903fba494f3191577b20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20G=2E=20Aragoneses?= kno...@gmail.com Date: Tue, 26 Nov 2013 12:38:19 +0100 Subject: [PATCH] transport: Catch non positive --depth option value Instead of simply ignoring the value passed to

Re: [PATCH 4/9] contrib: remove git-p4import

2013-11-26 Thread Pete Wyckoff
jrnie...@gmail.com wrote on Mon, 25 Nov 2013 12:58 -0800: The git p4import documentation has suggested git p4 as a better alternative for more than 6 years. (According to the mailing list discussion when it was moved to contrib/, git-p4import has serious bugs --- e.g., its incremental mode

Re: [PATCH v3 04/28] update-server-info: do not publish shallow clones

2013-11-26 Thread Duy Nguyen
On Tue, Nov 26, 2013 at 3:08 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Dumb commit walker does not care about .git/shallow and until someone steps up to make it happen, let's not publish shallow clones using dumb protocols. Signed-off-by:

Re: [PATCH v3 07/28] shallow.c: add remove_reachable_shallow_points()

2013-11-26 Thread Duy Nguyen
On Tue, Nov 26, 2013 at 4:53 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: When we receive a pack and the shallow points from another repository, we may want to add more shallow points to current repo to make sure no commits point to nowhere.

Re: [PATCH v3 08/28] shallow.c: add mark_new_shallow_refs()

2013-11-26 Thread Duy Nguyen
On Tue, Nov 26, 2013 at 5:20 AM, Junio C Hamano gits...@pobox.com wrote: Hmph. the use of -util field in this patch feels that it was something commit-slab data structure was invented to solve. Good stuff! Thanks. + if (c-util == NULL) + c-util = bitmap; +

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread René Scharfe
Am 26.11.2013 01:04, schrieb Nick Townsend: My first git patch - so shout out if I’ve got the etiquette wrong! Or of course if I’ve missed something. Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter),

[PATCH] Prevent buffer overflows when path is too long

2013-11-26 Thread Antoine Pelisse
Some buffers created with PATH_MAX length are not checked when being written, and can overflow if PATH_MAX is not big enough to hold the path. Some of the use-case are probably impossible to reach, and the program dies if the path looks too long. When it would be possible for the user to use a

Re: Git issues with submodules

2013-11-26 Thread Jens Lehmann
Am 25.11.2013 22:01, schrieb Junio C Hamano: Jens Lehmann jens.lehm...@web.de writes: Looking good to me. Please add tests for diff.ignoreSubmodules and submodule.name.ignore, the latter both in .gitmodules and .git/config. While doing some testing for this thread I found an inconsistency

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Jens Lehmann
Am 26.11.2013 16:17, schrieb René Scharfe: Am 26.11.2013 01:04, schrieb Nick Townsend: diff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt index b97aaab..b4df735 100644 --- a/Documentation/git-archive.txt +++ b/Documentation/git-archive.txt @@ -11,6 +11,7 @@ SYNOPSIS

Re: [PATCHv4] transport: Catch non positive --depth option value

2013-11-26 Thread Jonathan Nieder
Hi, Thanks for tackling this. This review will be kind of nitpicky, as a way to save time when reviewing future patches. Andrés G. Aragoneses wrote: From 4f3b24379090b7b69046903fba494f3191577b20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20G=2E=20Aragoneses?= kno...@gmail.com

Re: Git issues with submodules

2013-11-26 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Am 25.11.2013 22:01, schrieb Junio C Hamano: Jens Lehmann jens.lehm...@web.de writes: Looking good to me. Please add tests for diff.ignoreSubmodules and submodule.name.ignore, the latter both in .gitmodules and .git/config. While doing some testing

Re: [PATCH] Prevent buffer overflows when path is too long

2013-11-26 Thread Junio C Hamano
Antoine Pelisse apeli...@gmail.com writes: Some buffers created with PATH_MAX length are not checked when being written, and can overflow if PATH_MAX is not big enough to hold the path. Perhaps it is time to update all of them to use strbuf? The callers of prefix_filename() aren't that many,

Re: Git issues with submodules

2013-11-26 Thread Jonathan Nieder
Junio C Hamano wrote: I have a feeling that the current not copy to fix it to a stable value, but look into .gitmodules as a fallback was not a designed behaviour for the other properties, but was done by accident and/or laziness. It was designed.

Re: [PATCH v3 17/28] Support pushing from a shallow clone

2013-11-26 Thread Eric Sunshine
On Sun, Nov 24, 2013 at 10:55 PM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: Pushing from a shallow clone using today's send-pack and receive-pack may work, if the transferred pack does not end up at any graft points. If it does, recent receive-pack that does connectivity check will reject

[PATCH 8/9 v2] test: replace shebangs with descriptions in shell libraries

2013-11-26 Thread Jonathan Nieder
A #! line in these files is misleading, since these scriptlets are meant to be sourced with '.' (using whatever shell sources them) instead of run directly using the interpreter named on the #! line. Removing the #! line shouldn't hurt syntax highlighting since these files have filenames ending

Re: [PATCH] gitweb: Add an option for adding more branch refs

2013-11-26 Thread Junio C Hamano
Krzesimir Nowak krzesi...@endocode.com writes: Overriding an @additional_branch_refs configuration variable with value ('wip') will make gitweb to show branches that appear in refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for gerrit setups where user branches are not

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Junio C Hamano
René Scharfe l@web.de writes: Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter), though -- that makes commenting on them much easier. Side note: Documentation/SubmittingPatches doesn't mention that

Re: Git issues with submodules

2013-11-26 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Junio C Hamano wrote: I have a feeling that the current not copy to fix it to a stable value, but look into .gitmodules as a fallback was not a designed behaviour for the other properties, but was done by

Re: [PATCHv4] transport: Catch non positive --depth option value

2013-11-26 Thread Junio C Hamano
Andrés G. Aragoneses kno...@gmail.com writes: From 4f3b24379090b7b69046903fba494f3191577b20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20G=2E=20Aragoneses?= kno...@gmail.com Date: Tue, 26 Nov 2013 12:38:19 +0100 Subject: [PATCH] transport: Catch non positive --depth option value

Re: Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Heiko Voigt
Hi, I like where this is going. On Tue, Nov 26, 2013 at 04:17:43PM +0100, René Scharfe wrote: Am 26.11.2013 01:04, schrieb Nick Townsend: + strbuf_addstr(dotgit, work_tree); + strbuf_addch(dotgit, '/'); + if (args-treepath) { +

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread René Scharfe
Am 26.11.2013 23:18, schrieb Junio C Hamano: René Scharfe l@web.de writes: Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter), though -- that makes commenting on them much easier. Side note:

Re: [PATCH v3 27/28] clone: use git protocol for cloning shallow repo locally

2013-11-26 Thread Eric Sunshine
On Sun, Nov 24, 2013 at 10:55 PM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: clone_local() does not handle $SRC/shallow. It could be made so, but it's simpler to use fetch-pack/upload-pack instead. This used by be caught by the check in upload-pack, which is triggered s/used by/used to/

Re: [PATCH v3 15/28] fetch: add --update-shallow to get refs that require updating .git/shallow

2013-11-26 Thread Eric Sunshine
On Sun, Nov 24, 2013 at 10:55 PM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: diff --git a/t/t5536-fetch-shallow.sh b/t/t5536-fetch-shallow.sh index e011ead..95b6313 100755 --- a/t/t5536-fetch-shallow.sh +++ b/t/t5536-fetch-shallow.sh @@ -141,4 +141,26 @@ EOF ) '

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 16:28, René Scharfe l@web.de wrote: Am 26.11.2013 23:18, schrieb Junio C Hamano: René Scharfe l@web.de writes: Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter), though --

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 14:38, Heiko Voigt hvo...@hvoigt.net wrote: Hi, I like where this is going. On Tue, Nov 26, 2013 at 04:17:43PM +0100, René Scharfe wrote: Am 26.11.2013 01:04, schrieb Nick Townsend: + strbuf_addstr(dotgit, work_tree); + strbuf_addch(dotgit, '/');

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 14:18, Junio C Hamano gits...@pobox.com wrote: René Scharfe l@web.de writes: Thanks for the patches! Please send only one per message (the second one as a reply to the first one, or both as replies to a cover letter), though -- that makes commenting on them much

Re: [PATCH] submodule recursion in git-archive

2013-11-26 Thread Nick Townsend
On 26 Nov 2013, at 07:17, René Scharfe l@web.de wrote: Am 26.11.2013 01:04, schrieb Nick Townsend: My first git patch - so shout out if I’ve got the etiquette wrong! Or of course if I’ve missed something. Thanks for the patches! Please send only one per message (the second one as a