Re: [PATCH 00/11] More preparatory work for multiparent tree-walker

2014-02-11 Thread Kirill Smelkov
On Mon, Feb 10, 2014 at 04:28:33PM -0800, Junio C Hamano wrote: > Kirill Smelkov writes: > > > Here I'm preparing tree-diff.c to be ready for the new tree-walker, so that > > the > > final change is tractable and looks good and non noisy. Some small speedups > > are gained along the way. The fin

[PATCH] Introduce experimental remote object access mode

2014-02-11 Thread Shawn Pearce
Make it easy to experiment what remote access to objects would be like if the network ran at say 1 ms round trip latency to obtain any object not on the local repository. $ time git ls-tree -r HEAD real 0m0.059s $ time GIT_RTT=1 git ls-tree -r HEAD real 0m27.283s Yes kids, slowing down l

[PATCH] contrib/diff-highlight: multibyte characters diff

2014-02-11 Thread Yoshihiro Sugi
Signed-off-by: Yoshihiro Sugi diff-highlight split each hunks and compare them as byte sequences. it causes problems when diff hunks include multibyte characters. This change enable to work on such cases by decoding inputs and encoding output as utf8 string. --- contrib/diff-highlight/diff-high

Profiling support?

2014-02-11 Thread David Kastrup
Looking in the Makefile, I just find support for coverage reports using gcov. Whatever is there with "profile" in it seems to be for profile-based compilation rather than using gprof. Now since I've managed to push most of the runtime for basic git-blame operation out of blame.c proper, it becom

Re: Profiling support?

2014-02-11 Thread Duy Nguyen
On Tue, Feb 11, 2014 at 6:17 PM, David Kastrup wrote: > > Looking in the Makefile, I just find support for coverage reports using > gcov. Whatever is there with "profile" in it seems to be for > profile-based compilation rather than using gprof. > > Now since I've managed to push most of the runt

Re: Profiling support?

2014-02-11 Thread David Kastrup
Duy Nguyen writes: > On Tue, Feb 11, 2014 at 6:17 PM, David Kastrup wrote: >> >> Looking in the Makefile, I just find support for coverage reports using >> gcov. Whatever is there with "profile" in it seems to be for >> profile-based compilation rather than using gprof. >> >> Now since I've man

feature request: text=input option in .gitattributes

2014-02-11 Thread Cameron Taggart
After requesting this as https://github.com/msysgit/msysgit/issues/164, I was told to take it upstream, so here I am. I would like a text=input feature added that has the same behavior as text=auto, except that it defaults to core.autocrlf=input behavior instead of core.autocrlf=true. This would e

Re: [PATCH v5 02/14] trailer: process trailers from file and arguments

2014-02-11 Thread Christian Couder
On Mon, Feb 10, 2014 at 9:51 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Many entries with the same key but distinct values can be configured >> using: >> >> if_exists = add_if_different >> if_missing = add >> >> Many entries with the same key but values that can be the same can be

Re: Profiling support?

2014-02-11 Thread John Keeping
On Tue, Feb 11, 2014 at 03:41:55PM +0100, David Kastrup wrote: > Duy Nguyen writes: > > > On Tue, Feb 11, 2014 at 6:17 PM, David Kastrup wrote: > >> > >> Looking in the Makefile, I just find support for coverage reports using > >> gcov. Whatever is there with "profile" in it seems to be for > >

Re: Profiling support?

2014-02-11 Thread David Kastrup
John Keeping writes: > On Tue, Feb 11, 2014 at 03:41:55PM +0100, David Kastrup wrote: >> Duy Nguyen writes: >> >> > Would perf help? No changes required, and almost no overhead, I think. >> >> Not useful. It would be probably nice for nailing down the performance >> gains when the work is fini

Re: [PATCH] fast-import.c: always honor the filename case

2014-02-11 Thread Torsten Bögershausen
On 2014-02-10 15.24, Reuben Hawkins wrote: > > > > On Sun, Feb 9, 2014 at 2:34 PM, Torsten Bögershausen > wrote: > > On 2014-02-06 12 .24, Reuben Hawkins wrote: > [snipped away minor interesting stuff] > > Reading the answers from Peff and Junio, I am convince

git-note -C changes commit type?

2014-02-11 Thread Joachim Breitner
Hi, judging from the documentation I got the impression that I can pass any git object has to "git note -C " and it would stored as-is. But it seems the objects gets mangled somehow... (I want to attach a commit object as a note, to reference the history of a feature before the final cleanup reba

Re: [PATCH v2 1/2] daemon: move daemonize() to libgit.a

2014-02-11 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Feb 11, 2014 at 1:46 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> diff --git a/setup.c b/setup.c >>> index 6c3f85f..b09a412 100644 >>> --- a/setup.c >>> +++ b/setup.c >>> @@ -787,3 +787,27 @@ void sanitize_stdfds(void) >>> if (fd > 2) >>>

Re: [PATCH v5 02/14] trailer: process trailers from file and arguments

2014-02-11 Thread Junio C Hamano
Christian Couder writes: >> Even if we assume, for the sake of discussion, that it *is* a good >> idea to separate "under this condition" part and "do this" part, I >> do not think the above is the only or the best way to express >> "distinct values allowed for the same key". How do we argue tha

Re: [RFH] hackday and GSoC topic suggestions

2014-02-11 Thread Junio C Hamano
Jeff King writes: > - Branch rename breaks local downstream branches >http://article.gmane.org/gmane.comp.version-control.git/241228 If you have a branch B that builds on A, if you are renaming A to C, you may want B to automatically set to build on C in some cases, and in other cases your

Re: [PATCH] bash completion: Add --recurse-submodules

2014-02-11 Thread Junio C Hamano
Keshav Kini writes: > Sup Yut Sum writes: > >> Signed-off-by: Sup Yut Sum >> --- >> contrib/completion/git-completion.bash | 19 ++- >> 1 file changed, 18 insertions(+), 1 deletion(-) > > Aren't you missing a commit message? The title itself is almost sufficient, I would think

Re: [PATCH] Introduce experimental remote object access mode

2014-02-11 Thread Junio C Hamano
Shawn Pearce writes: > Why would you do this? Perhaps you need more time in your day > to consume tea or coffee. Set GIT_RTT and enjoy a beverage. So the conclusion is that it is not practical to do a lazy fetch if it is done extremely naively at "we want this object --- wait a bit and we'll giv

Re: [PATCH] contrib/diff-highlight: multibyte characters diff

2014-02-11 Thread Junio C Hamano
Yoshihiro Sugi writes: > Signed-off-by: Yoshihiro Sugi > > diff-highlight split each hunks and compare them as byte sequences. > it causes problems when diff hunks include multibyte characters. > This change enable to work on such cases by decoding inputs and encoding > output as utf8 string. >

Re: [RFH] hackday and GSoC topic suggestions

2014-02-11 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> - Branch rename breaks local downstream branches >>http://article.gmane.org/gmane.comp.version-control.git/241228 > > If you have a branch B that builds on A, if you are renaming A to C, > you may want B to automatically set to build on C in s

Re: [PATCH] tests: turn on network daemon tests by default

2014-02-11 Thread Junio C Hamano
Jeff King writes: > I dug in the history to see if there was any reasoning given for the > current "off by default" setting. It looks like Junio asked for it when > the original http-push tests were added, and everything else just > followed that. The reasoning there was basically "they're heavyw

Re: [PATCH 00/11] More preparatory work for multiparent tree-walker

2014-02-11 Thread Junio C Hamano
Kirill Smelkov writes: > Sorry for the confusion. Could you please do the following: > > Patches should be applied over to ks/tree-diff-walk > (74aa4a18). Before applying the patches, please cherry-pick > > c90483d9(tree-diff: no need to manually verify that there is no >

Re: [PATCH] tests: turn on network daemon tests by default

2014-02-11 Thread Jeff King
On Tue, Feb 11, 2014 at 11:51:18AM -0800, Junio C Hamano wrote: > Those who run buildfarms may want to disable the networking test if > the buildfarms are not isolated well, for example. They have to be > told somewhere that now they need to explicitly disable these tests > and how. I think they

Re: Profiling support?

2014-02-11 Thread David Kastrup
David Kastrup writes: > John Keeping writes: > >> On Tue, Feb 11, 2014 at 03:41:55PM +0100, David Kastrup wrote: >>> Duy Nguyen writes: >>> >>> > Would perf help? No changes required, and almost no overhead, I think. >>> >>> Not useful. It would be probably nice for nailing down the performan

Re: git-note -C changes commit type?

2014-02-11 Thread Johan Herland
On Tue, Feb 11, 2014 at 6:23 PM, Joachim Breitner wrote: > Hi, > > judging from the documentation I got the impression that I can pass any > git object has to "git note -C " and it would stored as-is. But it > seems the objects gets mangled somehow... ...well... the documentation does not say "an

Re: [PATCH] tests: turn on network daemon tests by default

2014-02-11 Thread Junio C Hamano
Jeff King writes: > On Tue, Feb 11, 2014 at 11:51:18AM -0800, Junio C Hamano wrote: > >> Those who run buildfarms may want to disable the networking test if >> the buildfarms are not isolated well, for example. They have to be >> told somewhere that now they need to explicitly disable these test

Re: git-note -C changes commit type?

2014-02-11 Thread Junio C Hamano
Johan Herland writes: > There is currently no way the "git notes" commands will allow you to > store the 3d7de37 commit object directly as a note. There is also > (AFAICS) no easy workaround (git fast-import could've been a > workaround if it did not already require the first N/notemodify > argum

Make the git codebase thread-safe

2014-02-11 Thread Stefan Zager
We in the chromium project have a keen interest in adding threading to git in the pursuit of performance for lengthy operations (checkout, status, blame, ...). Our motivation comes from hitting some performance walls when working with repositories the size of chromium and blink: https://chromium.

[PATCH] Make the global packed_git variable static to sha1_file.c.

2014-02-11 Thread Stefan Zager
>From b4796d9d99c03b0b7cddd50808a41413e45f1129 Mon Sep 17 00:00:00 2001 From: Stefan Zager Date: Mon, 10 Feb 2014 16:55:12 -0800 Subject: [PATCH] Make the global packed_git variable static to sha1_file.c. This is a first step in making the codebase thread-safe. By and large, the operations which

Re: [PATCH v2 2/2] gc: config option for running --auto in background

2014-02-11 Thread Duy Nguyen
On Tue, Feb 11, 2014 at 2:11 AM, Junio C Hamano wrote: > On Mon, Feb 10, 2014 at 10:43 AM, Junio C Hamano wrote: >>> If --quiet is set, we should not be printing anyway. If not, I thinkg >>> we could only print "auto packing in background.." when we actually >>> can do that, else just print the o

Re: Make the git codebase thread-safe

2014-02-11 Thread Robin H. Johnson
On Tue, Feb 11, 2014 at 05:54:51PM -0800, Stefan Zager wrote: > We in the chromium project have a keen interest in adding threading to > git in the pursuit of performance for lengthy operations (checkout, > status, blame, ...). Our motivation comes from hitting some > performance walls when worki

Re: Make the git codebase thread-safe

2014-02-11 Thread Duy Nguyen
On Wed, Feb 12, 2014 at 8:54 AM, Stefan Zager wrote: > We in the chromium project have a keen interest in adding threading to > git in the pursuit of performance for lengthy operations (checkout, > status, blame, ...). Our motivation comes from hitting some > performance walls when working with r

Re: Make the git codebase thread-safe

2014-02-11 Thread Duy Nguyen
On Wed, Feb 12, 2014 at 9:02 AM, Robin H. Johnson wrote: > On Tue, Feb 11, 2014 at 05:54:51PM -0800, Stefan Zager wrote: >> We in the chromium project have a keen interest in adding threading to >> git in the pursuit of performance for lengthy operations (checkout, >> status, blame, ...). Our mo

Re: git-note -C changes commit type?

2014-02-11 Thread Kyle J. McKay
On Feb 11, 2014, at 16:06, Junio C Hamano wrote: Johan Herland writes: There is currently no way the "git notes" commands will allow you to store the 3d7de37 commit object directly as a note. There is also (AFAICS) no easy workaround (git fast-import could've been a workaround if it did not al

Re: [GIT PULL] l10n updates for 1.9.0 round 2

2014-02-11 Thread Jiang Xin
Hi Junio, Update window is still open? Here is l10n for German for your to pull. The following changes since commit e265f1f7168a262c2f50c68707ff17318ebfdc5a: Merge git://github.com/git-l10n/git-po (2014-02-11 11:02:05 -0800) are available in the git repository at: git://github.com/git-l10

Error compiling git when docbooc2k is custom compiled.

2014-02-11 Thread Mimiko
Hello. I've compiled docbook2x to --prefix=/opt/docbook2X. When building git make fails not finding docbook2x-texi, but /opt/docbook2X/bin is in the PATH. Investigating I've found that default build of docbook2X from sources creates file with the following names: docbook2man docbook2texi So

pack bitmap woes on Windows

2014-02-11 Thread Johannes Sixt
Running test suite of 'next' on Windows fails in t5310-pack-bitmaps with the following symptoms. I haven't followed the topic. Have there been patches floating that addressed the problem in one way or another? (gdb) run Starting program: D:\Src\mingw-git\t\trash directory.t5310-pack-bitmaps/..\..

Re: [PATCH] Make the global packed_git variable static to sha1_file.c.

2014-02-11 Thread Chris Packham
Hi, On 12/02/14 14:57, Stefan Zager wrote: > From b4796d9d99c03b0b7cddd50808a41413e45f1129 Mon Sep 17 00:00:00 2001 > From: Stefan Zager > Date: Mon, 10 Feb 2014 16:55:12 -0800 > Subject: [PATCH] Make the global packed_git variable static to sha1_file.c. > > This is a first step in making the co