[PATCH v2] commit: support commit.verbose and --no-verbose

2014-05-25 Thread Caleb Thompson
Incorporated changes from Duy Nguyen and Jeremiah Mahler. Jeremiah, I didn't make the changes about `-EOF` or `test_expect_success` because I'm guessing that keeping the local style of the code intact is more important than using those. Do you think it makes sense to refactor the rest of the test

Re: [PATCH v2] commit: support commit.verbose and --no-verbose

2014-05-25 Thread Jeremiah Mahler
On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote: ... would be committed at the bottom of the commit message template. Note that this diff output doesn't have its - lines prefixed with '#'. + lines prefixed with '#'. The `commit.verbose` configuration +

Re: [PATCH v2] commit: support commit.verbose and --no-verbose

2014-05-25 Thread Jeremiah Mahler
On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote: Incorporated changes from Duy Nguyen and Jeremiah Mahler. ... +test_expect_success 'commit shows verbose diff with set commit.verbose' ' + echo morecontent file + git add file + test_config commit.verbose true

Re: [PATCH] wording fixes in the user manual and glossary

2014-05-25 Thread Chris Packham
On 25/05/14 15:50, Jeremiah Mahler wrote: Some minor wording fixes in the user manual and glossary. Signed-off-by: Jeremiah Mahler jmmah...@gmail.com --- Documentation/glossary-content.txt | 2 +- Documentation/user-manual.txt | 8 2 files changed, 5 insertions(+), 5

Re: [PATCH] wording fixes in the user manual and glossary

2014-05-25 Thread Jeremiah Mahler
On Sun, May 25, 2014 at 07:56:41PM +1200, Chris Packham wrote: On 25/05/14 15:50, Jeremiah Mahler wrote: Some minor wording fixes in the user manual and glossary. ... -Eventually the developer cloned from will do additional work in her +Eventually the developer will do additional work

Re: [PATCH v10 11/12] Documentation: add documentation for 'git interpret-trailers'

2014-05-25 Thread Christian Couder
From: Michael Haggerty mhag...@alum.mit.edu On 04/25/2014 11:07 PM, Christian Couder wrote: I don't think there is a lot of complexity. But maybe I need to explain how it works better. Feel free to suggest me sentences I could add. I am really excited about having better support for

Re: [PATCH v2] commit: support commit.verbose and --no-verbose

2014-05-25 Thread Duy Nguyen
On Sun, May 25, 2014 at 1:24 PM, Caleb Thompson cjays...@gmail.com wrote: Duy, you were right about `-V`. Do you know of a simple way to add that shortened flag? `OPT_BOOL('v', verbose, ...)` gives me `-v`, `--verbose`, and `--no-verbose`, but no `-V` as a shortened form of `--no-verbose`.

Re: [PATCH v2] commit: support commit.verbose and --no-verbose

2014-05-25 Thread Eric Sunshine
On Sun, May 25, 2014 at 2:24 AM, Caleb Thompson cjays...@gmail.com wrote: Incorporated changes from Duy Nguyen and Jeremiah Mahler. As a courtesy to reviewers, it is helpful to provide a pointer to the previous submission to give context for the new submission. For instance, like this [1]. [1]:

[PATCH] t9138-git-svn-authors-prog.sh fixups

2014-05-25 Thread Jeremiah Mahler
Several fixups of the t9138-git-svn-authors-prog.sh test script to follow current recommendations in t/README. - Fixed a Perl script with a full #!/usr/bin/perl shebang to use write_script() and $PERL_PATH as per t/README. - Placed svn-authors data setup inside a test_expect_success.

K*i*t*c*h*e*n Design Lancashire Reviews

2014-05-25 Thread orakenak
K*i*t*c*h*e*n Design Lancashire. K*i*t*c*h*e*n worked out at about half of what IKEA wanted for their K*i*t*c*h*e*n. -- View this message in context: http://git.661346.n2.nabble.com/K-i-t-c-h-e-n-Design-Lancashire-Reviews-tp7611671.html Sent from the git mailing list archive at Nabble.com. --