Re: BUG: git request-pull broken for plain branches

2014-06-26 Thread Uwe Kleine-König
Hi Junio, On Wed, Jun 25, 2014 at 01:41:23PM -0700, Junio C Hamano wrote: Uwe Kleine-König u.kleine-koe...@pengutronix.de writes: On Wed, Jun 25, 2014 at 05:05:51AM -0700, Linus Torvalds wrote: On Wed, Jun 25, 2014 at 2:55 AM, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote:

Re: [RFC/PATCH V2] branch.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 10:15 AM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: diff --git a/branch.c b/branch.c index 660097b..c9a2a0d 100644 --- a/branch.c +++ b/branch.c @@ -140,33 +140,25 @@ static int setup_tracking(const char *new_ref, const char

Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 12:39 PM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. You may want to mention as a side-note

Re: [RFC/PATCH] notes-util.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 1:24 PM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra

Re: [RFC/PATCH] notes.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 1:36 PM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra

Re: [RFC/PATCH V2] alias.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 7:42 AM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra

Re: [RFC/PATCH] pager.c: replace git_config with git_config_get_string

2014-06-26 Thread Tanay Abhra
On 6/25/2014 9:29 AM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: Use git_config_get_string instead of git_config to take advantage of the config hash-table api which provides a cleaner control flow. Signed-off-by: Tanay Abhra

Re: [PATCH v3 3/3] test-config: add usage examples for non-callback query functions

2014-06-26 Thread Tanay Abhra
Hi, I thought about adding a test*.sh file after sending the series. No worries, I will rectify it in the next patch. Also, I have read all your comments. Thanks for the review. Cheers, Tanay Abhra. On 6/25/2014 4:49 PM, Eric Sunshine wrote: On Mon, Jun 23, 2014 at 6:11 AM, Tanay Abhra

[BUG/RFC] cherry-pick adds newline to last line of file

2014-06-26 Thread Max Kirillov
Hi. If a file does not contain newline in the last line, and the file has changed somewhere in other branch, and the newline has not been not added in that change, when I cherry-pick the commit, the commit does contain the newline in the last line. This sometimes leads to conflict and in general

Re: [PATCH v20 13/48] refs.c: make resolve_ref_unsafe set errno to something meaningful on error

2014-06-26 Thread Karsten Blees
Am 20.06.2014 16:42, schrieb Ronnie Sahlberg: + errno = ELOOP; This fails on MinGW and MSVC 2010. Perhaps add this to compat/mingw.h? #ifndef ELOOP #define ELOOP EMLINK #endif -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

GOOD DAY,

2014-06-26 Thread KONG HUI
My name is Kong Hui from Hong Kong, I want you to be my partner in a business project. If Interested Contact me back via my email address. Thank you, Mr. Kong Hui. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCH (performance tracing)] test git-status performance

2014-06-26 Thread Duy Nguyen
On Wed, Jun 25, 2014 at 5:56 AM, Karsten Blees karsten.bl...@gmail.com wrote: void wt_status_collect(struct wt_status *s) { + uint64_t start = getnanotime(); + wt_status_collect_changes_worktree(s); + trace_performance_since(start, wt_status_collect_changes_worktree);

Is it possible to list unpushed tags without accessing remote?

2014-06-26 Thread Kirill Likhodedov
Hi, is it possible to know which tags are not yet pushed to a remote via a completely local command? (e.g. the list of unpushed _commits_ may be received by ‘git log upstream..’) I know it is possible to execute 'git ls-remote’ or 'git push --dry-run’, but both ask the remote server. I’m

[PATCH] Fix: wrong offset for CET timezone

2014-06-26 Thread Alan Franzoni
From: Alan Franzoni usern...@franzoni.eu Signed-off-by: Alan Franzoni usern...@franzoni.eu --- Documentation/date-formats.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/date-formats.txt b/Documentation/date-formats.txt index ccd1fc8..284308a 100644 ---

Re: [PATCH 4/8] add functions for memory-efficient bitmaps

2014-06-26 Thread Jeff King
On Thu, Jun 26, 2014 at 05:15:05AM +0200, Torsten Bögershausen wrote: + */ +static inline int bitset_sizeof(int num_bits) +{ + return (num_bits + CHAR_BIT - 1) / CHAR_BIT; +} Just a general question about the usage of int here (and at other places): Is there a special reason for new

Re: [PATCH 4/4] replace: add a --raw mode for --edit

2014-06-26 Thread Jeff King
On Wed, Jun 25, 2014 at 03:33:42PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: One of the purposes of git replace --edit is to help a user repair objects which are malformed or corrupted. Usually we pretty-print trees with ls-tree, which is much easier to work with

Re: Is it possible to list unpushed tags without accessing remote?

2014-06-26 Thread Shawn Pearce
On Thu, Jun 26, 2014 at 5:42 AM, Kirill Likhodedov kirill.likhode...@jetbrains.com wrote: is it possible to know which tags are not yet pushed to a remote via a completely local command? (e.g. the list of unpushed _commits_ may be received by ‘git log upstream..’) I know it is possible to

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Matthieu Moy
Ramsay Jones ram...@ramsay1.demon.co.uk writes: Hmm, maybe. The ... take advantage of the new code refers to the possibility (or otherwise) of re-using your work to update these older API functions to the new API style. (also, see Junio's response). I agree that, while caching the usual

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: For the config_cache_free(), would this change be enough? +static void config_cache_free(void) +{ + struct hashmap *config_cache; + struct config_cache_entry *entry; + struct hashmap_iter iter; + if (!hashmap_initialized) +

Re: [RFC/PATCH V2] alias.c: replace git_config with git_config_get_string

2014-06-26 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: the config hash-table api which provides a cleaner control flow. api - API -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: +Querying For Specific Variables +--- + +For programs wanting to query for specific variables in a non-callback +manner, the config API provides two functions `git_config_get_string` +and `git_config_get_string_multi`.They

Re: files deleted with no record?

2014-06-26 Thread Phil Hord
On Mon, Jun 23, 2014 at 9:15 PM, Jeremy Scott jer...@great-scotts.org wrote: I just encountered a situation where a merge was made, with no apparent changes in files (ie no log), but the result was that some files were deleted. person A adds some files person B adds some files from the same

Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-26 Thread Matthieu Moy
Tanay Abhra tanay...@gmail.com writes: + if (!git_config_get_string(imap.user, value)) + server.user = xstrdup(value); + if (!git_config_get_string(imap.pass, value)) + server.pass = xstrdup(value); + if (!git_config_get_string(imap.port, value)) +

Re: Is it possible to list unpushed tags without accessing remote?

2014-06-26 Thread Andreas Schwab
Shawn Pearce spea...@spearce.org writes: On Thu, Jun 26, 2014 at 5:42 AM, Kirill Likhodedov kirill.likhode...@jetbrains.com wrote: is it possible to know which tags are not yet pushed to a remote via a completely local command? (e.g. the list of unpushed _commits_ may be received by ‘git

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: When the submodule script that uses git config -f .gitmodules is converted into C, if the updated config API is ready, it may be able to do something like these in a single program: const char *url; struct config_set *gm_config;

Re: [PATCH v2 4/4] diff: mark any file larger than core.bigfilethreshold binary

2014-06-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Too large files may lead to failure to allocate memory. If it happens here, it could impact quite a few commands that involve diff. Moreover, too large files are inefficient to compare anyway (and most likely non-text), so mark them binary and

Re: [PATCH v2 2/4] fsck: do not die when not enough memory to examine a pack entry

2014-06-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: fsck is a tool that error() is more preferred than die(), but many more preferred without justifying why it is more preferred is not quite a justification, is it? Also, an object failing to load in-core is not a missing object, so if your aim is

Re: [RFC/PATCH] pager.c: replace git_config with git_config_get_string

2014-06-26 Thread Karsten Blees
Am 25.06.2014 05:59, schrieb Eric Sunshine: On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote: [...] /* returns 0 for no pager, 1 for use pager, and -1 for not specified */ int check_pager_config(const char *cmd) { - struct pager_config c; - c.cmd =

Re: [PATCH 6/8] commit: provide a fast multi-tip contains function

2014-06-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: I haven't quite convinced myself that the stale logic in the middle is right. The origin paint_down function checks PARENT1 | PARENT2 to see if we found a merge base (even though PARENT2 may represent many tips). Here I check whether we have _any_ left parent

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: When the submodule script that uses git config -f .gitmodules is converted into C, if the updated config API is ready, it may be able to do something like these in a single program: const char

Re: Is it possible to list unpushed tags without accessing remote?

2014-06-26 Thread Junio C Hamano
Andreas Schwab sch...@linux-m68k.org writes: Shawn Pearce spea...@spearce.org writes: On Thu, Jun 26, 2014 at 5:42 AM, Kirill Likhodedov kirill.likhode...@jetbrains.com wrote: is it possible to know which tags are not yet pushed to a remote via a completely local command? (e.g. the list

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Karsten Blees
Am 26.06.2014 21:00, schrieb Junio C Hamano: Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: When the submodule script that uses git config -f .gitmodules is converted into C, if the updated config API is ready, it may be able to do something like

Re: [PATCH 6/8] commit: provide a fast multi-tip contains function

2014-06-26 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: The only time you can say Ah, we've seen this one and no need to dig further is when you are propagating a colour C and the parent in question is already painted in C (it is OK to be painted as reachable from more tips), I would think, so shouldn't the

Re: Is it possible to list unpushed tags without accessing remote?

2014-06-26 Thread Kirill Likhodedov
On 26 Jun 2014, at 23:04 , Junio C Hamano gits...@pobox.com wrote: Andreas Schwab sch...@linux-m68k.org writes: Not by default, but it is easy to configure your clone to fetch tags to a separate namespace. But then in order to learn what tags the remote has, you need to talk to the

Re: [PATCH 6/8] commit: provide a fast multi-tip contains function

2014-06-26 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: What does it mean to look for branch --with $commit1 $commit2 (i.e. more than one in the Left set)? If we are trying to see which branches reach _both_ of these commits, then replace the ablve with if a commit is already painted as reachable from both

Re: files deleted with no record?

2014-06-26 Thread Philip Oakley
From: Phil Hord phil.h...@gmail.com On Mon, Jun 23, 2014 at 9:15 PM, Jeremy Scott jer...@great-scotts.org wrote: I just encountered a situation where a merge was made, with no apparent changes in files (ie no log), but the result was that some files were deleted. person A adds some files

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-26 Thread Junio C Hamano
David Aguilar dav...@gmail.com writes: 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency on mkdtemp, which is not available on Windows. Use the original temporary directory behavior when mkdtemp fails. This makes the code use mkdtemp when available and gracefully fallback to

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-26 Thread Junio C Hamano
David Aguilar dav...@gmail.com writes: 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency on mkdtemp, which is not available on Windows. Use the original temporary directory behavior when mkdtemp fails. This makes the code use mkdtemp when available and gracefully fallback to

Re: files deleted with no record?

2014-06-26 Thread Jeremy Scott
Hi. Thanks for getting back to me. here is a screenshot from source tree to visualise the scenario: https://drive.google.com/file/d/0B-Wn7DfHsuhyTEVkRHAzeGVZelpMWjFxZW1kbVBKVlNab3pR/edit?usp=sharing I will attempt a script to reproduce this later today. Thanks On Fri, Jun 27, 2014 at 5:53 AM,

Re: files deleted with no record?

2014-06-26 Thread Jeremy Scott
we're all using source tree. I'm really interested to try and reproduce this so I'll find some time today to do it. Thanks again On Fri, Jun 27, 2014 at 6:56 AM, Jeremy Scott jer...@great-scotts.org wrote: Hi. Thanks for getting back to me. here is a screenshot from source tree to visualise

Re: [PATCH v3 2/3] config: add hashtable for config parsing retrieval

2014-06-26 Thread Junio C Hamano
Karsten Blees karsten.bl...@gmail.com writes: Because I had an experience under my belt of a painful refactoring of the_index which turned out to be not just a single array, I simply suspect that the final data structure to represent a set of config-like things will not be just a single

What's cooking in git.git (Jun 2014, #06; Thu, 26)

2014-06-26 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. Fixes accumulated on the 'master' front made into 2.0.1. The topics in flight continue to separate into two distinct layers (i.e.

Re: [PATCH] Fix: wrong offset for CET timezone

2014-06-26 Thread Robin Rosenberg
- Ursprungligt meddelande - Från: Alan Franzoni mail...@franzoni.eu Till: git@vger.kernel.org Kopia: Alan Franzoni usern...@franzoni.eu Skickat: torsdag, 26 jun 2014 15:53:32 Ämne: [PATCH] Fix: wrong offset for CET timezone From: Alan Franzoni usern...@franzoni.eu

Re: [RFC/PATCH] imap-send.c: replace git_config with git_config_get_string

2014-06-26 Thread Karsten Blees
Am 26.06.2014 18:50, schrieb Matthieu Moy: Tanay Abhra tanay...@gmail.com writes: +if (!git_config_get_string(imap.user, value)) +server.user = xstrdup(value); +if (!git_config_get_string(imap.pass, value)) +server.pass = xstrdup(value); +if

Re: [PATCH] gitk: catch mkdtemp errors

2014-06-26 Thread David Aguilar
On Thu, Jun 26, 2014 at 01:42:04PM -0700, Junio C Hamano wrote: David Aguilar dav...@gmail.com writes: 105b5d3fbb1c00bb0aeaf9d3e0fbe26a7b1993fc introduced a dependency on mkdtemp, which is not available on Windows. Use the original temporary directory behavior when mkdtemp fails. This

How to populate index/worktree when recursive merge merges multiple common ancestors?

2014-06-26 Thread Christian Halstrick
Imagine git does a recursive merge between A and B and finds multiple common ancestors X1,X2 for these commits. - Does git try to create an implicit/temporary common ancestor X3 by merging X1 and X2? - How should workingtree, index (stage1,2,3) look like if during that merge of common ancestors a