Re: [PATCH 1/3] fdopen_lock_file(): access a lockfile using stdio

2014-10-12 Thread Michael Haggerty
Sorry, I see I never responded to this email. On 10/02/2014 11:29 AM, Torsten Bögershausen wrote: On 01.10.14 13:14, Michael Haggerty wrote: [] Nice done, small comments inline diff --git a/lockfile.c b/lockfile.c index d27e61c..e046027 100644 --- a/lockfile.c +++ b/lockfile.c @@ -7,20

[PATCH v2] Handle atexit list internaly fo unthreaded builds

2014-10-12 Thread Etienne Buira
Replace atexit()s calls with cmd_atexit that is atexit() on threaded builds, but handles the callbacks list internally for unthreaded builds. This is needed because on unthreaded builds, asyncs inherits parent's atexit() list, that gets run as soon as the async exit()s (and again at the end of

Re: [PATCH RFC] git-am: support any number of signatures

2014-10-12 Thread Christian Couder
On Sun, Sep 28, 2014 at 9:32 PM, Junio C Hamano gits...@pobox.com wrote: Christian Couder chrisc...@tuxfamily.org writes: From: Junio C Hamano gits...@pobox.com If that is what happens, it is not a workable workaround to set Sob to addIfDifferent only for this invocation. Setting S-o-b to

Re: $GIT_DIR/info/exclude fails to negate a pattern defined by core.excludesfile

2014-10-12 Thread Dun Peal
I used `check-ignore -v`, and the `.out` file is being ignored by the `*.out` pattern in the `core.excludesfile` file. Its parent folder is not being ignored. So as a rule, `core.excludesfile` overrides `$GIT_DIR/info/exclude`. That doesn't make much sense to me, because I'm much more likely to

Re: [PATCH] git-imap-send: use libcurl for implementation

2014-10-12 Thread Bernhard Reiter
Sorry for not getting back to this any sooner, I've been pretty busy recently with Other Projects(tm). Am 2014-08-27 um 19:20 schrieb Junio C Hamano: Bernhard Reiter ock...@raz.or.at writes: [...] For now, the old ones are wrapped in #ifdefs, and the new functions are enabled by make if

Re: [RFC/PATCH] fsck: do not canonicalize modes in trees we are checking

2014-10-12 Thread Ben Aveling
Hi, A question about fsck - is there a reason it doesn't have an option to delete bad objects? Regards, Ben On 24/09/2014 02:30, Jeff King wrote: [-cc Kirill, as his address seem out-of-date] On Tue, Sep 23, 2014 at 04:23:43PM +, Edward Thomson wrote: On Tue, Sep 23, 2014 at

Re: $GIT_DIR/info/exclude fails to negate a pattern defined by core.excludesfile

2014-10-12 Thread Duy Nguyen
On Sun, Oct 12, 2014 at 9:58 AM, Dun Peal dunpea...@gmail.com wrote: I have the pattern `*.out` defined in my `core.excludesfile`. According to the documentation[1], patterns defined in `$GIT_DIR/info/exclude` take precedence over `core.excludesfile`, so for one particular project that needs

Re: [PATCH v2] Handle atexit list internaly fo unthreaded builds

2014-10-12 Thread Duy Nguyen
On Sun, Oct 12, 2014 at 4:09 PM, Etienne Buira etienne.bu...@gmail.com wrote: Replace atexit()s calls with cmd_atexit that is atexit() on threaded builds, but handles the callbacks list internally for unthreaded builds. Maybe hide this in git-compat-util.h and #define atexit(x) cmd_atexit(x)?

Re: [PATCH RFC] git-am: support any number of signatures

2014-10-12 Thread Christian Couder
On Sun, Oct 12, 2014 at 11:36 AM, Christian Couder christian.cou...@gmail.com wrote: With v16 you can easily choose if you want to have the S-o-b in the output or not, when there is already one, ... By the way, I sent v16 just before the above email, but the series still hasn't hit the mailing