RE: IT-HELPDESK

2014-11-22 Thread Callan, Paul
This Is To Inform All Web-mail Account Users, That The Web-mail Admin Is Currently Congested, So We Are Deleting Inactive Accounts. Please Notify That This Account Is Active By Verifying It Below CLICK HERE ©2014 Web-mail portal Veri

Re: [PATCHv2] add: ignore only ignored files

2014-11-22 Thread Torsten Bögershausen
On 2014-11-22 20.19, Jeff King wrote: > On Sat, Nov 22, 2014 at 03:59:12PM +0100, Torsten Bögershausen wrote: > +test_expect_success 'error out when attempting to add ignored ones but add others' ' + touch a.if && + test_must_fail git add a.?? && + ! (git ls-files | gr

Re: [PATCH 6/6] prune_remote(): iterate using for_each_string_list_item()

2014-11-22 Thread Jonathan Nieder
Michael Haggerty wrote: > Signed-off-by: Michael Haggerty > --- > builtin/remote.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) Reviewed-by: Jonathan Nieder (That makes 6/6. :)) Thanks for your thoughtfulness in putting these together. They were pleasant to read. -

Re: [PATCH 5/6] prune_remote(): rename local variable

2014-11-22 Thread Jonathan Nieder
Michael Haggerty wrote: > Signed-off-by: Michael Haggerty > --- > builtin/remote.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kern

Re: [PATCH 4/6] repack_without_refs(): make the refnames argument a string_list

2014-11-22 Thread Jonathan Nieder
Michael Haggerty wrote: > All of the callers have string_lists available already Technically ref_transaction_commit doesn't, but that doesn't matter. > Suggested-by: Ronnie Sahlberg > Signed-off-by: Michael Haggerty > --- > builtin/remote.c | 14 ++ > refs.c | 38 +++

Re: [PATCH 3/6] prune_remote(): sort delete_refs_list references en masse

2014-11-22 Thread Jonathan Nieder
Michael Haggerty wrote: > Signed-off-by: Michael Haggerty > --- > builtin/remote.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This and 2/6 are also Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord.

Re: [PATCH 1/6] prune_remote(): exit early if there are no stale references

2014-11-22 Thread Jonathan Nieder
Michael Haggerty wrote: > Aside from making the logic clearer, this avoids a call to > warn_dangling_symrefs(), which always does a for_each_rawref() > iteration. > > Signed-off-by: Michael Haggerty > --- > builtin/remote.c | 39 +-- > 1 file changed, 21 inser

Re: How safe are signed git tags? Only as safe as SHA-1 or somehow safer?

2014-11-22 Thread Jeff King
On Fri, Nov 21, 2014 at 06:32:46PM -0500, Jason Pyeron wrote: > The whole issue is a lot better than this makes it sound. Yes it is > just a SHA1 hash, but it is a hash of a structured data format. > > You have very observable parts of that well structured data providede to the > hash. Yeah, I

Re: How safe are signed git tags? Only as safe as SHA-1 or somehow safer?

2014-11-22 Thread Jeff King
On Fri, Nov 21, 2014 at 11:01:26PM +, Patrick Schleizer wrote: > > Yes, it is only as "safe as SHA-1" in the sense that you have GPG-signed > > only a SHA-1 hash. If somebody can find a collision with a hash you have > > signed, they can substitute the colliding data for the data you signed. >

Re: [PATCHv2] add: ignore only ignored files

2014-11-22 Thread Jeff King
On Sat, Nov 22, 2014 at 03:59:12PM +0100, Torsten Bögershausen wrote: > >> +test_expect_success 'error out when attempting to add ignored ones but > >> add others' ' > >> + touch a.if && > >> + test_must_fail git add a.?? && > >> + ! (git ls-files | grep "\\.ig") && > >> + (git ls-files | gre

Re: [PATCH] notes: accept any ref for merge

2014-11-22 Thread Kyle J. McKay
I see this patch has not been picked up. I would like to lobby for inclusion of this patch. On Sep 19, 2014, at 11:22, Junio C Hamano wrote: > Johan Herland writes: > >> On Fri, Sep 19, 2014 at 11:39 AM, Jeff King wrote: >>> On Fri, Sep 19, 2014 at 09:39:45AM +0200, Scott Chacon wrote: Th

recent cygwin breakage

2014-11-22 Thread Ramsay Jones
Hi Junio, Just a quick heads-up on a recent cygwin breakage. I updated my (64-bit) cygwin installation yesterday and (along with many other packages) I noticed a new version of gcc (and presumably libc) was installed (gcc v4.8.3-5 x86-64). Unfortunately, this caused new warning to be issued when

Re: [PATCHv2] add: ignore only ignored files

2014-11-22 Thread Torsten Bögershausen
>> +test_expect_success 'error out when attempting to add ignored ones but add >> others' ' >> +touch a.if && >> +test_must_fail git add a.?? && >> +! (git ls-files | grep "\\.ig") && >> +(git ls-files | grep a.if) >> +' > > I am somewhat allergic to pipes in our test suite, becau