[PATCH 1/5] t2004: modernize style

2014-12-24 Thread Eric Sunshine
In particular: * indent test body * place test description on same line as test_expect_* * place closing quote on its own line * name output file actual rather than out * name setup test setup rather than preparation Signed-off-by: Eric Sunshine sunsh...@sunshineco.com ---

[PATCH 0/5] resolve checkout-index --temp path mangling

2014-12-24 Thread Eric Sunshine
This patch series fixes a path mangling bug in checkout-index --temp reported by Russ Cox[1]. As a bonus, it also squashes a bug in which checkout-index was accessing and printing memory beyond end-of-string. [1]: http://thread.gmane.org/gmane.comp.version-control.git/261739 Eric Sunshine (5):

[PATCH 4/5] t2004: demonstrate broken relative path printing

2014-12-24 Thread Eric Sunshine
checkout-index --temp only properly prints relative paths which are descendants of the current directory. Paths in ancestor or sibling directories (or their children) are often printed in mangled form. For example: mkdir a bbb file bbb/file git update-index --add file bbb/file

[PATCH 5/5] checkout-index: fix --temp relative path mangling

2014-12-24 Thread Eric Sunshine
checkout-index --temp only properly prints relative paths which are descendants of the current directory. Paths in ancestor or sibling directories (or their children) are often printed in mangled form. For example: mkdir a bbb file bbb/file git update-index --add file bbb/file

[PATCH 3/5] t2004: standardize file naming in symlink test

2014-12-24 Thread Eric Sunshine
Update symlink test to use the common file naming scheme so that its temporary files can be cleaned up by the rm -f path* idiom employed by other tests in this script. Signed-off-by: Eric Sunshine sunsh...@sunshineco.com --- t/t2004-checkout-cache-temp.sh | 6 +++--- 1 file changed, 3

[PATCH 2/5] t2004: drop unnecessary write-tree/read-tree

2014-12-24 Thread Eric Sunshine
Unlike earlier tests which reference several trees prepared by setup, no other tests utilize the tree from the symlink test, so there is no need to write it (or read it back immediately). Signed-off-by: Eric Sunshine sunsh...@sunshineco.com --- t/t2004-checkout-cache-temp.sh | 3 --- 1 file

Stash save exits with 0 when nothing to stash

2014-12-24 Thread Pascal Malaise
Hi, When calling git stash save in a clean situation (no change since last commit), git-stash reports No local changes to save, which is OK. But it exits with code 0, despite no stash has been saved. It would be better to exit with code 1 in this case. N.B. In a similar situation git commit -a

[PATCH 5/5] engine.pl: provide more debug print statements

2014-12-24 Thread Philip Oakley
Assist developers transitioning between the two cultures by including appropriate, but commented out, debug statements. This acts as a poor man's --verbose option. The test suite doesn't cover the contrib/buildsystems (or Msysgit's msvc-build) contributions so fails to notice breakages there-in.

[PATCH 4/5] vcbuild/readme: Improve layout and reference msvc-build script

2014-12-24 Thread Philip Oakley
Layout the 'either/or' with more white space to clarify which alternatives are matched up. Reference the Msysgit build script which automates one sequence of options. Signed-off-by: Philip Oakley philipoak...@iee.org --- compat/vcbuild/README | 27 +++ 1 file changed, 19

[PATCH 1/5] engine.pl: Fix i18n -o option in msvc buildsystem generator

2014-12-24 Thread Philip Oakley
The i18n 5e9637c (i18n: add infrastructure for translating Git with gettext, 2011-11-18) introduced an extra '-o' option into the make file, which broke engine.pl code for extracting the git.sln for msvc gui-IDE. Add tests to remove these non linker options, in same vein as 74cf9bd (engine.pl:

[PATCH 2/5] engine.pl: Properly accept quoted spaces in filenames

2014-12-24 Thread Philip Oakley
The engine.pl script barfs on the properly quoted spaces in filename options prevalent on Windows. Use shellwords() rather than split() to separate such options. Signed-off-by: Philip Oakley philipoak...@iee.org --- contrib/buildsystems/engine.pl | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 0/5] Fix the Visual Studio 2008 .sln generator

2014-12-24 Thread Philip Oakley
Potential Windows developers are likely to be using Visual Studio as their IDE. The tool stack required for Windows can be tortuous as it crosses the boundaries between platforms and philosophies. This patch series seeks to maintain the tools that could assist such developers. In particular, those

[PATCH 3/5] engine.pl: ignore invalidcontinue.obj which is known to MSVC

2014-12-24 Thread Philip Oakley
Commit 4b623d8 (MSVC: link in invalidcontinue.obj for better POSIX compatibility, 2014-03-29) is not processed correctly by the buildsystem. Ignore it. Also split the .o and .obj processing; 'make' does not produce .obj files. Only substitute filenames ending with .o when generating the source .c

Cygwin sparse checkout degrades performance

2014-12-24 Thread Brian Ericson
Counter-intuitively, using sparse checkout in Cygwin degrades status times as status appears to stat non-existent files and directories. To demonstrate, I created a repo with 100k random files in a dir/dir/dir/file structure (on a linux box -- to do this in Cygwin requires piping the result

Re: Cygwin sparse checkout degrades performance

2014-12-24 Thread Brian Ericson
Huh. The graphs (somehow) ended up incoherently reformatted... Sorry about that! Here's the raw data after a second run: Linux: 10 0.49 9 0.27 8 0.27 7 0.28 6 0.23 5 0.21 4 0.21 3 0.19 2 0.19 1 0.16 1 0.14 Cygwin: 10 4.72 9 4.28

Re: [PATCH v6 1/1] http: Add Accept-Language header if possible

2014-12-24 Thread Eric Sunshine
On Mon, Dec 22, 2014 at 11:44 AM, Yi EungJun semtlen...@gmail.com wrote: From: Yi EungJun eungjun...@navercorp.com Add an Accept-Language header which indicates the user's preferred languages defined by $LANGUAGE, $LC_ALL, $LC_MESSAGES and $LANG. Examples: LANGUAGE= - LANGUAGE=ko:en -

Upgrade Git in openSUSE13.1

2014-12-24 Thread Arup Rakshit
Hi, I am keep getting the below warning, whenever I am trying to deploy my code there : [arup@to_do_app]$ heroku logs -t Your version of git is 1.8.4.5. Which has serious security vulnerabilities. More information here:

Re: [PATCH v3 2/4] rev-list: add an option to mark fewer edges as uninteresting

2014-12-24 Thread brian m. carlson
On Tue, Dec 23, 2014 at 01:51:42PM -0500, Jeff King wrote: On Tue, Dec 23, 2014 at 12:55:48PM -0500, Michael Blume wrote: This patch causes an error on my mac, test 5500 fetch-pack errors on part 44 - fetch creating new shallow root. It looks for remote: Total 1 in the fetch output and

Re: [PATCH v3 0/4] Improve push performance with lots of refs

2014-12-24 Thread brian m. carlson
On Tue, Dec 23, 2014 at 10:40:54AM -0800, Junio C Hamano wrote: You spell --thin-aggressive as two words, --thin --shallow, in this series, essentially, no? Essentially, yes. It became obligatory after I noticed the test failure, since that test actually checks whether the remote side sends a

[PATCH v4 0/3] Improve push performance with lots of refs

2014-12-24 Thread brian m. carlson
This series contains patches to address a significant push performance regression in repositories with large amounts of refs. It avoids performing expensive edge marking unless the repository is shallow. The first patch in the series is a fix for a minor typo I discovered when editing the

[PATCH v4 2/3] rev-list: add an option to mark fewer edges as uninteresting

2014-12-24 Thread brian m. carlson
In commit fbd4a70 (list-objects: mark more commits as edges in mark_edges_uninteresting - 2013-08-16), we marked an increasing number of edges uninteresting. This change, and the subsequent change to make this conditional on --objects-edge, are used by --thin to make much smaller packs for

[PATCH v4 3/3] pack-objects: use --objects-edge-aggressive for shallow repos

2014-12-24 Thread brian m. carlson
When fetching into or pushing from a shallow repository, we want to aggressively mark edges as uninteresting, since this decreases the pack size. However, aggressively marking edges can negatively affect performance on large non-shallow repositories with lots of refs. Teach pack-objects a

[PATCH v4 1/3] Documentation: add missing article in rev-list-options.txt

2014-12-24 Thread brian m. carlson
Add the missing article a. Signed-off-by: brian m. carlson sand...@crustytoothpaste.net --- Documentation/rev-list-options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt index afccfdc..2277fcb

Re: Supporting a few more usecases with remote helpers

2014-12-24 Thread Mike Hommey
On Mon, Dec 22, 2014 at 10:07:26AM +0900, Mike Hommey wrote: Hi, As you may or may not know, I'm working on a remote-helper to interact with mercurial servers, with the main focus being to make it work with developer workflows at Mozilla. I think remote-helpers, in the context of non-git

Re: Upgrade Git in openSUSE13.1

2014-12-24 Thread Yue Lin Ho
go https://msysgit.github.io/ -- View this message in context: http://git.661346.n2.nabble.com/Upgrade-Git-in-openSUSE13-1-tp7623397p7623405.html Sent from the git mailing list archive at Nabble.com. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: Upgrade Git in openSUSE13.1

2014-12-24 Thread Yue Lin Ho
or http://sourceforge.net/projects/git-osx-installer/files/ for OS X users see https://blog.heroku.com/archives/2014/12/24/update_your_git_clients_on_windows_and_os_x -- View this message in context: http://git.661346.n2.nabble.com/Upgrade-Git-in-openSUSE13-1-tp7623397p7623406.html Sent

Re: Upgrade Git in openSUSE13.1

2014-12-24 Thread Duy Nguyen
On Thu, Dec 25, 2014 at 3:02 AM, Arup Rakshit arupraks...@rocketmail.com wrote: Hi, I am keep getting the below warning, whenever I am trying to deploy my code there : [arup@to_do_app]$ heroku logs -t Your version of git is 1.8.4.5. Which has serious security vulnerabilities. More