Now update_ref (via write_pseudoref) does almost exactly what
write_cherry_pick_head did, so we can remove write_cherry_pick_head
and just use update_ref.
Signed-off-by: David Turner
---
sequencer.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/sequ
Instead of manually writing a pseudoref (in one case) and shelling out
to git update-ref (in another), use the update_ref function. This
is much simpler.
Signed-off-by: David Turner
---
bisect.c | 37 -
1 file changed, 8 insertions(+), 29 deletions(-)
diff -
Pseudorefs should not be updated through the ref transaction
API, because alternate ref backends still need to store pseudorefs
in GIT_DIR (instead of wherever they store refs). Instead,
change update_ref and delete_ref to call pseudoref-specific
functions.
Signed-off-by: David Turner
---
refs.
Add a function ref_type, which categorizes refs as per-worktree,
pseudoref, or normal ref.
Later, we will use this in refs.c to treat pseudorefs specially.
Alternate ref backends may use it to treat both pseudorefs and
per-worktree refs differently.
Signed-off-by: David Turner
---
refs.c | 26 +
Add glossary entries for both concepts.
Pseudorefs and per-worktree refs do not yet have special handling,
because the files refs backend already handles them correctly. Later,
we will make the LMDB backend call out to the files backend to handle
per-worktree refs.
Signed-off-by: David Turner
-
On Thu, 2015-07-30 at 19:30 -0400, David Turner wrote:
> On Thu, 2015-07-30 at 21:09 +0700, Duy Nguyen wrote:
> > On Thu, Jul 30, 2015 at 9:32 AM, David Turner
> > wrote:
> > > I'm looking at dir.c, and there's a bit I'm confused about:
> > >
> > > prep_exclude() says:
> > >
Dear Professor
Our colleagues has just published two very nice web pages with information for
the indexing and feedback from our WSEAS conferences and Journals
http://www.worldses.org/journals and http://www.wseas.us
For example, visit
http://www.worldses.org/journals/#feedback
The contents o
Eric Sunshine writes:
> On Wed, Jul 29, 2015 at 11:51 AM, Patrick Steinhardt wrote:
>> Test behavior of `git clone` when working with an empty path
>> component. This may be the case when cloning a file system's root
>> directory or from a remote server's root.
>>
>> Signed-off-by: Patrick Stein
Signed-off-by: Stefan Beller
---
So I was trying to understand how to implement "git add .gitmodules" as
I intend to rewrite git submodules in C.
builtin/add.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/builtin/add.c b/builtin/add.c
index 4bd98b7..b2a5c57 100644
--- a/builtin/add.c
+
On Thu, 2015-07-30 at 21:09 +0700, Duy Nguyen wrote:
> On Thu, Jul 30, 2015 at 9:32 AM, David Turner
> wrote:
> > I'm looking at dir.c, and there's a bit I'm confused about:
> >
> > prep_exclude() says:
> > /*
> > * .. and .gitignore does not exist befor
On Thu, Jul 30, 2015 at 04:17:35PM -0400, Eric Sunshine wrote:
> > + test_expect_success "Override hiding of $configsection.hiderefs" '
> > + test_when_finished "test_unconfig $configsection.hiderefs"
> > &&
> > + git config --add $configsection.hiderefs refs/tag
Thanks, queued.
By the way, do you plan to revisit two rather large-ish stalled
topics of yours queued on 'pu' any time soon?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/major
Matthieu Moy writes:
> The previous code broke for example
>
> git pull --upload-pack 'echo --foo'
>
> Reported-by: Joey Hess
> Fix-suggested-by: Junio C Hamano
> Signed-off-by: Matthieu Moy
> ---
> Junio wrote:
>> ${upload_pack+"$upload_pack"} or something.
>
> Indeed, we need to pass nothi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The previous code broke for example
git pull --upload-pack 'echo --foo'
Reported-by: Joey Hess
Fix-suggested-by: Junio C Hamano
Signed-off-by: Matthieu Moy
---
Junio wrote:
> ${upload_pack+"$upload_pack"} or something.
Indeed, we need to pass nothing, not the empty string if $upload_pack
is
On Tue, Jul 28, 2015 at 3:59 PM, Jeff King wrote:
> If you hide a hierarchy of refs using the transfer.hideRefs
> config, there is no way to later override that config to
> "unhide" it. This patch implements a "negative" hide which
> causes matches to immediately be marked as unhidden, even if
> a
On Thu, Jul 30, 2015 at 11:31 AM, Joey Hess wrote:
> I think this comes down to a lack of quoting where git-pull runs
> git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6,
> "$@" was passed through to git-fetch, but now there is a $upload_pack
> which is passed without being quoted.
Yes,
I think this comes down to a lack of quoting where git-pull runs
git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6,
"$@" was passed through to git-fetch, but now there is a $upload_pack
which is passed without being quoted.
--
see shy jo
signature.asc
Description: Digital signature
On Wed, Jul 29, 2015 at 11:51 AM, Patrick Steinhardt wrote:
> Test behavior of `git clone` when working with an empty path
> component. This may be the case when cloning a file system's root
> directory or from a remote server's root.
>
> Signed-off-by: Patrick Steinhardt
> ---
> diff --git a/t/t
On Thu, Jul 30, 2015 at 11:48 AM, Karthik Nayak wrote:
> Add a new atom "padright" and support %(padright:X) where X is a
> number. This will align the succeeding atom or string to the left
> followed by spaces for a total length of X characters. If X is less
> than the atom or string length then
Joey Hess writes:
> In git 2.1.4, I can run: git pull --upload-pack 'echo --foo'
>
> This also seems to work in 2.4.6, but in 2.5.0, the option parser
> does something weird, apparently looking inside the quoted parameter
> and parsing parameters in there:
>
> error: unknown option `foo'
> usage:
Junio C Hamano writes:
> Well, but there is the above "or we may not" ;-)
>
>> But actually you are right, currently I still have the old logic
>> in place that splits on colons in the path component.
>
> Yes. The reason why I suggested the simple route was exactly
> because I noticed that you
Patrick Steinhardt writes:
>> Regardless of the issue you are trying to address, we may want to
>> limit that "be prepared for and careful with ':'" logic in the
>> existing code to the case where the "last component" does not have
>> any other component before it. That is:
>>
>> http://ex
Johan Herland writes:
>> Actually, the name "linked worktree" is probably a misnomer.
>> ...
> Makes sense, although currently, IINM, those multiple $GIT_DIRs must
> be associated with strictly different branches, which is completely
> unrelated to the desired notes-merge restriction (which appli
Jacob Keller writes:
> On Wed, Jul 29, 2015 at 2:30 PM, Matthieu Moy
> wrote:
>> Eric Sunshine writes:
>>
>>> Also, please explain here and in the commit message why this highly
>>> specialized colorizer ('colornext'), is needed even though a more
>>> general purpose one ('color') is already av
This is update 6 :D
--
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello All,
As part of GSoC I'm working on the Unification of 'for-each-ref', 'tag -l'
and 'branch -l'.
Current Progress:
1. Building ref-filter.{c,h} from for-each-ref.
This is the process of creating an initial library for the unification
by moving most of the code from for-each-ref to ref-filt
From: Karthik Nayak
Since 'ref-filter' only has an option to match path names add an
option for plain fnmatch pattern-matching.
This is to support the pattern matching options which are used in `git
tag -l` and `git branch -l` where we can match patterns like `git tag
-l foo*` which would match
From: Karthik Nayak
Using 'ref-filter' APIs implement the '--merged' and '--no-merged'
options into 'tag.c'. The '--merged' option lets the user to only
list tags merged into the named commit. The '--no-merged' option
lets the user to only list tags not merged into the named commit.
If no object
From: Karthik Nayak
Implement the '--format' option provided by 'ref-filter'.
This lets the user list tags as per desired format similar
to the implementation in 'git for-each-ref'.
Add tests and documentation for the same.
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-off-by
Hello,
I send my v7 patch series as a reply to the v6 series by mistake, Have
sent it again as reply to [Patch v7 00/11]. Please ignore the v6
series.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
From: Karthik Nayak
Make 'tag.c' use 'ref-filter' APIs for iterating through refs, sorting
and printing of refs. This removes most of the code used in 'tag.c'
replacing it with calls to the 'ref-filter' library.
Make 'tag.c' use the 'filter_refs()' function provided by 'ref-filter'
to filter out
From: Karthik Nayak
Make 'tag.c' use 'ref-filter' data structures and make changes to
support the new data structures. This is a part of the process
of porting 'tag.c' to use 'ref-filter' APIs.
This is a temporary step before porting 'tag.c' to use 'ref-filter'
completely. As this is a temporary
From: Karthik Nayak
Add a functions called 'for_each_tag_ref_fullpath()' to refs.{c,h}
which iterates through each tag ref without trimming the path.
Add an option in 'filter_refs()' to use 'for_each_tag_ref_fullpath()'
and filter refs. This type checking is done by adding a
'FILTER_REFS_TAGS' i
Add a new atom "padright" and support %(padright:X) where X is a
number. This will align the succeeding atom or string to the left
followed by spaces for a total length of X characters. If X is less
than the atom or string length then no padding is done.
Add tests and documentation for the same.
From: Karthik Nayak
Add support to sort by version using the "v:refname" and
"version:refname" option. This is achieved by using the 'versioncmp()'
function as the comparing function for qsort.
This option is included to support sorting by versions in `git tag -l`
which will eventaully be ported
From: Karthik Nayak
Since 'ref-filter' only has an option to match path names add an
option for plain fnmatch pattern-matching.
This is to support the pattern matching options which are used in `git
tag -l` and `git branch -l` where we can match patterns like `git tag
-l foo*` which would match
From: Karthik Nayak
In 'tag.c' we can print N lines from the annotation of the tag using
the '-n' option. Copy code from 'tag.c' to 'ref-filter' and
modify 'ref-filter' to support printing of N lines from the annotation
of tags.
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-of
Convert the 'color' atom to behave as a modifier atom and make it use
'ref_formatting_state' which was introduced in the previous patch.
Helped-by: Junio C Hamano
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-off-by: Karthik Nayak
---
ref-filter.c | 10 --
ref-filter.
Add a new atom "padright" and support %(padright:X) where X is a
number. This will align the succeeding atom or string to the left
followed by spaces for a total length of X characters. If X is less
than the atom or string length then no padding is done.
Add tests and documentation for the same.
Introduce 'ref_formatting_state' structure to hold values of modifier
atoms which help only in formatting. This will eventually be used by
atoms like `padright` which will be introduced in a later patch.
Helped-by: Junio C Hamano
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-of
In git 2.1.4, I can run: git pull --upload-pack 'echo --foo'
This also seems to work in 2.4.6, but in 2.5.0, the option parser
does something weird, apparently looking inside the quoted parameter
and parsing parameters in there:
error: unknown option `foo'
usage: git fetch [] [ [...]]
Needless t
From: Karthik Nayak
Add support to sort by version using the "v:refname" and
"version:refname" option. This is achieved by using the 'versioncmp()'
function as the comparing function for qsort.
This option is included to support sorting by versions in `git tag -l`
which will eventaully be ported
This is part of my GSoC project to unify git tag -l, git branch -l,
git for-each-ref. This patch series is continued from: Git (next)
https://github.com/git/git/commit/bf5418f49ff0cebc6e5ce04ad1417e1a47c81b61
Version 6 can be found here:
http://article.gmane.org/gmane.comp.version-control.git/274
Introduce 'ref_formatting_state' structure to hold values of modifier
atoms which help only in formatting. This will eventually be used by
atoms like `padright` which will be introduced in a later patch.
Helped-by: Junio C Hamano
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-of
From: Karthik Nayak
Using 'ref-filter' APIs implement the '--merged' and '--no-merged'
options into 'tag.c'. The '--merged' option lets the user to only
list tags merged into the named commit. The '--no-merged' option
lets the user to only list tags not merged into the named commit.
If no object
From: Karthik Nayak
Make 'tag.c' use 'ref-filter' data structures and make changes to
support the new data structures. This is a part of the process
of porting 'tag.c' to use 'ref-filter' APIs.
This is a temporary step before porting 'tag.c' to use 'ref-filter'
completely. As this is a temporary
From: Karthik Nayak
Add a functions called 'for_each_tag_ref_fullpath()' to refs.{c,h}
which iterates through each tag ref without trimming the path.
Add an option in 'filter_refs()' to use 'for_each_tag_ref_fullpath()'
and filter refs. This type checking is done by adding a
'FILTER_REFS_TAGS' i
From: Karthik Nayak
In 'tag.c' we can print N lines from the annotation of the tag using
the '-n' option. Copy code from 'tag.c' to 'ref-filter' and
modify 'ref-filter' to support printing of N lines from the annotation
of tags.
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-of
From: Karthik Nayak
Make 'tag.c' use 'ref-filter' APIs for iterating through refs, sorting
and printing of refs. This removes most of the code used in 'tag.c'
replacing it with calls to the 'ref-filter' library.
Make 'tag.c' use the 'filter_refs()' function provided by 'ref-filter'
to filter out
Convert the 'color' atom to behave as a modifier atom and make it use
'ref_formatting_state' which was introduced in the previous patch.
Helped-by: Junio C Hamano
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-off-by: Karthik Nayak
---
ref-filter.c | 10 --
ref-filter.
From: Karthik Nayak
Implement the '--format' option provided by 'ref-filter'.
This lets the user list tags as per desired format similar
to the implementation in 'git for-each-ref'.
Add tests and documentation for the same.
Mentored-by: Christian Couder
Mentored-by: Matthieu Moy
Signed-off-by
On 2015-07-30 12:35 AM, Jacob Keller wrote:
> On Wed, Jul 29, 2015 at 3:20 PM, Stefan Beller wrote:
>> On Wed, Jul 29, 2015 at 3:01 PM, Paul Gortmaker
>> wrote:
>>> The linux kernel repository has some commits in it with dates from
>>> the year 1970 and also 2030 (and possibly others). We probab
Commit 833bd64f ("bisect: simplify the addition of new bisect terms",
29-06-2015) added a public function, read_bisect_terms(), to 'bisect.c'
which was then called by code in 'revision.c', having directly referenced
the symbol with an explicit external declaration. This causes sparse to
complain (
On Wed, Jul 29, 2015 at 04:32:13PM -0400, Eric Sunshine wrote:
> On Wed, Jul 29, 2015 at 11:51 AM, Patrick Steinhardt wrote:
> > parse_connect_url() checks if the path component of the URL is
> > empty and if so causes the program to die. As the function is to
> > be used at other call sites which
On Wed, Jul 29, 2015 at 10:42:21AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt writes:
>
> > We fail to guess a sensible directory name for a newly cloned
> > repository when the path component of the URL is empty. E.g.
> > cloning a repository 'ssh://user:passw...@example.com/' we create
>
On Thu, Jul 30, 2015 at 01:24:03PM +0200, SZEDER Gábor wrote:
>
> Quoting Thomas Braun :
>
> > Signed-off-by: Thomas Braun
> > ---
> >> John Keeping hat am 13. Juli 2015 um 15:11
> >> geschrieben:
> >> git-rebase.sh contains:
> >>
> >>if test "$action" = "edit-todo" && test "$type" != "int
Quoting Thomas Braun :
Signed-off-by: Thomas Braun
---
John Keeping hat am 13. Juli 2015 um 15:11 geschrieben:
git-rebase.sh contains:
if test "$action" = "edit-todo" && test "$type" != "interactive"
then
die "$(gettext "The --edit-todo action can only be use
On Wed, Jul 29, 2015 at 3:19 AM, Eric Sunshine wrote:
> On Mon, Jul 27, 2015 at 3:27 AM, Karthik Nayak wrote:
>> From: Karthik Nayak
>>
>> Since 'ref-filter' only has an option to match path names add an
>> option for plain fnmatch pattern-matching.
>>
>> This is to support the pattern matching
On Thu, Jul 30, 2015 at 1:04 AM, Eric Sunshine wrote:
> On Tuesday, July 28, 2015, Karthik Nayak wrote:
>> Add support to sort by version using the "v:refname" and
>> "version:refname" option. This is achieved by using the 'versioncmp()'
>> function as the comparing function for qsort.
>>
>> This
On Thu, Jul 30, 2015 at 12:59 AM, Eric Sunshine wrote:
> On Tuesday, July 28, 2015, Karthik Nayak wrote:
>> Add a new atom "padright" and support %(padright:X) where X is a
>> number. This will align the succeeding atom value to the left
>> followed by spaces for a total length of X characters.
On Thu, Jul 30, 2015 at 3:14 PM, Matthieu Moy
wrote:
> Junio C Hamano writes:
>
>> "Currently we do not need it to reimplement the canned 'tag -l'
>> format" is an OK and sensible justification to stick to the current
>> implementation of %(padright:N), but we'd need to think if we would
>> want
"brian m. carlson" writes:
> On Mon, Jul 27, 2015 at 02:23:04PM -0700, Junio C Hamano wrote:
>> * bc/object-id (2015-06-17) 10 commits
>> . remote.c: use struct object_id in many functions
>> . object-id: use struct object_id in struct object
>> . remote.c: use struct object_id in ref_newer()
Junio C Hamano writes:
> "Currently we do not need it to reimplement the canned 'tag -l'
> format" is an OK and sensible justification to stick to the current
> implementation of %(padright:N), but we'd need to think if we would
> want to keep this limited and strange form that applies to a singl
Junio C Hamano writes:
> If the act of printing an atom uses the formatting state that says
> "next one needs X", then it is responsible to clear that "next one
> needs X" part of the state, as it is the one who consumed that
> state. E.g. if it used to say "next one needs to be padded to the
>
On Thu, Jul 30, 2015 at 1:24 AM, Junio C Hamano wrote:
> Actually, I think it is wrong to have this function in the first
> place. It is a sign that the caller is doing too little before
> calling this function.
>
> If the act of printing an atom uses the formatting state that says
> "next one ne
Karthik Nayak writes:
> On Wed, Jul 29, 2015 at 9:26 PM, Matthieu Moy
> wrote:
>> Karthik Nayak writes:
>>
>>> On Tue, Jul 28, 2015 at 7:47 PM, Matthieu Moy
>>> wrote:
I'm not sure what's the convention, but I think the test description
should give the expected behavior even wit
67 matches
Mail list logo
