допоможіть нашому сайту http://schoolsite.pp.ua/ - будь ласка, відкрийте його для перегляду однієї-двох сторінок

2015-09-25 Thread admin
Доброго дня, будь ласка, просимо переглянути наш сайт, якщо це не важко для вас, http://schoolsite.pp.ua/ - будь ласка, відкрийте його для перегляду однієї-двох сторінок, і на будь-якій сторінці один раз натисніть на рекламний банер, який вам найбільш цікавий, це Ваша допомога, щоб ми могли

[PATCH] submodule-parallel-fetch: make some file local symbols static

2015-09-25 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Stefan, When you next re-roll the patches for your 'sb/submodule-parallel-fetch' branch, could you please squash parts of this into the relevant patches. [which would correspond to commits a93fb7a ("run-command: add an

Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-25 Thread Matthieu Moy
Junio C Hamano writes: > While I was trying to address your "actually already report", I > spotted a typo and then found that the early part of the second > paragraph is a bit hard, so here is what I ended up with. LGTM. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ --

Re: [PATCH] submodule-parallel-fetch: make some file local symbols static

2015-09-25 Thread Jacob Keller
On Fri, Sep 25, 2015 at 8:15 AM, Ramsay Jones wrote: > [Note these issues were spotted by sparse and static-check.pl] Any chance you got a link to docs about static-check.pl? I've never heard of this... Regards, Jake -- To unsubscribe from this list: send the line

Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-25 Thread Junio C Hamano
Matthieu Moy writes: > Karthik Nayak writes: > >> Remove the error "branch '%s' does not point at a commit" in >> apppend_ref() which reports branch refs which do not point to >> commits. Also remove the error "some refs could not be read" in

Re: [PATCH] t5561: get rid of racy appending to logfile

2015-09-25 Thread Junio C Hamano
Stephan Beyer writes: > The definition of log_div() appended information to the web server's > logfile to make the test more readable. However, log_div() was called > right after a request is served (which is done by git-http-backend); > the web server waits for the

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Jeff King
On Thu, Sep 24, 2015 at 05:41:06PM -0700, Junio C Hamano wrote: > Of course, this can be improved if we start using signed push into > GitHub. It is a separate issue in the sense that it would help > GitHub to make that assurance stronger---those who fetch/clone can > be assured that the tips of

Re: [PATCH] t5561: get rid of racy appending to logfile

2015-09-25 Thread Junio C Hamano
Stephan Beyer writes: > SubmittingPatches says that when there is consensus the patch has to > be resent to Junio and cc'ed to the list. Here it is (although I > don't know if there is consensus, but, hey, it's a rather trivial patch, > so it should be okay). Yup. The

Re: [PATCH 20/43] refs-be-files.c: add methods for the ref iterators

2015-09-25 Thread David Turner
On Fri, 2015-09-25 at 13:54 -0700, Junio C Hamano wrote: > Up to high-teens in this 43 patch series, the changes all looked > "separate filesystem backend specific part from refs.c to > refs-be-files.c" without other questionable changes, but I have to > give up at this step for now, as conflicts

Re: [PATCH 20/43] refs-be-files.c: add methods for the ref iterators

2015-09-25 Thread Junio C Hamano
David Turner writes: >> * Pick 'next', 'jch' and 'pu' as the starting point, attempted to > > Do you mean that you merged these branches together, or that you tried > each of the three? I tried at least these three (and some other intermediate states) before giving up.

Re: [PATCH 20/43] refs-be-files.c: add methods for the ref iterators

2015-09-25 Thread Junio C Hamano
Up to high-teens in this 43 patch series, the changes all looked "separate filesystem backend specific part from refs.c to refs-be-files.c" without other questionable changes, but I have to give up at this step for now, as conflicts between the patch and the current codebase is getting a bit too

Re: [PATCH 0/2] Another squash on run-command: add an asynchronous parallel child processor

2015-09-25 Thread Stefan Beller
On Thu, Sep 24, 2015 at 6:08 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> * If you do not die() in start_failure_fn or return_value_fn, you >>don't want to write to stderr directly as you would destroy the fine >>ordering of the processes

Re: [PATCH 0/2] Another squash on run-command: add an asynchronous parallel child processor

2015-09-25 Thread Stefan Beller
On Fri, Sep 25, 2015 at 12:04 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> I think two sensible choices that start-failure and return-value can >>> make are >>> >>> (1) This one task failed, but that is OK. Please let the other >>> tasks

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Jeff King
On Fri, Sep 25, 2015 at 11:29:31AM -0700, Junio C Hamano wrote: > When I finally complain to the hosting site that it is deliberately > rejecting the fix that would rob them the illicit revenue source, it > does not help the hosting site to keep copies of push certificates > when it wants to

Re: [PATCH 0/2] Another squash on run-command: add an asynchronous parallel child processor

2015-09-25 Thread Junio C Hamano
Stefan Beller writes: >> I think two sensible choices that start-failure and return-value can >> make are >> >> (1) This one task failed, but that is OK. Please let the other >> tasks run [*1*]. >> >> (2) There is something seriously wrong with the whole world and I

Re: [PATCH 0/2] Another squash on run-command: add an asynchronous parallel child processor

2015-09-25 Thread Junio C Hamano
Stefan Beller writes: > We could also offer more access to the pp machinery and an implementation for > (2) might look like this: > > static void fictious_start_failure(void *data, > void *pp, > struct

Re: [PATCH v3 3/5] enter_repo: allow .git files in strict mode

2015-09-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Strict mode is about not guessing where .git is. If the user points to a > .git file, we know exactly where the target .git dir will be. > > This is needed even in local clone case because transport.c code uses > upload-pack for fetching remote

Re: [PATCH] branch: handle errors on setting tracking branches

2015-09-25 Thread Junio C Hamano
Jeff King writes: > I count 4 callers in the current code, and none of them currently looks > at the return value. Your patch updates setup_tracking() to propagate > the error, which is good. But that is called from exactly one place, > create_branch(), which also ignores the

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Junio C Hamano
Luke Diamand writes: > From past experience, if it's configured to email people when things > break, sooner or later it will email the wrong people, probably once > every few seconds over a weekend. > > Automated testing is a Good Thing, but it's still software, so needs >

Re: [PATCH 1/2] SQUASH???

2015-09-25 Thread Stefan Beller
On Thu, Sep 24, 2015 at 5:49 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> * If you do not die() in start_failure_fn or return_value_fn, you >>don't want to write to stderr directly as you would destroy the fine >>ordering of the processes

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Junio C Hamano
Jeff King writes: > If the point is for clients not to trust GitHub, though, it doesn't > really matter what GitHub does with the cert, as long as it is put > somewhere that clients know to get it. Correct. A spiffy Web interface that says "Click this button and we show you the

Re: [PATCH v6b 5/8] branch: drop non-commit error reporting

2015-09-25 Thread Karthik Nayak
On Fri, Sep 25, 2015 at 9:30 PM, Junio C Hamano wrote: > Matthieu Moy writes: > >> Karthik Nayak writes: >> >>> Remove the error "branch '%s' does not point at a commit" in >>> apppend_ref() which reports branch refs which

Re: [PATCH 1/2] SQUASH???

2015-09-25 Thread Junio C Hamano
Stefan Beller writes: > Sure. I just wanted to point out the details instead of resending the series. > I'll do a resend later today, hoping to get all issues addressed. Thanks. For something this small, unless there are many small pieces that need to be picked apart, I do

broken racy detection and performance issues with nanosecond file times

2015-09-25 Thread Karsten Blees
Hi there, I think I found a few nasty problems with racy detection, as well as performance issues when using git implementations with different file time resolutions on the same repository (e.g. git compiled with and without USE_NSEC, libgit2 compiled with and without USE_NSEC, JGit executed in

Re: [PATCH 66/68] fsck: use for_each_loose_file_in_objdir

2015-09-25 Thread Jeff King
On Thu, Sep 24, 2015 at 05:08:32PM -0400, Jeff King wrote: > +static int fsck_subdir(int nr, const char *path, void *progress) > +{ > + display_progress(progress, nr + 1); > + return 0; > +} > + > static void fsck_object_dir(const char *path) > { > - int i; > struct progress

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Luke Diamand
On 25 September 2015 at 08:27, Johannes Schindelin wrote: > Hi, > > On 2015-09-25 05:14, Dennis Kaarsemaker wrote: >> On do, 2015-09-24 at 17:41 -0700, Junio C Hamano wrote: >>> larsxschnei...@gmail.com writes: >>> >>> > My idea is that the owner of

Re: [PATCH v7 0/7] git-p4: add support for large file systems

2015-09-25 Thread Luke Diamand
On 25/09/15 09:35, Lars Schneider wrote: size: 3 flags: 0 What's going on? I believe this is correct. Git-LFS uses the clean/smudge filter to replace the LFS pointer with the actual file on checkout. Therefore you see the actual file! You can find details here:

Re: [RFC/PATCH v1] Add Travis CI support

2015-09-25 Thread Johannes Schindelin
Hi, On 2015-09-25 05:14, Dennis Kaarsemaker wrote: > On do, 2015-09-24 at 17:41 -0700, Junio C Hamano wrote: >> larsxschnei...@gmail.com writes: >> >> > My idea is that the owner of "https://github.com/git/git; enables this >> > account >> > for Travis (it's free!). Then we would automatically

Re: [PATCH v7 6/7] git-p4: add support for large file systems

2015-09-25 Thread Luke Diamand
One tiny comment, otherwise this looks good to me. Can we use test_path_is_missing in place of !test_path_is_file ? On 21 September 2015 at 23:41, wrote: > From: Lars Schneider > > Perforce repositories can contain large (binary) files.

Formatting error in page http://git-scm.com/docs/user-manual

2015-09-25 Thread Valentin VALCIU
Hello! There is a formatting error in the source code of page http://git-scm.com/docs/user-manual that makes almost half of it be rendered in a element displaying the page source in the original markup language instead of being converted to HTML. The issue is in the paragraph that stars with

Re: Formatting error in page http://git-scm.com/docs/user-manual

2015-09-25 Thread John Keeping
On Fri, Sep 25, 2015 at 03:38:02PM +0300, Valentin VALCIU wrote: > There is a formatting error in the source code of page > http://git-scm.com/docs/user-manual that makes almost half of it be > rendered in a element displaying the page source in the original > markup language instead of being

Re: git-p4: t9819 failing

2015-09-25 Thread Lars Schneider
Good catch. The case-handling test is actually fine. There was a bug in my implementation! If you do this: git p4 clone //depot/something/... Then git p4 generates a directory “something” and clones into that (similar to Git). Since I set “cloneDirectory” to the current working directory that

Re: Fwd: diff not finding difference

2015-09-25 Thread Johannes Schindelin
Hi Jack Adrian, On 2015-09-24 23:09, Jack Adrian Zappa wrote: > This is a weird one: > > [file-1 begin] > > abcd efg hijklmnop > > [file-1 end] > > [file-2 begin] > > blah blah blah > / > abdc boo ya! > >

Re: Fwd: diff not finding difference

2015-09-25 Thread Michael J Gruber
Johannes Schindelin venit, vidit, dixit 25.09.2015 12:11: > Hi Jack Adrian, > > On 2015-09-24 23:09, Jack Adrian Zappa wrote: >> This is a weird one: >> >> [file-1 begin] >> >> abcd efg hijklmnop >> >> [file-1 end] >> >> [file-2 begin] >> >> blah blah blah >>

Re: Formatting error in page http://git-scm.com/docs/user-manual

2015-09-25 Thread Michael J Gruber
John Keeping venit, vidit, dixit 25.09.2015 14:59: > On Fri, Sep 25, 2015 at 03:38:02PM +0300, Valentin VALCIU wrote: >> There is a formatting error in the source code of page >> http://git-scm.com/docs/user-manual that makes almost half of it be >> rendered in a element displaying the page