Bug: t5813 failing on Cygwin

2015-11-07 Thread Adam Dinwoodie
In the process of pulling up the Cygwin Git release from v2.5.3, I've discovered t5813 is failing, and appears to have been failing since it was first introduced in a5adace. I've not yet done any significant digging into the problem myself; I'm reporting here now in case in the hope someone

Re: [PATCH] run-command: detect finished children by closed pipe rather than waitpid

2015-11-07 Thread Johannes Sixt
Am 07.11.2015 um 00:48 schrieb Stefan Beller: Detect if a child stopped working by checking if their stderr pipe was closed instead of checking their state with waitpid. As waitpid is not fully working in Windows, this is an approach which allows for better cross platform operation. (It's less

Re: [PATCH] receive-pack: avoid sending duplicate "have" lines

2015-11-07 Thread Lukas Fleischer
On Sat, 07 Nov 2015 at 00:38:00, Junio C Hamano wrote: > [...] > I suspect that many of these that turn into ".have"s point the same > object as those sit at the tip of our refs (e.g. tags in alternates > we borrow from, which are the folks of the same project that copy > the same tags from the

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Adam Dinwoodie
On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote: > On Sat, Nov 07, 2015 at 12:11:29PM +, Adam Dinwoodie wrote: > > > Specifically, I'm seeing t5813 subtests 9-13 and 15-19 failing. This happens > > with a clean build straight from the Git source tree (git clean -dfx && make > >

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Dennis Kaarsemaker
On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote: > On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote: > > On Sat, Nov 07, 2015 at 12:11:29PM +, Adam Dinwoodie wrote: > > > > > Specifically, I'm seeing t5813 subtests 9-13 and 15-19 failing. > > > This happens > > > with a clean

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Ramsay Jones
On 07/11/15 21:02, Dennis Kaarsemaker wrote: > On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote: >> On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote: >>> On Sat, Nov 07, 2015 at 12:11:29PM +, Adam Dinwoodie wrote: >>> Specifically, I'm seeing t5813 subtests 9-13 and 15-19

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Jeff King
On Sat, Nov 07, 2015 at 12:11:29PM +, Adam Dinwoodie wrote: > Specifically, I'm seeing t5813 subtests 9-13 and 15-19 failing. This happens > with a clean build straight from the Git source tree (git clean -dfx && make > configure && ./configure && make && cd t && ./t5813-proto-disable-ssh.sh)

Re: Git potential bug with fork-point

2015-11-07 Thread John Keeping
On Mon, Nov 02, 2015 at 06:27:52AM +, Stenberg Jim (2) wrote: > My problem: > "Git merge-base --fork-point" acts unexpected when I refer to remote > branches (typically "origin/".) With unexpected I mean that if I swap > the position of the two references that the function takes as argument >

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Adam Dinwoodie
On Sat, Nov 07, 2015 at 10:02:45PM +0100, Dennis Kaarsemaker wrote: > On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote: > > On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote: > > > On Sat, Nov 07, 2015 at 12:11:29PM +, Adam Dinwoodie wrote: > > > > > > > Specifically, I'm seeing

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Ramsay Jones
On 07/11/15 23:32, Dennis Kaarsemaker wrote: > On za, 2015-11-07 at 23:05 +, Ramsay Jones wrote: >> >> On 07/11/15 21:21, Ramsay Jones wrote: >>> >>> >>> On 07/11/15 21:02, Dennis Kaarsemaker wrote: On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote: > On Sat, Nov 07, 2015 at

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Ramsay Jones
On 07/11/15 21:21, Ramsay Jones wrote: > > > On 07/11/15 21:02, Dennis Kaarsemaker wrote: >> On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote: >>> On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote: On Sat, Nov 07, 2015 at 12:11:29PM +, Adam Dinwoodie wrote: >

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Dennis Kaarsemaker
On za, 2015-11-07 at 23:05 +, Ramsay Jones wrote: > > On 07/11/15 21:21, Ramsay Jones wrote: > > > > > > On 07/11/15 21:02, Dennis Kaarsemaker wrote: > > > On za, 2015-11-07 at 19:20 +, Adam Dinwoodie wrote: > > > > On Sat, Nov 07, 2015 at 01:45:27PM -0500, Jeff King wrote: > > > > > On

Re: [PATCH v6 25/25] refs: break out ref conflict checks

2015-11-07 Thread Michael Haggerty
On 11/07/2015 12:24 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Michael Haggerty writes: >> >>> [...] And then, if you are also OK with the >>> new subdirectory introduced in this patch series, David and I seem to be >>> in agreement that it

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Jeff King
On Sat, Nov 07, 2015 at 10:02:45PM +0100, Dennis Kaarsemaker wrote: > Looks like lib-proto-disable.sh's fake SSH doesn't strip double leading > /'es from the path. Try this patch: > > diff --git a/t/t5813-proto-disable-ssh.sh b/t/t5813-proto-disable > -ssh.sh > index ad877d7..a954ead 100755 >

Re: [PATCH v6 25/25] refs: break out ref conflict checks

2015-11-07 Thread Michael Haggerty
On 11/08/2015 06:03 AM, Michael Haggerty wrote: > [...] > I can see a few ways that we could make our series even more > straightforward: > > 1. Leave refs.c in its original location (as suggested by Junio). >Optionally, it could be moved at a later date when this area is >quiescent. >

[PATCH v2] gitk: Update Japanese translation

2015-11-07 Thread miurahr
From: Hiroshi Miura Signed-off-by: Hiroshi Miura --- Notes: A patch based on git://ozlabs.org/~paulus/gitk po/ja.po | 115 --- 1 file changed, 51 insertions(+), 64 deletions(-) diff --git

Draft of Git Rev News edition 9

2015-11-07 Thread Christian Couder
Hi, A draft of Git Rev News edition 9 is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-9.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub issue:

Re: Bug: t5813 failing on Cygwin

2015-11-07 Thread Torsten Bögershausen
>> >> diff --git a/connect.c b/connect.c >> index 108f5ab..fc73cf9 100644 >> --- a/connect.c >> +++ b/connect.c >> @@ -636,6 +636,8 @@ static enum protocol parse_connect_url(const char >> *url_orig, char **ret_host, >> end = path; /* Need to \0 terminate host here */ >> if (separator ==