Re: [PATCH] Remove dependency on deprecated Net::SMTP::SSL

On 20/11/16 22:18, Mike Fisher wrote: Thanks for contributing to Git. One comment on the head line: >Refactor send_message() to remove dependency on deprecated Net::SMTP::SSL The word "refactor" may be used in other way: Re-structure the code, and use the same API. "Remove dependency on de

Re: [PATCH] Remove dependency on deprecated Net::SMTP::SSL

On Sun, Nov 20, 2016 at 04:18:16PM -0500, Mike Fisher wrote: > Refactor send_message() to remove dependency on deprecated > Net::SMTP::SSL: > > As much as I hate to say this, I think this is going to cause compatibili

[PATCH] Remove dependency on deprecated Net::SMTP::SSL

Refactor send_message() to remove dependency on deprecated Net::SMTP::SSL: Signed-off-by: Mike Fisher --- git-send-email.perl | 54 + 1 file changed, 25 inserti

Re: [PATCH v15 13/27] bisect--helper: `bisect_start` shell function partially in C

On 11/20/2016 09:01 PM, Stephan Beyer wrote: > First, replace the current set_terms() by > > static void set_terms(struct bisect_terms *terms, const char *bad, > const char *good) > { > terms->term_good = xstrdup(good); > terms->term_bad

Re: Fwd: git diff with “--word-diff-regex” extremely slow compared to “--word-diff”?

On Fri, Nov 18, 2016 at 03:40:22PM -0800, Matthieu S wrote: > Why is the speed so different if one uses --word-diff instead of > --word-diff-regex= ? Is it just because my expression is (slightly) > more complex than the default one (split on period instead of only > whitespace) ? Or is it that th

Re: [PATCH v15 18/27] bisect--helper: `bisect_autostart` shell function in C

Hi, On 10/14/2016 04:14 PM, Pranit Bauva wrote: > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index 502bf18..1767916 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -422,6 +425,7 @@ static int bisect_next(...) > { > int res, no_checkout;

Re: [PATCH v15 13/27] bisect--helper: `bisect_start` shell function partially in C

Hi, On 10/14/2016 04:14 PM, Pranit Bauva wrote: > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > index 6a5878c..1d3e17f 100644 > --- a/builtin/bisect--helper.c > +++ b/builtin/bisect--helper.c > @@ -403,6 +408,205 @@ static int bisect_terms(struct bisect_terms *terms, > const

Re: [PATCH v15 15/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C

Hi Pranit, this one is hard to review because you do two or three commits in one here. I think the first commit should be the exit()->return conversion, the second commit is next and autonext, and the third commit is the pretty trivial bisect_start commit ;) However, you did it this way and it's a

Re: [PATCH v7 13/17] ref-filter: add `:dir` and `:base` options for ref printing atoms

W dniu 20.11.2016 o 18:32, Junio C Hamano pisze: > Karthik Nayak writes: > >> We could have lstrip and rstrip as you suggested and perhaps make >> it work together too. But I see this going off the scope of this >> series. Maybe I'll follow up with another series introducing these >> features. Si

Re: [PATCH v7 13/17] ref-filter: add `:dir` and `:base` options for ref printing atoms

Karthik Nayak writes: > We could have lstrip and rstrip as you suggested and perhaps make it work > together too. But I see this going off the scope of this series. Maybe > I'll follow up > with another series introducing these features. Since we can currently > make do with > 'strip=2' I'll drop

Re: [PATCH v7 13/17] ref-filter: add `:dir` and `:base` options for ref printing atoms

On Sun, Nov 20, 2016 at 8:46 PM, Karthik Nayak wrote: > On Fri, Nov 18, 2016 at 11:48 PM, Junio C Hamano wrote: >> Jacob Keller writes: >> >> to get remotes from /refs/foo/abc/xyz we'd need to do >> strip=1,strip=-1, which could be >> done but ... > > ... would be unnecessary

Re: [PATCH v7 14/17] ref-filter: allow porcelain to translate messages in the output

cc'in Matthieu since he wrote the patch. On Sat, Nov 19, 2016 at 4:16 AM, Jakub Narębski wrote: > W dniu 08.11.2016 o 21:12, Karthik Nayak pisze: >> From: Karthik Nayak >> >> Introduce setup_ref_filter_porcelain_msg() so that the messages used in >> the atom %(upstream:track) can be translated i

Re: [PATCH v7 13/17] ref-filter: add `:dir` and `:base` options for ref printing atoms

On Fri, Nov 18, 2016 at 11:48 PM, Junio C Hamano wrote: > Jacob Keller writes: > > to get remotes from /refs/foo/abc/xyz we'd need to do > strip=1,strip=-1, which could be > done but ... ... would be unnecessary if this is the only use case: > strbuf_addf(&fmt,

[PATCH] i18n: Fixed unmatched single quote in error message

Fixed unmatched single quote introduced by commit: * f56fffef9a sequencer: teach write_message() to append an optional LF Signed-off-by: Jiang Xin --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sequencer.c b/sequencer.c index 6f0ff9e413..30b10ba143 100644 -