Re: [PATCH] Add shell completion for git remote rm

2017-12-31 Thread Keith Smiley
I'm definitely happy to update this patch for now to just complete the remote names, and not add rm to the list of subcommand completions if we're all ok with that! -- Keith Smiley On 12/30, Ævar Arnfjörð Bjarmason wrote: On Sat, Dec 30 2017, Todd Zullinger jotted: Ævar Arnfjörð Bjarmason

[PATCH 2/2] mv: remove unneeded 'if (!show_only)'

2017-12-31 Thread Stefan Moch
Commit a127331cd (mv: allow moving nested submodules, 2016-04-19), introduced if (show_only) continue; in this for-loop before if (!show_only) which became redundant, because it is now always true. Signed-off-by: Stefan Moch --- builtin/mv.c | 3 +-- 1 file

[PATCH 1/2] Add test case for mv --dry-run to t7001-mv.sh

2017-12-31 Thread Stefan Moch
It checks if mv --dry-run does not move file. Signed-off-by: Stefan Moch --- t/t7001-mv.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh index 6e5031f56..d4e6485a2 100755 --- a/t/t7001-mv.sh +++ b/t/t7001-mv.sh @@ -38,6 +38,12 @@

Re: feature-request: git "cp" like there is git mv.

2017-12-31 Thread Stefan Moch
* Jonathan Nieder [2017-12-15T17:31:30-0800]: > This sounds like a reasonable thing to add. See builtin/mv.c for how > "git mv" works if you're looking for inspiration. > > cmd_mv in that file looks rather long, so I'd also be happy if someone > interested refactors to break

[PATCH 2/2] travis-ci: check that all build artifacts are .gitignore-d

2017-12-31 Thread SZEDER Gábor
Every once in a while our explicit .gitignore files get out of sync when our build process learns to create new artifacts, like test helper executables, but the .gitignore files are not updated accordingly. Use Travis CI to help catch such issues earlier: check that there are no untracked files

[PATCH 0/2] Travis CI: check unignored build artifacts

2017-12-31 Thread SZEDER Gábor
Every once in a while our explicit .gitignore files get out of sync when our build process learns to create new artifacts, but the .gitignore files are not updated accordingly. It was recently that we got a report about unignored test helper executables, see 44103f419 (t/helper: ignore everything

[PATCH 1/2] travis-ci: don't store P4 and Git LFS in the working tree

2017-12-31 Thread SZEDER Gábor
The Clang and GCC 64 bit Linux build jobs download and store the P4 and Git LFS executables under the current directory, which is the working tree that we are about to build and test. This means that Git commands like 'status' or 'ls-files' would list these files as untracked. The next commit is

[L10N] Kickoff of translation for Git 2.16.0 round 1

2017-12-31 Thread Jiang Xin
Hi guys, Happy new year. New round of Git l10n is coming. It's time to start l10n for Git 2.16.0. This time there are 64 updated messages need to be translated since last update: l10n: git.pot: v2.16.0 round 1 (64 new, 25 removed) Generate po/git.pot from v2.16.0-rc0 for git v2.16.0

Re: [PATCH 1/5] convert_to_git(): checksafe becomes an integer

2017-12-31 Thread Lars Schneider
> On 31 Dec 2017, at 09:05, tbo...@web.de wrote: > > From: Torsten Bögershausen > > When calling convert_to_git(), the checksafe parameter has been used to > check if commit would give a non-roundtrip conversion of EOL. > > When checksafe was introduced, 3 values had been in

Re: [PATCHv2 0/3] Travis CI: skip commits with successfully built and tested trees

2017-12-31 Thread Lars Schneider
> On 31 Dec 2017, at 11:12, SZEDER Gábor wrote: > > This is the second iteration of 'sg/travis-skip-identical-test', > addressing the comments of Lars and Jonathan: > > - Colorize the "Tip of $TRAVIS_BRANCH is exactly at $TAG" message >in the new patch 1/3. > > -

[PATCHv2 0/3] Travis CI: skip commits with successfully built and tested trees

2017-12-31 Thread SZEDER Gábor
This is the second iteration of 'sg/travis-skip-identical-test', addressing the comments of Lars and Jonathan: - Colorize the "Tip of $TRAVIS_BRANCH is exactly at $TAG" message in the new patch 1/3. - Create the cache directory at the beginning of the build process (patch 2/3). -

[PATCHv2 3/3] travis-ci: record and skip successfully built trees

2017-12-31 Thread SZEDER Gábor
Travis CI dutifully builds and tests each new branch tip, even if its tree has previously been successfully built and tested. This happens often enough in contributors' workflows, when a work-in-progress branch is rebased changing e.g. only commit messages or the order or number of commits while

[PATCHv2 2/3] travis-ci: create the cache directory early in the build process

2017-12-31 Thread SZEDER Gábor
It seems that Travis CI creates the cache directory for us anyway, even when a previous cache doesn't exist for the current build job. Alas, this behavior is not explicitly documented, therefore we don't rely on it and create the cache directory ourselves in those build jobs that read/write cached

[PATCHv2 1/3] travis-ci: print the "tip of branch is exactly at tag" message in color

2017-12-31 Thread SZEDER Gábor
To make this info message stand out from the regular build job trace output. Signed-off-by: SZEDER Gábor --- ci/lib-travisci.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh index 348fe3c3c..9d379db8a 100755 ---

Re: Segfault

2017-12-31 Thread Eric Sunshine
On Fri, Dec 29, 2017 at 4:04 AM, Andrew Tsykhonya wrote: > git stash pop resulted in crash: > /usr/local/Cellar/git/2.10.2/libexec/git-core/git-stash: line 470: > 14946 Segmentation fault: 11 git merge-recursive $b_tree -- $c_tree > $w_tree > although, the changes have

[PATCH 2/5] strbuf: add xstrdup_toupper()

2017-12-31 Thread tboegi
From: Lars Schneider Create a copy of an existing string and make all characters upper case. Similar xstrdup_tolower(). This function is used in a subsequent commit. Signed-off-by: Lars Schneider Signed-off-by: Torsten Bögershausen

[PATCH 4/5] utf8: add function to detect a missing UTF-16/32 BOM

2017-12-31 Thread tboegi
From: Lars Schneider If the endianness is not defined in the encoding name, then let's be strict and require a BOM to avoid any encoding confusion. The has_missing_utf_bom() function returns true if a required BOM is missing. The Unicode standard instructs to assume

[PATCH 0/5] V2B: simplify convert.c/h

2017-12-31 Thread tboegi
From: Torsten Bögershausen Simplify the convert.h/convert.c logic amd don't touch convert_to_git() The rest is v2 from Lars Lars Schneider (4): strbuf: add xstrdup_toupper() utf8: add function to detect prohibited UTF-16/32 BOM utf8: add function to detect a missing

[PATCH 3/5] utf8: add function to detect prohibited UTF-16/32 BOM

2017-12-31 Thread tboegi
From: Lars Schneider Whenever a data stream is declared to be UTF-16BE, UTF-16LE, UTF-32BE or UTF-32LE a BOM must not be used [1]. The function returns true if this is the case. This function is used in a subsequent commit. [1]

[PATCH 5/5] convert: add support for 'checkout-encoding' attribute

2017-12-31 Thread tboegi
From: Lars Schneider Git and its tools (e.g. git diff) expect all text files in UTF-8 encoding. Git will happily accept content in all other encodings, too, but it might not be able to process the text (e.g. viewing diffs or changing line endings). Add an attribute to

[PATCH 1/5] convert_to_git(): checksafe becomes an integer

2017-12-31 Thread tboegi
From: Torsten Bögershausen When calling convert_to_git(), the checksafe parameter has been used to check if commit would give a non-roundtrip conversion of EOL. When checksafe was introduced, 3 values had been in use: SAFE_CRLF_FALSE: no warning SAFE_CRLF_FAIL: reject the commit