[PATCH 18/27] sha1_file: add repository argument to open_sha1_file

From: Stefan Beller Add a repository argument to allow the open_sha1_file caller to be more specific about which repository to act on. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As with the

[PATCH 03/27] object-store: move alt_odb_list and alt_odb_tail to object store

From: Stefan Beller In a process with multiple repositories open, alternates should be associated to a single repository and not shared globally. Move alt_odb_list and alt_odb_tail into the_repository and adjust callers to reflect this. Now that the alternative object data

[PATCH 24/27] sha1_file: allow open_sha1_file to handle arbitrary repositories

From: Stefan Beller Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1_file.c | 11 +-- 1 file

[PATCH 08/27] pack: move approximate object count to object store

From: Stefan Beller The approximate_object_count() function maintains a rough count of objects in a repository to estimate how long object name abbreviates should be. Object names are scoped to a repository and the appropriate length may differ by repository, so the object

[PATCH 04/27] object-store: free alt_odb_list

From: Stefan Beller Free the memory and reset alt_odb_{list, tail} to NULL. Signed-off-by: Stefan Beller Signed-off-by: Nguyễn Thái Ngọc Duy --- object.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH 10/27] sha1_file: add repository argument to link_alt_odb_entry

From: Stefan Beller Add a repository argument to allow the link_alt_odb_entry caller to be more specific about which repository to act on. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. Since the

[PATCH 12/27] sha1_file: add repository argument to link_alt_odb_entries

From: Stefan Beller See previous patch for explanation. Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1_file.c | 19 +-- 1 file changed, 13

[PATCH 25/27] sha1_file: allow map_sha1_file_1 to handle arbitrary repositories

From: Jonathan Nieder Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

[PATCH 26/27] sha1_file: allow map_sha1_file to handle arbitrary repositories

From: Stefan Beller Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

[PATCH 15/27] sha1_file: allow prepare_alt_odb to handle arbitrary repositories

From: Stefan Beller Signed-off-by: Stefan Beller Signed-off-by: Nguyễn Thái Ngọc Duy --- object-store.h | 3 +-- sha1_file.c| 13 + 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/object-store.h

[PATCH 21/27] sha1_file: add repository argument to sha1_loose_object_info

From: Stefan Beller Add a repository argument to allow the sha1_loose_object_info caller to be more specific about which repository to act on. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As

[PATCH 23/27] sha1_file: allow stat_sha1_file to handle arbitrary repositories

From: Stefan Beller Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1_file.c | 11 +-- 1 file

[PATCH 16/27] sha1_file: add repository argument to sha1_file_name

From: Stefan Beller Add a repository argument to allow sha1_file_name callers to be more specific about which repository to handle. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As with the

[PATCH 14/27] sha1_file: allow link_alt_odb_entries to handle arbitrary repositories

From: Stefan Beller Actually this also allows read_info_alternates and link_alt_odb_entry to handle arbitrary repositories, but link_alt_odb_entries is the most interesting function in this set of functions, hence the commit subject. These functions span a strongly connected

[PATCH 27/27] sha1_file: allow sha1_loose_object_info to handle arbitrary repositories

From: Jonathan Nieder Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano

[PATCH 17/27] sha1_file: add repository argument to stat_sha1_file

From: Stefan Beller Add a repository argument to allow the stat_sha1_file caller to be more specific about which repository to act on. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As with the

[PATCH 20/27] sha1_file: add repository argument to map_sha1_file

From: Stefan Beller Add a repository argument to allow map_sha1_file callers to be more specific about which repository to handle. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As with the

[PATCH 22/27] sha1_file: allow sha1_file_name to handle arbitrary repositories

From: Stefan Beller Signed-off-by: Stefan Beller Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy --- object-store.h | 3 +-- sha1_file.c| 4

[PATCH 02/27] object-store: migrate alternates struct and functions from cache.h

From: Stefan Beller Migrate the struct alternate_object_database and all its related functions to the object store as these functions are easier found in that header. The migration is just a verbatim copy, no need to include the object store header at any C file, because

[PATCH 00/27] sb/object-store updates

I think I have addressed all comments I've received so far. What I decided not to do, I have responded individually. One comment I did not respond nor do is the approximate thing, which could be done later. Interdiff is big due to the "objects." to "objects->" conversion (blame Brandon for his

Re: [PATCH v2 3/5] fast-import: update pool_* functions to work on local pool

Jameson Miller writes: > Update memory pool functions to work on a passed in mem_pool instead of > the global mem_pool type. This is in preparation for making the memory > pool logic reusable. This should be part of 2/5; the same comments to 2/5 I just sent out would still

Re: [PATCH v3] json_writer: new routines to create data in JSON format

g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Add basic routines to generate data in JSON format. > > Signed-off-by: Jeff Hostetler If I understand the cover letter correctly, this is a JSON-like format, not actual JSON. Am I

Re: [PATCH v2 2/5] fast-import: introduce mem_pool type

Jameson Miller writes: > Introduce the mem_pool type and wrap the existing mp_block in this new > type. The new mem_pool type will allow for the memory pool logic to be > reused outside of fast-import. This type will be moved into its own file > in a future commit. > >

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

Hi Wink, On Thu, 22 Mar 2018, Wink Saville wrote: > The backend scriptlets for "git rebase" were structured in a > bit unusual way for historical reasons. Originally, it was > designed in such a way that dot-sourcing them from "git > rebase" would be sufficient to invoke the specific backend. >

Re: [GSoC] Convert “git stash” to builtin proposal

On Fri, Mar 23, 2018 at 12:15 AM, Paul-Sebastian Ungureanu wrote: > > On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: >> >> On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu >> wrote: >> > >> > * Convert

Re: [RFC PATCH v4] rebase-interactive: Simplify pick_on_preserving_merges

Hi Wink, On Thu, 22 Mar 2018, Wink Saville wrote: > Use compound if statement instead of nested if statements to > simplify pick_on_preserving_merges. > > Signed-off-by: Wink Saville > Reviewed-by: Junio C Hamano > --- > git-rebase--interactive.sh | 17

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

On Fri, Mar 23, 2018 at 6:03 PM, Duy Nguyen wrote: > On Wed, Mar 21, 2018 at 11:18 PM, Brandon Williams wrote: >> You're marking packed_git >> as "private"...well C has no notion of private vs public fields in a >> struct so it might be difficult to keep

Re: [GSoC] Convert “git stash” to builtin proposal

Hi Paul-Sebastian, On Fri, 23 Mar 2018, Paul-Sebastian Ungureanu wrote: > On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: > > Hi, > > > > On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu > > wrote: > > > > > > * Convert function: this step

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

On Wed, Mar 21, 2018 at 11:18 PM, Brandon Williams wrote: > You're marking packed_git > as "private"...well C has no notion of private vs public fields in a > struct so it might be difficult to keep that convention, it also took me > a second to realize that it was only in the

Re: [PATCH 10/44] object-store: move packed_git and packed_git_mru to object store

On Mon, Mar 19, 2018 at 8:39 PM, Jonathan Tan wrote: > On Sat, 3 Mar 2018 18:36:03 +0700 > Nguyễn Thái Ngọc Duy wrote: > >> From: Stefan Beller >> >> In a process with multiple repositories open, packfile accessors >> should be

Re: [PATCH v2 1/5] fast-import: rename mem_pool type to mp_block

Jameson Miller writes: > This is part of a patch series to extract the memory pool logic in > fast-import into a more generalized version. The existing mem_pool type > maps more closely to a "block of memory" (mp_block) in the more > generalized memory pool. Sounds good.

Re: [PATCH v3] routines to generate JSON data

Hi, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > This is version 3 of my JSON data format routines. > > This version addresses the variable name changes in [v2] and adds additional > test cases. I also changed the BUG() calls to die() to help with testing.

[PATCH v3] json_writer: new routines to create data in JSON format

From: Jeff Hostetler Add basic routines to generate data in JSON format. Signed-off-by: Jeff Hostetler --- Makefile| 2 + json-writer.c | 321 + json-writer.h |

[PATCH v3] routines to generate JSON data

From: Jeff Hostetler This is version 3 of my JSON data format routines. This version addresses the variable name changes in [v2] and adds additional test cases. I also changed the BUG() calls to die() to help with testing. The json-writer routines can be used generate

Re: [PATCH v6 00/11] nd/pack-objects-pack-struct updates

On 23/03/18 05:50, Jeff King wrote: > On Thu, Mar 22, 2018 at 10:46:09PM -0400, Jeff King wrote: [snip] > I was curious whether my hand-waving there was true. It turns out that > it is: the radix sort has stayed about the same speed but the comparison > sort has gotten even slower. Here are

[PATCH 0/1] nd/remove-ignore-env-field updates

This is a very small, non-functional update. On top of 'next' Nguyễn Thái Ngọc Duy (1): repository.h: add comment and clarify repo_set_gitdir repository.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.17.0.rc0.348.gd5a49e0b6f

[PATCH 1/1] repository.h: add comment and clarify repo_set_gitdir

The argument name "optional" may mislead the reader to think this option could be NULL. But it can't be. While at there, document a bit more about struct set_gitdir_args. Signed-off-by: Nguyễn Thái Ngọc Duy --- repository.h | 6 +- 1 file changed, 5 insertions(+), 1

Re: [PATCH] completion: clear cached --options when sourcing the completion script

On Thu, Mar 22, 2018 at 3:16 PM, SZEDER Gábor wrote: > Add tests to ensure that these variables are indeed cleared when the > completion script is sourced; not just the variables caching options, > but all other caching variables, i.e. the variables caching commands, >

[GSoC][PATCH v4] test: avoid pipes in git related commands for test

Thank you Eric and Junio for the review. I hope this follow-on patch[1] is ready for merge. [1]: https://public-inbox.org/git/20180321152356.10754-1-predatoram...@gmail.com/ -- >8 -- Avoid using pipes downstream of Git commands since the exit codes of commands upstream of pipes get swallowed,

[PATCH v2 1/5] fast-import: rename mem_pool type to mp_block

This is part of a patch series to extract the memory pool logic in fast-import into a more generalized version. The existing mem_pool type maps more closely to a "block of memory" (mp_block) in the more generalized memory pool. This commit renames the mem_pool to mp_block to reduce churn in future

[PATCH v2 4/5] Move the reusable parts of memory pool into its own file

This moves the reusable parts of the memory pool logic used by fast-import.c into its own file for use by other components. Signed-off-by: Jameson Miller --- Makefile | 1 + fast-import.c | 118 +- mem-pool.c

[PATCH v2 2/5] fast-import: introduce mem_pool type

Introduce the mem_pool type and wrap the existing mp_block in this new type. The new mem_pool type will allow for the memory pool logic to be reused outside of fast-import. This type will be moved into its own file in a future commit. Signed-off-by: Jameson Miller ---

[PATCH v2 5/5] Expand implementation of mem-pool type

This commit adds functionality to the mem-pool type that can be generally useful. This functionality will be used in a future commit. Signed-off-by: Jameson Miller --- mem-pool.c | 58 ++ mem-pool.h | 24

[PATCH v2 3/5] fast-import: update pool_* functions to work on local pool

Update memory pool functions to work on a passed in mem_pool instead of the global mem_pool type. This is in preparation for making the memory pool logic reusable. Signed-off-by: Jameson Miller --- fast-import.c | 52 ++-- 1

[PATCH v2 0/3] Extract memory pool logic into reusable component

Changes from v1: - Rework the structure of commits to be more reviewer friendly. This patch series extracts the memory pool implementation, currently used by fast-import, into a generalized component. This memory pool can then be generally used by any component that needs a pool of memory.

Re: The most efficient way to test if repositories share the same objects

On Fri, Mar 23 2018, Konstantin Ryabitsev wrote: > On 03/22/18 17:44, Junio C Hamano wrote: >> Wouldn't it be more efficient to avoid doing so one-by-one? >> That is, wouldn't >> >> rev-list --max-parents=0 --all >> >> be a bit faster than >> >> for-each-ref | >> while read object

Re: [PATCH v2] json_writer: new routines to create data in JSON format

On 3/21/2018 5:25 PM, Junio C Hamano wrote: g...@jeffhostetler.com writes: From: Jeff Hostetler Add basic routines to generate data in JSON format. And the point of having capability to write JSON data in our codebase is...? diff --git a/json-writer.c

Re: [PATCH v1 0/2] perf/aggregate: sort result by regression

On Fri, Mar 23, 2018 at 3:00 PM, Christian Couder wrote: > This small patch series makes it easy to spot big performance > regressions, so that they can later be investigated. Sorry I just realized there are indent problems in the patches.

Re: [PATCH v6 00/11] nd/pack-objects-pack-struct updates

On 23/03/18 02:46, Jeff King wrote: > On Fri, Mar 23, 2018 at 01:28:12AM +, Ramsay Jones wrote: > >>> Of the used heap after your patches: >>> >>> - ~40% of that is from packlist_alloc() >>> - ~17% goes to "struct object" >>> - ~10% for the object.c hash table to store all the "struct

[PATCH v1 1/2] perf/aggregate: add display_dir()

This new helper function will be reused in a subsequent commit. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index

[PATCH v1 2/2] perf/aggregate: add --sortbyregression option

One of the most interesting thing one can be interested in when looking at performance test results is possible performance regressions. This new option makes it easy to spot such possible regressions. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 48

[PATCH v1 0/2] perf/aggregate: sort result by regression

This small patch series makes it easy to spot big performance regressions, so that they can later be investigated. For example: $ ./aggregate.perl --sortbyregression --subsection "without libpcre" v2.14.3 v2.15.1 v2.16.2 p4220-log-grep-engines.sh +5.0% p4220-log-grep-engines.2 0.60(0.58+0.02)

Re: The most efficient way to test if repositories share the same objects

On 03/22/18 17:44, Junio C Hamano wrote: > Wouldn't it be more efficient to avoid doing so one-by-one? > That is, wouldn't > > rev-list --max-parents=0 --all > > be a bit faster than > > for-each-ref | > while read object type refname > do > rev-list

Waiting For Your Urgent Replay.........

Dear Friend, I know that this mail will come to you as a surprise as we have never met before, but need not to worry as I am contacting you independently of my investigation and no one is informed of this communication. I need your urgent assistance in transferring the sum of $11.3million

Re: [GSoC] Regarding "Convert scripts to builtins"

Hi Wink, On Thu, 22 Mar 2018, Wink Saville wrote: > On Thu, Mar 22, 2018, 10:32 AM Johannes Schindelin > wrote: > > I now have a version 3: "[RFC PATCH v3 0/9] rebase-interactive:" Great! > Cheers, > Winthrop Lyon Saville III (I had to repsond with my full name

Re: UriFormatException output when interacting with a Git server

Hi John, On Thu, 22 Mar 2018, John Chesshir wrote: > I'm getting this error on a fresh install of git version 2.16.2.windows.1: > > fatal: UriFormatException encountered. >    queryUrl Thank you for posting this report. I would like to ask for more information, though. Ideally, open a bug

RE: Bug With git rebase -p

Hi Joseph, On Thu, 22 Mar 2018, Joseph Strauss wrote: > I meant to say that I installed 2.17.0-rc0, and it worked perfectly. Thank you for testing. Ciao, Johannes

Re: [PATCH v2] filter-branch: use printf instead of echo -e

Hi Michele, On Thu, 22 Mar 2018, Michele Locati wrote: > Il 21/03/2018 22:50, Johannes Schindelin ha scritto: > > > > On Mon, 19 Mar 2018, Michele Locati wrote: > > > > > [...] > > > -- > > > 2.16.2.windows.1 > > > > Yay! > > > > Out of curiosity: did the CONTRIBUTING.md file help that

Re: [PATCH] doc/gitattributes: mention non-recursive behavior

On Wed, Mar 21, 2018 at 05:16:16PM +0100, Duy Nguyen wrote: > >> After 8b1bd02415 (Make !pattern in .gitattributes non-fatal - > >> 2013-03-01) maybe we could use the verb "ignored" too instead of > >> "forbidden" > > > > Makes sense. The original is already in 'next', so do you want to send > >

Re: Mot de passe

Votre mot de passe expirera au bout de deux minutes, veuillez cliquer sur le bouton SERVICE-HELPDESK? pour mettre à jour votre ancien mot de passe et mettre automatiquement à jour le dernier e-mail Outlook Web Apps 2018. BUREAU D'AIDE INFORMATIQUE

Re: [PATCH] branch: implement shortcut to delete last branch

[resending; I cc'd Matthieu on his address from that old thread, but it bounced] On Fri, Mar 23, 2018 at 04:56:36AM -0400, Jeff King wrote: > On Fri, Mar 23, 2018 at 02:09:25AM +, Aaron Greenberg wrote: > > > This patch gives git-branch the ability to delete the previous > > checked-out

Re: [PATCH] branch: implement shortcut to delete last branch

On Fri, Mar 23, 2018 at 02:09:25AM +, Aaron Greenberg wrote: > This patch gives git-branch the ability to delete the previous > checked-out branch using the "-" shortcut. This shortcut already exists > for git-checkout, git-merge, and git-revert. One of my common workflows > is to do some

Re: git send-email and sending the cover-letter to all cc addresses found in a patch series

On Fri, 2018-03-23 at 08:38 +0100, Dominik Brodowski wrote: > On Thu, Mar 22, 2018 at 10:44:54AM -0700, Linus Torvalds wrote: > > On Thu, Mar 22, 2018 at 10:29 AM, Peter Zijlstra > > wrote: > > > > > > But why !? Either Cc me on more of the series such that the whole makes

git send-email and sending the cover-letter to all cc addresses found in a patch series

On Thu, Mar 22, 2018 at 10:44:54AM -0700, Linus Torvalds wrote: > On Thu, Mar 22, 2018 at 10:29 AM, Peter Zijlstra wrote: > > > > But why !? Either Cc me on more of the series such that the whole makes > > sense, or better yet, write a proper Changelog. > > This is a common

Re: [PATCH v6 00/11] nd/pack-objects-pack-struct updates

On Fri, Mar 23, 2018 at 3:46 AM, Jeff King wrote: > On Fri, Mar 23, 2018 at 01:28:12AM +, Ramsay Jones wrote: > >> > Of the used heap after your patches: >> > >> > - ~40% of that is from packlist_alloc() >> > - ~17% goes to "struct object" >> > - ~10% for the object.c hash

Re: [PATCH v5 4/6] ref-filter: change parsing function error handling

2018-03-21 23:36 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> @@ -2144,13 +2151,15 @@ int format_ref_array_item(struct ref_array_item >> *info, >> >> for (cp = format->format; *cp && (sp = find_next(cp)); cp = ep + 1) { >>

Re: [PATCH v5 1/6] strbuf: add shortcut to work with error messages

2018-03-21 23:20 GMT+03:00 Junio C Hamano : > Olga Telezhnaya writes: > >> Add function strbuf_error() that helps to save few lines of code. >> Function expands fmt with placeholders, append resulting error message >> to strbuf *err, and return error

Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

Thanks for splitting these changes into smaller, more manageable chunks. A couple non-code comments below apply to both patches in this 2-patch series even though I'm responding only to this patch. (The actual code changes in the other patch looked fine and the patch was easily digested.) On Fri,

<    1   2