[PATCH 0/1] t7406: avoid failures solely due to timing issues

2018-07-23 Thread Johannes Schindelin via GitGitGadget
This fixes a regression test that produces false positives occasionally: https://git-for-windows.visualstudio.com/git/_build/results?buildId=14035&view=logs Johannes Schindelin (1): t7406: avoid failures solely due to timing issues t/t7406-submodule-update.sh | 11 ++- 1 file changed,

Reply

2018-07-23 Thread Buka Saraki
Greeting, I contacted you last two weeks and I got no response. I mentioned about my late client that has the same surname with you. He deposited the sum of US$10.5 million dollars in one of the bank here in our country and they have asked me to provide a next of kin.Kindly show your interest to w

Re: [PATCH 0/2] travis-ci: fail if Coccinelle found something to transform

2018-07-23 Thread Derrick Stolee
On 7/23/2018 9:02 AM, SZEDER Gábor wrote: The first patch makes the static analysis build job on Travis CI faster by running it with 'make -j2'. The second patch makes it more more useful by failing the build job if Coccinelle finds something to transform, thereby drawing our attention to undesi

Re: [PATCH 3/2 for pb/bisect-helper-2] squash! bisect--helper: `bisect_start` shell function partially in C

2018-07-23 Thread Derrick Stolee
On 7/23/2018 9:06 AM, SZEDER Gábor wrote: bisect--helper: use oid_to_hex() Signed-off-by: SZEDER Gábor --- builtin/bisect--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index fc02f889e6..eac4c27787 100644 ---

Re: [PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform

2018-07-23 Thread Derrick Stolee
On 7/23/2018 9:02 AM, SZEDER Gábor wrote: Coccinelle's and in turn 'make coccicheck's exit code only indicates that Coccinelle managed to finish its analysis without any errors (e.g. no unknown --options, no missing files, no syntax errors in the semantic patches, etc.), but it doesn't indicate w

Re: [PATCH 1/2] t3507: add a testcase showing failure with sparse checkout

2018-07-23 Thread Ben Peart
On 7/21/2018 3:21 AM, Eric Sunshine wrote: On Sat, Jul 21, 2018 at 2:34 AM Elijah Newren wrote: diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-pick-conflict.sh @@ -392,4 +392,17 @@ test_expect_success 'commit --amend -s places the sign-off at the right place' ' +test_expect_f

[PATCH 3/2 for pb/bisect-helper-2] squash! bisect--helper: `bisect_start` shell function partially in C

2018-07-23 Thread SZEDER Gábor
bisect--helper: use oid_to_hex() Signed-off-by: SZEDER Gábor --- builtin/bisect--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index fc02f889e6..eac4c27787 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisec

[PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform

2018-07-23 Thread SZEDER Gábor
Coccinelle's and in turn 'make coccicheck's exit code only indicates that Coccinelle managed to finish its analysis without any errors (e.g. no unknown --options, no missing files, no syntax errors in the semantic patches, etc.), but it doesn't indicate whether it found any undesired code patterns

[PATCH 1/2] travis-ci: run Coccinelle static analysis with two parallel jobs

2018-07-23 Thread SZEDER Gábor
Currently the static analysis build job runs Coccinelle using a single 'make' job. Using two parallel jobs cuts down the build job's run time from around 10-12mins to 6-7mins, sometimes even under 6mins (there is quite large variation between build job runtimes). More than two parallel jobs don't

[PATCH 0/2] travis-ci: fail if Coccinelle found something to transform

2018-07-23 Thread SZEDER Gábor
The first patch makes the static analysis build job on Travis CI faster by running it with 'make -j2'. The second patch makes it more more useful by failing the build job if Coccinelle finds something to transform, thereby drawing our attention to undesired code patterns trying to enter the codeba

Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros

2018-07-23 Thread SZEDER Gábor
On Tue, Jun 19, 2018 at 5:21 PM Derrick Stolee wrote: > > On 6/19/2018 10:51 AM, Duy Nguyen wrote: > > Do we run 'make coccicheck' > > automatically somewhere? If true, I need to move this script elsewhere > > because it's meant to run manually. You run it when you intend to do > > more manual fi

Re: Hash algorithm analysis

2018-07-23 Thread demerphq
On Mon, 23 Jul 2018 at 14:48, Sitaram Chamarty wrote: > On 07/23/2018 06:10 PM, demerphq wrote: > > On Sun, 22 Jul 2018 at 01:59, brian m. carlson > > wrote: > >> I will admit that I don't love making this decision by myself, because > >> right now, whatever I pick, somebody is going to be unhapp

Re: [BUG] merge-recursive overly aggressive when skipping updating the working tree

2018-07-23 Thread Ben Peart
On 7/20/2018 7:02 PM, Elijah Newren wrote: On Fri, Jul 20, 2018 at 3:05 PM, Junio C Hamano wrote: Elijah Newren writes: Ah, okay, that's helpful. So, if there are conflicts, it should be free to clear the skip_worktree flag. Since merge-recursive calls add_cacheinfo() for all entries it

Re: Hash algorithm analysis

2018-07-23 Thread Sitaram Chamarty
On 07/23/2018 06:10 PM, demerphq wrote: > On Sun, 22 Jul 2018 at 01:59, brian m. carlson > wrote: >> I will admit that I don't love making this decision by myself, because >> right now, whatever I pick, somebody is going to be unhappy. I want to >> state, unambiguously, that I'm trying to make

Re: Hash algorithm analysis

2018-07-23 Thread demerphq
On Sun, 22 Jul 2018 at 01:59, brian m. carlson wrote: > I will admit that I don't love making this decision by myself, because > right now, whatever I pick, somebody is going to be unhappy. I want to > state, unambiguously, that I'm trying to make a decision that is in the > interests of the Git

Re: [PATCH] pack-objects: fix performance issues on packing large deltas

2018-07-23 Thread Elijah Newren
On Fri, Jul 20, 2018 at 10:43 AM, Elijah Newren wrote: > On Fri, Jul 20, 2018 at 8:39 AM, Nguyễn Thái Ngọc Duy > wrote: >> If we want a quick fix for 2.18.1. I suggest bumping up >> OE_DELTA_SIZE_BITS like Elijah did in his second option. I don't >> think it's safe to fast track this patch.

[PATCH 1/1] add hook pre-p4-submit

2018-07-23 Thread Chen Bin
Hook pre-p4-submit is executed before git-p4 actually submits code. If the hook exits with non-zero value, submit process will abort. Signed-off-by: Chen Bin --- git-p4.py | 6 ++ t/t9800-git-p4-basic.sh | 22 ++ 2 files changed, 28 insertions(+) diff --gi

<    1   2