Re: [PATCH] http-backend: treat empty CONTENT_LENGTH as zero

2018-09-11 Thread Jeff King
On Tue, Sep 11, 2018 at 11:15:13AM -0700, Junio C Hamano wrote: > > That said, a quick search of codesearch.debian.net mostly finds > > examples using straight comparison, so maybe the patch is fine as-is. > > I do not think we would mind terribly if we do not support > combinations like

[PATCH 2/3] archive: implement protocol v2 archive command

2018-09-11 Thread Josh Steadmon
This adds a new archive command for protocol v2. The command expects arguments in the form "argument X" which are passed unmodified to git-upload-archive--writer. This command works over the file://, Git, and SSH transports. HTTP support will be added in a separate patch. Signed-off-by: Josh

[PATCH 3/3] archive: allow archive over HTTP(S) with proto v2

2018-09-11 Thread Josh Steadmon
Signed-off-by: Josh Steadmon --- builtin/archive.c | 8 +++- http-backend.c | 10 +- transport-helper.c | 5 +++-- 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/builtin/archive.c b/builtin/archive.c index 73831887d..5fa75b3f7 100644 --- a/builtin/archive.c

Add proto v2 archive command with HTTP support

2018-09-11 Thread Josh Steadmon
This series adds a new protocol v2 command for archiving, and allows this command to work over HTTP(S). This was previously discussed in [1]. I've CCed everyone who participated in that discussion. [1]:

[PATCH 1/3] archive: use packet_reader for communications

2018-09-11 Thread Josh Steadmon
Using packet_reader will simplify version detection and capability handling, which will make implementation of protocol v2 support in git-archive easier. Signed-off-by: Josh Steadmon --- builtin/archive.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v2 17/18] commit-reach: make can_all_from_reach... linear

2018-09-11 Thread Jeff King
On Wed, Sep 12, 2018 at 12:14:25AM -0400, Jeff King wrote: > > + ALLOC_ARRAY(list, from->nr); > > for (i = 0; i < from->nr; i++) { > > - struct object *from_one = from->objects[i].item; > > + list[i] = (struct commit *)from->objects[i].item; > > Some of the objects in

Re: [PATCH v2 17/18] commit-reach: make can_all_from_reach... linear

2018-09-11 Thread Jeff King
On Fri, Jul 20, 2018 at 04:33:28PM +, Derrick Stolee wrote: > The can_all_from_reach_with_flags() algorithm is currently quadratic in > the worst case, because it calls the reachable() method for every 'from' > without tracking which commits have already been walked or which can > already

2.19.0 regression: leaving editor with empty commit message doesn't stop rebase [was: Re: [RFC PATCH v5 9/9] git-rebase: make --allow-empty-message the default]

2018-09-11 Thread SZEDER Gábor
Lately I noticed that occasionally I ended up with an empty commit message after an interactive rebase. However, since I didn't do anything that I haven't already done countless times before, I thought that one of my local patches touching the area where 'git commit' calls launch_editor() got

Re: What's cooking in git.git (Sep 2018, #02; Tue, 11)

2018-09-11 Thread Stephen & Linda Smith
On Tuesday, September 11, 2018 3:20:19 PM MST Junio C Hamano wrote: > > * jc/wt-status-state-cleanup (2018-09-07) 1 commit > - WIP: roll wt_status_state into wt_status and populate in the collect > phase (this branch uses ss/wt-status-committable.) > > * ss/wt-status-committable (2018-09-07) 4

Re: [PATCH 6/9] submodule.c: do not copy around submodule list

2018-09-11 Thread Ramsay Jones
On 12/09/18 00:49, Stefan Beller wrote: > 'calculate_changed_submodule_paths' uses a local list to compute the > changed submodules, and then produces the result by copying appropriate > items into the result list. > > Instead use the result list directly and prune items afterwards > using

Re: [PATCH 1/9] string-list: add string_list_{pop, last} functions

2018-09-11 Thread Ramsay Jones
On 12/09/18 00:49, Stefan Beller wrote: > Add a few functions to allow a string-list to be used as a stack: > > - string_list_last() lets a caller peek the string_list_item at the >end of the string list. The caller needs to be aware that it is >borrowing a pointer, which can become

Re: Is it possible to git clone --filter= without any objects?

2018-09-11 Thread Matthew DeVore
On Tue, Sep 11, 2018 at 11:30 AM Ciro Santilli wrote: > The mentioned --filter=tree:0 would basically do what I want it seems, > good to hear!. I wonder why not call it tree:none though to match > blob:none. There are some plans of making tree: accept positive integers in order to filter out

[PATCH 6/9] submodule.c: do not copy around submodule list

2018-09-11 Thread Stefan Beller
'calculate_changed_submodule_paths' uses a local list to compute the changed submodules, and then produces the result by copying appropriate items into the result list. Instead use the result list directly and prune items afterwards using string_list_remove_empty_items. By doin so we'll have

[PATCH 8/9] fetch: retry fetching submodules if sha1 were not fetched

2018-09-11 Thread Stefan Beller
Currently when git-fetch is asked to recurse into submodules, it dispatches a plain "git-fetch -C " (and some submodule related options such as prefix and recusing strategy, but) without any information of the remote or the tip that should be fetched. This works surprisingly well in some

[PATCH 4/9] submodule.c: sort changed_submodule_names before searching it

2018-09-11 Thread Stefan Beller
We can string_list_insert() to maintain sorted-ness of the list as we find new items, or we can string_list_append() to build an unsorted list and sort it at the end just once. To pick which one is more appropriate, we notice the fact that we discover new items more or less in the already sorted

[PATCH 7/9] submodule: fetch in submodules git directory instead of in worktree

2018-09-11 Thread Stefan Beller
This patch started as a refactoring to make 'get_next_submodule' more readable, but upon doing so, I realized that git-fetch actually doesn't need to be run in the worktree. So let's run it in the git dir instead. That should pave the way towards fetching submodules that are currently not checked

[PATCH 1/9] string-list: add string_list_{pop, last} functions

2018-09-11 Thread Stefan Beller
Add a few functions to allow a string-list to be used as a stack: - string_list_last() lets a caller peek the string_list_item at the end of the string list. The caller needs to be aware that it is borrowing a pointer, which can become invalid if/when the string_list is resized. -

[PATCH 0/9] fetch: make sure submodule oids are fetched

2018-09-11 Thread Stefan Beller
Currently when git-fetch is asked to recurse into submodules, it dispatches a plain "git-fetch -C " (and some submodule related options such as prefix and recusing strategy, but) without any information of the remote or the tip that should be fetched. This works surprisingly well in some

[PATCH 9/9] builtin/fetch: check for submodule updates for non branch fetches

2018-09-11 Thread Stefan Beller
For Gerrit users that use submodules the invocation of fetch without a branch is their main use case. Signed-off-by: Stefan Beller --- builtin/fetch.c | 5 - t/t5526-fetch-submodules.sh | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/builtin/fetch.c

[PATCH 5/9] submodule: move global changed_submodule_names into fetch submodule struct

2018-09-11 Thread Stefan Beller
The `changed_submodule_names` are only used for fetching, so let's make it part of the struct that is passed around for fetching submodules. Signed-off-by: Stefan Beller --- submodule.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff

[PATCH 2/9] sha1-array: provide oid_array_filter

2018-09-11 Thread Stefan Beller
Helped-by: Junio C Hamano Signed-off-by: Stefan Beller --- sha1-array.c | 18 ++ sha1-array.h | 5 + 2 files changed, 23 insertions(+) diff --git a/sha1-array.c b/sha1-array.c index 265941fbf40..76323935dd7 100644 --- a/sha1-array.c +++ b/sha1-array.c @@ -77,3 +77,21 @@

[PATCH 3/9] submodule.c: fix indentation

2018-09-11 Thread Stefan Beller
The submodule subsystem is really bad at staying within 80 characters. Fix it while we are here. Signed-off-by: Stefan Beller --- submodule.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/submodule.c b/submodule.c index a2b266fbfae..d29dfa3d1f5 100644 ---

[PATCH v4 2/5] read-cache: load cache extensions on a worker thread

2018-09-11 Thread Ben Peart
This patch helps address the CPU cost of loading the index by loading the cache extensions on a worker thread in parallel with loading the cache entries. In some cases, loading the extensions takes longer than loading the cache entries so this patch utilizes the new EOIE to start the thread to

[PATCH v4 1/5] eoie: add End of Index Entry (EOIE) extension

2018-09-11 Thread Ben Peart
The End of Index Entry (EOIE) is used to locate the end of the variable length index entries and the beginning of the extensions. Code can take advantage of this to quickly locate the index extensions without having to parse through all of the index entries. Because it must be able to be loaded

[PATCH v4 0/5] read-cache: speed up index load through parallelization

2018-09-11 Thread Ben Peart
This version of the patch merges in Duy's work to speed up index v4 decoding. I had to massage it a bit to get it to work with the multi-threading but its still largely his code. It helps a little (3%-4%) when the cache entry thread(s) take the longest and not when the index extensions loading is

[PATCH v4 5/5] read-cache: clean up casting and byte decoding

2018-09-11 Thread Ben Peart
This patch does a clean up pass to minimize the casting required to work with the memory mapped index (mmap). It also makes the decoding of network byte order more consistent by using get_be32() where possible. Signed-off-by: Ben Peart --- read-cache.c | 49

[PATCH v4 4/5] read-cache.c: optimize reading index format v4

2018-09-11 Thread Ben Peart
From: Nguyễn Thái Ngọc Duy Index format v4 requires some more computation to assemble a path based on a previous one. The current code is not very efficient because - it doubles memory copy, we assemble the final path in a temporary first before putting it back to a cache_entry -

[PATCH v4 3/5] read-cache: speed up index load through parallelization

2018-09-11 Thread Ben Peart
This patch helps address the CPU cost of loading the index by creating multiple threads to divide the work of loading and converting the cache entries across all available CPU cores. It accomplishes this by having the primary thread loop across the index file tracking the offset and (for V4

Re: 2.19.0.rc2.windows.1: stash fails with dirty submodule

2018-09-11 Thread Stefan Beller
On Fri, Sep 7, 2018 at 5:35 PM Jonathan Nieder wrote: > > Hi, > > Thomas Braun wrote: > > > I'm using git with stash and rebase builtins. > > > > $ git --version --build-options > > > > git version 2.19.0.rc2.windows.1 > [...] > > mkdir test > > cd test > > git init > > echo 1 > file > > git add

What's cooking in git.git (Sep 2018, #02; Tue, 11)

2018-09-11 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. Git 2.19 is out. The tip of

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Eric Sunshine
On Tue, Sep 11, 2018 at 4:26 PM Derrick Stolee via GitGitGadget wrote: > The commit 40ce4160 "format-patch: allow --range-diff to apply to > a lone-patch" added the ability to see a range-diff as commentary > after the commit message of a single patch series (i.e. [PATCH] > instead of [PATCH

Re: [PATCH 0/1] Add coverage for 'git format-patch --range-diff' single-patch case

2018-09-11 Thread Eric Sunshine
On Tue, Sep 11, 2018 at 4:26 PM Derrick Stolee via GitGitGadget wrote: > In es/format-patch-rangediff, we added a '--range-diff' option to > git-format-patch to automatically add a range-diff. We also added an option > to write the diff as commentary to a single patch submission. However, this >

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Junio C Hamano
Junio C Hamano writes: >> +test_expect_success 'format-patch --range-diff as commentary' ' >> +git format-patch --stdout --range-diff=HEAD~1 HEAD~1 >actual && >> +grep -A 1 -e "\-\-\-" actual | grep "Range-diff:" > > Isn't "grep -A" GNUism? Sorry for short-write(2) X-<. Perhaps

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Stefan Beller
On Tue, Sep 11, 2018 at 1:21 PM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The commit 40ce4160 "format-patch: allow --range-diff to apply to > a lone-patch" added the ability to see a range-diff as commentary > after the commit message of a single patch series (i.e.

Re: [PATCH 1/2] trace: add trace_print_string_list_key

2018-09-11 Thread Jeff King
On Mon, Sep 10, 2018 at 08:08:35PM -0700, Stefan Beller wrote: > > So the choice being offered are: > > > > (0) take 2/2 only, keeping zero unused helper. > > (1) take 1/2 only, keeping two unused helpers. > > (2) do nothing, keeping the simple unused helper we had from the > > beginning

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The commit 40ce4160 "format-patch: allow --range-diff to apply to > a lone-patch" added the ability to see a range-diff as commentary > after the commit message of a single patch series (i.e. [PATCH] > instead of [PATCH X/N]).

Re: git silently ignores include directive with single quotes

2018-09-11 Thread Jeff King
On Tue, Sep 11, 2018 at 01:36:01PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I think that's syntactically invalid. At any rate, there are clearly > > three options for setting a bit: > > > > 1. In the section header (+include, or Ævar's includeIf suggestion). > > > > 2. In

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Junio C Hamano
Stefan Beller writes: >> >> >> >> [1] >> >> https://public-inbox.org/git/1421343725-3973-1-git-send-email-kuleshovm...@gmail.com/ >> >> Signed-off-by: Stefan Beller >> > >> > I'll add a blank line before the sign-off. Is this an example that >> > our "where is the existing trailer?" code

Re: [PATCHv2 2/2] rerere: avoid buffer overrun

2018-09-11 Thread Junio C Hamano
Elijah Newren writes: > check_one_conflict() compares `i` to `active_nr` in two places to avoid > buffer overruns, but left out an important third location. > > The code did used to have a check here comparing i to active_nr, back > before commit fb70a06da2f1 ("rerere: fix an off-by-one

Re: git silently ignores include directive with single quotes

2018-09-11 Thread Junio C Hamano
Jeff King writes: > I think that's syntactically invalid. At any rate, there are clearly > three options for setting a bit: > > 1. In the section header (+include, or Ævar's includeIf suggestion). > > 2. In another key (which looks pretty clean, but does introduce > ordering

[PATCH v2] http-backend test: make empty CONTENT_LENGTH test more realistic

2018-09-11 Thread Max Kirillov
This is a test of smart HTTP, so it should use the smart HTTP endpoints (e.g. /info/refs?service=git-receive-pack), not dumb HTTP (HEAD). Signed-off-by: Jonathan Nieder Signed-off-by: Max Kirillov --- > do you know why the test passes without 574c513e8d (http-backend: allow > empty

Re: [PATCH 0/1] Add coverage for 'git format-patch --range-diff' single-patch case

2018-09-11 Thread Derrick Stolee
On 9/11/2018 4:21 PM, Derrick Stolee via GitGitGadget wrote: In es/format-patch-rangediff, we added a '--range-diff' option to git-format-patch to automatically add a range-diff. We also added an option to write the diff as commentary to a single patch submission. However, this check was not

Re: [PATCH v2 0/2] commit-graph: add progress output

2018-09-11 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Based on feedback on v1, and the "this is yelling at my users through > gc.log" bug I found. I notice that between 'master' and 'pu' there already is one new callsite of the write_commit_graph_reachable() function; because I suspect that we will discover more

[PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit 40ce4160 "format-patch: allow --range-diff to apply to a lone-patch" added the ability to see a range-diff as commentary after the commit message of a single patch series (i.e. [PATCH] instead of [PATCH X/N]). However, this functionality was not covered by a test

[PATCH 0/1] Add coverage for 'git format-patch --range-diff' single-patch case

2018-09-11 Thread Derrick Stolee via GitGitGadget
In es/format-patch-rangediff, we added a '--range-diff' option to git-format-patch to automatically add a range-diff. We also added an option to write the diff as commentary to a single patch submission. However, this check was not tested. I discovered this test gap by running 'make coverage-test

[PATCH v3 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-11 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c| 36 --- t/t0051-windows-named-pipe.sh | 2 +- 2 files changed, 34 insertions(+), 4 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..18caf21969

[PATCH v3 0/2] Fixup for js/mingw-o-append

2018-09-11 Thread Jeff Hostetler via GitGitGadget
The recent change mingw O_APPEND change breaks writing to named pipes on Windows. The first commit adds a new test to confirm the breakage and the second commit fixes the problem. These could be squashed together or we can just keep the fix and omit the test if that would be better. d641097589

[PATCH v3 1/2] t0051: test GIT_TRACE to a windows named pipe

2018-09-11 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Create a test-tool helper to create the server side of a windows named pipe, wait for a client connection, and copy data written to the pipe to stdout. Create t0051 test to route GIT_TRACE output of a command to a named pipe using the above test-tool helper. Signed-off-by:

Re: Allow git bisect in reverse mode?

2018-09-11 Thread Ævar Arnfjörð Bjarmason
On Tue, Sep 11, 2018 at 9:54 PM Brad Davis wrote: > I'm currently trying to determine when an issue was fixed in a long > list of commits. I attempted to do this by running `git bisect` and > marking the commit where I knew it was broken as bad, and the tip as > good, but I got back an error

Allow git bisect in reverse mode?

2018-09-11 Thread Brad Davis
I'm currently trying to determine when an issue was fixed in a long list of commits. I attempted to do this by running `git bisect` and marking the commit where I knew it was broken as bad, and the tip as good, but I got back an error message saying that good revs weren't ancestors of bad ones.

Re: [PATCH] Revert "Merge branch 'sb/submodule-core-worktree'" (was Re: Old submodules broken in 2.19rc1 and 2.19rc2)

2018-09-11 Thread Junio C Hamano
Johannes Sixt writes: >>> Like this (generated using "git revert -m1)? >> >> OK. Thanks for taking care of it. > > Please don't forget to remove the corresponding release notes entry. Thanks for a reminder. Very much appreciated.

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Stefan Beller
On Tue, Sep 11, 2018 at 12:31 PM Junio C Hamano wrote: > > Junio C Hamano writes: > > > Stefan Beller writes: > > > >> The helper function stayed unused for 3 years. A removal of that function > > > > I think it stayed unused for more than that before the previous > > proposal to remove it was

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> The helper function stayed unused for 3 years. A removal of that function > > I think it stayed unused for more than that before the previous > proposal to remove it was written (I do not bother going back to my > earlier message that

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Junio C Hamano
Stefan Beller writes: > The helper function stayed unused for 3 years. A removal of that function I think it stayed unused for more than that before the previous proposal to remove it was written (I do not bother going back to my earlier message that identified which exact commit this was

Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change

2018-09-11 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Sep 11, 2018 at 11:16 AM Junio C Hamano wrote: >> >> Stefan Beller writes: >> >> >> [...] So this should be sufficient. >> > >> > Yup. >> > Thanks for keeping track of this patch, as I lost track of it. >> > >> > thanks, >> > Stefan >> >> So does the above

Re: with git 1.8.3.1 get only merged tags

2018-09-11 Thread Jeff King
On Tue, Sep 11, 2018 at 12:43:15PM +0200, Michal Novotny wrote: > I need to emulate git tag --merged with very old git 1.8.3.1. Is that > somehow possible? > I am looking for a bash function that would take what git 1.8.3.1 > offers and return only the tags accessible from the current branch >

[PATCHv2 0/2] Fix rerere segfault with specially crafted merge

2018-09-11 Thread Elijah Newren
This series documents and fixes a rerere segfault (dating back to git-2.7.0) when a merge strategy makes the last entry in the index be at stage 1. Changes since last version: - In my last submission I only had the code fix and no testcase; I even commented in the commit message that the

[PATCHv2 1/2] t4200: demonstrate rerere segfault on specially crafted merge

2018-09-11 Thread Elijah Newren
Signed-off-by: Elijah Newren --- t/t4200-rerere.sh | 29 + 1 file changed, 29 insertions(+) diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh index 65da74c766..f9294b7677 100755 --- a/t/t4200-rerere.sh +++ b/t/t4200-rerere.sh @@ -577,4 +577,33 @@ test_expect_success

[PATCHv2 2/2] rerere: avoid buffer overrun

2018-09-11 Thread Elijah Newren
check_one_conflict() compares `i` to `active_nr` in two places to avoid buffer overruns, but left out an important third location. The code did used to have a check here comparing i to active_nr, back before commit fb70a06da2f1 ("rerere: fix an off-by-one non-bug", 2015-06-28), however the code

[PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Stefan Beller
The helper function stayed unused for 3 years. A removal of that function was proposed before[1], but now time has proven we really do not need the function. [1] https://public-inbox.org/git/1421343725-3973-1-git-send-email-kuleshovm...@gmail.com/ Signed-off-by: Stefan Beller --- string-list.c

Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change

2018-09-11 Thread Stefan Beller
On Tue, Sep 11, 2018 at 11:16 AM Junio C Hamano wrote: > > Stefan Beller writes: > > >> [...] So this should be sufficient. > > > > Yup. > > Thanks for keeping track of this patch, as I lost track of it. > > > > thanks, > > Stefan > > So does the above exchange mean that >

Re: [PATCH 06/11] submodule.c: sort changed_submodule_names before searching it

2018-09-11 Thread Stefan Beller
On Thu, Sep 6, 2018 at 11:03 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > Instead of sorting it after we created an unsorted list, we could insert > > correctly into the list. > > It is unclear what problem you are solving, especially with > subjunctive "could" there. We are

Re: Is it possible to git clone --filter= without any objects?

2018-09-11 Thread Ciro Santilli
On Tue, Sep 11, 2018 at 6:47 PM Junio C Hamano wrote: > > Jonathan Tan writes: > > > By "without any objects" in your email subject, do you mean "without > > blob and tree objects"? If yes, there is some code in the > > md/filter-trees branch that can do that with a "--filter=tree:0" > > option.

Re: [PATCH] http-backend: treat empty CONTENT_LENGTH as zero

2018-09-11 Thread Junio C Hamano
Junio C Hamano writes: >>> + /* >>> +* According to RFC 3875, an empty or missing >>> +* CONTENT_LENGTH means "no body", but RFC 3875 >>> +* precedes HTTP/1.1 and chunked encoding. Apache and >>> +* its imitators leave CONTENT_LENGTH

Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change

2018-09-11 Thread Junio C Hamano
Stefan Beller writes: >> [...] So this should be sufficient. > > Yup. > Thanks for keeping track of this patch, as I lost track of it. > > thanks, > Stefan So does the above exchange mean that <20180904135258.31300-1-phillip.w...@talktalk.net> is ready to go with your Acked-by?

Re: [PATCH] http-backend: treat empty CONTENT_LENGTH as zero

2018-09-11 Thread Junio C Hamano
Jonathan Nieder writes: > Kicking off the reviews: ;-) > > Jonathan Nieder wrote: > >> --- a/http-backend.c >> +++ b/http-backend.c >> @@ -350,10 +350,25 @@ static ssize_t read_request_fixed_len(int fd, ssize_t >> req_len, unsigned char **o >> >> static ssize_t get_content_length(void) >

Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change

2018-09-11 Thread Stefan Beller
> [...] So this should be sufficient. Yup. Thanks for keeping track of this patch, as I lost track of it. thanks, Stefan

Re: Is it possible to git clone --filter= without any objects?

2018-09-11 Thread Junio C Hamano
Jonathan Tan writes: > By "without any objects" in your email subject, do you mean "without > blob and tree objects"? If yes, there is some code in the > md/filter-trees branch that can do that with a "--filter=tree:0" > option. I too was wondering what the "without any objects" thing meant

Re: [PATCH] t5551-http-fetch-smart.sh: sort cookies before comparing

2018-09-11 Thread Junio C Hamano
Todd Zullinger writes: > With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output > used in the 'cookies stored in http.cookiefile when http.savecookies > set' test before comparing it to the expected cookies. > > ¹ https://github.com/curl/curl/commit/e2ef8d6fa ("cookies: support

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Thomas Gummerer
On 09/11, Thomas Gummerer wrote: > I think you're on the right track here. I can not test this on Mac > OS, but on Linux, the following fails when running the test under > valgrind: > > diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh > index 2237c7f4af..a8b0ef8c1d 100755 >

Re: [PATCH v3 4/4] wt-status.c: Set the committable flag in the collect phase.

2018-09-11 Thread Junio C Hamano
"Stephen P. Smith" writes: > On Friday, September 7, 2018 3:31:55 PM MST you wrote: >> Junio C Hamano writes: > >> The patch is mostly for illustration of the idea. >> >> The result seems to compile and pass the test suite, but I haven't >> carefully thought about what else I may be breaking

Re: Is it possible to git clone --filter= without any objects?

2018-09-11 Thread Jonathan Tan
On Tue, Sep 11, 2018 at 10:15 AM, Stefan Beller wrote: > You might be pleased to hear about a series floating on the mailing list, > that started at > https://public-inbox.org/git/cover.1533854545.git.matv...@google.com/ > and promised to filter trees away, and its latest version can be found at

Re: Is it possible to git clone --filter= without any objects?

2018-09-11 Thread Stefan Beller
On Tue, Sep 11, 2018 at 12:29 AM Ciro Santilli wrote: > > At v2.19.0 I was trying to clone a fetch just a single directory: > https://stackoverflow.com/questions/600079/how-do-i-clone-a-subdirectory-only-of-a-git-repository/52269934#52269934 > > I got really close with: > > git clone --depth 1

Re: [PATCH v2 24/24] Rename functions to avoid breaking in-flight topics

2018-09-11 Thread Junio C Hamano
Duy Nguyen writes: > In the end, there's no variant, only one function that always takes > 'struct repository *' and I wanted to keep the shorter name 'rerere'. > But let's go with adding repo_rerere() and deprecating rerere(). If it > turns out later that repo_rerere is too long (or it's

Re: [PATCH v3 11/23] ll-merge.c: remove implicit dependency on the_index

2018-09-11 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > --- > apply.c| 9 ++--- > builtin/checkout.c | 3 ++- > diff.c | 2 +- > ll-merge.c | 17 + > ll-merge.h | 5 - > merge-blobs.c | 3 ++- > merge-recursive.c | 3 ++- > notes-merge.c

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Junio C Hamano
Derrick Stolee writes: > On 9/11/2018 12:04 PM, Derrick Stolee wrote: > >> The patch below includes a test that fails on Mac OSX with a segfault. > ... > Sorry, nevermind. The test failed for a different reason: Even if it is for a different reason, segfaulting is not acceptable, but it seems

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Elijah Newren
On Tue, Sep 11, 2018 at 9:07 AM ryenus wrote: > On Tue, 11 Sep 2018 at 23:49, Thomas Gummerer wrote: > > > > Hi, > > > > thanks for your bug report! > > > > On 09/11, ryenus wrote: > > > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > > > only got a Segmentation fault: 11

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Thomas Gummerer
On 09/11, Derrick Stolee wrote: > On 9/11/2018 12:04 PM, Derrick Stolee wrote: > > On 9/11/2018 11:38 AM, Derrick Stolee wrote: > > The patch below includes a test that fails on Mac OSX with a segfault. > > > > GitGitGadget PR: https://github.com/gitgitgadget/git/pull/36 > > Failed Build: > >

Editing 1

2018-09-11 Thread Aaron
Hi, If you have photos for editing, please send email to: hansre...@outlook.com We have 12 in house image editors and we can help you for cutting out your photos, or path the photos. Includes retouching if needed. Used for products photos or portrait photos, catalog photos. You may drop us

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Derrick Stolee
On 9/11/2018 12:04 PM, Derrick Stolee wrote: On 9/11/2018 11:38 AM, Derrick Stolee wrote: On 9/11/2018 11:25 AM, ryenus wrote: I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master  HEAD@{2}

Re: Temporary git files for the gitdir created on a separate drive in workdir

2018-09-11 Thread Duy Nguyen
On Mon, Sep 10, 2018 at 12:27 PM Hultqvist wrote: > > Sending again without HTML > > Den mån 10 sep. 2018 kl 12:28 skrev Hultqvist : > > > > First I need to correct my previous observations. Please don't top-post. > > Today there appeared new set of config files in the root. > > I looked into a

Re: [PATCH v3 14/23] patch-ids.c: remove implicit dependency on the_index

2018-09-11 Thread Duy Nguyen
On Mon, Sep 10, 2018 at 8:50 PM Stefan Beller wrote: > > On Sun, Sep 9, 2018 at 1:54 AM Nguyễn Thái Ngọc Duy wrote: > > > > --- > > Junio would have to forge your Sign off here? I _knew_ I missed something in that "git format-patch" command but couldn't figure out what! Will resend (I have to

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Derrick Stolee
On 9/11/2018 11:38 AM, Derrick Stolee wrote: On 9/11/2018 11:25 AM, ryenus wrote: I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master  HEAD@{2} HEAD git version 2.19.0 Segmentation

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread ryenus
On Tue, 11 Sep 2018 at 23:49, Thomas Gummerer wrote: > > Hi, > > thanks for your bug report! > > On 09/11, ryenus wrote: > > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > > only got a Segmentation fault: 11 > > > > $ git version; git range-diff origin/master

Re: Help on autocompletion not localized?

2018-09-11 Thread Duy Nguyen
On Tue, Sep 11, 2018 at 2:55 PM Jean-Noël Avila wrote: > > Hi, > > > When invoking the autocompletion help with after a double > hyphen under zsh, the help list is not localized. I guess the help list > comes from some usage output of the on-going git command, but I wasn't > able to find where

Editing 2

2018-09-11 Thread Aaron
Hi, If you have photos for editing, please send email to: hansre...@outlook.com We have 12 in house image editors and we can help you for cutting out your photos, or path the photos. Includes retouching if needed. Used for products photos or portrait photos, catalog photos. You may drop us

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Thomas Gummerer
Hi, thanks for your bug report! On 09/11, ryenus wrote: > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > only got a Segmentation fault: 11 > > $ git version; git range-diff origin/master HEAD@{2} HEAD Unfortunately the HEAD@{2} syntax needs your reflog, which is

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Elijah Newren
On Tue, Sep 11, 2018 at 8:27 AM ryenus wrote: > > I just updated to 2.19 via Homebrew, git range-diff seems cool, but I > only got a Segmentation fault: 11 > > $ git version; git range-diff origin/master HEAD@{2} HEAD > git version 2.19.0 > Segmentation fault: 11 > > Both

Re: Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread Derrick Stolee
On 9/11/2018 11:25 AM, ryenus wrote: I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master HEAD@{2} HEAD git version 2.19.0 Segmentation fault: 11 Both origin/master and my local

Git 2.19 Segmentation fault 11 on macOS

2018-09-11 Thread ryenus
I just updated to 2.19 via Homebrew, git range-diff seems cool, but I only got a Segmentation fault: 11 $ git version; git range-diff origin/master HEAD@{2} HEAD git version 2.19.0 Segmentation fault: 11 Both origin/master and my local branch each got two new commits of their own,

Re: [PATCH v7 20/22] commit-graph: add '--reachable' option

2018-09-11 Thread Christian Couder
On Tue, Sep 11, 2018 at 1:19 PM, Derrick Stolee wrote: > On 9/11/2018 1:22 AM, Christian Couder wrote: >> It would be nice if the "Future Work" section of >> Documentation/technical/commit-graph.txt had something about >> integration with 'git gc'. > > I'm a bit confused about this statement,

Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-11 Thread Jeff Hostetler
On 9/10/2018 6:00 PM, Junio C Hamano wrote: Johannes Sixt writes: +#define IS_SBS(ch) (((ch) == '/') || ((ch) == '\\')) I think you already have mingw_is_dir_sep() and its shorter alias is_dir_sep() available to you. good catch. thanks. +/* + * Does the pathname map to the local

Help on autocompletion not localized?

2018-09-11 Thread Jean-Noël Avila
Hi, When invoking the autocompletion help with after a double hyphen under zsh, the help list is not localized. I guess the help list comes from some usage output of the on-going git command, but I wasn't able to find where and how this happens (completion scripts are quite hairy). Thanks

Re: [PATCH v7 20/22] commit-graph: add '--reachable' option

2018-09-11 Thread Derrick Stolee
On 9/11/2018 1:22 AM, Christian Couder wrote: On Wed, Jun 27, 2018 at 3:24 PM, Derrick Stolee wrote: When writing commit-graph files, it can be convenient to ask for all reachable commits (starting at the ref set) in the resulting file. This is particularly helpful when writing to stdin is

Re: I HAVE NOT HEARD FROM YOUR

2018-09-11 Thread Reem Al-Hashimy
Hello, My name is ms. Reem Al-Hashimi. The UAE minister of state for international cooparation. I got your contact from a certain email database from your country while i was looking for someone to handle a huge financial transaction for me in confidence. Can you receive and invest on behalf

with git 1.8.3.1 get only merged tags

2018-09-11 Thread Michal Novotny
Hello, I need to emulate git tag --merged with very old git 1.8.3.1. Is that somehow possible? I am looking for a bash function that would take what git 1.8.3.1 offers and return only the tags accessible from the current branch tip. Could you, please, give me at least a hint how this could be

Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change

2018-09-11 Thread Phillip Wood
On 04/09/2018 19:51, Phillip Wood wrote: > Hi Stefan > > On 04/09/2018 19:08, Stefan Beller wrote: >> On Tue, Sep 4, 2018 at 6:53 AM Phillip Wood >> wrote: >>> >>> From: Phillip Wood >>> >>> If there is more than one potential moved block and the longest block >>> is not the first element of

Re: Multiple GIT Accounts & HTTPS Client Certificates - Config

2018-09-11 Thread Sergei Haller
PS: while I was trying to send the mail to this mailing list, there is some update from the stack overflow side: * I am using sslBackend schannel * the private key of my client certificate can be provided by using the http.sslKey config option * the private key is on a smart card, so there is no

Re: Multiple GIT Accounts & HTTPS Client Certificates - Config

2018-09-11 Thread Sergei Haller
no, using SSH is not an option. I have no control over the server setup whatsoever. Thx! On Mon, Sep 10, 2018 at 3:29 PM, Randall S. Becker wrote: > On September 10, 2018 4:09 AM, Sergei Haller wrote: >> my problem is basically the following: my git server (https) requires >> authentication

Is it possible to git clone --filter= without any objects?

2018-09-11 Thread Ciro Santilli
At v2.19.0 I was trying to clone a fetch just a single directory: https://stackoverflow.com/questions/600079/how-do-i-clone-a-subdirectory-only-of-a-git-repository/52269934#52269934 I got really close with: git clone --depth 1 --no-checkout --filter=blob:none \ "file://$(pwd)/server_repo"

  1   2   >