Re: git log -S or -G

2018-10-06 Thread Julia Lawall
On Sun, 7 Oct 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: > >> Git log -S or -G make it possible to find commits that have particular > >> words in the changed lines. Sometimes it would be helpful to search for > >>

Re: [PATCH v2 3/8] refs: new ref types to make per-worktree refs visible to all worktrees

2018-10-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/refs/files-backend.c b/refs/files-backend.c > index 2dd77f9485..9ca2a3706c 100644 > --- a/refs/files-backend.c > +++ b/refs/files-backend.c > ... > case REF_TYPE_PSEUDOREF: > strbuf_addf(sb, "%s/logs/%s", refs->gitdir, refname); >

Re: [PATCH] git-completion.bash: Add completion for stash list

2018-10-06 Thread Junio C Hamano
Steve writes: > Since stash list accepts git-log options, add the following useful > options that make sense in the context of the `git stash list` command: > > --name-status --oneline --patch-with-stat > > Signed-off-by: Steven Fernandez > --- > > This is my first patch to the project so

Re: [RFC PATCH v2 2/4] transport: do not list refs if possible

2018-10-06 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Sep 27, 2018 at 12:24 PM Jonathan Tan > wrote: > >> >> +test_expect_success 'when dynamically fetching missing object, do not list >> refs' ' >> + cat trace && > > leftover debug cat? It does look that way.

Re: git log -S or -G

2018-10-06 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: >> Git log -S or -G make it possible to find commits that have particular >> words in the changed lines. Sometimes it would be helpful to search for >> words in the removed lines or in the added lines

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-06 Thread Junio C Hamano
Stefan Beller writes: > After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules > file, 2017-08-03) this is no longer necessary, but that commit did not > cleanup the whole tree, but just show cased the new way how to deal with > submodules in ls-files. The log message of the

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-06 Thread Junio C Hamano
Stefan Beller writes: > In f9ee2fcdfa (grep: recurse in-process using 'struct repository', > 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep > to simplify the submodule handling. > > After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules > file,

Re: [PATCH v11 8/8] list-objects-filter: implement filter tree:0

2018-10-06 Thread Junio C Hamano
Matthew DeVore writes: > The name "tree:0" allows later filtering based on depth, i.e. "tree:1" > would filter out all but the root tree and blobs. In order to avoid > confusion between 0 and capital O, the documentation was worded in a > somewhat round-about way that also hints at this future

Re: [PATCH v5 0/7] subject: Clean up tests for test_cmp arg ordering and pipe placement

2018-10-06 Thread Junio C Hamano
Matthew DeVore writes: > This version of the patchset fixes some wording and formatting issues > pointed out by Junio. The commit message in the first patch has also > been reworded. Thanks. If no further major issues are raised, let's merge it to 'next'.

Re: [PATCH v3 0/1] Teach the builtin rebase about the builtin interactive rebase

2018-10-06 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > Note: while this patch targets pk/rebase-in-c-6-final, it will not work > correctly without ag/rebase-i-in-c. So my suggestion is to rewrite the > pk/rebas-in-c-6-final branch by first merging ag/rebase-i-in-c, then > applying this here patch,

Re: [PATCH v6 08/10] submodule: add a helper to check if it is safe to write to .gitmodules

2018-10-06 Thread Junio C Hamano
Stefan Beller writes: >> static int module_config(int argc, const char **argv, const char *prefix) >> { >> + enum { >> + CHECK_WRITEABLE = 1 >> + } command = 0; > > Can we have the default named? Then we would only use states > from within the enum? Why? Do we use a

Re: [PATCH] [Outreachy] git/userdiff.c fix regex pattern error

2018-10-06 Thread Junio C Hamano
Ananya Krishna Maram writes: >> But it does not need to be escaped, when you specify the regular >> expression the way we do. And the way we specified it is really the >> standard when specifying regular expressions in C code, i.e. *without* the >> suggested backslash. > > Aha!. this makes total

Re: [PATCH 3/8] refs: new ref types to make per-worktree refs visible to all worktrees

2018-10-06 Thread Junio C Hamano
Duy Nguyen writes: >> > The main worktree has to be treated specially because well.. it's >> > special from the beginning. So HEAD from the main worktree is >> > acccessible via the name "main/HEAD" (we can't use >> > "worktrees/main/HEAD" because "main" under "worktrees" is not >> > reserved).

Re: Understanding Index Header

2018-10-06 Thread Kevin Daudt
On Sat, Oct 06, 2018 at 05:13:45PM -0400, Farhan Khan wrote: > Hi all, > > I am writing a program that parses out the .git/index file. I am > reading the git index header documentation, but I seem to be getting > jibberish data. >

Understanding Index Header

2018-10-06 Thread Farhan Khan
Hi all, I am writing a program that parses out the .git/index file. I am reading the git index header documentation, but I seem to be getting jibberish data. https://github.com/git/git/blob/master/Documentation/technical/index-format.txt The first 12 bytes are the signature, version and entries.

CHARITY DONATION

2018-10-06 Thread Mavis Wanczyk...
-- I am Mavis Wanczyk i know you may not know me but am the latest largest US Powerball lottery winner of $758.7m just of recent, am currently helping out people in need of financial assistance, i know it's hard to believe anything on the internet, so if you don't need my help please

Re: [PATCH v3 7/7] revision.c: refactor basic topo-order logic

2018-10-06 Thread Jakub Narebski
Derrick Stolee writes: > On 9/21/2018 1:39 PM, Derrick Stolee via GitGitGadget wrote: > Hello, Git contributors. > > I understand that this commit message and patch are pretty > daunting. There is a lot to read and digest. I would like to see if > anyone is willing to put the work in to review

Re: [PATCH 1/1] commit: don't use generation numbers if not needed

2018-10-06 Thread Jakub Narebski
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > In 3afc679b "commit: use generations in paint_down_to_common()", > the queue in paint_down_to_common() was changed to use a priority > order based on generation number before commit date. This served > two purposes: > > 1.

Re: git log -S or -G

2018-10-06 Thread Ævar Arnfjörð Bjarmason
On Sat, Oct 6, 2018 at 5:16 PM Julia Lawall wrote: > Git log -S or -G make it possible to find commits that have particular > words in the changed lines. Sometimes it would be helpful to search for > words in the removed lines or in the added lines specifically. From the > implementation, I had

Re: [PATCH 0/1] v2.19.0-rc1 Performance Regression in 'git merge-base'

2018-10-06 Thread Jakub Narebski
"Derrick Stolee via GitGitGadget" writes: > As I was testing the release candidate, I stumbled across a regression in > 'git merge-base' as a result of the switch to generation numbers. The commit > message in [PATCH 1/1] describes the topology involved, but you can test it > yourself by

git log -S or -G

2018-10-06 Thread Julia Lawall
Hello, Git log -S or -G make it possible to find commits that have particular words in the changed lines. Sometimes it would be helpful to search for words in the removed lines or in the added lines specifically. From the implementation, I had the impression that this would be easy to

[no subject]

2018-10-06 Thread Major Dennis Hornbeck.
I am in the military unit here in Afghanistan, we have some amount of funds that we want to move out of the country. My partners and I need a good partner someone we can trust. It is risk free and legal. Reply to this email: hornbeckmajorden...@gmail.com Regards, Major Dennis Hornbeck.

Re: [PATCH v6 00/10] Make submodules work if .gitmodules is not checked out

2018-10-06 Thread Antonio Ospite
On Fri, 5 Oct 2018 15:05:51 +0200 Antonio Ospite wrote: [...] > t/t7416-submodule-sparse-gitmodules.sh | 78 ++ > 16 files changed, 410 insertions(+), 32 deletions(-) > create mode 100755 t/t7416-submodule-sparse-gitmodules.sh I just saw that t7416 and t7417 have been added in

Re: [PATCH v6 08/10] submodule: add a helper to check if it is safe to write to .gitmodules

2018-10-06 Thread Antonio Ospite
On Fri, 5 Oct 2018 16:50:10 -0700 Stefan Beller wrote: > > static int module_config(int argc, const char **argv, const char *prefix) > > { > > + enum { > > + CHECK_WRITEABLE = 1 > > + } command = 0; > > Can we have the default named? Then we would only use states >

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-06 Thread Antonio Ospite
On Fri, 5 Oct 2018 15:45:57 -0700 Stefan Beller wrote: > In f9ee2fcdfa (grep: recurse in-process using 'struct repository', > 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep > to simplify the submodule handling. > > After ff6f1f564c4 (submodule-config: lazy-load a

Re: [PATCH v3] coccicheck: process every source file at once

2018-10-06 Thread René Scharfe
Am 05.10.2018 um 21:00 schrieb Jeff King: > On Fri, Oct 05, 2018 at 08:50:50PM +0200, SZEDER Gábor wrote: > >> On Fri, Oct 05, 2018 at 12:59:01PM -0400, Jeff King wrote: >>> On Fri, Oct 05, 2018 at 04:53:35PM +, Keller, Jacob E wrote: >>> > Are we OK with saying 1.3-1.8GB is necessary to