Re: 'git stash list' => Segmentation fault

2019-05-27 Thread Jeff King
On Mon, May 27, 2019 at 08:47:56PM +0200, Johannes Schindelin wrote: > > bboerner@myhost:~/funproject/Src/bash$ git stash list > > Segmentation fault (core dumped) > > Segmentation fault (core dumped) > > Segmentation fault (core dumped) > > stash@{0}: On devel: NYFL optimization > > stash@{1}: On

Re: [PATCH v2] list-objects-filter: disable 'sparse:path' filters

2019-05-27 Thread Jeff King
On Sat, May 25, 2019 at 04:28:34PM +0200, Christian Couder wrote: > If someone wants to use as a filter a sparse file that is in the > repository, something like "--filter=sparse:oid=:" > already works. > > So 'sparse:path' is only interesting if the sparse file is not in > the repository. In thi

Re: [PATCH 0/1] trace2: fix tracing when NO_PTHREADS is defined

2019-05-27 Thread Jeff King
On Sat, May 25, 2019 at 05:43:55PM +0700, Duy Nguyen wrote: > > +typedef struct { > > + void *data; > > + /* extra indirection because setspecific is passed key by value */ > > + void **vdata; > > Ha! I was thinking a separate key->value mapping which is complicated > in C. But

Re: git filter-branch re-write history over a range of commits did notwork

2019-05-27 Thread Johannes Sixt
Am 28.05.19 um 07:42 schrieb LU Chuck: >> From: Philip Oakley >> The three dots is provided in the literal EXAMPLES section of the man page. >> That is >> probably an error, as I think it is meant to be an ellipsis to indicate >> 'insert other >> options here'. >> >> Simply remove the three dots

Re: [RFC PATCH] list-objects-filter: disable 'sparse:path' filters

2019-05-27 Thread Jeff King
On Fri, May 24, 2019 at 02:46:06PM -0400, Jeff Hostetler wrote: > My original thoughts were that we could limit the sparse:path to > local use and disallow it over the wire to the server, but that > distinction is probably not worth the bother. Removing it completely > is fine. Yeah, it had been

Re: [PATCH 2/3] hash-object doc: elaborate on -w and --literally promises

2019-05-27 Thread Jeff King
On Fri, May 24, 2019 at 12:12:10PM +0200, Ævar Arnfjörð Bjarmason wrote: > > I thik that this implemetation detail of `--literally` is here to stay; > > how would you otherwise fix the issue if garbage object makes Git crash? > > > > However, I would prefer to have options state _intent_; if there

Re: git archive generates tar with malformed pax extended attribute

2019-05-27 Thread Jeff King
On Sat, May 25, 2019 at 03:26:53PM +0200, René Scharfe wrote: > We could truncate symlink targets at the first NUL as well in git > archive -- but that would be a bit sad, as the archive formats allow > storing the "real" target from the repo, with NUL and all. We could > make git fsck report suc

Re: git archive generates tar with malformed pax extended attribute

2019-05-27 Thread Jeff King
On Sun, May 26, 2019 at 11:33:20PM +0200, René Scharfe wrote: > Git archive writes link targets that are 100 characters long or less > into the appropriate field in the plain tar header. It copies > everything, including NULs, but unlike a PAX extended header that field > lacks a length indicator

RE: git filter-branch re-write history over a range of commits did notwork

2019-05-27 Thread LU Chuck
> -Original Message- > From: Philip Oakley > Sent: Tuesday, May 28, 2019 4:23 AM > To: Johannes Sixt ; LU Chuck > Cc: git@vger.kernel.org; chuck...@qq.com > Subject: Re: git filter-branch re-write history over a range of commits did > notwork > > Hi Chuck, > > On 27/05/2019 19:21, Jo

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Tue, May 28 2019, brian m. carlson wrote: > On 2019-05-27 at 20:36:36, Ævar Arnfjörð Bjarmason wrote: >> I've done enough git-send-email patching in anger for a year at least >> with what's sitting in "next" so I'm not working on this, but just my >> 0.02: >> >> I wonder if we shouldn't just

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Tue, May 28 2019, Eric Wong wrote: > > Todd Zullinger wrote: > >> Something like: > >> > >> diff --git i/git-send-email.perl w/git-send-email.perl > >> index 24859a7bc3..84ac03994d 100755 > >> --- i/git-send-email.perl > >> +++ w/git-send-email.perl > >> @@ -14

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Todd Zullinger
Hi, Sorry I missed your earlier reply which also mentioned using $obj->can() Ævar. That's what I get for typing a reply and then walking away for a few hours before hitting send. ;) Ævar Arnfjörð Bjarmason wrote: > Same, but to bikeshed a bit, at this point we can just do: > > diff --gi

Re: [PATCH 1/1] bundle verify: error out if called without an object database

2019-05-27 Thread Jeff King
On Mon, May 27, 2019 at 12:59:14PM -0700, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > The deal with bundles is: they really are thin packs, with very little > sugar on top. So we really need a repository (or more appropriately, an > object database) to work with,

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Tue, May 28 2019, Eric Wong wrote: > Todd Zullinger wrote: >> I wonder if it's (separately from this change) worth >> adjusting the conditional which sets $use_net_smtp_ssl to >> use "Net::SMTP->can('starttls')" rather than a strict >> version check? (It might not be if using 'can' is too >

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Todd Zullinger wrote: > I wonder if it's (separately from this change) worth > adjusting the conditional which sets $use_net_smtp_ssl to > use "Net::SMTP->can('starttls')" rather than a strict > version check? (It might not be if using 'can' is too > fragile or would only benefit the Red Hat 7 pa

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Mon, May 27 2019, Eric Wong wrote: > > Chris Mayo wrote: > >> git-send-email uses the TLS support in the Net::SMTP core module from > >> recent versions of Perl. Documenting the minimum version is complex > >> because of separate numbering for Perl (5.21.5~169)

Re: [PATCH v4] fast-import: checkpoint: only write out refs and tags if we changed them

2019-05-27 Thread Eric Rannaud
On Mon, May 27, 2019 at 4:27 PM Elijah Newren wrote: > That sounds good...though it's taking my short patch and just about > amounts to completely rewriting it. Would you like to take it over > including authorship, and just add either a "Original-patch-by:" or > "Based-on-patch-by:" for me in th

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Todd Zullinger
Eric Wong wrote: > Chris Mayo wrote: >> git-send-email uses the TLS support in the Net::SMTP core module from >> recent versions of Perl. Documenting the minimum version is complex >> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) >> and libnet (3.01). Version numbers from co

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread brian m. carlson
On 2019-05-27 at 20:36:36, Ævar Arnfjörð Bjarmason wrote: > I've done enough git-send-email patching in anger for a year at least > with what's sitting in "next" so I'm not working on this, but just my > 0.02: > > I wonder if we shouldn't just be much more aggressive about version > requirements f

Re: [PATCH v4] fast-import: checkpoint: only write out refs and tags if we changed them

2019-05-27 Thread Elijah Newren
Hi Eric, On Mon, May 27, 2019 at 3:46 PM Eric Rannaud wrote: > On Mon, May 27, 2019 at 2:12 PM Elijah Newren wrote: > > On Fri, May 24, 2019 at 4:10 PM Eric Rannaud wrote: > > I think the test will not fail without the patch (and therefore won't > catch a regression): while checkpoint doesn't c

Re: [PATCH v4] fast-import: checkpoint: only write out refs and tags if we changed them

2019-05-27 Thread Eric Rannaud
On Mon, May 27, 2019 at 2:12 PM Elijah Newren wrote: > On Fri, May 24, 2019 at 4:10 PM Eric Rannaud wrote: > > > > With this patch, we keep track of whether a particular branch or tag has > > been changed by this fast-import process since our last checkpoint (or > > startup). At the next checkpoi

Re: [PATCH v4] fast-import: checkpoint: only write out refs and tags if we changed them

2019-05-27 Thread Elijah Newren
On Fri, May 24, 2019 at 4:10 PM Eric Rannaud wrote: > > With this patch, we keep track of whether a particular branch or tag has > been changed by this fast-import process since our last checkpoint (or > startup). At the next checkpoint, only refs and tags that new commands > have changed are writ

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Mon, May 27 2019, Eric Wong wrote: > Chris Mayo wrote: >> git-send-email uses the TLS support in the Net::SMTP core module from >> recent versions of Perl. Documenting the minimum version is complex >> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) >> and libnet (3.01).

Re: [PATCH v2 1/1] bundle verify: error out if called without an object database

2019-05-27 Thread brian m. carlson
On 2019-05-27 at 20:21:00, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > The deal with bundles is that they really are thin packs, with very > little sugar on top. So we really need a repository (or more > appropriately, an object database) to work with, when asked t

Re: git filter-branch re-write history over a range of commits did notwork

2019-05-27 Thread Philip Oakley
Hi Chuck, On 27/05/2019 19:21, Johannes Sixt wrote: Am 27.05.19 um 10:01 schrieb LU Chuck: Hi team, The issue comes from https://github.com/git-for-windows/git/issues/2206. I want to re-write history by filter-branch command over a range of commits, but the command did not work.

Re: [PATCH 1/1] bundle verify: error out if called without an object database

2019-05-27 Thread Johannes Schindelin
Hi brian, On Mon, 27 May 2019, brian m. carlson wrote: > On 2019-05-27 at 19:59:14, Johannes Schindelin via GitGitGadget wrote: > > From: Johannes Schindelin > > > > The deal with bundles is: they really are thin packs, with very little > > Generally a colon can only follow what could be a compl

Re: [PATCH 1/1] bundle verify: error out if called without an object database

2019-05-27 Thread brian m. carlson
On 2019-05-27 at 19:59:14, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > The deal with bundles is: they really are thin packs, with very little Generally a colon can only follow what could be a complete sentence, so maybe we want to say something like "The deal with

[PATCH 0/1] bundle verify: improve the user experience when called without a .git/ directory

2019-05-27 Thread Johannes Schindelin via GitGitGadget
The git bundle verify command really needs access to a .git/ directory. But it did not make sure, instead erroring out with a BUG(), making for a terrible user experience. This patch fixes that. Johannes Schindelin (1): bundle verify: error out if called without an object database bundle.c

[PATCH 1/1] bundle verify: error out if called without an object database

2019-05-27 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The deal with bundles is: they really are thin packs, with very little sugar on top. So we really need a repository (or more appropriately, an object database) to work with, when asked to verify a bundle. Let's error out with a useful error message if `git bundle verify

Re: [PATCH v3] git-gui: Handle Ctrl + BS/Del in the commit msg

2019-05-27 Thread Johannes Schindelin
Hi, On Mon, 6 May 2019, Ismael Luceno wrote: > On 08/Apr/2019 12:54, Ismael Luceno Cortes wrote: > > - Control+BackSpace: Delete word to the left of the cursor. > > - Control+Delete : Delete word to the right of the cursor. > > > > Originally introduced by BRIEF and Turbo Vision between 1985 an

Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL

2019-05-27 Thread Eric Wong
Chris Mayo wrote: > git-send-email uses the TLS support in the Net::SMTP core module from > recent versions of Perl. Documenting the minimum version is complex > because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34) > and libnet (3.01). Version numbers from commit: > bfbfc9a953 ("se

Re: 'git stash list' => Segmentation fault

2019-05-27 Thread Johannes Schindelin
Hi Brendan, On Fri, 24 May 2019, Brendan Boerner wrote: > Ubuntu 14.04 > > I was using some prior v2.x using linuxbrew, everything was fine, took > an update, this started happening. > > I verified also happens using the 2.21.0 from the Ubuntu 14.04 PPA > (this reproduction was using that build,

Re: git filter-branch re-write history over a range of commits did notwork

2019-05-27 Thread Johannes Sixt
Am 27.05.19 um 10:01 schrieb LU Chuck: > Hi team, > > The issue comes from https://github.com/git-for-windows/git/issues/2206. > > I want to re-write history by filter-branch command over a range of > commits, but the command did not work. > I have referred to the following three doc

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Paolo Bonzini
On 27/05/19 17:39, Junio C Hamano wrote: > I do not think lightweight vs annotated should be the issue. The > tag that the requestor asks to be pulled (from repository ../b) > should be what the requestor has locally when writing the request > (in repository .). Even if both tags at remote and lo

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > It mostly (and I believe always should) works by looking at whether > "someref" is a named ref, and e.g. looking at whether it's "master". We > then see that it lives in "refs/heads/master" locally, and thus > correspondingly add a "refs/heads/" to your "tags/fo

worktree add already exists

2019-05-27 Thread Ingo Wolf
x@y MINGW64 ~/gittest $ ls bare/  barework/ x@y MINGW64 ~/gittest $ ls -a barework ./  ../  test.txt x@y MINGW64 ~/gittest $ git -C bare branch * master x@y MINGW64 ~/gittest $ git -C bare worktree add --no-checkout ../barework Preparing worktree (new branch 'barework') fatal: '../barework' a

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Ævar Arnfjörð Bjarmason
On Mon, May 27 2019, Paolo Bonzini wrote: > On 27/05/19 00:54, Ævar Arnfjörð Bjarmason wrote: >> This resulted in a case[1] where someone on LKML did: >> >> git push kvm +HEAD:tags/for-linus >> >> Which would have created a new "tags/for-linus" branch in their "kvm" >> repository, except bec

Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*

2019-05-27 Thread Paolo Bonzini
On 27/05/19 00:54, Ævar Arnfjörð Bjarmason wrote: > This resulted in a case[1] where someone on LKML did: > > git push kvm +HEAD:tags/for-linus > > Which would have created a new "tags/for-linus" branch in their "kvm" > repository, except because they happened to have an existing > "refs/tags

Re: [PATCH v2 08/11] commit-graph: add --split option to builtin

2019-05-27 Thread SZEDER Gábor
On Wed, May 22, 2019 at 12:53:27PM -0700, Derrick Stolee via GitGitGadget wrote: > diff --git a/t/t5323-split-commit-graph.sh b/t/t5323-split-commit-graph.sh > new file mode 100755 > index 00..96704b9f5b > --- /dev/null > +++ b/t/t5323-split-commit-graph.sh > @@ -0,0 +1,122 @@ > +#!/bin/sh

git filter-branch re-write history over a range of commits did notwork

2019-05-27 Thread LU Chuck
Hi team, The issue comes from https://github.com/git-for-windows/git/issues/2206. I want to re-write history by filter-branch command over a range of commits, but the command did not work. I have referred to the following three documentation about how to use git filter-branch:

I,m Searhing For You Since,

2019-05-27 Thread Honorable Mr. Royce Mark.
Hello My Dear, Your Payment Compensation funds value the sum of USD $900.000.00 was forward to the western union money transfer for immediate transfer it to you as soon as you meet up with the Director of the Board Remittance Authority. Contact Foreign Operation Manger Western Union Office. Mrs

git filter-branch re-write history over a range of commits did notwork

2019-05-27 Thread LU Chuck
Hi team, The issue comes from https://github.com/git-for-windows/git/issues/2206. I want to re-write history by filter-branch command over a range of commits, but the command did not work. I have referred to the following three documentation about how to use git filter-branch: