Re: [GSoC] A late proposal: a modern send-email

2016-03-29 0:49 GMT+08:00 Ævar Arnfjörð Bjarmason <ava...@gmail.com>: > On Sat, Mar 26, 2016 at 3:13 AM, 惠轶群 <huiyi...@gmail.com> wrote: >> 2016-03-26 2:16 GMT+08:00 Junio C Hamano <gits...@pobox.com>: >>> 惠轶群 <huiyi...@gmail.com> writes: >>> >

Re: [PATCH v2] path.c enter_repo(): fix unproper strbuf unwrapping and memory leakage

2016-03-29 1:55 GMT+08:00 Jeff King : > On Mon, Mar 28, 2016 at 11:56:10PM +0800, Hui Yiqun wrote: > >> According to strbuf.h, strbuf_detach is the sole supported method >> to unwrap a memory buffer from its strbuf shell. >> >> So we should not return the pointer of strbuf.buf

Re: [PATCH v3] path.c enter_repo(): fix unproper strbuf unwrapping and memory leakage

2016-03-29 1:58 GMT+08:00 Junio C Hamano : > Hui Yiqun writes: > >> According to strbuf.h, strbuf_detach is the sole supported method >> to unwrap a memory buffer from its strbuf shell. >> ... >> diff --git a/path.c b/path.c >> index 969b494..9801617 100644

Re: [PATCH v3] path.c enter_repo(): fix unproper strbuf unwrapping and memory leakage

Sorry, I sent the patch repeatedly to fix a wrongly indent with space. 2016-03-28 23:57 GMT+08:00 Hui Yiqun : > According to strbuf.h, strbuf_detach is the sole supported method > to unwrap a memory buffer from its strbuf shell. > > So we should not return the pointer of

Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()

2016-03-28 22:50 GMT+08:00 Junio C Hamano <gits...@pobox.com>: > 惠轶群 <huiyi...@gmail.com> writes: > >> After read the source code of strbuf more carefully, I get the conclusion >> that if a strbuf is initialized with STRBUF_INIT but is not used, there is >&g

Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()

2016-03-26 1:59 GMT+08:00 Jeff King <p...@peff.net>: > On Fri, Mar 25, 2016 at 10:21:48PM +0800, 惠轶群 wrote: > >> > There are some minor English problems here (and elsewhere). E.g., you >> > probably want "So we just issue a warning and leave it to the user

Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()

2016-03-26 0:55 GMT+08:00 Junio C Hamano <gits...@pobox.com>: > 惠轶群 <huiyi...@gmail.com> writes: > >>> There's a lot of "what" here that the caller doesn't really care about, >>> and which may go stale with respect to the implementation over time

Re: [GSoC] A late proposal: a modern send-email

2016-03-28 6:00 GMT+08:00 Eric Wong <normalper...@yhbt.net>: > Junio C Hamano <gits...@pobox.com> wrote: >> 惠轶群 <huiyi...@gmail.com> writes: >> > - Build a simple email client (maybe a web components based web app or >> > wxwidgets based GUI client, the

Re: [GSoC] A late proposal: a modern send-email

2016-03-26 17:52 GMT+08:00 惠轶群 <huiyi...@gmail.com>: > 2016-03-26 14:18 GMT+08:00 Pranit Bauva <pranit.ba...@gmail.com>: >> On Sat, Mar 26, 2016 at 7:43 AM, 惠轶群 <huiyi...@gmail.com> wrote: >>> 2016-03-26 2:16 GMT+08:00 Junio C Hamano <gits...@pobox.com

Re: [GSoC] A late proposal: a modern send-email

To make it clearer: 1. there are so many great mail clients, why not let these experts to handle the dispatch of mail? For example, as a One-time-password user of gmail, I have to generate an app password for each terminal device I'd like to send patch on. It's more important that I could

Re: [GSoC] A late proposal: a modern send-email

2016-03-26 14:18 GMT+08:00 Pranit Bauva <pranit.ba...@gmail.com>: > On Sat, Mar 26, 2016 at 7:43 AM, 惠轶群 <huiyi...@gmail.com> wrote: >> 2016-03-26 2:16 GMT+08:00 Junio C Hamano <gits...@pobox.com>: >>> 惠轶群 <huiyi...@gmail.com> writes: >>> >

Re: [GSoC] Proposal

I had updated the proposal before deadline, if someone is interesting. 2016-03-25 15:12 GMT+08:00 惠轶群 <huiyi...@gmail.com>: > Well, I should have done some search before ask. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord

Re: [GSoC] A late proposal: a modern send-email

2016-03-26 2:16 GMT+08:00 Junio C Hamano <gits...@pobox.com>: > 惠轶群 <huiyi...@gmail.com> writes: > >> # Purpose >> The current implementation of send-email is based on perl and has only >> a tui, it has two problems: >> - user must install a ton of

Re: [PATCH v3/GSoC 3/5] git-credential-cache: put socket to xdg-compatible path

2016-03-26 1:56 GMT+08:00 Jeff King <p...@peff.net>: > On Fri, Mar 25, 2016 at 10:28:55PM +0800, 惠轶群 wrote: > >> >> diff --git a/credential-cache.c b/credential-cache.c >> >> index f4afdc6..40d838b 100644 >> >> --- a/credential-cache.c >> >

[GSoC] A late proposal: a modern send-email

I know it's tooo late to post proposal here, but I'd like to let my idea known by others. # Summary Although many projects hosted on github or gitlab adopt the fork-and-merge working flow, email is still irreplaceable for its compatibility. However, the send-email module is old and difficult for

Re: [PATCH v3/GSoC 3/5] git-credential-cache: put socket to xdg-compatible path

2016-03-25 18:00 GMT+08:00 Jeff King : > On Wed, Mar 23, 2016 at 06:13:23PM +0800, Hui Yiqun wrote: > >> move .git-credential-cache/socket to xdg_runtime_dir("credential-cache.sock") > > Motivation? I will improve my commit message. > >> diff --git a/credential-cache.c

Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()

> I find there are some similar leakage in this file. I'll fix them in > another patch. > > Do you think we need some additional comments for the release of strbuf? For example, in strbuf.h. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()

2016-03-25 17:59 GMT+08:00 Jeff King : > On Wed, Mar 23, 2016 at 06:13:22PM +0800, Hui Yiqun wrote: > >> +/** >> + * this function does the following: >> + * >> + * 1. if $XDG_RUNTIME_DIR is non-empty, `$XDG_RUNTIME_DIR/git` is used in >> next >> + * step, otherwise `/tmp/git-$uid`

Re: [PATCH v3/GSoC 1/5] path.c: implement strbuf_mkpath()

So, are there some additional points I could improve? 2016-03-23 18:13 GMT+08:00 Hui Yiqun : > There were already `mkpath`, `mkpathdup` and `mksnpath` for build > filename, but lacked a version of `strbuf_` just like `strbuf_git_path`. > > It is convenient to build a path and

Re: [GSoC] Proposal

Well, I should have done some search before ask. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GSoC] Proposal

There is an interesting idea as an idea for GSoC of 2008, is it still proposable? https://git.wiki.kernel.org/index.php/SoC2008Ideas#Restartable_Clone 2016-03-25 11:45 GMT+08:00 惠轶群 <huiyi...@gmail.com>: > Hi, > > I'm proposing to take part in GSoC as a developer of git. > >

[GSoC] Proposal

Hi, I'm proposing to take part in GSoC as a developer of git. Here is my [Draft](https://docs.google.com/document/d/1zqOVb_cnYcaix48ep1KNPeLpRHvNKA26kNXc78yjhMg/edit?usp=sharing). I'm planning to refactor some part of git. Following is what I'm interested in: - port parts of “git rebase” to a

Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-17 1:24 GMT+08:00 Junio C Hamano <gits...@pobox.com>: > 惠轶群 <huiyi...@gmail.com> writes: > >>> Is it because the wish is to always use /tmp/git-$uid/ as a fallback >>> for $XDG_RUNTIME_DIR (as opposed to ~/.git-credential-cache/, which >>> is sp

Re: [PATCH/RFC/GSoC 2/3] git-credential-cache: put socket to xdg-compatible path

2016-03-16 18:07 GMT+08:00 Hui Yiqun : > move .git-credential-cache/socket to xdg_runtime_dir("credential-cache.sock") > > Signed-off-by: Hui Yiqun > --- > credential-cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-17 1:15 GMT+08:00 Jeff King : > On Wed, Mar 16, 2016 at 06:07:45PM +0800, Hui Yiqun wrote: > >> diff --git a/t/t0301-credential-cache.sh b/t/t0301-credential-cache.sh >> index 82c8411..0718bb0 100755 >> --- a/t/t0301-credential-cache.sh >> +++ b/t/t0301-credential-cache.sh

Re: [PATCH/RFC/GSoC 1/3] path.c: implement xdg_runtime_dir()

2016-03-17 1:06 GMT+08:00 Jeff King : > On Wed, Mar 16, 2016 at 06:07:43PM +0800, Hui Yiqun wrote: > >> + if (runtime_dir && *runtime_dir) >> + git_runtime_dir = mkpathdup("%s/git/", runtime_dir); >> + else >> + git_runtime_dir =

Re: [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-18 13:01 GMT+08:00 Jeff King <p...@peff.net>: > On Fri, Mar 18, 2016 at 12:38:16PM +0800, 惠轶群 wrote: > >> >> +test_expect_success 'when $XDG_RUNTIME_DIR is set, >> >> `$XDG_RUNTIME_DIR/git` are used' ' >> >> + test_path_is_miss

Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-17 0:17 GMT+08:00 Junio C Hamano : > Hui Yiqun writes: > >> t0301 now tests git-credential-cache support for XDG user-specific >> runtime file $XDG_RUNTIME_DIR/git/credential.sock. Specifically: >> >> * if $XDG_RUNTIME_DIR exists, use socket at >>

Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-18 13:00 GMT+08:00 Jeff King <p...@peff.net>: > On Fri, Mar 18, 2016 at 12:34:04PM +0800, 惠轶群 wrote: > >> >> +test_expect_success 'set $XDG_RUNTIME_DIR' ' >> >> + XDG_RUNTIME_DIR=$HOME/xdg_runtime/ >> >> +' >> > >> > Doe

Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-17 16:12 GMT+08:00 Junio C Hamano : > 谭俊浩 writes: > >> On 17/03/2016 01:24, Junio C Hamano wrote: >> >>> Using ~/.git-credential-cache/credential-cache.sock would not help >>> at all for existing users, but ~/.git-credential-cache/socket would >>>

Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-18 13:11 GMT+08:00 惠轶群 <huiyi...@gmail.com>: > 2016-03-18 13:00 GMT+08:00 Jeff King <p...@peff.net>: >> On Fri, Mar 18, 2016 at 12:34:04PM +0800, 惠轶群 wrote: >> >>> >> +test_expect_success 'set $XDG_RUNTIME_DIR' ' >>> >> + XDG_RUN

Re: [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-18 2:08 GMT+08:00 Jeff King : > On Fri, Mar 18, 2016 at 12:48:46AM +0800, Hui Yiqun wrote: > >> t0301 now tests git-credential-cache support for XDG user-specific >> runtime file $XDG_RUNTIME_DIR/git/credential.sock. Specifically: >> >> * if $XDG_RUNTIME_DIR exists, use

Re: [GSOC] Microproject "Move ~/.git-credential-cache to ~/.config/git"

2016-03-16 3:21 GMT+08:00 Jeff King : > I don't think so. I suppose one could have a script that tests for the > existence of the socket or something. I agree, that is what I meant by "third-party tools". But for user who write script like that, it's easy to figure out the problem

Re: [GSOC] Microproject "Move ~/.git-credential-cache to ~/.config/git"

> You sound like you think it is better to check the location of the > existing socket, Yes, for the purpose of compatibility, it's the only choice, as I can see. To sum up, I'd like to implement: 1. is configured by --socket, then put it here. 2. else if `~/.git-credential-cache` exists, put

Re: [GSOC] Microproject "Move ~/.git-credential-cache to ~/.config/git"

2016-03-14 23:42 GMT+08:00 Junio C Hamano <gits...@pobox.com>: > 惠轶群 <huiyi...@gmail.com> writes: > >> I'm still confused about following: >> >> 1. should `~/.git-credential-cache` been moved to >> `~/.cache/git/credential`(as the descreption of the microp

[GSOC] Microproject "Move ~/.git-credential-cache to ~/.config/git"

I'm Hui Yiqun, a master degress candidate of Tsinghua University. I'd like to participate GSOC 2016 as an developer of git. I have basic knowledge about several programming languages (namely C, python, go and etc.), compilers and cmake which may help my development. My github page is at