Re:Re: [PATCH v5] send-email: --batch-size to work around some SMTP server limit

At 2017-05-22 17:26:41, "Ævar Arnfjörð Bjarmason" wrote: >On Sun, May 21, 2017 at 2:59 PM, xiaoqiang zhao wrote: >> Some email servers (e.g. smtp.163.com) limit the number emails to be >> sent per session(connection) and this will lead to a faliure when >>

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

> 在 2017年5月17日，07:49，Junio C Hamano 写道： > > Junio C Hamano writes: > >> xiaoqiang zhao writes: >> ... >>> Note: >>> Re-authentication will happen every $ messages, so it >>> will be much more acceptable if you use some form of

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

在 2017年5月17日，01:43，Ævar Arnfjörð Bjarmason 写道： >>> Regards >>> Jan >> >> Thank you for reporting this，I will take a look . > > You just need to initialize the variables you're using, see e.g. these > existing ones: > >my ($quiet, $dry_run) = (0, 0); > > Just do the

Re: [PATCH v4] send-email: --batch-size to work around some SMTP server limit

> 在 2017年5月16日，20:10，Jan Viktorin 写道： > > Hello, > > with this patch applied to git 2.12, I could see: > > Use of uninitialized value $batch_size in numeric eq (==) at > /usr/lib/git-core/git-send-email line 1679 > > when --batch-size is NOT used. See below... > >

Re: [PATCH v3] send-email: --batch-size to work around some SMTP server limit

> 在 2017年5月8日，12:11，Junio C Hamano 写道： > > Two suggestions. > > (1) I do not think $smtp is always valid when we come here; it is > unsafe to unconditionally say $smtp->quit like this patch does. > >$smtp->quit if defined $smtp; > > may help codepaths like

Re: [PATCH v2] send-email: new options to walkaround email server limits

> 在 2017年5月2日，10:24，Junio C Hamano 写道： > > But I am having a huge problem seeing how this patch is correct. It > always is troubling to see a patch that makes the behaviour of a > program change even when the optional feature it implements is not > being used at all. Why

Re: [PATCH] send-email: new option to walkaround email server limits

在 2017年5月2日，17:32，Paolo Bonzini 写道： >> On 29/04/2017 14:26, xiaoqiang zhao wrote: >> Some email server(e.g. smtp.163.com) limits a fixed number emails to be send >> per >> session(connection) and this will lead to a send faliure. >> With --split option, a auto

Re: [PATCH] send-email: new option to walkaround email server limits

Thanks for your reply , Junio ! > 在 2017年5月1日，09:54，Junio C Hamano 写道： > > here. We need to find a better name for the option. Perhaps > "--batch-size=", "--max-messages-per-connection=" or > something? > --batch-size is ok with me > - The code seems to do the