Re: [PATCH v3] send-email: Improve format of smtp initialization error message

What's about output like this: Unable to initialize SMTP properly. Check config and use --smtp-debug. VALUES: server=smtp.gmail.com encryption= hello=localhost.localdomain port=587 Junio C Hamano @ 2014-12-30 00:50 QYZT: > Alexander Kuleshov writes: > >> Signed

Re: Re*: [PATCH] change contract between system_path and it's callers

Junio C Hamano @ 2014-11-25 01:33 ALMT: >> -static const char *git_etc_gitattributes(void) >> +static char *git_etc_gitattributes(void) > > Hmph, I think this should keep returning "const char *", as the > caller is not expected to free the pointer or write into the memory > held by the returned

Re: [PATCH] exec_cmd: system_path memory leak fix

Now system_path returns path which is allocated string to callers; It prevents memory leaks in some places. All callers of system_path are owners of path string and they must release it. Added new parameter to wrapper.c/int access_or_die - etc_config, because only etc_config in this case use syst

Re: [PATCH] exec_cmd: system_path memory leak fix

Junio C Hamano @ 2014-11-24 13:37 ALMT: > [jc: added those who were mentioned but were missing back to Cc] > > On Sun, Nov 23, 2014 at 11:02 PM, Alex Kuleshov > wrote: >> >> Junio C Hamano: >> >>>Fixing these callers are done as separate patches, that c

Re: [PATCH] exec_cmd: system_path memory leak fix

Jeff King: >If I am reading this right, calls to system_path() will always reuse the >same buffer, even if they are called with another "path" argument. So >all callers must make sure to make a copy if they are going to hold on >to it for a long time. Grepping for callers shows us saving the res

Re: [PATCH] exec_cmd: system_path memory leak fix

Signed-off-by: Alex Kuleshov --- exec_cmd.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/exec_cmd.c b/exec_cmd.c index 698e752..7ed9bcc 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -13,7 +13,7 @@ const char *system_path(const char *path) #else static const

Re: [PATCH] exec_cmd: system_path memory leak fix

Junio C Hamano @ 2014-11-24 00:51 ALMT: > 0xAX writes: > >> Signed-off-by: 0xAX >> --- > > The comment on names I've already mentioned elsewhere. Yes, i understand about names. > > You need a better explanation than a "no log message", as you are > not doing "system-path memory leak fix". >

Re: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

Hello Max and Paul, thank you for your feedback, so what's must be my next workflow? Resend patch with "Reviewed-By:..." or somethine else? -- Best regards. 0xAX -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/1] git-config: git-config --list fixed when GIT_CONFIG value starts with ~/

Hello Eric and Jeff, >Eric Sunshine >A few issues: > >(1) Style: s/char* /char */ > >(2) Avoid declaration (of 'newpath') after statement. > >(3) You can drop 'newpath' altogether and just assign the result of >expand_user_path() directly to given_config_source.file. > >This code is potentially l

Re: t9902-completion.sh failed

ah, i catched the problem, I launched make test with sudo and now all tests passed successfully. Jeff King @ 2014-11-13 17:24 ALMT: > On Thu, Nov 13, 2014 at 04:59:12PM +0600, Alex Kuleshov wrote: > >> i just got git from master (f6f61cbbad0611e03b712cc354f1665b5d7b087e),

Re: t9902-completion.sh failed

Hello Jeff, I'm using ubuntu 14.04 x86_64 and bash GNU bash, version 4.3.11(1)-release (x86_64-pc-linux-gnu). I didn't applied any patches to bash for all time since i installed system. so it reall weird Jeff King @ 2014-11-13 17:24 ALMT: > On Thu, Nov 13, 2014 at 04:59:12P

t9902-completion.sh failed

Hello all, i just got git from master (f6f61cbbad0611e03b712cc354f1665b5d7b087e), built and installed it successfully, now i'm running make test and got following error: *** t9902-completion.sh *** t9902-completion.sh: 118: /home/shk/dev/git/t/../contrib/completion/git-completion.bash: Syntax er