Re: [RFC] send-email aliases when editing patches or using --xx-cmd

2015-06-04 Thread Allen Hubbe
On Thu, Jun 4, 2015 at 6:53 PM, Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr wrote: On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET remi.lespi...@ensimag.grenoble-inp.fr wrote: Hi, Working on git-send-email, I've seen that there's no aliases support when manually adding a recipient in

Re: [RFC] send-email aliases when editing patches or using --xx-cmd

2015-06-04 Thread Allen Hubbe
On Thu, Jun 4, 2015 at 8:38 PM, Allen Hubbe alle...@gmail.com wrote: On Thu, Jun 4, 2015 at 6:53 PM, Remi Lespinet remi.lespi...@ensimag.grenoble-inp.fr wrote: On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET remi.lespi...@ensimag.grenoble-inp.fr wrote: Hi, Working on git-send-email, I've

Re: [PATCH 1/9] send-email: further document missing sendmail aliases functionality

2015-06-01 Thread Allen Hubbe
According to the documentation, the parser should print a warning for any explicitly unsupported constructs. These are now explicitly unsupported, so the parser should warn on |, /, and :include: . Perhaps the lines that match should be ignored like the others, too. On Sun, May 31, 2015 at 6:29

Re: [PATCH 0/9] send-email: add sendmail aliases line continuation support

2015-06-01 Thread Allen Hubbe
This series looks very good to me. Thanks for the extra work you've done to make the sendmail alias support much better :) I'm not too concerned about this, but if you think it would be appropriate you may use it: Acked-by: Allen Hubbe alle...@gmail.com On Sun, May 31, 2015 at 6:29 PM, Eric

Re: [PATCH 1/9] send-email: further document missing sendmail aliases functionality

2015-06-01 Thread Allen Hubbe
This looks good. On Mon, Jun 1, 2015 at 2:22 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Mon, Jun 01, 2015 at 07:43:08AM -0400, Allen Hubbe wrote: On May 31, 2015 at 6:29 PM, Eric Sunshine sunsh...@sunshineco.com wrote: Sendmail aliases[1] supports expansion to a file (/path/name

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Saturday, May 23, 2015, Allen Hubbe alle...@gmail.com wrote: Note that this only adds support for a limited subset of the sendmail format. The format is is as follows. alias: address|alias[, address

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
On Tue, May 26, 2015 at 4:53 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Tue, May 26, 2015 at 3:41 PM, Allen Hubbe alle...@gmail.com wrote: On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Saturday, May 23, 2015, Allen Hubbe alle...@gmail.com wrote

[PATCH v6] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
by the parser. Signed-off-by: Allen Hubbe alle...@gmail.com --- Notes: This v6 makes the following changes from v5: * In the documentation: ** Move 'sendmail' to the end of the list of formats. ** Remove the description, synopsis, and example of sendmail aliases. ** Specify exceptions

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Allen Hubbe
On Sat, May 23, 2015 at 6:24 PM, Allen Hubbe alle...@gmail.com wrote: On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: A small thing I noticed in the test (and this patch is not adding a new breakage---there are a few existing

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Allen Hubbe
On Mon, May 25, 2015 at 9:58 PM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: Thanks for letting me know. Are you still expecting v6 from me then? The other thing you asked for was a change in the documentation: just mention the email programs' documentation

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Allen Hubbe
On Mon, May 25, 2015 at 5:35 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Junio C Hamano gits...@pobox.com writes: FYI, I have tentatively queued this on top of your patch. Please see git log master..cf954075 to double check. Sorry but I had a typo

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Allen Hubbe
On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: A small thing I noticed in the test (and this patch is not adding a new breakage---there are a few existing instances) is the use of ~/; it should be spelled $HOME/ instead for

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Allen Hubbe
On Sat, May 23, 2015 at 2:00 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 804554609def..97387fd27a8d 100644 --- a/Documentation/git-send-email.txt +++

[PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Allen Hubbe
that are not recognized. Signed-off-by: Allen Hubbe alle...@gmail.com --- Notes: This v5 renames the parser 'sendmail' again, from 'simple'. Therefore, the subject line is changed again, too. Previous subject line: send-email: Add simple email aliases format The format

Re: [PATCH v4] send-email: Add simple email aliases format

2015-05-22 Thread Allen Hubbe
On Fri, May 22, 2015 at 12:29 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 11:40 PM, Allen Hubbe alle...@gmail.com wrote: This format is more simple than the other alias file formats, so it may be preferred by some users. [...] Signed-off-by: Allen Hubbe alle

Re: [PATCH v2] send-email: Add simple email aliases format

2015-05-22 Thread Allen Hubbe
On Thu, May 21, 2015 at 11:59 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 11:19 PM, Allen Hubbe alle...@gmail.com wrote: On May 21, 2015 9:05 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 8:16 PM, Allen Hubbe alle...@gmail.com wrote

Re: [PATCH v4] send-email: Add simple email aliases format

2015-05-22 Thread Allen Hubbe
On Fri, May 22, 2015 at 10:44 AM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: It depends what we want to do with this parser: accept existing sendmail aliases files in git, or enforce that git alias files are usable for sendmail. I really don't expect

Re: [PATCH v4] send-email: Add simple email aliases format

2015-05-22 Thread Allen Hubbe
On Fri, May 22, 2015 at 12:53 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Fri, May 22, 2015 at 8:12 AM, Allen Hubbe alle...@gmail.com wrote: On Fri, May 22, 2015 at 12:29 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 11:40 PM, Allen Hubbe alle...@gmail.com

Re: [PATCH v4] send-email: Add simple email aliases format

2015-05-22 Thread Allen Hubbe
On Fri, May 22, 2015 at 1:17 PM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: On Fri, May 22, 2015 at 10:44 AM, Junio C Hamano gits...@pobox.com wrote: Let me step back a bit. Earlier you said your aim is not to use an alias file you already have and use

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
On Thu, May 21, 2015 at 5:05 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 4:48 PM, Allen Hubbe alle...@gmail.com wrote: My motivation for this patch was not really to support the sendmail aliases file directly. The commit message may therefore be misleading. So, I

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
On Thu, May 21, 2015 at 4:19 PM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: diff --git a/git-send-email.perl b/git-send-email.perl index e1e9b14..5f2ec0d 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -515,7 +515,12 @@ my %parse_alias

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
On Thu, May 21, 2015 at 5:38 PM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: Those are good points. Maybe I shouldn't even mention sendmail at all, not in the name of the format, and not in the commit message. What name would be a good name for this format

[PATCH v2] send-email: Add simple email aliases format

2015-05-21 Thread Allen Hubbe
bob: Robert Bobbyton b...@example.com chloe: ch...@example.com abgroup: alice, bob bcgrp: bob, chloe, Other o...@example.com Signed-off-by: Allen Hubbe alle...@gmail.com --- Notes: The v1 of this patch had the following subject line: git-send-email.perl: Add

[PATCH v3] send-email: Add simple email aliases format

2015-05-21 Thread Allen Hubbe
abgroup: alice, bob # comment after an alias bcgrp: bob, chloe, Other o...@example.com Signed-off-by: Allen Hubbe alle...@gmail.com --- Notes: This v3 extends the syntax to allow blank lines, and comments. The test case is extended with comments added to alias file input

[PATCH v4] send-email: Add simple email aliases format

2015-05-21 Thread Allen Hubbe
abgroup: alice, bob # comment after an alias bcgrp: bob, chloe, Other o...@example.com Signed-off-by: Allen Hubbe alle...@gmail.com --- Notes: Note, v3 was sent in error. This v4 presents changes since v2. This v4 extends the syntax to allow blank lines, and comments. The test

Re: [PATCH v2] send-email: Add simple email aliases format

2015-05-21 Thread Allen Hubbe
On May 21, 2015 9:05 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 8:16 PM, Allen Hubbe alle...@gmail.com wrote: This format is more simple than the other alias file formats, so it may be preferred by some users. The format is as follows. alias: address|alias

Re: [PATCH v3] send-email: Add simple email aliases format

2015-05-21 Thread Allen Hubbe
Please ignore v3... this is the same as v2 for some reason. I will resend as v4. On Thu, May 21, 2015 at 11:35 PM, Allen Hubbe alle...@gmail.com wrote: This format is more simple than the other alias file formats, so it may be preferred by some users. The format is as follows. alias

[PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
'\' on the line to be continued, or leading whitespace on the continuing line. This patch does not do anything with the trailing '\', and ignores lines starting with whitespace. This patch also ignores lines that starts with '#', comment character, and empty lines. Signed-off-by: Allen Hubbe alle