Re: [PATCH] Clear --exclude list after 'git rev-parse --all'

2018-10-24 Thread Andreas Gruenbacher
On Wed, 24 Oct 2018 at 11:24, Junio C Hamano wrote: > Andreas Gruenbacher writes: > >> All other glob options do show_reference with for_each_ref_in() and > >> then calls clear_ref_exclusion(), and logically the patch makes > >> sense. > >> > >>

Re: [PATCH] Clear --exclude list after 'git rev-parse --all'

2018-10-24 Thread Andreas Gruenbacher
On Wed, 24 Oct 2018 at 06:35, Junio C Hamano wrote: > Andreas Gruenbacher writes: > > > Commit [1] added the --exclude option to revision.c. The --all, > > --branches, --tags, --remotes, and --glob options clear the exclude > > list. Shortly therafter, commit [2] ad

[PATCH] Clear --exclude list after 'git rev-parse --all'

2018-10-23 Thread Andreas Gruenbacher
("revision: introduce --exclude= to tame wildcards", 2013-08-30) [2] 9dc01bf06 ("rev-parse: introduce --exclude= to tame wildcards", 2013-11-01) Signed-off-by: Andreas Gruenbacher --- builtin/rev-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/builtin/rev-parse.c b

Re: [RFC v2] revision: Add --sticky-default option

2018-10-18 Thread Andreas Gruenbacher
On Thu, 18 Oct 2018 at 08:53, Jeff King wrote: > On Wed, Oct 17, 2018 at 03:49:47PM +0200, Andreas Gruenbacher wrote: > > @@ -2431,7 +2446,11 @@ int setup_revisions(int argc, const char **argv, > > struct rev_info *revs, struct s > > opt->tweak(revs,

Re: [RFC] revision: Add --sticky-default option

2018-10-18 Thread Andreas Gruenbacher
On Thu, 18 Oct 2018 at 05:23, Junio C Hamano wrote: > Jeff King writes: > > > I'd probably call it something verbose and boring like > > --use-default-with-uninteresting or --default-on-negative. > > I dunno. > > These two names are improvement, but there needs a hint that the > change we are

Re: [RFC] revision: Add --sticky-default option

2018-10-18 Thread Andreas Gruenbacher
On Thu, 18 Oct 2018 at 08:59, Junio C Hamano wrote: > Jeff King writes: > > Just to play devil's advocate, how about this: > > > > git log --branches=jk/* --not origin/master > > > > Right now that shows nothing if there are no matching branches. But I > > think under the proposed behavior, it

Re: [RFC] revision: Add --sticky-default option

2018-10-17 Thread Andreas Gruenbacher
On Wed, 17 Oct 2018 at 11:12, Jeff King wrote: > On Tue, Oct 16, 2018 at 11:24:38PM +0200, Andreas Gruenbacher wrote: > > here's a long-overdue update of my proposal from August 29: > > > > [RFC] revision: Don't let ^ cancel out the default > > > > Does this l

[RFC v2] revision: Add --sticky-default option

2018-10-17 Thread Andreas Gruenbacher
arguments, and 'l foo' will show the revisions between origin/master and foo. Signed-off-by: Andreas Gruenbacher --- Documentation/rev-list-options.txt | 10 ++ revision.c | 21 - revision.h | 1 + t/t4

[RFC] revision: Add --sticky-default option

2018-10-16 Thread Andreas Gruenbacher
n wrappers that exclude certain revisions: for example, a simple alias l='git log --sticky-default ^origin/master' will show the revisions between origin/master and HEAD when invoked without arguments, and 'l foo' will show the revisions between origin/master and foo. Signed-off-by: Andreas G

[RFC] revision: Don't let ^ cancel out the default

2018-08-29 Thread Andreas Gruenbacher
' will show the revisions between origin/master and foo, as you would usually expect. Signed-off-by: Andreas Gruenbacher --- revision.c | 18 ++ t/t4202-log.sh | 6 ++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/revision.c b/revision.c index de4dce600

Re: [PATCH] Inconsistency between git log and git rev-parse for ^HEAD^@

2017-03-18 Thread Andreas Gruenbacher
On Sat, Mar 18, 2017 at 9:18 PM, Junio C Hamano <gits...@pobox.com> wrote: > Andreas Gruenbacher <agrue...@redhat.com> writes: > >> Hello, >> >> the log and rev-parse commands both support the rev^@ syntax which stands for >> all parents of rev. The log c

[PATCH] Inconsistency between git log and git rev-parse for ^HEAD^@

2017-03-18 Thread Andreas Gruenbacher
-- rev-parse: Add support for ^rev^@ Add support for the ^rev^@ syntax to exclude all of the parents of rev. This syntax is already supported by git log. Signed-off-by: Andreas Gruenbacher <agrue...@redhat.com> --- builtin/rev-parse.c | 10 +- 1 file changed, 5 insertions(+), 5 del

Re: patch-2.7.3 no longer applies relative symbolic link patches

2015-01-27 Thread Andreas Gruenbacher
On Mon, 26 Jan 2015 12:44:33 -0800, Linus Torvalds wrote: I've considered that for a while already, because patch _does_ kind of understand them these days, although I think it gets the cross-rename case wrong because it fundamentally works on a file-by-file basis. Patch handles cross-renames