Subject line: s/i18n/index/
On 20/10/2018 14:38, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> Documentation/config.txt | 11 +--
> Documentation/index-config.txt | 10 ++
> 2 files changed, 11 insertions(+), 10 deletions(-)
> create mode
On 2018-09-26 21:16, Junio C Hamano wrote:
> While at it, update the way to creatd these scripts to use the
s/creatd/create/
Or rewording as "... update the way these scripts are created ..."
> write_script wrapper, so that we do not have to worry about writing
> the she-bang line and making
On 2018-08-29 12:02, Eric Wong wrote:
> Anyways I hope to teach public-inbox to auto-linkify Message-ID-looking
> strings "" into URLs for domain-portability,
> (but it's ambiguous with email addresses). But yeah, I don't
> like things being tied to domain names.
This would be very useful for
On 2018-08-27 19:32, Andrei Rybak wrote:
>
> How about just using unconditional includes?
>
> global.gitconfig (synced across machines):
>
> [include]
> path = platform-specific.gitconfig
>
> And two version of file named "platform-specific.gi
On 2018-08-27 17:52, Duy Nguyen wrote:
> On Mon, Aug 27, 2018 at 5:37 PM Torsten Bögershausen wrote:
>>> In those cases, when it falls back to
>>> configuration for line ending management, I want it to be
>>> automatically configured based on the host platform.
>>
>
> An alternative is
On 25/08/18 10:05, Jeff King wrote:
> The main comparison functions we provide for comparing
> object ids are hashcmp() and oidcmp(). These are more
> flexible than a strict equality check, since they also
> express ordering. That makes them them useful for sorting
s/them them/them/
> We can
On 19/08/18 22:32, Jeff King wrote:
> On Sun, Aug 19, 2018 at 07:50:42PM +0200, Andrei Rybak wrote:
>
>> 1. Check both files at the same time (combination with Gábor's
>> function):
>>
>> test_cmp () {
>> if test &quo
On 17/08/18 22:09, Junio C Hamano wrote:
> Andrei Rybak writes:
>>
>> I'll try something like the following on the weekend:
>>
>> test_cmp () {
>> if test "$1" != - && ! test -s "$1"
>> then
>&g
On 17/08/18 19:39, SZEDER Gábor wrote:
>
> See, we have quite a few tests that extract repetitive common tasks
> into helper functions, which sometimes includes preparing the expected
> results and running 'test_cmp', e.g. something like this
> (oversimplified) example:
>
> check_cmd () {
>
On 14/08/18 13:47, SZEDER Gábor wrote:
> ... both
> invocations produce empty 'pack{a,b}.objects' files, and the
> subsequent 'test_cmp' happily finds those two empty files identical.
Is test_cmp ever used for empty files? Would it make sense for
test_cmp to issue warning when an empty file is
line-log.[ch] use left-closed, right-open interval logic. Update
comments and debug output to use square brackets+parentheses notation
to help developers avoid off-by-one errors.
Signed-off-by: Andrei Rybak
---
Applies on top of c0babbe69 (range-set: publish API for re-use by
git-blame -L, 2013
line-log.[ch] use left-closed, right-open interval logic. Change comment
and debug output to square brackets+parentheses notation to help
developers avoid off-by-one errors.
---
Original idea for this change in recent thread about line-log changes:
On 2018-08-06 22:14, Junio C Hamano wrote:
> Andrei Rybak writes:
>>
>> Only changes since v2 are more clear tag names.
>
> ... and updated log message, which I think makes it worthwhile to
> replace the previous one plus the squash/fixup with this version.
My bad, t
on of the test, give files and tags more explicit names.
[1]: introduced in bf72ac17d (t4150: tests for am --[no-]scissors,
2015-07-19)
Signed-off-by: Andrei Rybak
---
Applies on top of 980a3d3dd (Merge branch 'pt/am-tests', 2015-08-03).
This patch is also available at
https://github.co
commit-with-scissors-line`?
How about "expected-for-scissors" and "expected-for-no-scissors"?
Junio, I'll send out v3 with updated tag names, if that's OK.
Also, squash-able patch below.
> So, this patch fixes the 3 problems with the tests, and so looks correct to
>
On 2018-08-05 00:18, Johannes Schindelin via GitGitGadget wrote:
>
> Now, I am fairly certain that the changes are correct, but given my track
> record with off-by-one bugs (and once even an off-by-two bug), I would
> really appreciate some thorough review of this code, in particular the
> second
of the test, give files and tags more explicit names.
[1]: introduced in bf72ac17d (t4150: tests for am --[no-]scissors,
2015-07-19)
Signed-off-by: Andrei Rybak
---
Applies on top of 980a3d3dd (Merge branch 'pt/am-tests', 2015-08-03).
This patch is also available at
https://github.com/r
On 2018-08-04 01:04, Junio C Hamano wrote:
> Hmph, I am not quite sure what is going on. Is the only bug in the
> original that scissors-patch.eml and no-scissors-patch.eml files were
> incorrectly named? IOW, if we fed no-scissors-patch.eml (which has
> a scissors line in it) with --scissors
e eml file--with scissors line, and
by using it both for --scissors and --no-scissors. To clarify the
intention of the test, give files and tags more explicit names.
[1]: introduced in bf72ac17d (t4150: tests for am --[no-]scissors,
2015-07-19)
Signed-off-by: Andrei Rybak
---
Applies on top of 980a3d
inside will be cut up and only the part under the cut will be
turned into commit.
However, the test for --scissors generates eml file without such line.
Fix the test for --scissors option.
Signed-off-by: Andrei Rybak
---
t/t4150-am.sh | 19 ---
1 file changed, 12 inserti
On 2018-08-02 21:17, René Scharfe wrote:
> Don't translate the argument specification for --chmod; "+x" and "-x"
> are the literal strings that the commands accept.
> > [...]
>
> - OPT_STRING( 0 , "chmod", _arg, N_("(+/-)x"), N_("override the
> executable bit of the listed files")),
> +
ld it make sense to mention new option in the cover letter section of
Documentation/SubmittingPatches?
--
Best regards, Andrei Rybak
On 2018-07-17 01:05, Stefan Beller wrote:
>
> This patch brings some challenges, related to the detection of blocks.
> We need a white net the catch the possible moved lines, but then need to
The s/white/wide/ was already suggested by Brandon Williams in previous
iteration, but it seems this
Add missing colon in two places to fix formatting of options.
Signed-off-by: Andrei Rybak
---
Done on top of maint.
The earliest this patch applies is on top of commit aebd23506e ("Merge
branch 'jk/ui-color-always-to-auto-maint' into
jk/ui-color-always-to-auto", 2017-10-04), one c
On Wed, 11 Jul 2018 at 22:34, Andrei Rybak wrote:
>
> Is -1 an OK initial value for timezone if local_time_tzoffset returns
> negative values as well? It looks like it doesn't matter for from functional
>
meant to say: "It looks like it doesn't matter from the functional
point of view".
stamp_t time, int tz, const
> struct date_mode *mode)
> return timebuf.buf;
> }
>
> + if (mode->type == DATE_HUMAN) {
> + struct timeval now;
> +
> + gettimeofday(, NULL);
> +
> + /* Fill in the data for "current time" in human_tz and human_tm
> */
> + human_tz = local_time_tzoffset(now.tv_sec, _tm);
> + }
> +
> if (mode->local)
> tz = local_tzoffset(time);
>
--
Best regards, Andrei Rybak
--
Best regards, Andrei Rybak
On 2018-07-08 20:01, Pratik Karki wrote:
> +
> +static int use_builtin_rebase(void)
> +{
> + struct child_process cp = CHILD_PROCESS_INIT;
> + struct strbuf out = STRBUF_INIT;
> + int ret;
> +
> + argv_array_pushl(,
> + "config", "--bool", "rebase.usebuiltin",
On 2018-06-24 12:36, Daniel Penkin wrote:
> Hello,
>
Hi,
> I believe I found a bug in how Git represents a diff when invoked with
> "--find-copies-harder" parameter.
> Specifically, the unified diff header of a hunk contains an extra
> piece of text which appears to be a line from the context
On 01.03.2018 0:54, Junio C Hamano wrote:
> Andrei Rybak <rybak@gmail.com> writes:
>
>> Is this part of guidelines obsolete, or am I not understanding this
>> correctly?
>
> I am merely being nice (but only on "time-permitting" basis).
>
Does
ot;Send your patch with "To:" set to the mailing list, with "cc:"
listing people who are involved in the area you are touching"
--
Best regards, Andrei Rybak
31 matches
Mail list logo
