. The current task can be easily done by providing offsets to
the
buffer pointer (the way it is implemented currently).
Signed-off-by: Ashwin Jha
---
fsck.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/fsck.c b/fsck.c
index 64bf279..82e1640 100644
--- a/fsck.c
Original Message
Subject:[PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()
Date: Fri, 21 Mar 2014 07:24:46 +0530
From: Ashwin Jha
To: git@vger.kernel.org
CC: Ashwin Jha
modified fsck.c:fsck_commit(). Replaced memcmp() with starts_with() function
On 03/22/2014 12:11 AM, Eric Sunshine wrote:
On Fri, Mar 21, 2014 at 5:18 AM, Ashwin Jha wrote:
On Fri, Mar 21, 2014 at 9:03 AM, Eric Sunshine
wrote:
On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha wrote:
Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()
starts_with() seems
Replace memcmp by skip_prefix as it serves the dual
purpose of checking the string for a prefix as well
as skipping that prefix.
Signed-off-by: Ashwin Jha
---
fsck.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/fsck.c b/fsck.c
index 64bf279
Thanks for your comments, Tanay and Eric.
Regarding the [PATCH v2], I will keep this in mind for the subsequent
patches.
On 03/23/2014 02:10 PM, Eric Sunshine wrote:
Thanks for the resubmission. Comments below...
On Sat, Mar 22, 2014 at 11:12 AM, Ashwin Jha wrote:
Subject: [PATCH] Modify
In fsck_ident(): Replace argument char **ident with const char **ident
In fsck_commit(): Replace char *buffer with const char *buffer
In both the cases, referenced memory addresses are not modified. So, it
will be a good practice, to declare them as const.
Signed-off-by: Ashwin Jha
---
Change
Replace memcmp by skip_prefix as it serves the dual
purpose of checking the string for a prefix as well
as skipping that prefix.
Signed-off-by: Ashwin Jha
---
fsck_commit(): After the first patch in this series, it is now safe to replace
memcmp() with skip_prefix().
Previous versions can be
7 matches
Mail list logo
