Re: [GSoC][PATCH v2 2/2] submodule: port submodule subcommand status

2017-06-05 Thread Christian Couder
On Mon, Jun 5, 2017 at 10:25 PM, Prathamesh Chavan wrote: > --- > In this new version of patch, function print_status is introduced. > > The functions for_each_submodule_list and get_submodule_displaypath > are found to be the same as those in the ported submodule subcommand > foreach's patches.

Re: [PATCH] perf: work around the tested repo having an index.lock

2017-06-04 Thread Christian Couder
On Mon, Jun 5, 2017 at 4:02 AM, Junio C Hamano wrote: > Christian Couder writes: > >> On Sun, Jun 4, 2017 at 2:00 AM, Junio C Hamano wrote: >>> Ævar Arnfjörð Bjarmason writes: >>> >>>>> My feeling exactly. Diagnosing and failing upfront say

Re: [PATCH] test-lib: add ability to cap the runtime of tests

2017-06-04 Thread Christian Couder
On Mon, Jun 5, 2017 at 3:55 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Realistically I'm going to submit this patch, I'm not going to take >> the much bigger project of refactoring the entire test suite so that >> no test runs under N second, and of course any such refactori

Re: Git Merge 2017 Videos

2017-06-04 Thread Christian Couder
On Sun, Jun 4, 2017 at 7:36 PM, Kevin Daudt wrote: > On Sun, Jun 04, 2017 at 11:24:17AM +0100, Philip Oakley wrote: >> While looking at the recent .gitignore issue (the need to use `**`) I came >> up against a comment in >> https://public-inbox.org/git/cagz79kzqsaubfotjyqm+-+ljyyec2ykj5exuy5kderez

Re: [PATCH] perf: work around the tested repo having an index.lock

2017-06-04 Thread Christian Couder
On Sun, Jun 4, 2017 at 2:00 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >>> My feeling exactly. Diagnosing and failing upfront saying "well you >>> made a copy but it is not suitable for testing" sounds more sensible >>> at lesat to me. >> >> This change makes the repo suitable

Re: [PATCH v3 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman

2017-05-31 Thread Christian Couder
On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: > templates/hooks--query-fsmonitor.sample | 37 > + > 1 file changed, 37 insertions(+) > create mode 100644 templates/hooks--query-fsmonitor.sample Please make this file executable like the other sample hook scr

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-31 Thread Christian Couder
On Thu, May 25, 2017 at 3:55 PM, Ben Peart wrote: > > On 5/24/2017 6:54 AM, Christian Couder wrote: >>> >>> A new git hook (query-fsmonitor) must exist and be enabled >>> (core.fsmonitor=true) that takes a time_t formatted as a string and >>> outputs t

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-31 Thread Christian Couder
Yeah, they could be encoded in the integration script, but it could be better if it was possible to just configure a generic command line. For example if the directory that should be watched for filesystem changes could be passed as well as the time since the last changes,

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Christian Couder
On Tue, May 30, 2017 at 11:21 PM, Ben Peart wrote: > > On 5/30/2017 9:18 AM, Christian Couder wrote: >> >> On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: >> >>> + printf "untracked\0" >>> + printf "dir1/untracked\0&

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-30 Thread Christian Couder
On Tue, May 30, 2017 at 8:05 PM, Ben Peart wrote: > > > On 5/27/2017 2:57 AM, Christian Couder wrote: >> >> On Thu, May 25, 2017 at 3:55 PM, Ben Peart wrote: >>> >>> >>> >>> On 5/24/2017 6:54 AM, Christian Couder wrote: >>>&g

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Christian Couder
On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: [...] > diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh > new file mode 100755 > index 00..395db46d55 > --- /dev/null > +++ b/t/t7519-status-fsmonitor.sh > @@ -0,0 +1,158 @@ > +#!/bin/sh > + > +test_description='git

Re: [PATCH v3 4/4] stash: implement builtin stash

2017-05-28 Thread Christian Couder
On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: [...] > +int untracked_files(struct strbuf *out, int include_untracked, > + const char **argv) > +{ > + struct child_process cp = CHILD_PROCESS_INIT; > + cp.git_cmd = 1; > + argv_array_push(&cp.args, "ls-files

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-26 Thread Christian Couder
On Thu, May 25, 2017 at 3:55 PM, Ben Peart wrote: > > > On 5/24/2017 6:54 AM, Christian Couder wrote: >>> >>> Design >>> ~~ >>> >>> A new git hook (query-fsmonitor) must exist and be enabled >>> (core.fsmonitor=true) that tak

Re: [PATCH v2 6/6] fsmonitor: add a sample query-fsmonitor hook script for Watchman

2017-05-24 Thread Christian Couder
On Thu, May 18, 2017 at 10:13 PM, Ben Peart wrote: > This hook script integrates the new fsmonitor capabilities of git with > the cross platform Watchman file watching service. To use the script: > > Download and install Watchman from https://facebook.github.io/watchman/ > and instruct Watchman to

Re: [PATCH v2 3/6] fsmonitor: teach git to optionally utilize a file system monitor to speed up detecting new or changed files.

2017-05-24 Thread Christian Couder
On Thu, May 18, 2017 at 10:13 PM, Ben Peart wrote: > When the index is read from disk, the query-fsmonitor index extension is > used to flag the last known potentially dirty index and untracked cach s/cach/cache/ > entries. [...] > diff --git a/cache.h b/cache.h > index 188811920c..36423c77cc

Re: [PATCH v2 0/6] Fast git status via a file system watcher

2017-05-24 Thread Christian Couder
> Design > ~~ > > A new git hook (query-fsmonitor) must exist and be enabled > (core.fsmonitor=true) that takes a time_t formatted as a string and > outputs to stdout all files that have been modified since the requested > time. Is there a reason why there is a new hook, instead of a "core.fsm

Re: [PATCH] Documentation: Fix reference to isExists for interpret-trailers

2017-05-22 Thread Christian Couder
On Mon, May 22, 2017 at 9:45 PM, Andreas Heiduk wrote: > The manual for "git interpret-trailers" mentioned a non-existing > literal `overwrite` for its config option `trailer.ifexists`. Fixed > by using `replace` instead. Yeah, I forgot to change it to `replace` there. > Signed-off-by: Andreas H

[ANNOUNCE] Git Rev News edition 27

2017-05-17 Thread Christian Couder
Hi everyone, The 27th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/05/17/edition-27/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: Draft of Git Rev News edition 27

2017-05-15 Thread Christian Couder
On Mon, May 15, 2017 at 11:34 AM, Christian Couder wrote: > Hi, > > A draft of a new Git Rev News edition is available here: > > > https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-27.md > > Everyone is welcome to contribute in any section eithe

Draft of Git Rev News edition 27

2017-05-15 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-27.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Christian Couder
On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler wrote: > > > On 5/8/2017 5:45 AM, Christian Couder wrote: >> >> This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is >> set on my Linux machine. >> >> Also it looks like you sent a v8 of thi

Re: [PATCH 0/1] Preserve the untracked cache across checkout, reset --hard, etc

2017-05-08 Thread Christian Couder
(Adding Dave in Cc as it looks like he is involved.) On Mon, May 8, 2017 at 11:41 AM, Johannes Schindelin wrote: > I recently sent out a request for assistance, after noticing that the > untracked cache is simply thrown away after operations such as > `git checkout` or `git reset --hard`: > > htt

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Christian Couder
On Fri, Apr 14, 2017 at 10:32 PM, wrote: > diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh > index 33a51c9..677e15a 100755 > --- a/t/t1450-fsck.sh > +++ b/t/t1450-fsck.sh > @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all > heads' ' > ! grep $blob out > ' > >

Re: [PATCH 0/2] split index extra bits

2017-05-07 Thread Christian Couder
On Mon, May 8, 2017 at 3:49 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Christian Couder writes: >> >>> This patch series contains 2 patches that have already been sent to >>> the list but have felt through the cracks. It would be nice if they

[PATCH 1/2] split-index: add and use unshare_split_index()

2017-05-05 Thread Christian Couder
From: Nguyễn Thái Ngọc Duy When split-index is being used, we have two cache_entry arrays in index_state->cache[] and index_state->split_index->base->cache[]. index_state->cache[] may share the same entries with base->cache[] so we can quickly determine what entries are shared. This makes memory

[PATCH 0/2] split index extra bits

2017-05-05 Thread Christian Couder
(5.85+1.36) -48.9% 8.06(6.54+1.60) -42.8% 7.53(6.40+1.12) -46.5% 3400.6: rebase a lot of unrelated changes with split-index 14.10(10.11+3.94) 6.94(5.71+1.27) -50.8% 7.99(6.49+1.57) -43.3% 6.10(5.12+1.07) -56.7% On bigger repositories results are likely to be better. Christian

[PATCH 2/2] p3400: add perf tests for rebasing many changes

2017-05-05 Thread Christian Couder
Rebasing onto many changes is interesting, but it's also interesting to see what happens when rebasing many changes. And while at it, let's also look at the impact of using a split index. Signed-off-by: Christian Couder --- t/perf/p3400-rebase.sh | 22 +- 1 file c

Re: Could GIT manage revision headers embedded in code ?

2017-05-02 Thread Christian Couder
Hi, On Tue, May 2, 2017 at 1:48 PM, Delanoe Eric wrote: > Hello, > > We need a great deal of traceability for our source, made of many scripts in > interpreted languages, spread in many "independent" modules, as far as can be > ;-). > In particular, somebody troubleshooting a script in producti

Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)

2017-04-24 Thread Christian Couder
On Mon, Apr 24, 2017 at 6:34 PM, Philip Oakley wrote: > > Sorry if I'm bikeshedding here, but it does look like adding an alternate > 'bisect' strategy may be useful for this style of integration testing. > > To me, given the multiplicity of independent branches being brought > together, it should

Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)

2017-04-24 Thread Christian Couder
On Sat, Apr 22, 2017 at 3:37 PM, Johannes Sixt wrote: > Am 21.04.2017 um 14:29 schrieb Christian Couder: >> >> First bisect should ask you to test merge bases only if there are >> "good" commits that are not ancestors of the "bad" commit. > > >

Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)

2017-04-22 Thread Christian Couder
Hi Dscho, On Sat, Apr 22, 2017 at 1:48 PM, Johannes Schindelin wrote: >> >> First bisect should ask you to test merge bases only if there are >> "good" commits that are not ancestors of the "bad" commit. > > Please note that this is a stateless job. The only "state" I have is the > branch name. >

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-21 Thread Christian Couder
On Fri, Apr 21, 2017 at 4:25 PM, Christian Couder wrote: > On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer > wrote: >> On 04/20, Christian Couder wrote: >>> >>> Could you try with the following patch: >>> >>> http://public-inbox.org/gi

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-21 Thread Christian Couder
On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer wrote: > On 04/20, Christian Couder wrote: >> >> Could you try with the following patch: >> >> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/ > > Yeah, I tried with and without that pat

Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)

2017-04-21 Thread Christian Couder
On Fri, Apr 21, 2017 at 11:50 AM, Johannes Schindelin wrote: > > Since that "let's aggregate everything and only push out the final result > at the end of the day" approach does not really allow the Continuous > Testing to identify problems associated with individual topic branches, I > have anoth

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-21 Thread Christian Couder
On Fri, Apr 21, 2017 at 1:46 PM, Christian Couder wrote: > On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen wrote: >> On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder >> wrote: >>> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer >>> wrote: >

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-21 Thread Christian Couder
On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen wrote: > On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder > wrote: >> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer >> wrote: >>> On 04/20, Christian Couder wrote: >>>> >>>> Could you tr

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-21 Thread Christian Couder
On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer wrote: > On 04/20, Christian Couder wrote: >> >> Could you try with the following patch: >> >> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/ > > Yeah, I tried with and without that pat

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-21 Thread Christian Couder
On Fri, Apr 21, 2017 at 6:01 AM, Junio C Hamano wrote: > Christian Couder writes: > >> Could you try with the following patch: >> >> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/ > > Ah, this reminds me. The patch has been in the stall

Re: [BUG] test suite broken with GIT_TEST_SPLIT_INDEX

2017-04-20 Thread Christian Couder
Hi, On Thu, Apr 20, 2017 at 10:52 PM, Thomas Gummerer wrote: > Hi, > > I just tried to run the test suite with GIT_TEST_SPLIT_INDEX=YesPlease > and noticed that a few tests are broken both in pu and master. > > Below the test failures on master: > > Test Summary Report > --- > t70

[ANNOUNCE] Git Rev News edition 26

2017-04-19 Thread Christian Couder
Hi everyone, The 26th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/04/19/edition-26/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: Draft of Git Rev News edition 26

2017-04-19 Thread Christian Couder
Hi Michael, > Hi Christian, > > Thanks for the ping on the draft. Thanks for you input on this! > Re gpg: Maybe some valuable point of information is what Werner Koch > himself said in that thread: > "That [the command line is not a stable API to GnuPG] is not true. The > command line interface

[PATCH] p0004: make perf test executable

2017-04-18 Thread Christian Couder
It looks like in 89c3b0ad43 (name-hash: add perf test for lazy_init_name_hash, 2017-03-23) p0004 was not created with the execute unix rights. Let's fix that. Signed-off-by: Christian Couder --- t/perf/p0004-lazy-init-name-hash.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-)

[PATCH] p3400: add perf tests for rebasing many changes

2017-04-18 Thread Christian Couder
Rebasing onto many changes is interesting, but it's also interesting to see what happens when rebasing many changes. And while at it, let's also look at the impact of using a split index. Signed-off-by: Christian Couder --- t/perf/p3400-rebase.sh | 22 +- 1 file c

Draft of Git Rev News edition 26

2017-04-17 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-26.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

Re: What's cooking in git.git (Apr 2017, #01; Tue, 11)

2017-04-11 Thread Christian Couder
> * cc/split-index-config (2017-03-30) 1 commit > - read-cache: avoid using git_path() in freshen_shared_index() > > The split-index code configuration code used an unsafe git_path() > function without copying its result out. > > Needs to be explained better. > The code looked OK, though. In:

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-06 Thread Christian Couder
On Tue, Apr 4, 2017 at 10:40 PM, Jeff King wrote: > On Tue, Apr 04, 2017 at 06:42:23PM +, David Turner wrote: > >> > What does it look like when it fails? What does GIT_TRACE_CURL look like >> > (or >> > GIT_CURL_VERBOSE if your client is older, but remember to sanitize any auth >> > lines)?

Re: [RFC PATCH] git-news: obtain latest news for your favorite VCS

2017-04-01 Thread Christian Couder
On Sat, Apr 1, 2017 at 1:59 AM, Stefan Beller wrote: [...] > diff --git a/git-news.sh b/git-news.sh > new file mode 100755 > index 00..1707dc633e > --- /dev/null > +++ b/git-news.sh > @@ -0,0 +1,4 @@ > +#!/bin/sh > +# > + > +/usr/bin/sensible-browser https://git.github.io/rev_news/ Than

[PATCH v2] read-cache: avoid using git_path() in freshen_shared_index()

2017-03-30 Thread Christian Couder
read_index_from(), 2017-03-06) is involved, which points to the unsafe use of git_path() in freshen_shared_index(). Signed-off-by: Christian Couder --- The only changes in this v2 compared to the previous version are in the title and commit message, which have been changed according to: http://public

Re: [PATCH] read-cache: avoid git_path() race in freshen_shared_index()

2017-03-30 Thread Christian Couder
On Wed, Mar 29, 2017 at 7:56 PM, Jeff King wrote: > On Wed, Mar 29, 2017 at 10:06:52AM -0700, Junio C Hamano wrote: > >> > This shows that we should be careful not to use git_path() in >> > freshen_shared_index(). It is using a shared buffer that can >> > too easily lead to races. >> >> The impres

Re: [PATCH v8 04/11] update-index: add untracked cache notifications

2017-03-29 Thread Christian Couder
On Thu, Mar 30, 2017 at 5:28 AM, Jeff King wrote: > On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote: > >> diff --git a/builtin/update-index.c b/builtin/update-index.c >> index 6dd..369c207 100644 >> --- a/builtin/update-index.c >> +++ b/built

[PATCH] update-index: fix xgetcwd() related memory leak

2017-03-29 Thread Christian Couder
As xgetcwd() returns an allocated buffer, we should free this buffer when we don't need it any more. This was found by Coverity. Reported-by: Jeff King Signed-off-by: Christian Couder --- builtin/update-index.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bu

Re: Git hackathon New York / London - call for mentors

2017-03-29 Thread Christian Couder
Hi Charles, I maybe available to mentor. I am in Paris so closer to London. I have no date restriction for the weekends after April 9th yet. Thanks, Christian. On Wed, Mar 29, 2017 at 12:18 AM, Charles Bailey wrote: > Bloomberg would like to host a Git hackathon over a weekend in both New > Yor

[PATCH] read-cache: avoid git_path() race in freshen_shared_index()

2017-03-29 Thread Christian Couder
_path() in freshen_shared_index(). It is using a shared buffer that can too easily lead to races. Signed-off-by: Christian Couder --- read-cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index e447751823..2f10242c24 100644 --- a/read-cache.c

Re: [PATCH] strbuf: support long paths w/o read rights in strbuf_getcwd() on FreeBSD

2017-03-28 Thread Christian Couder
On Tue, Mar 28, 2017 at 11:49 PM, Jeff King wrote: > On Tue, Mar 28, 2017 at 11:15:12PM +0200, Christian Couder wrote: > >> On Sun, Mar 26, 2017 at 3:43 PM, René Scharfe wrote: >> > FreeBSD implements getcwd(3) as a syscall, but falls back to a version >> > based

Re: [PATCH] strbuf: support long paths w/o read rights in strbuf_getcwd() on FreeBSD

2017-03-28 Thread Christian Couder
On Tue, Mar 28, 2017 at 11:24 PM, Stefan Beller wrote: > On Tue, Mar 28, 2017 at 2:15 PM, Christian Couder > wrote: >> On Sun, Mar 26, 2017 at 3:43 PM, René Scharfe wrote: >>> FreeBSD implements getcwd(3) as a syscall, but falls back to a version >>> based on r

Re: [PATCH] strbuf: support long paths w/o read rights in strbuf_getcwd() on FreeBSD

2017-03-28 Thread Christian Couder
On Sun, Mar 26, 2017 at 3:43 PM, René Scharfe wrote: > FreeBSD implements getcwd(3) as a syscall, but falls back to a version > based on readdir(3) if it fails for some reason. The latter requires > permissions to read and execute path components, while the former does > not. That means that if

Re: Re: Re: Re: GSoC Project | Convert interactive rebase to C

2017-03-27 Thread Christian Couder
On Mon, Mar 27, 2017 at 6:31 PM, Pickfire wrote: > Johannes Schindelin wrote: > >> On Sat, 25 Mar 2017, Ivan Tham wrote: >> >> > Johannes Schindelin wrote: >> > > On Tue, 21 Mar 2017, Ivan Tham wrote: >> > > > Stefan Beller wrote: >> > > > > On Mon, Mar 20, 2017 at 9:41 AM, Ivan Tham >> > > >

Re: [GSoC] Proposal Discussion

2017-03-27 Thread Christian Couder
Hi, On Tue, Mar 28, 2017 at 12:17 AM, Devin Lehmacher wrote: > Hello everyone, > > I am a student studying Computer Science at Cornell University. I > already completed a microproject, Move ~/.git-credential-cache/socket to > $XDG_CACHE_HOME/credential/socket a week and a half ago or so. Nice. I

Re: [PATCH v3] t2027: avoid using pipes

2017-03-23 Thread Christian Couder
Please add something like [GSoC] in the subject so that it is easy for us to find GSoC related patches. On Mon, Mar 13, 2017 at 7:51 AM, Prathamesh wrote: > Whenever a git command is present in the upstream of a pipe, its failure > gets masked by piping and hence it should be avoided for testing

Re: [PATCH]v2 adding built-in driver for javascript

2017-03-16 Thread Christian Couder
On Thu, Mar 16, 2017 at 7:56 PM, Junio C Hamano wrote: > Christian Couder writes: > >> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal >> wrote: >>> javascript is one of the famous langugae,it's needs a built-in driver. >> >> Please use "Javascrip

Re: [PATCH]v2 adding built-in driver for javascript

2017-03-16 Thread Christian Couder
On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal wrote: > javascript is one of the famous langugae,it's needs a built-in driver. Please use "Javascript" instead of "javascript". There is a typo in "language" above, also maybe "it needs" instead of "it's needs", and please add a blank space before i

[ANNOUNCE] Git Rev News edition 25

2017-03-15 Thread Christian Couder
Hi everyone, The 25th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/03/15/edition-25/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Draft of Git Rev News edition 25

2017-03-12 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-25.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

Re: [Gsoc] adding built-in driver for javascript

2017-03-11 Thread Christian Couder
On Sat, Mar 11, 2017 at 10:23 AM, sourav mondal wrote: > I'm working on "Add more builtin pattern for userdiff" as my microproject for > Gsoc17.As I noticed javascript's builtin driver was not present in userdiff > of git/git tree. Hopefully this pattern will cover all cases. I'm really > eager

Re: [RFC PATCH] help: add optional instructions for reporting bugs

2017-03-10 Thread Christian Couder
On Fri, Mar 10, 2017 at 7:13 PM, Jonathan Nieder wrote: > Hi, > > Stefan Beller wrote: > >> When reporting bugs, users will usually look at the output of >> 'git --version' at one point to write a quality bug report. >> So that is a good spot to provide additional information to the user >> about

Re: [PATCH v2] ref-filter: Add --no-contains option to tag/branch/for-each-ref

2017-03-09 Thread Christian Couder
On Thu, Mar 9, 2017 at 9:02 PM, Ævar Arnfjörð Bjarmason wrote: > > diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt > index 525737a5d8..4938496194 100644 > --- a/Documentation/git-tag.txt > +++ b/Documentation/git-tag.txt > @@ -12,7 +12,7 @@ SYNOPSIS > 'git tag' [-a | -s | -u ]

Re: [PATCH] t2027: avoid using pipes

2017-03-09 Thread Christian Couder
On Thu, Mar 9, 2017 at 8:03 PM, Prathamesh Chavan wrote: > From: Prathamesh > > Whenever a git command is present in the upstream of a pipe, its failure > gets masked by piping and hence it should be avoided for testing the > upstream git command. By writing out the output of the git command to >

Re: [GSOC] Regarding microprojects for gsoc 2017

2017-03-09 Thread Christian Couder
On Thu, Mar 9, 2017 at 2:14 PM, Avinash Tiwary wrote: > [GSOC] > Sir, i am interested in git projects and i want to complete one of the git > microprojects. But i am unable to figure out which git repo they are talking > about. Since , there is no link provided. Please help On the microproject pa

Re: [PATCH v2] t2027: avoid using pipes

2017-03-09 Thread Christian Couder
On Thu, Mar 9, 2017 at 10:53 AM, Prathamesh Chavan wrote: > Whenever a git command is present in the upstream of a pipe, its failure > gets masked by piping and hence it should be avoided for testing the > upstream git command. By writing out the output of the git command to > a file, we can test

Re: [PATCH] t2027: avoid using pipes

2017-03-09 Thread Christian Couder
On Wed, Mar 8, 2017 at 4:13 PM, Prathamesh Chavan wrote: > The exit code of the upstream of a pipe is ignored thus we should avoid > using it. You might want to say more specifically that we should avoid piping a git command into another one as this could mask a failure of the git command. > By

Re: [PATCH][GSoc] Changed signed flags to unsigned type

2017-03-08 Thread Christian Couder
On Thu, Mar 9, 2017 at 5:24 AM, Vedant Bassi wrote: > As part of my microproject : > > Use unsigned integral type for collection of bits: > Pick one field of a structure that (1) is of signed integral type and > (2) is used as a collection of multiple bits. Discuss if there is a > good reason why

Re: Reg : GSoC 2017 Microproject

2017-03-07 Thread Christian Couder
Hi, On Tue, Mar 7, 2017 at 11:22 AM, Vedant Bassi wrote: > Hi, > > I would like to participate in GSoC 2017 and I have chosen the Use > unsigned integral type for collection of bits , idea from the Micro > projects list. > > I request the help of the community for clarifying a few questions that

[PATCH v5 03/22] config: add git_config_get_split_index()

2017-03-06 Thread Christian Couder
This new function will be used in a following commit to know if we want to use the split index feature or not. Signed-off-by: Christian Couder --- cache.h | 1 + config.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/cache.h b/cache.h index 80b6372cf7..03de80daae 100644

[PATCH v5 01/22] config: mark an error message up for translation

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.c b/config.c index c6b874a7bf..2ac1aa19b0 100644 --- a/config.c +++ b/config.c @@ -1728,8 +1728,8 @@ int git_config_get_untracked_cache(void) if

[PATCH v5 00/22] Add configuration options for split-index

2017-03-06 Thread Christian Couder
ox.org/git/2016122610.17150-1-chrisc...@tuxfamily.org/ v4: https://public-inbox.org/git/20170227180019.18666-1-chrisc...@tuxfamily.org/ Christian Couder (22): config: mark an error message up for translation t1700: change here document style config: add git_config_get_split_index() spl

[PATCH v5 05/22] read-cache: add and then use tweak_split_index()

2017-03-06 Thread Christian Couder
This will make us use the split-index feature or not depending on the value of the "core.splitIndex" config variable. Signed-off-by: Christian Couder --- read-cache.c | 17 + 1 file changed, 17 insertions(+) diff --git a/read-cache.c b/read-cache.c index 9054369dd0..

[PATCH v5 12/22] t1700: add tests for splitIndex.maxPercentChange

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t1700-split-index.sh | 72 ++ 1 file changed, 72 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index 9d7c01c3e1..00a64bed97 100755 --- a/t/t1700-split-index.sh +++ b/t/t1700-split

[PATCH v5 16/22] config: add git_config_get_expiry() from gc.c

2017-03-06 Thread Christian Couder
This function will be used in a following commit to get the expiration time of the shared index files from the config, and it is generic enough to be put in "config.c". Signed-off-by: Christian Couder --- builtin/gc.c | 18 +++--- cache.h | 3 +++ config.

[PATCH v5 07/22] t1700: add tests for core.splitIndex

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t1700-split-index.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index 5ea227e6a1..aa2aff1778 100755 --- a/t/t1700-split-index.sh +++ b/t/t1700-split-index.sh

[PATCH v5 08/22] Documentation/config: add information for core.splitIndex

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 47603f5484..f102879261 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -334,6 +334,10

[PATCH v5 21/22] Documentation/config: add splitIndex.sharedIndexExpire

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index b64aa7db2d..2afd5d982b 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2864,6 +2864,18

[PATCH v5 02/22] t1700: change here document style

2017-03-06 Thread Christian Couder
This improves test indentation by getting rid of the outdated here document style. Signed-off-by: Christian Couder --- t/t1700-split-index.sh | 170 - 1 file changed, 85 insertions(+), 85 deletions(-) diff --git a/t/t1700-split-index.sh b/t/t1700

[PATCH v5 04/22] split-index: add {add,remove}_split_index() functions

2017-03-06 Thread Christian Couder
Also use the functions in cmd_update_index() in builtin/update-index.c. These functions will be used in a following commit to tweak our use of the split-index feature depending on the setting of a configuration variable. Signed-off-by: Christian Couder --- builtin/update-index.c | 18

[PATCH v5 15/22] read-cache: touch shared index files when used

2017-03-06 Thread Christian Couder
soon. Signed-off-by: Christian Couder --- read-cache.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/read-cache.c b/read-cache.c index aeb413a508..13375fa0ff 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1674,6 +1674,19 @@ int do_read_

[PATCH v5 06/22] update-index: warn in case of split-index incoherency

2017-03-06 Thread Christian Couder
will happen and why. Signed-off-by: Christian Couder --- builtin/update-index.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/builtin/update-index.c b/builtin/update-index.c index 24fdadfa4b..d74d72cc7f 100644 --- a/builtin/update-index.c +++ b/builtin

[PATCH v5 18/22] t1700: test shared index file expiration

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- t/t1700-split-index.sh | 44 1 file changed, 44 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index 00a64bed97..f5a95a6c28 100755 --- a/t/t1700-split-index.sh +++ b/t/t1700-split

[PATCH v5 20/22] read-cache: use freshen_shared_index() in read_index_from()

2017-03-06 Thread Christian Couder
a new one. Signed-off-by: Christian Couder --- read-cache.c | 1 + t/t1700-split-index.sh | 14 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/read-cache.c b/read-cache.c index 89c95d59b3..e447751823 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1

[PATCH v5 19/22] read-cache: refactor read_index_from()

2017-03-06 Thread Christian Couder
It looks better and is simpler to review when we don't compute the same things many times in the function. It will also help make the following commit simpler. Signed-off-by: Christian Couder --- read-cache.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --

[PATCH v5 10/22] config: add git_config_get_max_percent_split_change()

2017-03-06 Thread Christian Couder
This new function will be used in a following commit to get the value of the "splitIndex.maxPercentChange" config variable. Signed-off-by: Christian Couder --- cache.h | 1 + config.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/cache.h b/cache.h index

[PATCH v5 13/22] Documentation/config: add splitIndex.maxPercentChange

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index f102879261..b64aa7db2d 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2851,6

[PATCH v5 09/22] Documentation/git-update-index: talk about core.splitIndex config var

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/git-update-index.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt index 7386c93162..e091b2a409 100644 --- a/Documentation/git-update-index.txt +++ b

[PATCH v5 17/22] read-cache: unlink old sharedindex files

2017-03-06 Thread Christian Couder
ecently used shared index file will not be deleted. Signed-off-by: Christian Couder --- read-cache.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index 13375fa0ff..16c05f359b 100644 --

[PATCH v5 22/22] Documentation/git-update-index: explain splitIndex.*

2017-03-06 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config.txt | 2 +- Documentation/git-update-index.txt | 37 + 2 files changed, 30 insertions(+), 9 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 2afd5d982b

[PATCH v5 14/22] sha1_file: make check_and_freshen_file() non static

2017-03-06 Thread Christian Couder
This function will be used in a commit soon, so let's make it available globally. Signed-off-by: Christian Couder --- cache.h | 3 +++ sha1_file.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cache.h b/cache.h index 0bb9adcd31..a35e9d5187 100644 --- a/cache.h

[PATCH v5 11/22] read-cache: regenerate shared index if necessary

2017-03-06 Thread Christian Couder
ts are assuming that the shared index is regenerated only when `git update-index --split-index` is used. Signed-off-by: Christian Couder --- read-cache.c | 32 t/t1700-split-index.sh | 1 + 2 files changed, 33 insertions(+) diff --git a/read-cache.c

Re: bisect-helper: we do not bisect --objects

2017-03-03 Thread Christian Couder
On Fri, Mar 3, 2017 at 5:16 PM, Junio C Hamano wrote: > Ever since "bisect--helper" was introduced in 1bf072e366 > ("bisect--helper: implement "git bisect--helper"", 2009-03-26), > after setting up the "rev-list $bad --not $good_ones" machinery, the > code somehow prepared to mark the trees and bl

Re: [PATCH v1] Travis: also test on 32-bit Linux

2017-03-02 Thread Christian Couder
On Thu, Mar 2, 2017 at 3:22 PM, Johannes Schindelin wrote: > >> >> +set -e >> > >> > Is this really necessary? I really like to avoid `set -e`, in >> > particular when we do pretty much everything in && chains anyway. >> >> Agreed, not really necessary here as we just invoke one command. Out of >

Git has been accepted as a GSoC 2017 mentor organization!

2017-02-27 Thread Christian Couder
Hi everyone, I am happy to let you know that Git has been accepted as a GSoC mentor organization again this year. https://summerofcode.withgoogle.com/organizations/ I invited Dscho and Stefan as potential mentors for Git. I also invited Junio to give him access to students proposals and the op

Re: [PATCH 4/4] ident: do not ignore empty config name/email

2017-02-27 Thread Christian Couder
On Mon, Feb 27, 2017 at 9:42 PM, Junio C Hamano wrote: > Dennis Kaarsemaker writes: > >> On Thu, 2017-02-23 at 23:18 -0500, Jeff King wrote: >>> On Thu, Feb 23, 2017 at 08:11:11PM -0800, Junio C Hamano wrote: >>> >>> > > So I dunno. I could really go either way on it. Feel free to drop it, or >>>

[PATCH v4 21/22] Documentation/config: add splitIndex.sharedIndexExpire

2017-02-27 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 8e745bda52..0e9982c5e3 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2844,6 +2844,18

<    7   8   9   10   11   12   13   14   15   16   >