Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-26.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub is
Rebasing onto many changes is interesting, but it's also
interesting to see what happens when rebasing many changes.
And while at it, let's also look at the impact of using a
split index.
Signed-off-by: Christian Couder
---
t/perf/p3400-rebase.sh | 22 +-
1 file c
It looks like in 89c3b0ad43 (name-hash: add perf test for lazy_init_name_hash,
2017-03-23) p0004 was not created with the execute unix rights.
Let's fix that.
Signed-off-by: Christian Couder
---
t/perf/p0004-lazy-init-name-hash.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
Hi Michael,
> Hi Christian,
>
> Thanks for the ping on the draft.
Thanks for you input on this!
> Re gpg: Maybe some valuable point of information is what Werner Koch
> himself said in that thread:
> "That [the command line is not a stable API to GnuPG] is not true. The
> command line interface
Hi everyone,
The 26th edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/04/19/edition-26/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Thomas, Jakub and Markus.
Hi,
On Thu, Apr 20, 2017 at 10:52 PM, Thomas Gummerer wrote:
> Hi,
>
> I just tried to run the test suite with GIT_TEST_SPLIT_INDEX=YesPlease
> and noticed that a few tests are broken both in pu and master.
>
> Below the test failures on master:
>
> Test Summary Report
> ---
> t70
On Fri, Apr 21, 2017 at 6:01 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> Could you try with the following patch:
>>
>> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/
>
> Ah, this reminds me. The patch has been in the stall
On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer wrote:
> On 04/20, Christian Couder wrote:
>>
>> Could you try with the following patch:
>>
>> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/
>
> Yeah, I tried with and without that pat
On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen wrote:
> On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder
> wrote:
>> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer
>> wrote:
>>> On 04/20, Christian Couder wrote:
>>>>
>>>> Could you tr
On Fri, Apr 21, 2017 at 1:46 PM, Christian Couder
wrote:
> On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen wrote:
>> On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder
>> wrote:
>>> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer
>>> wrote:
>
On Fri, Apr 21, 2017 at 11:50 AM, Johannes Schindelin
wrote:
>
> Since that "let's aggregate everything and only push out the final result
> at the end of the day" approach does not really allow the Continuous
> Testing to identify problems associated with individual topic branches, I
> have anoth
On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer wrote:
> On 04/20, Christian Couder wrote:
>>
>> Could you try with the following patch:
>>
>> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/
>
> Yeah, I tried with and without that pat
On Fri, Apr 21, 2017 at 4:25 PM, Christian Couder
wrote:
> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer
> wrote:
>> On 04/20, Christian Couder wrote:
>>>
>>> Could you try with the following patch:
>>>
>>> http://public-inbox.org/gi
Hi Dscho,
On Sat, Apr 22, 2017 at 1:48 PM, Johannes Schindelin
wrote:
>>
>> First bisect should ask you to test merge bases only if there are
>> "good" commits that are not ancestors of the "bad" commit.
>
> Please note that this is a stateless job. The only "state" I have is the
> branch name.
>
On Sat, Apr 22, 2017 at 3:37 PM, Johannes Sixt wrote:
> Am 21.04.2017 um 14:29 schrieb Christian Couder:
>>
>> First bisect should ask you to test merge bases only if there are
>> "good" commits that are not ancestors of the "bad" commit.
>
>
>
On Mon, Apr 24, 2017 at 6:34 PM, Philip Oakley wrote:
>
> Sorry if I'm bikeshedding here, but it does look like adding an alternate
> 'bisect' strategy may be useful for this style of integration testing.
>
> To me, given the multiplicity of independent branches being brought
> together, it should
Hi,
On Tue, May 2, 2017 at 1:48 PM, Delanoe Eric wrote:
> Hello,
>
> We need a great deal of traceability for our source, made of many scripts in
> interpreted languages, spread in many "independent" modules, as far as can be
> ;-).
> In particular, somebody troubleshooting a script in producti
Rebasing onto many changes is interesting, but it's also
interesting to see what happens when rebasing many changes.
And while at it, let's also look at the impact of using a
split index.
Signed-off-by: Christian Couder
---
t/perf/p3400-rebase.sh | 22 +-
1 file c
(5.85+1.36) -48.9% 8.06(6.54+1.60) -42.8%
7.53(6.40+1.12) -46.5%
3400.6: rebase a lot of unrelated changes with split-index
14.10(10.11+3.94) 6.94(5.71+1.27) -50.8% 7.99(6.49+1.57) -43.3%
6.10(5.12+1.07) -56.7%
On bigger repositories results are likely to be better.
Christian
From: Nguyễn Thái Ngọc Duy
When split-index is being used, we have two cache_entry arrays in
index_state->cache[] and index_state->split_index->base->cache[].
index_state->cache[] may share the same entries with base->cache[] so
we can quickly determine what entries are shared. This makes memory
On Mon, May 8, 2017 at 3:49 AM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Christian Couder writes:
>>
>>> This patch series contains 2 patches that have already been sent to
>>> the list but have felt through the cracks. It would be nice if they
On Fri, Apr 14, 2017 at 10:32 PM, wrote:
> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
> index 33a51c9..677e15a 100755
> --- a/t/t1450-fsck.sh
> +++ b/t/t1450-fsck.sh
> @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all
> heads' '
> ! grep $blob out
> '
>
>
(Adding Dave in Cc as it looks like he is involved.)
On Mon, May 8, 2017 at 11:41 AM, Johannes Schindelin
wrote:
> I recently sent out a request for assistance, after noticing that the
> untracked cache is simply thrown away after operations such as
> `git checkout` or `git reset --hard`:
>
> htt
On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler wrote:
>
>
> On 5/8/2017 5:45 AM, Christian Couder wrote:
>>
>> This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is
>> set on my Linux machine.
>>
>> Also it looks like you sent a v8 of thi
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-27.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub is
On Mon, May 15, 2017 at 11:34 AM, Christian Couder
wrote:
> Hi,
>
> A draft of a new Git Rev News edition is available here:
>
>
> https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-27.md
>
> Everyone is welcome to contribute in any section eithe
Hi everyone,
The 27th edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/05/17/edition-27/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Thomas, Jakub and Markus.
On Sat, Mar 24, 2018 at 6:37 PM, Joel Teichroeb wrote:
> diff --git a/git-stash.sh b/git-stash.sh
> index fc8f8ae640..92c084eb17 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -711,7 +711,8 @@ push)
> ;;
> apply)
> shift
> - apply_stash "$@"
> + cd "$START_DIR"
On Sat, Mar 24, 2018 at 6:37 PM, Joel Teichroeb wrote:
> diff --git a/git-stash.sh b/git-stash.sh
> index 92c084eb17..360643ad4e 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -736,7 +736,8 @@ pop)
> ;;
> branch)
> shift
> - apply_to_branch "$@"
> + cd "$START_D
On Sun, Mar 25, 2018 at 8:40 AM, Eric Sunshine wrote:
> On Sat, Mar 24, 2018 at 1:37 PM, Joel Teichroeb wrote:
>> +static int do_apply_stash(const char *prefix, struct stash_info *info, int
>> index)
>> +{
>> + if (index) {
>> + if (!oidcmp(&info->b_tree, &info->i_tree) ||
On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu
wrote:
> On 23.03.2018 19:11, Christian Couder wrote:
>
>>> * Ensure that no regression occurred: considering that there are plenty
>>> of tests and that I have a good understanding of the function, this
>
On Sun, Mar 25, 2018 at 6:51 PM, Joel Teichroeb wrote:
> On Sun, Mar 25, 2018 at 1:09 AM, Christian Couder
> wrote:
>> It seems to me that the apply_stash() shell function is also used in
>> pop_stash() and in apply_to_branch(). Can the new helper be used there
>> to
On Mon, Mar 26, 2018 at 3:14 AM, Joel Teichroeb wrote:
> Signed-off-by: Joel Teichroeb
The commit message in this patch and the following ones could be a bit
more verbose. It could at least tell that the end goal is to convert
git-stash.sh to a C builtin.
> +static void destroy_stash_info(struc
-engines.2 0.63(0.59+0.04) 0.60(0.57+0.03) v2.15.1 v2.16.2
Since V1, the indent issues have been fixed and the name of the option
has been changed to --sort-by=regression (from --sortbyregression) as
suggested by Junio.
Christian Couder (2):
perf/aggregate: add display_dir()
perf/aggregate: add
7;--sort-by=regression:rtime'.
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 59 ++-
1 file changed, 58 insertions(+), 1 deletion(-)
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
index 890d85fa7b..48637ef64b 100755
--- a/t/perf/a
This new helper function will be reused in a subsequent
commit.
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
index 821cf1498b..890d85fa7b 100755
--- a/t
Hi,
On Tue, Mar 27, 2018 at 2:18 AM, Jan Keromnes wrote:
> Dear Git developers,
>
> I'd like to understand what would be required to run `git blame` on
> individual characters instead of full lines. Could you please point me
> in the right direction?
You might want to take a look at cregit
(http
On Sun, Mar 25, 2018 at 4:38 PM, Paul-Sebastian Ungureanu
wrote:
> On 25.03.2018 12:46, Christian Couder wrote:
>>
>> On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu
>> wrote:
>>>
>>> On 23.03.2018 19:11, Christian Couder wrote:
>>
On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная wrote:
> Move helper function from strbuf to ref-filter.
> Get rid of some memory leaks.
The above seems to be the changes since v5. Usually in a cover letter
(patch 0/X) there is both information about the goal of the patch
series and the changes sin
Members of an Alien species that have a far superior technology have
recently privately contacted some Git developers. They said that they
are amazed by Git technology and mostly wanted to thank us all for our
hard work on Git, as they are surely going to use it due to its free
software nature.
At
On Thu, Apr 5, 2018 at 4:28 AM, Joel Teichroeb wrote:
> Add a bulitin helper for performing stash commands. Converting
> all at once proved hard to review, so starting with just apply
> let conversion get started without the other command being
> finished.
>
> The helper is being implemented as a
On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder
wrote:
>
> So maybe we can get rid of `result` and have something like:
>
>if (argc < 1) {
>error(_("at least one argument is required"));
>usage_with_options(git_stash_helper_u
On Thu, Apr 5, 2018 at 9:59 AM, Christian Couder
wrote:
> On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder
> wrote:
>>
>> So maybe we can get rid of `result` and have something like:
>>
>>if (argc < 1) {
>>err
The new bisect_regression script can be used to automatically bisect
performance regressions. It will pass the new bisect_run_script to
`git bisect run`.
Signed-off-by: Christian Couder
---
t/perf/bisect_regression | 73
t/perf/bisect_run_script | 47
This new option makes it possible to run perf tests as defined
in only one subsection of a config file.
Signed-off-by: Christian Couder
---
t/perf/run | 56 --
1 file changed, 46 insertions(+), 10 deletions(-)
diff --git a/t/perf/run b/t/perf
t;good" runs and the
"bad" runs.
For example the following is not easily bisectable:
+100.0% p-perf-lib-sanity.2 0.01(0.01+0.01) 0.02(0.02+0.00) v2.15.1 v2.16.2
as the rtime went from 0.01 s to 0.02 s and we only have 0.01 s precision.
Christian Couder (2):
perf/run: add --s
On Thu, Apr 12, 2018 at 9:49 AM, Harald Nordgren
wrote:
> I think it looks similar. But if I'm reading that thread correctly
> then there was never a patch created, right?
(It is customary on this mailing list to reply after the sentences we
reply to. We don't "top post".)
On the GSoC idea pages
Hi,
On Sun, Apr 15, 2018 at 10:58 AM, Harald Nordgren
wrote:
> ---
>
> Notes:
> Preperatory patch to enable either Tiago Botelho's or my patch, to do
> bisection on first parents / merge commits
It would be nice if you could move some part of the above note into
the commit message (above th
On Sun, Apr 15, 2018 at 12:44 PM, Harald Nordgren
wrote:
> Signed-off-by: Harald Nordgren
> ---
>
> Notes:
> Updates according to Christian Couder's code review
About the commit message (its first line and its body), I was
suggesting a patch like the following:
>From 3a0ced0953ccc6038a43885
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-38.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub is
On Mon, Apr 16, 2018 at 12:11 AM, Christian Couder
wrote:
>
> A draft of a new Git Rev News edition is available here:
>
>
> https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-38.md
The draft has just been updated with 2 articles contributed by Jake
about
Hi Sergey,
On Mon, Apr 16, 2018 at 2:29 PM, Sergey Organov wrote:
> Hi Christian,
>
> Christian Couder writes:
>> On Mon, Apr 16, 2018 at 12:11 AM, Christian Couder
>> wrote:
>>>
>>> A draft of a new Git Rev News edition is available here:
>>>
Hi,
On Mon, Apr 16, 2018 at 5:07 PM, Kaartic Sivaraam
wrote:
>
> That said, I read the draft and found it good except for two minor issues,
Thanks for your comments!
> 1. I see the following sentence in the "Rebasing merges: a jorney to the
> ultimate solution (Road Clear) (written by Jacob Kel
On Mon, Apr 16, 2018 at 5:19 PM, Sergey Organov wrote:
> Kaartic Sivaraam writes:
>
>> 1. I see the following sentence in the "Rebasing merges: a jorney to the
>> ultimate solution (Road Clear) (written by Jacob Keller)" article
>>
>> "A few examples were tried, but it was proven that the o
Hi,
On Tue, Apr 17, 2018 at 4:17 AM, Kaartic Sivaraam
wrote:
>
> On Tuesday 17 April 2018 03:56 AM, Christian Couder wrote:
>>
>> Thanks for your comments!
>
> You're welcome!
>
> I'm sorry to say that I read only part of the draft when I sent my
>
Hi everyone,
The 38th edition of Git Rev News is now published:
https://git.github.io/rev_news/2018/04/18/edition-38/
Thanks a lot to all the contributors: Jiang Xin, Jacob Keller, Luca
Milanesio, Sergey Organov and Kaartic Sivaraam!
Enjoy,
Christian, Jakub, Markus and Gabriel.
On Thu, Apr 19, 2018 at 10:17 AM, Johannes Schindelin
wrote:
> @@ -87,9 +88,13 @@ OPTIONS
> content as except that its parents will be
> [...] instead of 's parents. A replacement ref
> is then created to replace with the newly created
> - commit. See contrib/conve
ed error: 128
While at it let's also prevent something like
'foo--sort-by=regression' to be handled as if
'--sort-by=regression' had been used.
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
On Sat, Apr 21, 2018 at 5:13 AM, Junio C Hamano wrote:
> @@ -388,6 +389,9 @@ int cmd_gc(int argc, const char **argv, const char
> *prefix)
> if (argc > 0)
> usage_with_options(builtin_gc_usage, builtin_gc_options);
>
> + if (prune_expire && parse_expiry_date(prune_e
Hi,
On Sat, Apr 21, 2018 at 8:19 AM, Vladimir Gorshenin
wrote:
> Hi,
>
> My team and I as well as millions of other developers are excited to
> have such tool at hand as Git. It helps us a lot.
>
> Now we challenged ourselves to be even more productive with Git
> analyzing our usage history.
Wha
On Sat, Apr 21, 2018 at 5:50 AM, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
>>> Not necessarily worth a re-roll.
>>
>> Not that it matters in this case, but just as a bit of Perl rx pedantry,
>> yes his is tighter & more correct. You didn't consider how "." interacts
>> with newlin
s '--' at the end of options, this changes
a bit the way '--' is handled as we can now have '--' both
after the options and before the scripts.
Signed-off-by: Christian Couder
---
Actually it looks like we should not use:
Getopt::Long::Configure qw/ pass_throug
eed format and maybe
to try to send this output to a Codespeed server.
This in unfortunate because the 'bisect_run_script' relies
on the regular output from 'aggregate.perl' to mesure
performance, so let's disable Codespeed output and sending
results to a Codespeed server.
eed format and maybe
to try to send this output to a Codespeed server.
This is unfortunate because the 'bisect_run_script' relies
on the regular output from 'aggregate.perl' to mesure
performance, so let's disable Codespeed output and sending
results to a Codespeed server.
Hi Yann,
On Sat, May 5, 2018 at 3:24 PM, Yann Dirson wrote:
> ---
> git-reintegrate | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/git-reintegrate b/git-reintegrate
It looks like git-reintegrate is not managed in Git but in this repository :
https://github.com/f
Hi Pratik and Alban,
On Sat, May 5, 2018 at 2:24 PM, Pratik Karki wrote:
> On Sat, May 5, 2018 at 5:11 PM, Alban Gruin wrote:
>>
>> as my fellow students, I started a blog series about my GSoC project[1].
>> First, I wanted to post them directly on the mailing list, but a blog
>> allows me to ed
On Sat, May 5, 2018 at 5:41 PM, wrote:
> Christian wrote:
>>
>> It looks like git-reintegrate is not managed in Git but in this
>> repository :
>>
>> https://github.com/felipec/git-reintegrate
>>
>> So could be a bit confusing to send those patches to the Git mailing
>> list without telling that
Hi,
I might start working on implementing reftable in Git soon.
During the last Git Merge conference last March Stefan talked about
reftable. In Alex Vandiver's notes [1] it is asked that people
announce it on the list when they start working on it, and it appears
that there is a reference implem
Hi Tiago,
On Wed, May 9, 2018 at 11:57 PM, Tiago Botelho wrote:
> ---
Please add something in the commit message (above the "---") about why
this new feature is useful. For example you could just say that it
will make it possible to implement bisecting on first parents which is
useful for people
On Fri, Sep 29, 2017 at 10:11 PM, Jonathan Tan wrote:
> These patches are also available online:
> https://github.com/jonathantanmy/git/commits/partialclone3
>
> (I've announced it in another e-mail, but am now sending the patches to the
> mailing list too.)
>
> Here's an update of my work so far.
On Mon, Oct 2, 2017 at 4:18 PM, Ben Peart wrote:
>
> On 9/16/2017 4:06 AM, Christian Couder wrote:
>
> - Patch 1/40 is a small code cleanup that I already sent to the
>>
>>mailing list but may be removed in the end due to ongoing work
>>on &qu
On Fri, Sep 29, 2017 at 10:36 PM, Jonathan Tan wrote:
> On Wed, 27 Sep 2017 18:46:30 +0200
> Christian Couder wrote:
>> I don't think single-shot processes would be a huge burden, because
>> the code is simpler, and because for example for filters we already
>> have
Hi,
On Tue, Oct 3, 2017 at 1:45 AM, Jonathan Nieder wrote:
> Proposed fix: because of case (1), I would like a way to tell Git to
> stop trusting any files in .git. That is:
>
> 1. Introduce a (configurable) list of "safe" configuration items that
> can be set in .git/config and don't resp
On Thu, Oct 5, 2017 at 3:22 PM, Paolo Bonzini wrote:
> The purpose of this action is for scripts to be able to keep the
> user's Signed-off-by at the end. For example say I have a script
> that adds a Reviewed-by tag:
>
> #! /bin/sh
> them=$(git log -i -1 --pretty='format:%an <%ae>' --aut
On Fri, Oct 6, 2017 at 12:40 PM, Paolo Bonzini wrote:
> On 06/10/2017 12:30, Christian Couder wrote:
>> Did you try using `--where end --if-exists replace --trailer "$sob"`?
>
> Yes, it's a different behavior; "--if-exists replace" matches on others'
On Fri, Oct 6, 2017 at 2:39 PM, Paolo Bonzini wrote:
> On 06/10/2017 14:33, Christian Couder wrote:
>> Ok. I think you might want something called for example
>> "replaceIfIdenticalClose" where "IdenticalClose" means: "there is a
>> trailer with the s
Hi,
On Thu, Oct 5, 2017 at 12:52 PM, Lars Schneider
wrote:
> Of couse I tried to log in via web browser etc. Does anyone else use
> Google as SMTP server? If yes, does it work for you?
As I wrote at the top of:
https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29jx...@ma
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-32.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub is
Hi everyone,
The 32st edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/10/11/edition-32/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Thomas, Jakub and Markus.
On Thu, Oct 12, 2017 at 3:21 AM, Junio C Hamano wrote:
> "Thais D. Braz" writes:
>
>> ---
>> Documentation/git-push.txt | 3 +++
>> builtin/push.c | 9 -
>> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> Can somebody explain what is going on?
>
> I am guessing that Thai
On Fri, Sep 29, 2017 at 10:11 PM, Jonathan Tan wrote:
> diff --git a/sha1_file.c b/sha1_file.c
> index b4a67bb83..77aa0ffdf 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -29,6 +29,7 @@
> #include "mergesort.h"
> #include "quote.h"
> #include "packfile.h"
> +#include "fetch-object.h"
>
>
On Thu, Oct 12, 2017 at 4:42 PM, Christian Couder
wrote:
>
> Instead of adding labels and gotos, I would suggest adding a new
> function like the following does on top of your changes:
Sorry for the usual Gmail related problems. You can find the patch and
a further refactoring tha
On Fri, Oct 13, 2017 at 12:06 PM, Mike Hommey wrote:
> On Fri, Oct 13, 2017 at 12:51:58PM +0300, Constantine wrote:
>> There's a gitbomb on github. It is undoubtedly creative and funny, but since
>> this is a bug in git, I thought it'd be nice to report. The command:
>>
>> $ git clone https:
On Fri, Oct 13, 2017 at 12:37 PM, Mike Hommey wrote:
> On Fri, Oct 13, 2017 at 12:26:46PM +0200, Christian Couder wrote:
>>
>> After cloning it with -n, there is the following "funny" situation:
>>
>> $ time git rev-list HEAD
>&g
On Wed, Oct 18, 2017 at 12:58 PM, Kevin Daudt wrote:
> On Sat, Sep 23, 2017 at 07:55:56PM +0000, Christian Couder wrote:
>> diff --git a/t/perf/run b/t/perf/run
>> index beb4acc0e428d..1e7c2a59e45dc 100755
>> --- a/t/perf/run
>> +++ b/t/perf/run
>> @@
Add functions to help read and write capabilities.
These functions will be reused in following patches.
Signed-off-by: Christian Couder
---
t/t0021/rot13-filter.pl | 40
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/t/t0021/rot13
If there is no new line at the end of something it receives,
the packet_txt_read() function die()s, but it's difficult to
debug without much context.
Let's give a bit more information when that happens.
Signed-off-by: Christian Couder
---
t/t0021/rot13-filter.pl | 3 ++-
1 file
And while at it let's simplify t0021/rot13-filter.pl by
using Git/Packet.pm.
This will make it possible to reuse packet related
functions in other test scripts.
Signed-off-by: Christian Couder
---
perl/Git/Packet.pm | 118
t/t0021/
Before further refactoring the "t0021/rot13-filter.pl" script,
let's modernize the style of its 'if .. elsif .. else' clauses
to improve its readability by making it more similar to our
other perl scripts.
Signed-off-by: Christian Couder
---
t/t
Let's refactor the code to initialize communication into its own
packet_initialize() function, so that we can reuse this
functionality in following patches.
Signed-off-by: Christian Couder
---
t/t0021/rot13-filter.pl | 20 +---
1 file changed, 13 insertions(+), 7 dele
al-odb239
https://github.com/chriscool/git/commits/gl-external-odb373
https://github.com/chriscool/git/commits/gl-external-odb411
Christian Couder (6):
t0021/rot13-filter: refactor packet reading functions
t0021/rot13-filter: improve 'if .. elsif .. else' style
t0021/rot13-filter: improve er
To make it possible in a following commit to move packet
reading and writing functions into a Packet.pm module,
let's refactor these functions, so they don't handle
printing debug output and exiting.
Signed-off-by: Christian Couder
---
t/t0021/rot13-filter.pl | 12
1 fi
On Fri, Oct 27, 2017 at 4:57 AM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> It is fine to leave the original code broken at this step while we
>> purely move the lines around, and hopefully this will be corrected
>> in a later step in the series (I am responding as I read on, so I do
>>
Hi,
On Mon, Oct 30, 2017 at 1:38 AM, Junio C Hamano wrote:
> I've queued this from Dscho; please take it into consideration when
> you reroll.
Yeah, I was planning to add something like that, though in Dscho's
first email the patch was adding:
+modules += Git/Packet
and now it's adding:
> +mo
On Sun, Oct 22, 2017 at 3:46 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> Add functions to help read and write capabilities.
>> These functions will be reused in following patches.
>
> One more thing that is more noteworthy (read: do not forget to
> desc
On Sun, Oct 22, 2017 at 2:58 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> To make it possible in a following commit to move packet
>> reading and writing functions into a Packet.pm module,
>> let's refactor these functions, so they don't handle
&g
its/gl-external-odb373
https://github.com/chriscool/git/commits/gl-external-odb411
Christian Couder (8):
t0021/rot13-filter: fix list comparison
t0021/rot13-filter: refactor packet reading functions
t0021/rot13-filter: improve 'if .. elsif .. else' style
t0021/rot13-filter: improve er
not what we want.
Signed-off-by: Christian Couder
---
t/t0021/rot13-filter.pl | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl
index ad685d92f8..4b2d9087d4 100644
--- a/t/t0021/rot13-filter.pl
out in a common case.
Signed-off-by: Christian Couder
---
t/t0021/rot13-filter.pl | 38 --
1 file changed, 28 insertions(+), 10 deletions(-)
diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl
index 4b2d9087d4..c025518c0a 100644
--- a/t/t0021/rot13-
And while at it let's simplify t0021/rot13-filter.pl by
using Git/Packet.pm.
This will make it possible to reuse packet related
functions in other test scripts.
Signed-off-by: Christian Couder
---
perl/Git/Packet.pm | 168
perl/Mak
201 - 300 of 1682 matches
Mail list logo
