[PATCH v1 1/8] fetch-object: make functions return an error code

2018-05-13 Thread Christian Couder
The callers of the fetch_object() and fetch_objects() might be interested in knowing if these functions succeeded or not. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- fetch-object.c | 15 +-- fetch-object.h | 6 +++--- sha1-file.c| 4 ++-- 3 files chang

[PATCH v1 6/8] Use odb_remote_get_direct() and has_external_odb()

2018-05-13 Thread Christian Couder
Instead of using the repository_format_partial_clone global and fetch_object() directly, let's use has_odb_remote() and odb_remote_get_direct(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/cat-file.c| 5 +++-- builtin/fetch.c

[PATCH v1 8/8] t0410: test fetching from many promisor remotes

2018-05-13 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 6af4712da8..4a7a662512 100755 --- a/t/t0410-p

[PATCH v1 7/8] Use odb.origin.partialclonefilter instead of core.partialclonefilter

2018-05-13 Thread Christian Couder
Let's make the partial clone filter specific to one odb instead of general to all the odbs. This makes it possible to have different partial clone filters for different odbs. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/fetch.c | 2 +- list-objects-

[PATCH v1 4/8] odb-remote: implement odb_remote_get_many_direct()

2018-05-13 Thread Christian Couder
This function will be used to get many objects from a promisor remote. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 15 +++ odb-helper.h | 3 +++ odb-remote.c | 17 + odb-remote.h | 1 + 4 files changed, 36 insertions(+) diff

[PATCH v1 3/8] odb-remote: implement odb_remote_get_direct()

2018-05-13 Thread Christian Couder
This is implemented only in the promisor remote mode for now by calling fetch_object(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c | 14 ++ odb-helper.h | 3 ++- odb-remote.c | 17 + odb-remote.h | 1 + 4 files changed, 34 inse

[PATCH v1 2/8] Add initial odb remote support

2018-05-13 Thread Christian Couder
functions or the external scripts or processes that will manage and provide remote git objects. For now only infrastructure to create helpers from the config and to check if there are odb remotes and helpers is implemented. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Christia

[PATCH v1 5/8] odb-remote: add odb_remote_reinit()

2018-05-13 Thread Christian Couder
We will need to reinitialize the odb remote configuration as we will make some changes to it in a later commit when we will detect that a remote is also an odb remote. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-remote.c | 14 -- odb-remote.h | 1 + 2

[PATCH v1 0/8] Introducing odb remote

2018-05-13 Thread Christian Couder
xternal ODB support" series: https://public-inbox.org/git/20180103163403.11303-1-chrisc...@tuxfamily.org/ https://public-inbox.org/git/20180319133147.15413-1-chrisc...@tuxfamily.org/ Version 1 and 2 of the "Promisor remotes and external ODB support" series on GitHub: https://github.com/

Re: [PATCH] Implement --first-parent for git rev-list --bisect

2018-05-09 Thread Christian Couder
Hi Tiago, On Wed, May 9, 2018 at 11:57 PM, Tiago Botelho wrote: > --- Please add something in the commit message (above the "---") about why this new feature is useful. For example you could just say that it will make it possible to implement bisecting on first parents

Implementing reftable in Git

2018-05-09 Thread Christian Couder
Hi, I might start working on implementing reftable in Git soon. During the last Git Merge conference last March Stefan talked about reftable. In Alex Vandiver's notes [1] it is asked that people announce it on the list when they start working on it, and it appears that there is a reference

Re: [PATCH 1/2] Fix support for merge options.

2018-05-05 Thread Christian Couder
On Sat, May 5, 2018 at 5:41 PM, wrote: > Christian wrote: >> >> It looks like git-reintegrate is not managed in Git but in this >> repository : >> >> https://github.com/felipec/git-reintegrate >> >> So could be a bit confusing to send those patches to the Git mailing >> list

Re: [GSoC] Yet another blog series about the GSoC

2018-05-05 Thread Christian Couder
Hi Pratik and Alban, On Sat, May 5, 2018 at 2:24 PM, Pratik Karki wrote: > On Sat, May 5, 2018 at 5:11 PM, Alban Gruin wrote: >> >> as my fellow students, I started a blog series about my GSoC project[1]. >> First, I wanted to post them directly

Re: [PATCH 1/2] Fix support for merge options.

2018-05-05 Thread Christian Couder
Hi Yann, On Sat, May 5, 2018 at 3:24 PM, Yann Dirson wrote: > --- > git-reintegrate | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/git-reintegrate b/git-reintegrate It looks like git-reintegrate is not managed in Git but in this repository :

[PATCH v2] perf/bisect_run_script: disable codespeed

2018-05-04 Thread Christian Couder
to try to send this output to a Codespeed server. This is unfortunate because the 'bisect_run_script' relies on the regular output from 'aggregate.perl' to mesure performance, so let's disable Codespeed output and sending results to a Codespeed server. Signed-off-by: Christian Couder <chr

[PATCH v1] perf/bisect_run_script: disable codespeed

2018-04-27 Thread Christian Couder
to try to send this output to a Codespeed server. This in unfortunate because the 'bisect_run_script' relies on the regular output from 'aggregate.perl' to mesure performance, so let's disable Codespeed output and sending results to a Codespeed server. Signed-off-by: Christian Couder <chr

[PATCH v2] perf/aggregate: use Getopt::Long for option parsing

2018-04-25 Thread Christian Couder
changes a bit the way '--' is handled as we can now have '--' both after the options and before the scripts. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Actually it looks like we should not use: Getopt::Long::Configure qw/ pass_through /; as GetOptions() would not error

Re: [PATCH v1] perf/aggregate: tighten option parsing

2018-04-25 Thread Christian Couder
On Sat, Apr 21, 2018 at 5:50 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >>> Not necessarily worth a re-roll. >> >> Not that it matters in this case, but just as a bit of Perl rx pedantry, >> yes his is tighter & more correct. You didn't

Re: Git archeology

2018-04-21 Thread Christian Couder
Hi, On Sat, Apr 21, 2018 at 8:19 AM, Vladimir Gorshenin wrote: > Hi, > > My team and I as well as millions of other developers are excited to > have such tool at hand as Git. It helps us a lot. > > Now we challenged ourselves to be even more productive with Git

Re: Silly "git gc" UI issue.

2018-04-21 Thread Christian Couder
On Sat, Apr 21, 2018 at 5:13 AM, Junio C Hamano wrote: > @@ -388,6 +389,9 @@ int cmd_gc(int argc, const char **argv, const char > *prefix) > if (argc > 0) > usage_with_options(builtin_gc_usage, builtin_gc_options); > > + if (prune_expire &&

[PATCH v1] perf/aggregate: tighten option parsing

2018-04-20 Thread Christian Couder
at it let's also prevent something like 'foo--sort-by=regression' to be handled as if '--sort-by=regression' had been used. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH v2 2/7] replace: introduce --convert-graft-file

2018-04-19 Thread Christian Couder
On Thu, Apr 19, 2018 at 10:17 AM, Johannes Schindelin wrote: > @@ -87,9 +88,13 @@ OPTIONS > content as except that its parents will be > [...] instead of 's parents. A replacement ref > is then created to replace with the newly created > -

[ANNOUNCE] Git Rev News edition 38

2018-04-18 Thread Christian Couder
Hi everyone, The 38th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/04/18/edition-38/ Thanks a lot to all the contributors: Jiang Xin, Jacob Keller, Luca Milanesio, Sergey Organov and Kaartic Sivaraam! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: Draft of Git Rev News edition 38

2018-04-17 Thread Christian Couder
Hi, On Tue, Apr 17, 2018 at 4:17 AM, Kaartic Sivaraam <kaartic.sivar...@gmail.com> wrote: > > On Tuesday 17 April 2018 03:56 AM, Christian Couder wrote: >> >> Thanks for your comments! > > You're welcome! > > I'm sorry to say that I read only part of the dr

Re: Draft of Git Rev News edition 38

2018-04-16 Thread Christian Couder
On Mon, Apr 16, 2018 at 5:19 PM, Sergey Organov wrote: > Kaartic Sivaraam writes: > >> 1. I see the following sentence in the "Rebasing merges: a jorney to the >> ultimate solution (Road Clear) (written by Jacob Keller)" article >> >> "A few

Re: Draft of Git Rev News edition 38

2018-04-16 Thread Christian Couder
Hi, On Mon, Apr 16, 2018 at 5:07 PM, Kaartic Sivaraam wrote: > > That said, I read the draft and found it good except for two minor issues, Thanks for your comments! > 1. I see the following sentence in the "Rebasing merges: a jorney to the > ultimate solution (Road

Re: Draft of Git Rev News edition 38

2018-04-16 Thread Christian Couder
Hi Sergey, On Mon, Apr 16, 2018 at 2:29 PM, Sergey Organov <sorga...@gmail.com> wrote: > Hi Christian, > > Christian Couder <christian.cou...@gmail.com> writes: >> On Mon, Apr 16, 2018 at 12:11 AM, Christian Couder >> <christian.cou...@gmail.com> wrote

Re: Draft of Git Rev News edition 38

2018-04-16 Thread Christian Couder
On Mon, Apr 16, 2018 at 12:11 AM, Christian Couder <christian.cou...@gmail.com> wrote: > > A draft of a new Git Rev News edition is available here: > > > https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-38.md The draft has just been updated with 2

Draft of Git Rev News edition 38

2018-04-15 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-38.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [PATCH v2] Make it possible to implement bisecting only on first parents or on merge commits by passing flags to find_bisection(), instead of just a find_all boolean

2018-04-15 Thread Christian Couder
On Sun, Apr 15, 2018 at 12:44 PM, Harald Nordgren wrote: > Signed-off-by: Harald Nordgren > --- > > Notes: > Updates according to Christian Couder's code review About the commit message (its first line and its body), I was suggesting a

Re: [PATCH] Create 'bisect_flags' parameter in find_bisection() in preparation of passing multiple options

2018-04-15 Thread Christian Couder
Hi, On Sun, Apr 15, 2018 at 10:58 AM, Harald Nordgren wrote: > --- > > Notes: > Preperatory patch to enable either Tiago Botelho's or my patch, to do > bisection on first parents / merge commits It would be nice if you could move some part of the above note into

Re: [PATCH] Create '--merges-only' option for 'git bisect'

2018-04-12 Thread Christian Couder
On Thu, Apr 12, 2018 at 9:49 AM, Harald Nordgren wrote: > I think it looks similar. But if I'm reading that thread correctly > then there was never a patch created, right? (It is customary on this mailing list to reply after the sentences we reply to. We don't "top

[PATCH v1 1/2] perf/run: add --subsection option

2018-04-08 Thread Christian Couder
This new option makes it possible to run perf tests as defined in only one subsection of a config file. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 56 -- 1 file changed, 46 insertions(+), 10 deletions(-)

[PATCH v1 0/2] t/perf: bisect performance regressions

2018-04-08 Thread Christian Couder
t;good" runs and the "bad" runs. For example the following is not easily bisectable: +100.0% p-perf-lib-sanity.2 0.01(0.01+0.01) 0.02(0.02+0.00) v2.15.1 v2.16.2 as the rtime went from 0.01 s to 0.02 s and we only have 0.01 s precision. Christian Couder (2): perf/run: add --s

[PATCH v1 2/2] t/perf: add scripts to bisect performance regressions

2018-04-08 Thread Christian Couder
The new bisect_regression script can be used to automatically bisect performance regressions. It will pass the new bisect_run_script to `git bisect run`. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/bisect_regression | 73

Re: [PATCH v5 2/5] stash: convert apply to builtin

2018-04-05 Thread Christian Couder
On Thu, Apr 5, 2018 at 9:59 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder > <christian.cou...@gmail.com> wrote: >> >> So maybe we can get rid of `result` and have something like: >> >>

Re: [PATCH v5 2/5] stash: convert apply to builtin

2018-04-05 Thread Christian Couder
On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder <christian.cou...@gmail.com> wrote: > > So maybe we can get rid of `result` and have something like: > >if (argc < 1) { >error(_("at least one argument is required")); &

Re: [PATCH v5 2/5] stash: convert apply to builtin

2018-04-05 Thread Christian Couder
On Thu, Apr 5, 2018 at 4:28 AM, Joel Teichroeb wrote: > Add a bulitin helper for performing stash commands. Converting > all at once proved hard to review, so starting with just apply > let conversion get started without the other command being > finished. > > The helper is

[ANNOUNCE] Git developers contacted by an advanced alien species

2018-04-01 Thread Christian Couder
Members of an Alien species that have a far superior technology have recently privately contacted some Git developers. They said that they are amazed by Git technology and mostly wanted to thank us all for our hard work on Git, as they are surely going to use it due to its free software nature.

Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic

2018-03-29 Thread Christian Couder
On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная wrote: > Move helper function from strbuf to ref-filter. > Get rid of some memory leaks. The above seems to be the changes since v5. Usually in a cover letter (patch 0/X) there is both information about the goal of the patch

Re: [GSoC] Convert “git stash” to builtin proposal

2018-03-27 Thread Christian Couder
On Sun, Mar 25, 2018 at 4:38 PM, Paul-Sebastian Ungureanu <ungureanupaulsebast...@gmail.com> wrote: > On 25.03.2018 12:46, Christian Couder wrote: >> >> On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu >> <ungureanupaulsebast...@gmail.com> wrote: >&

Re: How to `git blame` individual characters?

2018-03-27 Thread Christian Couder
Hi, On Tue, Mar 27, 2018 at 2:18 AM, Jan Keromnes wrote: > Dear Git developers, > > I'd like to understand what would be required to run `git blame` on > individual characters instead of full lines. Could you please point me > in the right direction? You might want to take a

[PATCH v2 1/2] perf/aggregate: add display_dir()

2018-03-26 Thread Christian Couder
This new helper function will be reused in a subsequent commit. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index 821c

[PATCH v2 2/2] perf/aggregate: add --sort-by=regression option

2018-03-26 Thread Christian Couder
-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index 890d85fa7b..48637ef64b 100755 --- a/t/perf/aggregate.perl +++ b/

[PATCH v2 0/2] perf/aggregate: sort results by regression

2018-03-26 Thread Christian Couder
-engines.2 0.63(0.59+0.04) 0.60(0.57+0.03) v2.15.1 v2.16.2 Since V1, the indent issues have been fixed and the name of the option has been changed to --sort-by=regression (from --sortbyregression) as suggested by Junio. Christian Couder (2): perf/aggregate: add display_dir() perf/aggregate:

Re: [PATCH v2 3/6] stash: convert apply to builtin

2018-03-26 Thread Christian Couder
On Mon, Mar 26, 2018 at 3:14 AM, Joel Teichroeb wrote: > Signed-off-by: Joel Teichroeb The commit message in this patch and the following ones could be a bit more verbose. It could at least tell that the end goal is to convert git-stash.sh to a C builtin.

Re: [PATCH 1/4] stash: convert apply to builtin

2018-03-25 Thread Christian Couder
On Sun, Mar 25, 2018 at 6:51 PM, Joel Teichroeb <j...@teichroeb.net> wrote: > On Sun, Mar 25, 2018 at 1:09 AM, Christian Couder > <christian.cou...@gmail.com> wrote: >> It seems to me that the apply_stash() shell function is also used in >> pop_stash() and in apply_t

Re: [GSoC] Convert “git stash” to builtin proposal

2018-03-25 Thread Christian Couder
On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu <ungureanupaulsebast...@gmail.com> wrote: > On 23.03.2018 19:11, Christian Couder wrote: > >>> * Ensure that no regression occurred: considering that there are plenty >>> of tests and that I have a good

Re: [PATCH 1/4] stash: convert apply to builtin

2018-03-25 Thread Christian Couder
On Sun, Mar 25, 2018 at 8:40 AM, Eric Sunshine wrote: > On Sat, Mar 24, 2018 at 1:37 PM, Joel Teichroeb wrote: >> +static int do_apply_stash(const char *prefix, struct stash_info *info, int >> index) >> +{ >> + if (index) { >> +

Re: [PATCH 2/4] stash: convert branch to builtin

2018-03-25 Thread Christian Couder
On Sat, Mar 24, 2018 at 6:37 PM, Joel Teichroeb wrote: > diff --git a/git-stash.sh b/git-stash.sh > index 92c084eb17..360643ad4e 100755 > --- a/git-stash.sh > +++ b/git-stash.sh > @@ -736,7 +736,8 @@ pop) > ;; > branch) > shift > - apply_to_branch "$@" >

Re: [PATCH 1/4] stash: convert apply to builtin

2018-03-25 Thread Christian Couder
On Sat, Mar 24, 2018 at 6:37 PM, Joel Teichroeb wrote: > diff --git a/git-stash.sh b/git-stash.sh > index fc8f8ae640..92c084eb17 100755 > --- a/git-stash.sh > +++ b/git-stash.sh > @@ -711,7 +711,8 @@ push) > ;; > apply) > shift > - apply_stash "$@" > +

Re: [PATCH 3/4] stash: convert drop and clear to builtin

2018-03-24 Thread Christian Couder
> + argv_array_pushl(, "reflog", "delete", "--updateref", > "--rewrite", NULL); > + argv_array_push(, info->revision); > + ret = cmd_reflog(args.argc, args.argv, prefix); > + if (!ret) { > + if (!quiet) { > + printf(_("Dropped %s

Re: [PATCH 1/4] stash: convert apply to builtin

2018-03-24 Thread Christian Couder
> + if (unpack_trees(nr_trees, t, )) > + return -1; > + > + if (write_locked_index(_index, _file, COMMIT_LOCK)) { > + error(_("unable to write new index file")); > + return -1; Maybe: return error(...); > + } > + > + return 0; >

Re: [GSoC] Re: Info: git log --oneline improvements

2018-03-24 Thread Christian Couder
Hi, On Sat, Mar 24, 2018 at 9:41 AM, Pratik Karki wrote: > > Hi Christian and Johannes, > > Though I sent a mail earlier, saying I would like to submit another > proposal, I am now skeptical on re-writing another proposal as you > guys are only available mentor for GSoC

Re: [RFC] [GSoC] Project proposal: convert scripts to builtins

2018-03-24 Thread Christian Couder
Hi, On Wed, Mar 21, 2018 at 7:16 AM, Pratik Karki wrote: > > Thanks for the feedback. Thanks to you, I realized my proposal was > a bit ambitious. Both git-stash and git-rebase are big > commitment. After much analyzing, I found out I cannot complete > both in the given

Re: [GSOC]About the microproject related to CI

2018-03-24 Thread Christian Couder
Hi, On Fri, Mar 23, 2018 at 2:44 AM, Zhibin Li <08826794b...@gmail.com> wrote: > Hi all, > > I'm Zhibin Li, an undergraduate from China and I'm interested in automated > testing. Since the application deadline is coming, hope it's not too late > for me to start with the microproject. As the

Re: [GSoC] Info: git log --oneline improvements

2018-03-24 Thread Christian Couder
Hi, On Sat, Mar 24, 2018 at 5:32 AM, Pratik Karki wrote: > > Hi Christian and Johannes, > > I will like to send another proposal on git log --oneline improvements. > My first proposal[1] was on "Convert scripts to builtins". Can > you provide me information about "git

Re: [RFC][GSoC] Project proposal: convert interactive rebase to C

2018-03-24 Thread Christian Couder
Hi, On Thu, Mar 22, 2018 at 11:03 PM, Alban Gruin wrote: > Hi, > > here is my second draft of my proposal. As last time, any feedback is > welcome :) > > I did not write my phone number and address here for obvious reasons, > but they will be in the “about me” section of

Re: [PATCH v1 0/2] perf/aggregate: sort result by regression

2018-03-24 Thread Christian Couder
On Fri, Mar 23, 2018 at 10:16 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> This small patch series makes it easy to spot big performance >> regressions, so that they can later be investigated. >> >

Re: [GSoC] Convert “git stash” to builtin proposal

2018-03-23 Thread Christian Couder
On Fri, Mar 23, 2018 at 12:15 AM, Paul-Sebastian Ungureanu <ungureanupaulsebast...@gmail.com> wrote: > > On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: >> >> On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu >> <ungureanupaulsebast...@gmai

Re: [PATCH v1 0/2] perf/aggregate: sort result by regression

2018-03-23 Thread Christian Couder
On Fri, Mar 23, 2018 at 3:00 PM, Christian Couder <christian.cou...@gmail.com> wrote: > This small patch series makes it easy to spot big performance > regressions, so that they can later be investigated. Sorry I just realized there are indent problems in the patches.

[PATCH v1 1/2] perf/aggregate: add display_dir()

2018-03-23 Thread Christian Couder
This new helper function will be reused in a subsequent commit. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index 821c

[PATCH v1 2/2] perf/aggregate: add --sortbyregression option

2018-03-23 Thread Christian Couder
One of the most interesting thing one can be interested in when looking at performance test results is possible performance regressions. This new option makes it easy to spot such possible regressions. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.per

[PATCH v1 0/2] perf/aggregate: sort result by regression

2018-03-23 Thread Christian Couder
nes.2 0.63(0.59+0.04) 0.60(0.57+0.03) v2.15.1 v2.16.2 Christian Couder (2): perf/aggregate: add display_dir() perf/aggregate: add --sortbyregression option t/perf/aggregate.perl | 59 +++ 1 file changed, 54 insertions(+), 5 deletions(-) -- 2.1

[ANNOUNCE] Git Rev News edition 37

2018-03-21 Thread Christian Couder
Hi everyone, The 37th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/03/21/edition-37/ Thanks a lot to all the contributors! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: [GSoC] Convert “git stash” to builtin proposal

2018-03-20 Thread Christian Couder
Hi, On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu wrote: > > * Convert function: this step is basically makes up the goal of this > project. Could you explain a bit more how you would convert a function? Or could you explain for example how you

Re: [RFC] [GSoC] Project proposal: convert scripts to builtins

2018-03-20 Thread Christian Couder
Hi, On Tue, Mar 20, 2018 at 10:00 AM, Pratik Karki wrote: > Hi, > This is my draft for my proposal on "Convert Scripts to builtin" for GSoC. > Please review and provide feedbacks. > > https://gist.github.com/prertik/daaa73a39d3ce30811d9a208043dc235 It would be easier

Re: [GSoC] Regarding "Convert scripts to builtins"

2018-03-19 Thread Christian Couder
On Tue, Mar 20, 2018 at 12:11 AM, Christian Couder <christian.cou...@gmail.com> wrote: > On Sun, Mar 18, 2018 at 11:15 PM, Paul Sebastian Ungureanu >> First of all, I find it difficult to pick which scripts would benefit >> the most by being rewritten. I am thinking of

Re: [GSoC] Regarding "Convert scripts to builtins"

2018-03-19 Thread Christian Couder
Hi, On Sun, Mar 18, 2018 at 11:15 PM, Paul Sebastian Ungureanu wrote: > Hello, > > I am interested in the "Convert scripts to builtins" project. I have > recently started to analyze it better and see exactly what it entails > and a few questions came to my mind.

[PATCH v2 08/36] external-odb: add external_odb_reinit()

2018-03-19 Thread Christian Couder
As we will need to reinitialize the list of odb helpers from the config file, let's add external_odb_reinit() for that purpose. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 14 -- external-odb.h | 1 + 2 files changed, 13 insertions(+), 2 del

[PATCH v2 10/36] odb-helper: add 'script_mode' to 'struct odb_helper'

2018-03-19 Thread Christian Couder
rs defined using the existing "odb..scriptcommand" are marked with the 'script_mode' field set to 1. Implementation of the different capabilities/instructions in the new (sub-)process mode is left for following commits. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org>

[PATCH v2 09/36] external-odb: add script mode support

2018-03-19 Thread Christian Couder
This adds support for the script command mode where an helper script or command is called to retrieve or manage objects. This implements the 'have' and 'get_git_obj' instructions for the script mode. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c

[PATCH v2 19/36] t0500: add test for external odb write support

2018-03-19 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0500-external-odb.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t0500-external-odb.sh b/t/t0500-external-odb.sh index 4ccca1e965..f924de870f 100755 --- a/t/t0500-external-odb.sh +++ b/t/t0500-external-

[PATCH v2 24/36] lib-httpd: add apache-e-odb.conf

2018-03-19 Thread Christian Couder
This is an apache config file to test external object databases. It uses the upload.sh and list.sh cgi that have been added previously to make apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd/apache-e-odb.conf

[PATCH v2 23/36] lib-httpd: add list.sh

2018-03-19 Thread Christian Couder
This cgi script can list Git objects that have been uploaded as files to an apache web server. This script can also retrieve the content of each of these files. This will help make apache work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> ---

[PATCH v2 20/36] Add t0510 to test external ODB transfer

2018-03-19 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0510-transfer-e-odb.sh | 144 ++ 1 file changed, 144 insertions(+) create mode 100755 t/t0510-transfer-e-odb.sh diff --git a/t/t0510-transfer-e-odb.sh b/t/t0510-transfer-e-odb.sh new fil

[PATCH v2 15/36] external-odb: add 'get_direct' support

2018-03-19 Thread Christian Couder
me kind of mechanism to "put" objects into an external odb, where the odb helper would access blobs it wants to send to an external odb directly from files, but it would be strange to call that a fault-in mode too. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- e

[PATCH v2 28/36] odb-helper: add init_object_process()

2018-03-19 Thread Christian Couder
This adds the infrastructure to launch and use long running sub-processes as external odb helpers. For now only the 'init' and 'get_direct' capabilities are supported with sub-processes. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 46 +++-- odb-he

[PATCH v2 25/36] odb-helper: add odb_helper_get_raw_object()

2018-03-19 Thread Christian Couder
The existing odb_helper_get_object() is renamed odb_helper_get_git_object() and a new odb_helper_get_raw_object() is introduced to deal with external objects that are not in Git format. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c

[PATCH v2 29/36] Add t0550 to test 'get_direct' mechanism

2018-03-19 Thread Christian Couder
From: Ben Peart <benpe...@microsoft.com> Signed-off-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0550-read-object.sh | 28 + t/t0550/read-object| 68 ++ 2

[PATCH v2 31/36] odb-helper: add put_object_process()

2018-03-19 Thread Christian Couder
This adds the infrastructure to send objects to a sub-process handling the communication with an external odb. For now we only handle sending raw blobs using the 'put_raw_obj' instruction. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.

[PATCH v2 32/36] Add t0570 to test passing raw objects

2018-03-19 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0570-read-object-http-e-odb.sh | 109 ++ t/t0570/read-object-plain | 83 +++ 2 files changed, 192 insertions(+) create mode 100755 t/t0570-read-object-http-e-odb.sh

[PATCH v2 35/36] external-odb: use 'odb=magic' attribute to mark odb blobs

2018-03-19 Thread Christian Couder
To tell which blobs should be sent to the "magic" external odb, let's require that the blobs be marked using the 'odb=magic' attribute. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 25 ++---

[PATCH v2 34/36] Add t0580 to test "have" capability and raw objects

2018-03-19 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0580-read-object-have-http-e-odb.sh | 109 + t/t0580/read-object-plain-have | 103 +++ 2 files changed, 212 insertions(+) create mode 100755 t/t0580-read-object-have-http-e-

[PATCH v2 30/36] Add t0560 to test passing git objects

2018-03-19 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0560-read-object-git.sh | 28 ++ t/t0560/read-object-git| 78 ++ 2 files changed, 106 insertions(+) create mode 100755 t/t0560-read-object-git.sh create mode 100755 t/t056

[PATCH v2 11/36] odb-helper: add odb_helper_init() to send 'init' instruction

2018-03-19 Thread Christian Couder
variable in struct odb_helper to store them. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 13 - odb-helper.c| 58 + odb-helper.h| 11 t/t0500-external-odb.sh | 4 +++ 4

[PATCH v2 33/36] odb-helper: add have_object_process()

2018-03-19 Thread Christian Couder
This adds the infrastructure to handle 'have' instructions in process mode. The answer from the helper sub-process should be like the output in script mode, that is lines like this: sha1 SPACE size SPACE type NEWLINE Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-he

[PATCH v2 36/36] Add Documentation/technical/external-odb.txt

2018-03-19 Thread Christian Couder
This describes the external odb mechanism's purpose and how it works. Helped-by: Ben Peart <benpe...@microsoft.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/technical/external-odb.txt | 342 +++ 1 file changed, 342 insertions(+)

[PATCH v2 21/36] lib-httpd: pass config file to start_httpd()

2018-03-19 Thread Christian Couder
This makes it possible to start an apache web server with different config files. This will be used in a later patch to pass a config file that makes apache store external objects. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh | 6 -- 1 file chan

[PATCH v2 27/36] Add t0520 to test transfer to HTTP external odb

2018-03-19 Thread Christian Couder
This tests that an apache web server can be used as an external object database and store files in their native format instead of converting them to a Git object. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0520-transfer-http-e-odb.sh

[PATCH v2 22/36] lib-httpd: add upload.sh

2018-03-19 Thread Christian Couder
This cgi will be used to upload objects to, or to delete objects from, an apache web server. This way the apache server can work as an external object database. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/lib-httpd.sh| 1 + t/lib-httpd/upload.s

[PATCH v2 26/36] pack-objects: don't pack objects in external odbs

2018-03-19 Thread Christian Couder
Objects managed by an external ODB should not be put into pack files. They should be transfered using other mechanism that can be specific to the external odb. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/pack-objects.c | 4 1 file changed, 4 insertions(+)

[PATCH v2 03/36] Add GIT_NO_EXTERNAL_ODB env variable

2018-03-19 Thread Christian Couder
This new environment variable will be used to perform git commands without involving any external odb mechanism. This makes it possible for example to create new blobs that will not be sent to an external odb even if the external odb supports "put_*" instructions. Signed-off-by: Christ

[PATCH v2 14/36] Use odb.origin.partialclonefilter instead of core.partialclonefilter

2018-03-19 Thread Christian Couder
Let's make the partial clone filter specific to one odb instead of general to all the odbs. This makes it possible to have different partial clone filters for different odbs. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/fetch.c | 2 +- external

[PATCH v2 13/36] Use external_odb_get_direct() and has_external_odb()

2018-03-19 Thread Christian Couder
Instead of using the repository_format_partial_clone global and fetch_object() directly, let's use has_external_odb() and external_odb_get_direct(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/cat-file.c| 5 +++-- builtin/fetch.c

[PATCH v2 12/36] external-odb: add external_odb_get_many_direct()

2018-03-19 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 17 + external-odb.h | 1 + odb-helper.c | 16 odb-helper.h | 2 ++ 4 files changed, 36 insertions(+) diff --git a/external-odb.c b/external-odb.c index ae6bc017fe..8be9

[PATCH v2 17/36] external odb: add 'put_raw_obj' support

2018-03-19 Thread Christian Couder
by an odb helper. This is not a great default, but let's leave it to following commits to tweak that. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 15 +++ external-odb.h | 2 ++ odb-helper.c | 51 -

[PATCH v2 00/36] Promisor remotes and external ODB support

2018-03-19 Thread Christian Couder
; series: https://public-inbox.org/git/20180103163403.11303-1-chrisc...@tuxfamily.org/ Version 1 of this "Promisor remotes and external ODB support" series on GitHub: https://github.com/chriscool/git/commits/gl-small-promisor-external-odb12 Ben Peart (1): Add t0550 to test 'ge

[PATCH v2 16/36] t0500: add 'put_raw_obj' instruction to odb-helper script

2018-03-19 Thread Christian Couder
odb-helper script works well. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0500-external-odb.sh | 24 1 file changed, 24 insertions(+) diff --git a/t/t0500-external-odb.sh b/t/t0500-external-odb.sh index 977fea852d..4ccca1e965 100755 --- a/t

[PATCH v2 18/36] external-odb: accept only blobs for now

2018-03-19 Thread Christian Couder
The mechanism to decide which blobs should be sent to which external object database will be very simple for now. If the external odb helper support any "put_*" instruction all the new blobs will be sent to it. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- ex

<    1   2   3   4   5   6   7   8   9   10   >