[ANNOUNCE] Git Rev News edition 39

Hi everyone, The 39th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/05/16/edition-39/ Thanks a lot to all the contributors: Johannes Schindelin, Elijah Newren and Luca Milanesio! Enjoy, Christian, Jakub, Markus and Gabriel.

[PATCH] t: make many tests depend less on the refs being files

care of many low hanging fruits. It does not try to completely solves the issue. Signed-off-by: David Turner Signed-off-by: Christian Couder --- Thanks for all the great feedback regarding implementing reftable [1]. Looking at David Turner's tests in [2], it seems that they could inde

Re: [PATCH] t: make many tests depend less on the refs being files

Hi Dscho, On Mon, May 21, 2018 at 11:41 AM, Johannes Schindelin wrote: > > On Mon, 21 May 2018, Christian Couder wrote: > >> From: David Turner > > I vaguely remember that Dave suggested using a different email address > these days... > > *clicketyclick* > >

Re: user name

On Tue, May 22, 2018 at 3:06 PM, Dennis Powless wrote: > Is it customary to use your real name or a user name when registering to GIT? I guess you are talking about using `git config --global user.name "XXX YYY"`. (Though maybe you are talking about github.com registration, but in this case you s

[PATCH v2] t: make many tests depend less on the refs being files

does not try to completely solves the issue. Helped-by: Stefan Beller Helped-by: Johannes Schindelin Signed-off-by: David Turner Signed-off-by: Christian Couder --- t/lib-t6000.sh | 6 +++--- t/t1401-symbolic-ref.sh | 2 +- t/t3200-branch.sh

Re: [PATCH] t: make many tests depend less on the refs being files

On Mon, May 21, 2018 at 1:49 PM, SZEDER Gábor wrote: >> > diff --git a/t/t9903-bash-prompt.sh b/t/t9903-bash-prompt.sh >> > index 8f5c811dd7..c3b89ae783 100755 >> > --- a/t/t9903-bash-prompt.sh >> > +++ b/t/t9903-bash-prompt.sh >> > @@ -148,7 +148,7 @@ test_expect_success 'prompt - inside .git dir

Re: [PATCH] t: make many tests depend less on the refs being files

On Mon, May 21, 2018 at 9:34 PM, Stefan Beller wrote: > On Sun, May 20, 2018 at 10:51 PM, Christian Couder > wrote: >> From: David Turner >> >> So that they work under alternate ref storage backends. > > Sometimes I have a disconnect between the subject and the

Re: git difftool with symlink to readonly jar failed

Hi, On Thu, May 24, 2018 at 11:11 PM, Etienne d'Hautefeuille wrote: > > #try a diff > git difftool --dir-diff 4cb98b4a307ce97d9e6b8e4b03211fa5ca8af7e7 > 0244799661b993b1f78fa5afb621de3fe4c4a39c > fatal: impossible d'ouvrir '/tmp/git-difftool.UQ4mqo/left/jenkins.war' en > écriture: Permission non

Re: [PATCH v2] t: make many tests depend less on the refs being files

On Fri, May 25, 2018 at 10:48 AM, Michael Haggerty wrote: > On 05/23/2018 07:25 AM, Christian Couder wrote: >> >> diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh >> index 9e782a8122..a4ebb0b65f 100755 >> --- a/t/t1401-symbolic-ref.sh >> +++ b/t/

Re: [PATCH v2] t: make many tests depend less on the refs being files

On Fri, May 25, 2018 at 11:05 AM, Michael Haggerty wrote: > On Fri, May 25, 2018 at 10:59 AM, Jeff King wrote: >> On Fri, May 25, 2018 at 10:48:04AM +0200, Michael Haggerty wrote: >> >>> > test_expect_success "multi-fetch works off a 'clean' repository" ' >>> > - rm -r "$GIT_DIR/svn" "$GIT_DIR

Re: [PATCH v2 4/5] config doc: mention future aspirations for transfer.fsckObjects

On Fri, May 25, 2018 at 9:28 PM, Ævar Arnfjörð Bjarmason wrote: > > Jeff King has said on at least a couple of occasions (at least one of > Let's note that in the documentation so we don't seem to be claiming > that this is by design. A previous version of this change called the > current behavior

[PATCH] t990X: use '.git/objects' as 'deep inside .git' path

ers that these tests do not depend on which ref backend is used. The internals of the loose refs backend are still tested in t1400-update-ref.sh. Helped-by: SZEDER Gábor Signed-off-by: David Turner Signed-off-by: Christian Couder --- t/t9902-completion.sh | 2 +- t/t9903-bash-prompt.

Re: [GSoC] GSoC with git, week 4

Hi Alban, On Sat, May 26, 2018 at 6:32 PM, Alban Gruin wrote: > > I published my blog post about this week. You can read it here: > > https://blog.pa1ch.fr/posts/2018/05/26/en/gsoc2018-week-4.html > > All comments are welcome! Thanks for publishing a nice update! Christian.

Re: Bug: Install from .tar.xz fails without write permission on /usr/local/share/man/man3

Hi, On Thu, May 31, 2018 at 6:30 PM, wrote: > > I was trying to build git 2.9.5 as a normal user, as I have no root access > on a cluster with outdated software. > > The build fails, unless I change the PREFIX=/usr/local line in > per/perl.mak:80 to a folder where I have write permission. > Appa

[PATCH] t9104: kosherly remove remote refs

d-off-by: Christian Couder --- This was suggested and discussed in: https://public-inbox.org/git/20180525085906.ga2...@sigill.intra.peff.net/ t/t9104-git-svn-follow-parent.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/t/t9104-git-svn-follow-parent.sh b/t/t9104-gi

Re: [RFC PATCH 2/2] sha1-name: add core.validateAbbrev & relative core.abbrev

On Wed, Jun 6, 2018 at 12:27 PM, Ævar Arnfjörð Bjarmason wrote: > +This setting changes that to `O(1)`, but with the trade-off that > +depending on the value of `core.abbrev` way may be printing s/way may be printing/we may be printing/ > +abbreviated hashes that collide. Too see how likely thi

Re: How to delete files and directories from git commit history?

Hi, On Tue, Jun 12, 2018 at 9:44 PM, Steve Litt wrote: > My project (call it myproject) had a directory (call it docs/propdir) > that was unnecessary for the project, and I've decided I don't want to > offer the files in that directory as free software. So I need to delete > docs/propdir from al

Re: Is NO_ICONV misnamed or is it broken?

Hi, On Fri, Jun 15, 2018 at 12:47 AM, Mahmoud Al-Qudsi wrote: > Hello list, > > With regards to the Makefile define/variable `NO_ICONV` - the Makefile > comments imply that it should be used if "your libc doesn't properly support > iconv," which could mean anything from "a patch will be applied"

Draft of Git Rev News edition 40

Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-40.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

Re: [GSoC][PATCH 1/3] sequencer: add a new function to silence a command, except if it fails.

Hi Alban, On Mon, Jun 18, 2018 at 3:18 PM, Alban Gruin wrote: > This adds a new function, run_command_silent_if_successful(), He re the function is called run_command_silent_if_successful()... > to > redirect the stdout and stderr of a command to a strbuf, and then to run > that command. This s

[ANNOUNCE] Git Rev News edition 40

Hi everyone, The 40th edition of Git Rev News is now published: https://git.github.io/rev_news/2018/06/20/edition-40/ Thanks a lot to all the contributors: Adam Spiers, Bryan Turner and Nicolas Pitre! Enjoy, Christian, Jakub, Markus and Gabriel.

Re: [PATCH v1 2/8] Add initial odb remote support

On Tue, May 15, 2018 at 3:44 AM, Junio C Hamano wrote: > Christian Couder writes: >> --- /dev/null >> +++ b/odb-helper.h >> @@ -0,0 +1,13 @@ >> +#ifndef ODB_HELPER_H >> +#define ODB_HELPER_H > > Here is a good space to write a comment on what this structu

[PATCH v1 02/11] Add initial remote odb support

ple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder --- Makefile | 2 ++ odb-helper.c | 16 odb-helper.h | 19 ++ remote-odb.c | 72 remote-odb.h | 7 + 5 files changed, 116

[PATCH v1 03/11] remote-odb: implement remote_odb_get_direct()

This is implemented only in the promisor remote mode for now by calling fetch_object(). Signed-off-by: Christian Couder --- odb-helper.c | 14 ++ odb-helper.h | 3 ++- remote-odb.c | 17 + remote-odb.h | 1 + 4 files changed, 34 insertions(+), 1 deletion(-) diff

[PATCH v1 07/11] Use odb.origin.partialclonefilter instead of core.partialclonefilter

Let's make the partial clone filter specific to one odb instead of general to all the odbs. This makes it possible to have different partial clone filters for different odbs. Signed-off-by: Christian Couder --- builtin/fetch.c | 2 +- list-objects-filter-options.c

[PATCH v1 08/11] t0410: test fetching from many promisor remotes

Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 6af4712da8..4a7a662512 100755 --- a/t/t0410-partial-clone.sh +++ b/t/t0410-partial

[PATCH v1 09/11] Documentation/config: add odb..promisorRemote

--- Documentation/config.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index ab641bf5a9..8df0c7177e 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2504,6 +2504,11 @@ This setting can be overridden with the

[PATCH v1 04/11] remote-odb: implement remote_odb_get_many_direct()

This function will be used to get many objects from a promisor remote. Signed-off-by: Christian Couder --- odb-helper.c | 15 +++ odb-helper.h | 3 +++ remote-odb.c | 17 + remote-odb.h | 1 + 4 files changed, 36 insertions(+) diff --git a/odb-helper.c b/odb

[PATCH v1 06/11] Use remote_odb_get_direct() and has_remote_odb()

Instead of using the repository_format_partial_clone global and fetch_object() directly, let's use has_remote_odb() and remote_odb_get_direct(). Signed-off-by: Christian Couder --- builtin/cat-file.c| 5 +++-- builtin/fetch.c | 11 ++- builtin

[PATCH v1 05/11] remote-odb: add remote_odb_reinit()

We will need to reinitialize the remote odb configuration as we will make some changes to it in a later commit when we will detect that a remote is also a remote odb. Signed-off-by: Christian Couder --- remote-odb.c | 14 -- remote-odb.h | 1 + 2 files changed, 13 insertions(+), 2

[PATCH v1 01/11] fetch-object: make functions return an error code

The callers of the fetch_object() and fetch_objects() might be interested in knowing if these functions succeeded or not. Signed-off-by: Christian Couder --- fetch-object.c | 15 +-- fetch-object.h | 6 +++--- sha1-file.c| 4 ++-- 3 files changed, 14 insertions(+), 11

[PATCH v1 0/9] Introducing remote ODBs

rg/git/20180103163403.11303-1-chrisc...@tuxfamily.org/ https://public-inbox.org/git/20180319133147.15413-1-chrisc...@tuxfamily.org/ Version 1 and 2 of the "Promisor remotes and external ODB support" series on GitHub: https://github.com/chriscool/git/commits/gl-small-promisor-external-o

Re: [PATCH v1 0/9] Introducing remote ODBs

On Sat, Jun 23, 2018 at 2:18 PM, Christian Couder wrote: > High level overview of this patch series > > > - Patch 1/9: Sorry the patches are numbered X/11 but they should be numbered X/9 as only the first 9 should be in the series and have been sent.

Re: [RFC PATCH v5] Implement --first-parent for git rev-list --bisect

On Mon, Jun 25, 2018 at 7:33 PM, Junio C Hamano wrote: > Tiago Botelho writes: > >> +test_expect_success "--bisect-all --first-parent" ' >> +cat >expect1 <> +$(git rev-parse CC) (dist=2) >> +$(git rev-parse EX) (dist=1) >> +$(git rev-parse D) (dist=1) >> +$(git rev-parse FX) (dist=0) >> +EOF >> +

Re: [RFC PATCH v5] Implement --first-parent for git rev-list --bisect

Hi Dscho, On Tue, Jun 26, 2018 at 4:10 PM, Johannes Schindelin wrote: > > On Tue, 26 Jun 2018, Christian Couder wrote: > >> On Mon, Jun 25, 2018 at 7:33 PM, Junio C Hamano wrote: >> >> > I hate to say this, but the above looks like a typical >> > unmaintai

Re: [PATCH 3/5] rebase: refactor common shell functions into their own file

On Thu, Jun 28, 2018 at 9:46 AM, Pratik Karki wrote: > The motivation behind this is to call the backend functions > *directly* from C, bypassing `git-rebase.sh`. Therefore those functions > need to live in a separate file: we need to be able to call > `.git-rebase--common` in that script snippet

Re: [PATCH 2/5] rebase: start implementing it as a builtin

On Thu, Jun 28, 2018 at 9:46 AM, Pratik Karki wrote: > diff --git a/builtin/rebase.c b/builtin/rebase.c > new file mode 100644 > index 0..1152b7229 > --- /dev/null > +++ b/builtin/rebase.c > @@ -0,0 +1,55 @@ > +/* > + * "git rebase" builtin command > + * > + * Copyright (c) 2018 Pratik Ka

Re: [PATCH 4/5] sequencer: refactor the code to detach HEAD to checkout.c

On Thu, Jun 28, 2018 at 9:46 AM, Pratik Karki wrote: > The motivation behind this commit is to extract the core part of > do_reset() from sequencer.c and move it to a new detach_head_to() > function in checkout.c. If this is independent from your other patches and if this can be used by Alban's w

Re: [PATCH v1 0/9] Introducing remote ODBs

On Mon, Jun 25, 2018 at 11:49 PM, Junio C Hamano wrote: > > Just an early warning, as I haven't even complained on patch titles > of these patches in the series ;-) > > 5702.20 and 5702.21 seems to fail in standalone test, when these are > directly queued on top of Git v2.18.0; I haven't looked in

Re: [PATCH v1 0/9] Introducing remote ODBs

On Tue, Jun 26, 2018 at 2:37 AM, Eric Sunshine wrote: > In addition to the t5702 failures, I'm also seeing failures of > t0410.1, t5616.6 and t5616.7 at the tip of 'pu' as of [1], all of > which seem to be related to these changes. Yeah but only s/core.partialclonefilter/odb.origin.partialclonef

[PATCH v2 0/9] Introducing remote ODBs

80103163403.11303-1-chrisc...@tuxfamily.org/ https://public-inbox.org/git/20180319133147.15413-1-chrisc...@tuxfamily.org/ Version 1 and 2 of the "Promisor remotes and external ODB support" series on GitHub: https://github.com/chriscool/git/commits/gl-small-promisor-external-odb12 htt

[PATCH v2 2/9] Add initial remote odb support

ple linked list to manage them. Helped-by: Jeff King Signed-off-by: Christian Couder --- Makefile | 2 ++ odb-helper.c | 16 + odb-helper.h | 19 +++ remote-odb.c | 93 remote-odb.h | 7 5 files changed, 137

[PATCH v2 1/9] fetch-object: make functions return an error code

The callers of the fetch_object() and fetch_objects() might be interested in knowing if these functions succeeded or not. Signed-off-by: Christian Couder --- fetch-object.c | 15 +-- fetch-object.h | 6 +++--- sha1-file.c| 4 ++-- 3 files changed, 14 insertions(+), 11

[PATCH v2 3/9] remote-odb: implement remote_odb_get_direct()

This is implemented only in the promisor remote mode for now by calling fetch_object(). Signed-off-by: Christian Couder --- odb-helper.c | 14 ++ odb-helper.h | 3 ++- remote-odb.c | 17 + remote-odb.h | 1 + 4 files changed, 34 insertions(+), 1 deletion(-) diff

[PATCH v2 8/9] t0410: test fetching from many promisor remotes

Signed-off-by: Christian Couder --- t/t0410-partial-clone.sh | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh index 71a9b9a3e8..9d513ebf57 100755 --- a/t/t0410-partial-clone.sh +++ b/t/t0410-partial

[PATCH v2 7/9] Use odb.origin.partialclonefilter instead of core.partialclonefilter

Let's make the partial clone filter specific to one odb instead of general to all the odbs. This makes it possible to have different partial clone filters for different odbs. Signed-off-by: Christian Couder --- builtin/fetch.c | 2 +- list-objects-filter-options.c

[PATCH v2 6/9] Use remote_odb_get_direct() and has_remote_odb()

Instead of using the repository_format_partial_clone global and fetch_object() directly, let's use has_remote_odb() and remote_odb_get_direct(). Signed-off-by: Christian Couder --- builtin/cat-file.c| 5 +++-- builtin/fetch.c | 11 ++- builtin

[PATCH v2 5/9] remote-odb: add remote_odb_reinit()

We will need to reinitialize the remote odb configuration as we will make some changes to it in a later commit when we will detect that a remote is also a remote odb. Signed-off-by: Christian Couder --- remote-odb.c | 14 -- remote-odb.h | 1 + 2 files changed, 13 insertions(+), 2

[PATCH v2 9/9] Documentation/config: add odb..promisorRemote

--- Documentation/config.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 1cc18a828c..066858886b 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2505,6 +2505,11 @@ This setting can be overridden with the

[PATCH v2 4/9] remote-odb: implement remote_odb_get_many_direct()

This function will be used to get many objects from a promisor remote. Signed-off-by: Christian Couder --- odb-helper.c | 15 +++ odb-helper.h | 3 +++ remote-odb.c | 17 + remote-odb.h | 1 + 4 files changed, 36 insertions(+) diff --git a/odb-helper.c b/odb

Re: [PATCH v2 0/9] Introducing remote ODBs

On Sat, Jun 30, 2018 at 10:35 AM, Christian Couder wrote: > Changes compared to V1 of this patch series > ~~~ > > - fix tests failures > - error out when more than one "odb..promisorremote" exist > with the same Her

Re: [PATCH v3 4/4] builtin/rebase: support running "git rebase "

On Fri, Jul 6, 2018 at 2:08 PM, Pratik Karki wrote: > + switch (opts->type) { > + case REBASE_AM: > + backend = "git-rebase--am"; > + backend_func = "git_rebase__am"; > + break; > + case REBASE_INTERACTIVE: > + backend = "g

[PATCH] list-objects-filter-options: fix 'keword' typo in comment

From: Christian Couder Signed-off-by: Christian Couder --- list-objects-filter-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c index 50b98109eb..6729a57dee 100644 --- a/list-objects-filter-options.c

[PATCH 1/3] git-compat-util: introduce skip_to_opt_val()

From: Christian Couder We often accept both a "--key" option and a "--key=" option. These options currently are parsed using something like: if (!strcmp(arg, "--key")) { /* do something */ } else if (skip_prefix(arg, "--key=", &arg)) {

[PATCH 3/3] diff: use skip_to_opt_val()

From: Christian Couder Let's simplify diff option parsing using skip_to_opt_val(). Signed-off-by: Christian Couder --- diff.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/diff.c b/diff.c index 2ebe2227b4..067b498187 100644 --- a/diff.c

[PATCH 2/3] index-pack: use skip_to_opt_val()

From: Christian Couder Let's simplify index-pack option parsing using skip_to_opt_val(). Signed-off-by: Christian Couder --- builtin/index-pack.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index 8ec45

Re: [PATCH 1/3] git-compat-util: introduce skip_to_opt_val()

On Sun, Dec 3, 2017 at 7:45 PM, Junio C Hamano wrote: > Christian Couder writes: > >> From: Christian Couder >> >> We often accept both a "--key" option and a "--key=" option. >> >> These options currently are parsed using something

Re: [PATCH 1/3] git-compat-util: introduce skip_to_opt_val()

On Sun, Dec 3, 2017 at 11:48 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Anyway there is a design choice to be made. Adding a "const char >> *default" argument makes the function more generic,... > > I didn't suggest anything of that sort

[PATCH v2 1/4] git-compat-util: introduce skip_to_optional_val()

From: Christian Couder We often accept both a "--key" option and a "--key=" option. These options currently are parsed using something like: if (!strcmp(arg, "--key")) { /* do something */ } else if (skip_prefix(arg, "--key=", &arg)) {

[PATCH v2 3/4] diff: use skip_to_optional_val()

From: Christian Couder Let's simplify diff option parsing using skip_to_optional_val(). Signed-off-by: Christian Couder --- diff.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/diff.c b/diff.c index 2ebe2227b4..83509f0658 100644

[PATCH v2 4/4] diff: use skip_to_optional_val_default()

Let's simplify diff option parsing using skip_to_optional_val_default(). Signed-off-by: Christian Couder --- diff.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/diff.c b/diff.c index 83509f0658..d234b4f0cb 100644 --- a/diff.c +++ b/diff.c @@ -4

[PATCH v2 2/4] index-pack: use skip_to_optional_val()

From: Christian Couder Let's simplify index-pack option parsing using skip_to_optional_val(). Signed-off-by: Christian Couder --- builtin/index-pack.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/builtin/index-pack.c b/builtin/index-pack.c index 8ec45

Re: [PATCH 3/3] diff: use skip_to_opt_val()

On Thu, Dec 7, 2017 at 1:18 AM, Jacob Keller wrote: > On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote: >> >> This causes a regression in the --relative option which prevents it >> from working properly. >> >> If I have a repository with a modified file in a subdirectory, such as: >> >> a/file

Re: git commit file completion recently broke

On Thu, Dec 7, 2017 at 1:56 AM, Jeff King wrote: > I think we'd do better to just assign NULL when there's "=", so we can > tell the difference between "--relative", "--relative=", and > "--relative=foo" (all of which are distinct). > > I think that's possible with the current scheme by doing: >

Re: What's cooking in git.git (Dec 2017, #02; Thu, 7)

On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote: > * cc/skip-to-optional-val (2017-12-07) 7 commits > - t4045: test 'diff --relative' for real > - t4045: reindent to make helpers readable > - diff: use skip-to-optional-val in parsing --relative > - diff: use skip_to_optional_val_default

[PATCH v3 2/7] index-pack: use skip_to_optional_arg()

From: Christian Couder Let's simplify index-pack option parsing using skip_to_optional_arg(). Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- builtin/index-pack.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/builtin/index-pack.c b/bu

[PATCH v3 3/7] diff: use skip_to_optional_arg()

From: Christian Couder Let's simplify diff option parsing using skip_to_optional_arg(). Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- diff.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/diff.c b/diff.c index 2ebe2

[PATCH v3 4/7] diff: use skip_to_optional_arg_default()

From: Christian Couder Let's simplify diff option parsing using skip_to_optional_arg_default(). Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano --- diff.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/diff.c b/diff.c index 464a5

[PATCH v3 5/7] diff: use skip_to_optional_arg_default() in parsing --relative

From: Junio C Hamano Helped-by: Jacob Keller Helped-by: Jeff King Signed-off-by: Junio C Hamano --- diff.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/diff.c b/diff.c index 28e1ab168f..3f14cdace6 100644 --- a/diff.c +++ b/diff.c @@ -4563,11 +4563,10 @@ int diff_

[PATCH v3 6/7] diff: add tests for --relative without optional prefix value

From: Jacob Keller We already have tests for --relative, but they currently only test when a prefix has been provided. This fails to test the case where --relative by itself should use the current directory as the prefix. Teach the check_$type functions to take a directory argument to indicate w

[PATCH v3 1/7] git-compat-util: introduce skip_to_optional_arg()

From: Christian Couder We often accept both a "--key" option and a "--key=" option. These options currently are parsed using something like: if (!strcmp(arg, "--key")) { /* do something */ } else if (skip_prefix(arg, "--key=", &arg)) {

[PATCH v3 7/7] t4045: reindent to make helpers readable

From: Junio C Hamano Signed-off-by: Junio C Hamano --- t/t4045-diff-relative.sh | 104 +-- 1 file changed, 56 insertions(+), 48 deletions(-) diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh index 7d68a6e2a5..4df55884c4 100755 --- a/t/

Re: [PATCH v3 1/7] git-compat-util: introduce skip_to_optional_arg()

On Sun, Dec 10, 2017 at 3:39 PM, Jeff King wrote: > On Sun, Dec 10, 2017 at 09:31:18AM -0500, Jeff King wrote: > >> On Sat, Dec 09, 2017 at 09:40:07PM +0100, Christian Couder wrote: >> >> > The changes compared to v2 are: >> > >> > - s/_val/_arg/ in

Re: [PATCH v6 3/3] rev-list: support --no-filter argument

On Tue, Dec 5, 2017 at 5:50 PM, Jeff Hostetler wrote: > From: Jeff Hostetler > > Teach rev-list to support --no-filter to override a > previous --filter= argument. This is > to be consistent with commands that use OPT_PARSE > macros. > > Signed-off-by: Jeff Hostetler > --- > Documentation/rev-

Re: What's cooking in git.git (Dec 2017, #02; Thu, 7)

On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote: > > * jh/object-filtering (2017-12-05) 9 commits > (merged to 'next' on 2017-12-05 at 3a56b51085) > + rev-list: support --no-filter argument > + list-objects-filter-options: support --no-filter > + list-objects-filter-options: fix 'keword'

[PATCH 0/8] Codespeed perf results

series is available here: https://github.com/chriscool/git/commits/codespeed The cc/perf-run-config patch series was discussed here: v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29j

[PATCH 4/8] perf/run: use $default_value instead of $4

Signed-off-by: Christian Couder --- t/perf/run | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/perf/run b/t/perf/run index 43e4de49ef..bbd703dc4f 100755 --- a/t/perf/run +++ b/t/perf/run @@ -105,7 +105,7 @@ get_var_from_env_or_config () { env_var=&qu

[PATCH 7/8] perf/run: learn to send output to codespeed server

Signed-off-by: Christian Couder --- t/perf/run | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 4454a2713d..7b7011f19b 100755 --- a/t/perf/run +++ b/t/perf/run @@ -148,10 +148,20 @@ run_subsection () { test

[PATCH 8/8] perf/run: read GIT_TEST_REPO_NAME from perf.repoName

Signed-off-by: Christian Couder --- t/perf/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/perf/run b/t/perf/run index 7b7011f19b..279c2d41f6 100755 --- a/t/perf/run +++ b/t/perf/run @@ -137,6 +137,9 @@ run_subsection () { get_var_from_env_or_config "GIT_PERF_MAKE_CO

[PATCH 2/8] perf/aggregate: refactor printing results

Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 96 +++ 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index 769d418708..3609cb5dc3 100755 --- a/t/perf/aggregate.perl +++ b

[PATCH 1/8] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index e401208488..769d418708 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregate.perl @@ -70,7 +70,7 @@ if (not @tests

[PATCH 3/8] perf/aggregate: implement codespeed JSON output

performance evolves over time and releases, let's implement a Codespeed output in "perf/aggregate.perl". Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 68 +-- 1 file changed, 66 insertions(+), 2 deletions(-) diff

[PATCH 6/8] perf/run: learn about perf.codespeedOutput

Signed-off-by: Christian Couder --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 04ea5090f9..4454a2713d 100755 --- a/t/perf/run +++ b/t/perf/run @@ -144,10 +144,15 @@ run_subsection () { set

[PATCH 5/8] perf/run: add conf_opts argument to get_var_from_env_or_config()

Signed-off-by: Christian Couder --- t/perf/run | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/t/perf/run b/t/perf/run index bbd703dc4f..04ea5090f9 100755 --- a/t/perf/run +++ b/t/perf/run @@ -106,6 +106,7 @@ get_var_from_env_or_config () { conf_sec=&qu

Re: [PATCH 0/8] Codespeed perf results

On Wed, Dec 13, 2017 at 5:02 PM, Philip Oakley wrote: >> The end goal would be to have such a server always available to track >> how the different git commands perform over time on different kind of >> repos (small, medium, large, ...) with different optimizations on and >> off (split-index, lib

Re: [PATCH 3/8] perf/aggregate: implement codespeed JSON output

On Wed, Dec 13, 2017 at 7:25 PM, Eric Sunshine wrote: > On Wed, Dec 13, 2017 at 10:13 AM, Christian Couder > wrote: >> Codespeed (https://github.com/tobami/codespeed/) is an open source >> project that can be used to track how some software performs over >> time. It

Re: [PATCH 3/8] perf/aggregate: implement codespeed JSON output

On Wed, Dec 13, 2017 at 9:33 PM, Junio C Hamano wrote: > Christian Couder writes: > >> my $resultsdir = "test-results"; >> +my $results_section = ""; >> if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

On Wed, Dec 13, 2017 at 9:40 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Signed-off-by: Christian Couder >> --- >> t/perf/run | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/t/perf/run b/t/perf/run >>

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

On Wed, Dec 13, 2017 at 9:54 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> If you want to be able to use this helper to specify a default value >> of an empty string (which the orignal that used $4 did), then the >> previous hunk must be corrected so that it does not unconditionally >>

Re: [PATCH v7] fixup: rev-list-options text

On Thu, Dec 14, 2017 at 10:19 PM, Jeff Hostetler wrote: > --- a/Documentation/rev-list-options.txt > +++ b/Documentation/rev-list-options.txt > @@ -714,9 +714,9 @@ ifdef::git-rev-list[] > + > The form '--filter=blob:none' omits all blobs. > + > -The form '--filter=blob:limit=[kmg]' omits blobs

Draft of Git Rev News edition 34

Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-34.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub is

[ANNOUNCE] Git Rev News edition 34

Hi everyone, The 34th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/12/20/edition-34/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Jakub and Markus.

[PATCH v2 2/7] perf/aggregate: refactor printing results

As we want to implement another kind of output than the current output for the perf test results, let's refactor the existing code that outputs the results in its own print_default_results() function. Signed-off-by: Christian Couder --- t/perf/aggregate.perl

[PATCH v2 5/7] perf/run: learn about perf.codespeedOutput

Let's make it possible to set in a config file the output format (regular or codespeed) of the perf tests. Signed-off-by: Christian Couder --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 214d658172..4e62d6bb3f 100755 --

[PATCH v2 3/7] perf/aggregate: implement codespeed JSON output

performance evolves over time and releases, let's implement a Codespeed output in "perf/aggregate.perl". Helped-by: Eric Sunshine Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 67 +-- 1 file changed, 65 insertions(

[PATCH v2 4/7] perf/run: add conf_opts argument to get_var_from_env_or_config()

fault value argument to be unset if it is not passed, and this is simpler if it is the last argument. Signed-off-by: Christian Couder --- t/perf/run | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/t/perf/run b/t/perf/run index 43e4de49ef..214d658172 100755 --- a/t/per

[PATCH v2 6/7] perf/run: learn to send output to codespeed server

available in Codespeed. Signed-off-by: Christian Couder --- t/perf/run | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 4e62d6bb3f..ef56396546 100755 --- a/t/perf/run +++ b/t/perf/run @@ -148,10 +148,20 @@ run_subsection () {

[PATCH v2 7/7] perf/run: read GIT_TEST_REPO_NAME from perf.repoName

The GIT_PERF_REPO_NAME env variable is used in the `aggregate.perl` script to set the 'environment' field in the JSON Codespeed output. Let's make it easy to set this variable by setting it in a config file. Signed-off-by: Christian Couder --- t/perf/run | 3 +++ 1 file change

[PATCH v2 1/7] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index e401208488..769d418708 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregate.perl @@ -70,7 +70,7 @@ if (not @tests

[PATCH v2 0/7] Codespeed perf results

om/ Discussions about the cc/perf-run-config patch series: v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29jx...@mail.gmail.com/ Christian Couder (7): perf/aggregate: fix checking ENV{G

<    2   3   4   5   6   7   8   9   10   11   >