Re: [PATCH] xdiff: trim common tail with -U0 after diff

2017-06-23 Thread Daniel Hahler
On 23.06.2017 22:39, René Scharfe wrote: > The changed test script passes just fine for me even without your change > to xdiff-interface.c, which is odd. Sorry, I've apparently messed this up - it seems to be the case for me, too. I would assume that using the functions.c context/diff in this

[PATCH] xdiff: trim common tail with -U0 after diff

2017-06-23 Thread Daniel Hahler
When -U0 is used, trim_common_tail should be called after `xdl_diff`, so that `--indent-heuristic` (and other diff processing) works as expected. It also removes the check for `!(xecfg->flags & XDL_EMIT_FUNCCONTEXT)` added in e0876bca4, which does not appear to be necessary anymore after moving

Left with empty files after "git stash pop" when system hung

2016-09-13 Thread Daniel Hahler
I have used "git stash --include-untracked", checked out another branch, went back, and "git stash pop"ed the changes. Then my system crashed/hung (music that was playing was repeated in a loop). I have waited for some minutes, and then turned it off. Afterwards, the repository in question was

"git-rebase -i --autostash" will leave dangling stash when editor is aborted

2016-06-15 Thread Daniel Hahler
TEST CASE: 1. Modify a file that need to get stashed on rebasing 2. Run "EDITOR=vim git rebase -i --autostash" 3. Abort with ":cq", which will make Vim exit non-zero Git then will create an autostash, but aborts with "Could not execute editor", via the following code in

Bug: "git rebase --no-autostash" not recognized

2015-09-10 Thread Daniel Hahler
Although the man page mentions the "--no-autostash" option, it is not supported: % git rebase --no-autostash error: unknown option `no-autostash' % git --version git version 2.5.1.dirty Please CC me in case of replies. Regards, Daniel. -- http://daniel.hahler.de/

Please use distinct messages for unable to read errors (with corrupt repo after git stash -k)

2015-02-18 Thread Daniel Hahler
Hi, I've just experienced an issue, where the system hung after git stash -k, and I've had to use Alt-SysRq-REISUB to reboot. Afterwards git diff and git status failed with: fatal: unable to read 7eaa1fb32551b16198924bfb8b9d3674fed2a59a When looking at Git's source I've found several places

Re: git: regression with mergetool and answering n (backport fix / add tests)

2015-01-23 Thread Daniel Hahler
Hi, I am a bit surprised that this bug still exists in maint / v2.2.2. Cherry-picking/merging 0ddedd4 fixes it. Regards, Daniel. On 26.12.2014 02:12, Daniel Hahler wrote: Hi David, sorry for the confusion - the patch / fix I've mentioned was meant to be applied on the commit that caused

Re: git: regression with mergetool and answering n (backport fix / add tests)

2014-12-25 Thread Daniel Hahler
Hi David, sorry for the confusion - the patch / fix I've mentioned was meant to be applied on the commit that caused the regression and not current master. Cheers, Daniel. On 26.12.2014 02:00, David Aguilar wrote: On Tue, Dec 23, 2014 at 08:08:34PM +0100, Daniel Hahler wrote: Hi

git: regression with mergetool and answering n (backport fix / add tests)

2014-12-23 Thread Daniel Hahler
Hi, this is in reply to the commits from David: commit 0ddedd4d6b9b3e8eb3557d8ed28e1a0b354a25f8 Refs: v2.2.0-60-g0ddedd4 Merge: e886efd 1e86d5b Author: Junio C Hamano gits...@pobox.com AuthorDate: Fri Dec 12 14:31:39 2014 -0800 Commit: Junio C Hamano

diff: use built-in patterns by default via git attributes

2014-12-09 Thread Daniel Hahler
Hi, I'm wondering why the built-in patterns (defined in userdiff.c) are not being applied by default, e.g. what you would normally do in core.attributesfile via: *.py diff=python Wouldn't it make sense to provide certain defaults for attributes, where Git provides enhanced patterns?

diff-index does not consider a removed submodule to be staged with --ignore-submodules

2014-09-20 Thread Daniel Hahler
After staging the removal of a submodule, diff-index does not consider this when --ignore-submodules is being used: # In a repository with submodule sm: % git rm --cached sm % git diff-index --cached --quiet --ignore-submodules HEAD % echo $? 0 % git status On branch

Output from rev-parse --resolve-git-dir changed: two lines (prints original argument)

2014-02-17 Thread Daniel Hahler
I have noticed that the output from git rev-parse --resolve-git-dir changed. While it used to only print the resolved git dir, it now prints the argument passed to it itself: % git rev-parse --resolve-git-dir .git /path/to/root/.git/modules/vim/bundle/reporoot .git This is with Git

Re: Bug: relative core.worktree is resolved from symlink and not its target

2014-02-17 Thread Daniel Hahler
On 09.02.2014 10:08, Duy Nguyen wrote: On Tue, Feb 04, 2014 at 11:20:39AM +0100, Daniel Hahler wrote: Thanks for looking into this. when using a submodule sm, there is a relative worktree in its config: .git/modules/sm/config: [core] worktree = ../../../smworktree git-new

Bug: relative core.worktree is resolved from symlink and not its target

2014-02-04 Thread Daniel Hahler
Hi, when using a submodule sm, there is a relative worktree in its config: .git/modules/sm/config: [core] worktree = ../../../smworktree git-new-worktree (from contrib) symlinks this config the new worktree. From inside the new worktree, git reads the config, but resolves the