Re: Git 2.18: RUNTIME_PREFIX... is it working?

Perry Hutchison wrote: > If we need /proc, wouldn't we _already_ be unhappy inside a chroot > that didn't mount /proc, even _with_ fallback to static paths? > Last I knew, the whole point of chroots/containers/jails/etc. was to > prevent access, from a process running inside the container, to any

Re: Git 2.18: RUNTIME_PREFIX... is it working?

Apologies for the delayed response - I've been out of town - and It looks like Paul is already on the right track. Johannes: I believe the GIT_EXEC_PATH snipped that you listed is not incorrect. It's defined to "gitexecdir_SQ", and RUNTIME_PREFIX expects (and enforces, as you snipped) that this

Re: [PATCH 2/2 v2] Makefile: quote $INSTLIBDIR when passing it to sed

Good catch, thanks for doing this! -Dan On Mon, Apr 23, 2018 at 10:18 PM Jonathan Nieder wrote: > f6a0ad4b (Makefile: generate Perl header from template file, > 2018-04-10) moved some code for generating the 'use lib' lines at the > top of perl scripts from the

Re: [PATCH 0/2] Add Windows support to the new RUNTIME_PREFIX design

On Tue, Mar 27, 2018 at 11:54 AM Johannes Schindelin < johannes.schinde...@gmx.de> wrote: > Yes, I performed manual testing. Alright! Just manually tested your "git" scenario myself on the Linux build and all seems to be in order. > I guess we should add a test where we copy the `git`

Re: [PATCH 0/2] Add Windows support to the new RUNTIME_PREFIX design

On Mon, Mar 26, 2018 at 5:31 PM Johannes Schindelin < johannes.schinde...@gmx.de> wrote: > Even if the RUNTIME_PREFIX feature originates from Git for Windows, the > current patch series is different enough in its design that it leaves the > Windows-specific RUNTIME_PREFIX handling in place: On

Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git

On Mon, Mar 26, 2018 at 10:08 AM Ævar Arnfjörð Bjarmason wrote: > > Oh sorry, I must have missed that. I have a personal preference for adding > > brackets for clarity; it leaked into this patch set. I did implement most > > of the suggestion, which was to use the escaped Q/E

Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git

On Sun, Mar 25, 2018 at 5:15 PM Ævar Arnfjörð Bjarmason wrote: > This looks good to me this time around, couple of small nits (maybe > Junio can amend while queuing): > * You add a dependnecy typo in 2/3 but fix it again in 3/3. Should be > squashed. d'oh, I'll fix that

Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git

On Mon, Mar 26, 2018 at 2:01 AM Junio C Hamano wrote: > When testing the non-relocatable (i.e. traditional) Git, we use > GIT_EXEC_PATH and bin-wrappers/ trick to ensure that we test the > version we just have built, not a random version that happen to be > on the $PATH,

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

On Mon, Mar 19, 2018 at 5:32 PM Martin Ågren wrote: > This commit message mentions RUNTIME_PREFIX_PERL twice, but there is no > use of RUNTIME_PREFIX_PERL in the actual diffs (patches 1-3/3). Should > it be s/_PERL//? Your cover letter hints as much under "Changes in v6 >

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

On Mon, Mar 19, 2018 at 3:21 PM Ævar Arnfjörð Bjarmason wrote: > I think it would be more idiomatic and more paranoid (we'll catch bugs) > to do: > my $exec_path; > if (exists $ENV{GIT_EXEC_PATH}) { > $exec_path = $ENV{GIT_EXEC_PATH}; > } else { >

Re: [PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

On Mon, Mar 19, 2018 at 3:27 PM Ævar Arnfjörð Bjarmason wrote: > I wonder if it wouldn't be a lot more understandable if these were noted > together, i.e. let's first document RUNTIME_PREFIX, then for all the > other ones say below that: Sounds good to me, done. > Whitespace

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

> > The merge conflict becomes a tad easier to deal with, also makes sense > > to have gitexecdir after infodir since that's the order we're listing > > these in just a few lines earlier, and this is otherwise (mostly) > > consistent. Actually as a quick follow-up question: for these patch sets,

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

On Mon, Mar 19, 2018 at 3:12 PM Ævar Arnfjörð Bjarmason wrote: > The merge conflict becomes a tad easier to deal with, also makes sense > to have gitexecdir after infodir since that's the order we're listing > these in just a few lines earlier, and this is otherwise (mostly) >

Re: [PATCH v6 3/3] exec_cmd: RUNTIME_PREFIX on some POSIX systems

On Mon, Mar 19, 2018 at 1:24 PM Junio C Hamano wrote: > Look for these misspelled words: Oh boy ... thanks, and done. > OK. An essentially no-op change but with the name better suited in > the extended context---we used to only care about argv0 but that was > an

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

On Mon, Mar 19, 2018 at 1:14 PM Junio C Hamano wrote: > > +# RUNTIME_PREFIX's resolution logic requires resource paths to be expressed > > +# relative to each other and share an installation path. > > +# > > +# This is a dependnecy in: > dependency? Oops, this is the second

Re: What's cooking in git.git (Mar 2018, #02; Tue, 6)

> It would be great to have this rebooted now that my perl cleanup efforts > have un-blocked this. Will be happy to help review & test the next > iteration. Yes, I was just thinking the same thing. I wanted to make sure the Perl changes had landed, and I'm pleased to see that they have. I should

Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

On Wed, Dec 6, 2017 at 1:47 PM, Junio C Hamano wrote: > > Johannes Sixt writes: > > > The updated series works for me now. Nevertheless, I suggest to squash > > in the following change to protect against IFS and globbing characters in > > $INSTLIBDIR. > > Yeah,