LGTM, thanks for the v2.
Overall this series looks good. Thanks for putting the patches together!
On 2018-07-06 2:23 AM, brian m. carlson wrote:
> diff --git a/git-send-email.perl b/git-send-email.perl
> index a76953c310..4ea30c4070 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1899,6 +1899,10 @@ sub validate_patch {
> return $hook_error if $hook_error;
>
I seem to be mistaken about the degree to which this is standardized and
supported. The Debian argument cinches it for me. Quoted printable is
probably the right way to go, then.
On 2018-07-01 6:15 PM, brian m. carlson wrote:
> Can you say a bit more about the exact error message you're seeing?
"patch contains a line longer than 998 characters"
A recent occasion when this came up was when someone attempted to send
me a patch which included a base64-encoded data URI,
long time which doesn't support
extended SMTP. The default behavior should probably change. If not, the
error message should be more clear about action items to address the
issue.
I'll send a patch around to change this shortly.
--
Drew DeVault
When shown the email summary, an opportunity is presented for the user
to edit the email as if they had specified --annotate. This also permits
them to edit it multiple times.
Signed-off-by: Drew DeVault <s...@cmpwn.com>
Reviewed-by: Simon Ser <cont...@emersion.fr>
---
Thanks for the
When shown the email summary, an opportunity is presented for the user
to edit the email as if they had specified --annotate. This also permits
them to edit it multiple times.
Signed-off-by: Drew DeVault <s...@cmpwn.com>
Reviewed-by: Simon Ser <cont...@emersion.fr>
---
Sent to th
When shown the email summary, an opportunity is presented for the user
to edit the email as if they had specified --annotate. This also permits
them to edit it multiple times.
Signed-off-by: Drew DeVault <s...@cmpwn.com>
Reviewed-by: Simon Ser <cont...@emersion.fr>
---
git-send-ema
9 matches
Mail list logo
