[PATCH v2] worktree: add --quiet option

Add the '--quiet' option to git worktree, as for the other git commands. 'add' is the only command affected by it since all other commands, except 'list', are currently silent by default. Helped-by: Martin Ågren Helped-by: Duy Nguyen Helped-by: Eric Sunshine Signed-off-by: Elia Pinto

Re: [PATCH] worktree: add --quiet option

2018-08-07 16:37 GMT+02:00 Martin Ågren : > Hi Elia > > On 7 August 2018 at 15:21, Elia Pinto wrote: >> Add the '--quiet' option to git worktree add, >> as for the other git commands. >> >> Signed-off-by: Elia Pinto >> --- >> Documentation/git-

[PATCH] worktree: add --quiet option

Add the '--quiet' option to git worktree add, as for the other git commands. Signed-off-by: Elia Pinto --- Documentation/git-worktree.txt | 4 +++- builtin/worktree.c | 11 +-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/git-worktree.txt b

[PATCH] Fixes compile warning with -Wimplicit-fallthrough CFLAGS

, comments and can acts as a comment itself. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- apply.c | 6 +++--- builtin/blame.c | 2 +- builtin/cat-file.c | 2 +- builtin/checkout.c | 2 +- builtin/fast-export.c | 4 ++-- b

[PATCHv4] builtin/commit.c: switch to strbuf, instead of snprintf()

of this change, we also reduce the snprintf() calls, that may silently truncate results if the programmer is not careful. Helped-by: René Scharfe <l@web.de> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gi

Re: [PATCHv3 2/2] builtin/commit.c: switch to xstrfmt(), instead of snprintf,

2017-01-15 3:42 GMT+01:00 Junio C Hamano <gits...@pobox.com>: > Elia Pinto <gitter.spi...@gmail.com> writes: > >> Ok. I agree. But is it strictly necessary to resend for this ? > > FWIW, the attacched is what I queued locally, after complaining > &quo

Re: [PATCHv3 2/2] builtin/commit.c: switch to xstrfmt(), instead of snprintf,

Ok. I agree. But is it strictly necessary to resend for this ? Thanks 2017-01-13 19:33 GMT+01:00 Brandon Williams <bmw...@google.com>: > On 01/13, Elia Pinto wrote: >> In this patch, instead of using xnprintf instead of snprintf, which asserts >> that we don't trunc

[PATCHv3 2/2] builtin/commit.c: switch to xstrfmt(), instead of snprintf,

to count bytes needed for static allocation. As a side effect of this patch we have also reduced the snprintf() calls, that may silently truncate results if the programmer is not careful. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by

[PATCHv3 1/2] builtin/commit.c: removes the PATH_MAX limitation via dynamic allocation

if the programmer is not careful. Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- This is the third version of the patch. Changes from the first version: I have split the original commit in two,

[PATCHv2 1/2] builtin/commit.c: drop use snprintf via dynamic allocation

In general snprintf is bad because it may silently truncate results if we're wrong. In this patch where we use PATH_MAX, we'd want to handle larger paths anyway, so we switch to dynamic allocation. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@

[PATCHv2 2/2] builtin/commit.c: drop use snprintf via dynamic allocation

net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- This is the second version of the patch. I have split the original commit in two, as discussed here http://public-inbox.org/git/20161213132717.42965-1-gitter.spi...@gmail.com/. builtin/commit.c | 10 -- 1 file changed,

[PATCH] builtin/commit.c: convert trivial snprintf calls to xsnprintf

. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/commit.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 0ed634b26..37228330c 100644 --- a/builtin/commit.c +++ b/builtin/co

[PATCH] git-check-ref-format.txt: fixup documentation

die is not a standard shell function. Use a different shell code for the example. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- Documentation/git-check-ref-format.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-check-ref-format.

[PATCHv1 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var

Use the new GIT_TRACE_CURL environment variable instead of the deprecated GIT_CURL_VERBOSE. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- Drop leftover debugging junk from previous patch t/t5550-http-fetch-dumb.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var

2016-09-05 15:43 GMT+02:00 Eric Sunshine <sunsh...@sunshineco.com>: > On Mon, Sep 5, 2016 at 6:24 AM, Elia Pinto <gitter.spi...@gmail.com> wrote: >> Use the new GIT_TRACE_CURL environment variable instead >> of the deprecated GIT_CURL_VERBOSE. >> >>

[PATCH 4/4] t5551-http-fetch-smart.sh: use the GIT_TRACE_CURL environment var

Use the new GIT_TRACE_CURL environment variable instead of the deprecated GIT_CURL_VERBOSE. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5551-http-fetch-smart.sh | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/t/t5551-http-fetch-smart.

[PATCH 2/4] test-lib.sh: preserve GIT_TRACE_CURL from the environment

Turning on this variable can be useful when debugging http tests. It can break a few tests in t5541 if not set to an absolute path but it is not a variable that the user is likely to have enabled accidentally. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/test-lib.sh | 1 +

[PATCH 1/4] t5541-http-push-smart.sh: use the GIT_TRACE_CURL environment var

Use the new GIT_TRACE_CURL environment variable instead of the deprecated GIT_CURL_VERBOSE. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5541-http-push-smart.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5541-http-push-smart.sh b/t/t5541-htt

[PATCH 0/4] test suite: use the GIT_TRACE_CURL environment var

Use the new GIT_TRACE_CURL environment variable in the test suite instead of the deprecated GIT_CURL_VERBOSE. Elia Pinto (4): t5541-http-push-smart.sh: use the GIT_TRACE_CURL environment var test-lib.sh: preserve GIT_TRACE_CURL from the environment t5550-http-fetch-dumb.sh: use

[PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var

Use the new GIT_TRACE_CURL environment variable instead of the deprecated GIT_CURL_VERBOSE. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5550-http-fetch-dumb.sh | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/t/t5550-http-fetch-dumb.sh b/t

Re: What's cooking in git.git (Jun 2016, #04; Tue, 14)

2016-06-15 0:08 GMT+02:00 Junio C Hamano : > Here are the topics that have been cooking. Commits prefixed with > '-' are only in 'pu' (proposed updates) while commits prefixed with > '+' are in 'next'. The ones marked with '.' do not appear in any of > the integration

[PATCH 07/10] fast-import.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- fast-import

[PATCH 02/10] builtin/index-pack.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/index-

[PATCH 06/10] diff.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- diff.c | 6 +++

[PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/commit

[PATCH 03/10] builtin/tag.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/tag

[PATCH 10/10] wrapper.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- wrapper

[PATCH 04/10] combine-diff.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- combine-diff

[PATCH 05/10] compat/inet_ntop.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- compat/inet_

[PATCH 09/10] transport-helper.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- transport-he

[PATCH 08/10] refs.c: convert trivial snprintf calls to xsnprintf

or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly. The other few remaining cases in which a call to snprintf can generate a soft error have not been changed. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- refs.c | 2 +-

[PATCH v7 1/2] http.c: implement the GIT_TRACE_CURL environment variable

GIT_TRACE_CURL environment variable. Helped-by: Torsten Bögershausen <tbo...@web.de> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net

[PATCH v7 2/2] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable

ic Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 1 + 1 file changed, 1 insertion(+) diff --git a/imap-send.c b/imap-send.c index 938c691..50377c5 100644 --- a/imap-send.c +++ b/imap-send

[PATCH v7 0/2] Implement the GIT_TRACE_CURL environment variable

tead of the hex equivalent - dropped the previous GIT_DEBUG_CURL env var - curl_dump and curl_trace factored out to a shared implementation in http.c Elia Pinto (2): http.c: implement the GIT_TRACE_CURL environment variable imap-send.c: introduce the GIT_TRACE_CURL enviroment variable Docu

[PATCH v6 0/2] Implement the GIT_TRACE_CURL environment variable

curl_trace factored out to a shared implementation in http.c Elia Pinto (2): http.c: implement the GIT_TRACE_CURL environment variable imap-send.c: introduce the GIT_TRACE_CURL enviroment variable Documentation/git.txt | 8 http.c| 123 ++

[PATCH v6 2/2] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable

ic Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 1 + 1 file changed, 1 insertion(+) diff --git a/imap-send.c b/imap-send.c index 938c691..50377c5 100644 --- a/imap-send.c +++ b/imap-send

[PATCH v6 1/2] http.c: implement the GIT_TRACE_CURL environment variable

GIT_TRACE_CURL environment variable. Helped-by: Torsten Bögershausen <tbo...@web.de> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net

[PATCHv5 1/2] http.c: implement the GIT_TRACE_CURL environment variable

GIT_TRACE_CURL environment variable. Helped-by: Torsten Bögershausen <tbo...@web.de> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net

[PATCHv5 0/2] Implement the GIT_TRACE_CURL environment variable

rary variable "i" in "w" in the helper routine - used the c escape sequences instead of the hex equivalent - dropped the previous GIT_DEBUG_CURL env var - curl_dump and curl_trace factored out to a shared implementation in http.c Elia Pinto (2): http.c: implement the GIT_TRACE_CUR

[PATCHv5 2/2] imap-send.c: introduce the GIT_TRACE_CURL environment variable

ic Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 1 + 1 file changed, 1 insertion(+) diff --git a/imap-send.c b/imap-send.c index 938c691..50377c5 100644 --- a/imap-send.c +++ b/imap

[PATCHv4 2/2] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable

ic Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/imap-send.c b/imap-send.c index 938c691..61c6787 100644 --- a/imap-send.c +

[PATCHv4 1/2] http.c: implement the GIT_TRACE_CURL environment variable

GIT_TRACE_CURL environment variable. Helped-by: Torsten Bögershausen <tbo...@web.de> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net

[PATCHv4 0/2] Implement the GIT_TRACE_CURL environment variable

env var - curl_dump and curl_trace factored out to a shared implementation in http.c Elia Pinto (2): http.c: implement the GIT_TRACE_CURL environment variable imap-send.c: introduce the GIT_TRACE_CURL enviroment variable Documentation/git.txt | 8 http.c

[PATCHv3 3/3] http.c: implements the GIT_TRACE_CURL environment variable

-by: Torsten Bögershausen <tbo...@web.de> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.sp

[PATCHv3 1/3] git.txt: document the new GIT_TRACE_CURL environment variable

Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- Documentation/git.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/git.txt b/Documentation/git.txt index 8afe349..958db0f 100644 --- a/Documentation/git.txt +++ b/Docum

[PATCHv3 0/3] Implements the GIT_TRACE_CURL environment variable

"i" in "w" in the helper routine - used the c escape sequences instead of the hex equivalent - dropped the previous GIT_DEBUG_CURL env var - curl_dump and curl_trace factored out to a shared implementation in http.c Elia Pinto (3): git.txt: document the new GIT_TRACE_CURL

[PATCHv3 2/3] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable

ic Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/imap-send.c b/imap-send.c index 938c691..61c6787 100644 --- a/imap-send.c +

[PATCH 3/4] git.txt: document the new GIT_TRACE_CURL environment variable

Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- Documentation/git.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/git.txt b/Documentation/git.txt index 8afe349..958db0f 100644 --- a/Documentation/git.txt +++ b/Docum

[PATCH 1/4] http.h: Add debug callback and helper routine for implementing the GIT_TRACE_CURL environment variable in http.c

nio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- http.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/http.h b/http.h index 4ef4bbd..a2d1

[PATCH 4/4] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable

ic Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/imap-send.c b/imap-send.c index 938c691..b371a78 100644 --- a/imap-send.c +

[PATCHv2 0/4] Implements the GIT_TRACE_CURL environment variable

routine - used the c escape sequences instead of the hex equivalent - dropped the previous GIT_DEBUG_CURL env var - curl_dump and curl_trace factored out to a shared implementation in http.c Elia Pinto (4): http.h: Add debug callback and helper routine for implementing the GIT_TR

[PATCH 2/4] http.c: implements the GIT_TRACE_CURL environment variable

-by: Torsten Bögershausen <tbo...@web.de> Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Jeff King <p...@peff.net> Signed-off-by: Elia Pinto <gitter.s

Re: [ANNOUNCE] Git v2.8.1 (and call-for-help to "make rpmbuild" users)

2016-04-03 21:21 GMT+02:00 Junio C Hamano : > If you do not build RPM binary packages from our pristine source, > you can safely ignore this release and stop reading this message. > > Now that the audience of this message has been limited to a narrow > target, before I make an

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 22:25 GMT+02:00 Eric Sunshine <sunsh...@sunshineco.com>: > On Fri, Apr 1, 2016 at 6:44 AM, Elia Pinto <gitter.spi...@gmail.com> wrote: >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE,

[PATCH] api-trace.txt: fix typo

The correct api is trace_printf_key Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- Documentation/technical/api-trace.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/api-trace.txt b/Documentation/technical/api-trace.txt index 3

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 17:35 GMT+02:00 Junio C Hamano <gits...@pobox.com>: > Elia Pinto <gitter.spi...@gmail.com> writes: > >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >> trans

Re: [PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 16:56 GMT+02:00 Ramsay Jones <ram...@ramsayjones.plus.com>: > > > On 01/04/16 11:44, Elia Pinto wrote: >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >>

Re: [PATCH 2/2] http.c: implements the GIT_CURL_DEBUG environment variable

2016-04-01 17:03 GMT+02:00 Ramsay Jones <ram...@ramsayjones.plus.com>: > > > On 01/04/16 11:44, Elia Pinto wrote: >> Implements the GIT_CURL_DEBUG environment variable to allow a greater >> degree of detail of GIT_CURL_VERBOSE, in particular the complete >>

[PATCH 1/2] imap-send.c: implements the GIT_CURL_DEBUG environment variable

-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 99 +++-- 1 file changed, 97 insertions(+), 2 deletions(-) diff --git a/imap-send.c b/imap-send.c index 4d3b773..cf79e7f 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1395,6 +1

[PATCH 2/2] http.c: implements the GIT_CURL_DEBUG environment variable

-by: Elia Pinto <gitter.spi...@gmail.com> --- http.c | 97 +- 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/http.c b/http.c index dfc53c1..079779d 100644 --- a/http.c +++ b/http.c @@ -437,6 +437,97 @@ stati

Re: [PATCH] http: honor no_http env variable to bypass proxy

2016-03-07 21:33 GMT+01:00 Junio C Hamano : > Junio C Hamano writes: > > Second call for help. I hate having to revert 30f302f7 (Merge > branch 'kf/http-proxy-auth-methods', 2016-02-03) this late in the > cycle. Ok. I made the original merge commit for

Re: [PATCH] http: honor no_http env variable to bypass proxy

xy_auth.host); > > This caused "no_proxy" environment variable not working any more. > > Set extra curl option "CURLOPT_NOPROXY" will fix this issue. > > Signed-off-by: Jiang Xin <xin.ji...@huawei.com> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com&

[PATCH 13/22] http-backend.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- http-backend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/http-backend.c b/http-backend.c

[PATCH 18/22] strbuf.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- strbuf.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/strbuf.h b/strbuf.h index f

[PATCH 14/22] imap-send.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- imap-send.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/imap-send.c b/imap-send.c index 4

[PATCH 16/22] pkt-line.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- pkt-line.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkt-line.h b/pkt-line.h index 3cb9d91..d

[PATCH 08/22] cache.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- cache.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/cache.h b/cache.h

[PATCH 12/22] fsck.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- fsck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsck.c b/fsck.c index c637f66..953b8e4

[PATCH 22/22] wt-status.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- wt-status.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wt-status.h b/wt-status.h index c

[PATCH 10/22] config.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.c b/config.c index 86a5eb2..671bfd3

[PATCH 06/22] builtin/update-index.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/update-index.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/update-index.c b/builtin/

[PATCH 09/22] color.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- color.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/color.h b/color.h index e155d13..8f763d7

[PATCH 15/22] merge-recursive.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- merge-recursive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/merge-recursive.c b/merge-recursive.c

[PATCH 17/22] remote.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/remote.c b/remote.c index 35940a5..579cfcb

[PATCH 03/22] argv-array.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- argv-array.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/argv-array.h b/argv-array.h index a2fa0aa..e

[PATCH 11/22] daemon.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon.c b/daemon.c index 46b411c..b4a9207

[PATCH 20/22] transport-helper.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- transport-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/transport-helper.c b/transport-he

[PATCH 00/22] add the FORMATPRINTF macro to declare the gcc function

Add the FORMATPRINTF macro for declaring the gcc function attribute 'format printf' for code style consistency with similar macro that git already use for other gcc attributes. And use it where necessary. Elia Pinto (22): git-compat-util.h: add the FORMATPRINTF macro advice.h: use

[PATCH 02/22] advice.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- advice.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/advice.h b/advice.h index b341a55..eef82e1

[PATCH 05/22] builtin/receive-pack.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/receive-pack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/receive-pack.c b/b

[PATCH 01/22] git-compat-util.h: add the FORMATPRINTF macro

Add the FORMATPRINTF macro for declaring the gcc function attribute 'format printf' for code style consistency with similar macro that git already use for other gcc attributes. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- git-compat-util.h | 14 -- 1 file chan

[PATCH 04/22] builtin/index-pack.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/index-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/index-pack.c b/builtin

[PATCH 07/22] builtin/upload-archive.c: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- builtin/upload-archive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/upload-archive.c b/b

[PATCH 19/22] trace.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- trace.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/trace.h b/trace.h index 1

[PATCH 21/22] utf8.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'

Use the new FORMATPRINTF macro (in git-compat-util.h) to declare the gcc function attribute 'format printf' Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- utf8.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utf8.h b/utf8.h index 7930b44..3dc301c 100644 ---

Re: [PATCH 8/8] one ugly test to verify basic functionality

2016-02-05 9:57 GMT+01:00 Nguyễn Thái Ngọc Duy : > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > t/t5544-fetch-resume.sh (new +x) | 42 > > 1 file changed, 42 insertions(+) > create mode 100755 t/t5544-fetch-resume.sh

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

2016-02-04 20:33 GMT+01:00 Junio C Hamano : > As pointed out already, quoting of "$this" inside the arithmetic > expansion would not work very well, so [14/15] needs fixing. > > I do not see 01/15 thru 13/15 here, by the way. Is it just me? Excuse me, everyone. Yesterday was a

Re: [PATCH 8/8] one ugly test to verify basic functionality

2016-02-05 14:20 GMT+01:00 Johannes Schindelin <johannes.schinde...@gmx.de>: > Hi Elia, > > On Fri, 5 Feb 2016, Elia Pinto wrote: > >> From the git coding guideline : "We prefer $( ... ) for command >> substitution; unlike ``, it properly nests. It should

Re: [PATCH 8/8] one ugly test to verify basic functionality

2016-02-05 14:02 GMT+01:00 Duy Nguyen <pclo...@gmail.com>: > On Fri, Feb 5, 2016 at 6:57 PM, Elia Pinto <gitter.spi...@gmail.com> wrote: >>> + mv `ls .git/objects/pack/*.pack` pack && >> >> No, please. From the git coding guideline : "We pr

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

2016-02-04 12:14 GMT+01:00 Johannes Schindelin <johannes.schinde...@gmx.de>: > Hi Elia, > > On Thu, 4 Feb 2016, Elia Pinto wrote: > >> - this=$(expr "$this" + 1) >> + this=$(( "$this" + 1 )) &g

[PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

than their equivalents in expr. Newly written scripts should avoid expr in favor of the new features within the shell." Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- git-am.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/git-am.sh b/git-am.

[PATCH 15/15] t4032-diff-inter-hunk-context.sh: replace using expr for arithmetic operations with the equivalent shell builtin

asier to use than their equivalents in expr. Newly written scripts should avoid expr in favor of the new features within the shell." Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t4032-diff-inter-hunk-context.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCHv2 1/2] http: allow selection of proxy authentication method

.@science-computing.de> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> Helped-by: Junio C Hamano <gits...@pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Elia Pinto <gitter.spi...@gmail.com> Signed-off-by: Junio C Hamano <gits...@po

[PATCHv2 2/2] http: use credential API to handle proxy authentication

pobox.com> Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Helped-by: Elia Pinto <gitter.spi...@gmail.com> Signed-off-by: Knut Franke <k.fra...@science-computing.de> Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> Signed-off-by: Junio C Hamano <gits...@pobox.com> -

[PATCH 09/10] t/t5700-clone-reference.sh: use the $( ... ) construct for command substitution

of-read. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5700-clone-reference.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh index dfa1bf7..4320082 100755 --- a/t/t5700-clone-reference.sh +++ b/

[PATCH 04/10] t/t5537-fetch-shallow.sh: use the $( ... ) construct for command substitution

of-read. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5537-fetch-shallow.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh index a980574..df8d2f0 100755 --- a/t/t5537-fetch-shallow.sh +++ b/t/t5537

[PATCH 03/10] t/t5532-fetch-proxy.sh: use the $( ... ) construct for command substitution

of-read. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5532-fetch-proxy.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5532-fetch-proxy.sh b/t/t5532-fetch-proxy.sh index 5531bd1..d75ef0e 100755 --- a/t/t5532-fetch-proxy.sh +++ b/t/t5532-fet

[PATCH 08/10] t/t5601-clone.sh: use the $( ... ) construct for command substitution

of-read. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5601-clone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index 9b34f3c..61dc4ce 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -221,7 +221,7 @@ test_expe

[PATCH 07/10] t/t5570-git-daemon.sh: use the $( ... ) construct for command substitution

of-read. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5570-git-daemon.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh index b7e2832..d76269a 100755 --- a/t/t5570-git-daemon.sh +++ b/t/t5570-gi

[PATCH 10/10] t/t5710-info-alternate.sh: use the $( ... ) construct for command substitution

of-read. Signed-off-by: Elia Pinto <gitter.spi...@gmail.com> --- t/t5710-info-alternate.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh index 5a6e49d..9cd2626 100755 --- a/t/t5710-info-alternate.sh +++ b/t/t5710-

  1   2   3   4   5   6   >