On Tue, Mar 4, 2014 at 9:59 PM, Sun He sunheeh...@gmail.com wrote:
Signed-off-by: Sun He sunheeh...@gmail.com
---
Check the limit.h of linux and find out that the MACRO
#define PATH_MAX4096/* # chars in a path name including nul */
So if the magic number 40 is just the size it
I'm the guilty one. I like the change (obviously, since I suggested
it). Writing strbufs comes up frequently and will hopefully increase in
usage and I think it is a positive thing to encourage the use of strbufs
by making them increasingly first-class citizens.
But I can see your points
On Tue, Mar 4, 2014 at 12:01 AM, Junio C Hamano gits...@pobox.com wrote:
Eric Sunshine sunsh...@sunshineco.com writes:
On Sat, Mar 1, 2014 at 7:51 AM, He Sun sunheeh...@gmail.com wrote:
2014-03-01 19:21 GMT+08:00 Faiz Kothari faiz.of...@gmail.com:
diff --git a/remote-curl.c b/remote-curl.c
On Sat, Mar 1, 2014 at 4:33 PM, He Sun sunheeh...@gmail.com wrote:
2014-03-01 15:18 GMT+08:00 Faiz Kothari faiz.of...@gmail.com:
Hi,
Yup, at that position.
I don't know, but it failed a few tests on my machine related to bitmap.
Another thing to use would be strbuf_splice()
Eric
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
Implemented write_or_die.c:strbuf_write_or_die() and used in relevant places
to substitute write_or_die(). I spotted other places where strbuf can be used
in place of buf[MAX_PATH] but that would require a change in prototype of a
lot
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
- write_or_die(1, rpc.result.buf, rpc.result.len);
+ strbuf_write_or_die(1, (rpc.result.buf));
May be this should be
strbuf_write_or_die(1, (rpc.result));
Yes, I changed that :-) Thanks again.
Maybe we just
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
Thanks for the feedback.
Implemented write_or_dir.c:strbuf_write_or_die() again.
Checks if NULL is passed to prevent segmentation fault, I was not sure
what error message to print so for now its write error.
Changed the prototype as suggested
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
Introduced a new function strbuf.c:strbuf_write_or_die()
to the strbuf family of functions. Now use this API instead
of write_or_die.c:write_or_die()
---
Hi,
Thanks for the suggestions and feedbacks.
As Johannes Sixt pointed out, the function
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
Used strbuf.c:strbuf_write_or_die() instead of
write_or_die.c:write_or_die() at relevant places.
---
builtin/cat-file.c |2 +-
builtin/notes.c|6 +++---
builtin/receive-pack.c |2 +-
builtin/send-pack.c|2
, 2014 at 2:58 AM, Faiz Kothari faiz.of...@gmail.com wrote:
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
Notes:
I finally got what's happening, and why the errors were caused.
packname is supposed to contain the complete path to the .pack file.
Packs are stored as /path/to/SHA1
From: Faiz Kotahri faiz.of...@gmail.com
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
Sticking with implementation involving changing the prototype for
pack-write.c:finish_tmp_packfile()
Fixing a small bug in Sun He's implementation which caused a fail in some tests.
builtin/pack
changed it to return a (const char *) accordingly.
On Thu, Feb 27, 2014 at 5:02 PM, Michael Haggerty mhag...@alum.mit.edu wrote:
On 02/26/2014 05:46 PM, Faiz Kothari wrote:
I am Faiz Kothari, I am a GSoC aspirant and want to contribute to git.
I am submitting the patch in reponse to Microproject 1
From: Faiz Kothari faiz.of...@gmail.com
Signed-off-by: Faiz Kothari django@dj-pc.(none)
---
git-compat-util.h |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index cbd86c3..bb2582a 100644
--- a/git-compat-util.h
+++ b/git
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
bulk-checkin.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/bulk-checkin.c b/bulk-checkin.c
index 118c625..feeff9f 100644
--- a/bulk-checkin.c
+++ b/bulk-checkin.c
@@ -23,7 +23,7 @@ static struct
...@alum.mit.edu wrote:
On 02/27/2014 08:02 PM, Faiz Kothari wrote:
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
bulk-checkin.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/bulk-checkin.c b/bulk-checkin.c
index 118c625..feeff9f 100644
--- a/bulk
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
Compiles without errors.
Fails in test t/t1050-large.sh ,fails 12/15 tests. Dumps memory map and
backtrace.
Somewhere its not able to free(): invalid pointer.
Please somone pointout where I am doing it wrong.
Help is really appreciated.
Thanks
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
Notes:
I finally got what's happening, and why the errors were caused.
packname is supposed to contain the complete path to the .pack file.
Packs are stored as /path/to/SHA1.pack which I overlooked earlier.
After inspecting what
Hi,
I am Faiz Kothari, I am a GSoC aspirant and want to contribute to git.
I am submitting the patch in reponse to Microproject 1,
rewrite git-compat-util.h:skip_prefix() as a loop.
Signed-off-by: Faiz Kothari faiz.of...@gmail.com
---
git-compat-util.h | 7 +--
1 file changed, 5 insertions
18 matches
Mail list logo