Re: [BUG] You can't have single quote in your username

2019-09-03 Thread Giuseppe Crinò
On Mon, Sep 02, 2019 at 12:25:37PM -0700, Junio C Hamano wrote: > I'd rather leave the sleeping dog lie, if we need to encourage > people to live in 21st century and step outside US-ASCII to do so, > then do that instead. +1 to let the sleeping dog lie. When you say we should encourage people to s

Re: Retrieve version-string on shallow clone

2019-09-02 Thread Giuseppe Crinò
> I'd figure one of these options would be to clone everything from tag > v2.0.0 onward, but if so how would I do that? > As another option I was thinking; maybe it's possible to do git describe > --tags on the remote repo? To my understanding both questions are solved by * https://stackoverflow

Re: [BUG} stash show does not show untracked files stashed (reposted)

2019-09-02 Thread Giuseppe Crinò
> Suppose I have files a,b,c,d modified, but only file d is in the index. > After stash push (or save) --include-untracked, stash show only displays > file d. A subsequent pop will restore files a,b,c,d. So functionally push > and pop are fine, but stash show appears to ignores files in the stash.

Re: [BUG] You can't have single quote in your username

2019-08-31 Thread Giuseppe Crinò
On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote: > We'd still want to keep the low-level removal of "<>\n", since those are > syntactically significant to Git (i.e., if they sneak in you end up with > a broken commit object). Would it work to change `strbuf_addstr_without_crud()` such th

Re: [BUG] You can't have single quote in your username

2019-08-25 Thread Giuseppe Crinò
On Sat, Aug 24, 2019 at 05:49:52PM +, Giuseppe Crinò wrote: > On Fri, Aug 23, 2019 at 10:29:00AM +0200, SZEDER Gábor wrote: > > What I wonder is whether we really have to remove crud from the user > > name if it comes from the configuration. > > Yes. If the primary use o

Re: [BUG] You can't have single quote in your username

2019-08-24 Thread Giuseppe Crinò
On Fri, Aug 23, 2019 at 10:29:00AM +0200, SZEDER Gábor wrote: > What I wonder is whether we really have to remove crud from the user > name if it comes from the configuration. Yes. If the primary use of removing crud is to remove quotes from a quoted name (as in `From: 'Foo baz Bar'`) why not dire

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread Giuseppe Crinò
On Fri, Aug 23, 2019 at 10:29 AM SZEDER Gábor wrote: > If we go down this route, then someone might want to write ő as o" or > ű as u", which still supposed to be used in pairs, but what if someone > wants to write ä as a:, ö as o:, ü as u:, ç as "c,", ş as "s,", etc. I don't know any language th

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread Giuseppe Crinò
On Thu, Aug 22, 2019 at 6:24 PM Junio C Hamano wrote: > The logic there exists in order to remove cruft around the name on a > typical e-mail header (remember, most of the very core-ish part of > the Git was written and got solidified back when the Linux kernel > was the primary client of the syst

[BUG] You can't have single quote in your username

2019-08-22 Thread Giuseppe Crinò
Note how `git log` discards the ending quote character: ``` root@NBR1710R:~# git init repo Initialized empty Git repository in /root/repo/.git/ root@NBR1710R:~# cd repo/ root@NBR1710R:~/repo# git config user.name Les Actualite\' root@NBR1710R:~/repo# cat .git/config [core] repositoryformatv

Re: Feature request: Allow to update commit ID in messages when rebasing

2019-04-18 Thread Giuseppe Crinò
ergoing rewrite > b.) the commit 01a9fe8 is undergoing rewrite in the same command > > We could use the infrastructure from git-filter-branch for this. > > It is serious limitation, but that might be good enough for Giuseppe > Crinò use case. In which case you need to change the ID o

Feature request: Allow to update commit ID in messages when rebasing

2019-04-17 Thread Giuseppe Crinò
The feature I'm asking is to add an extra-step during rebasing, checking whether there's a reference to a commit that's not going to be included in history and asks the user whether the heuristics is correct and if she wants to update those references. Scenario: it can happen for a commit message

Re: Possible minor bug in Git

2019-02-06 Thread Giuseppe Crinò
I wanted to have a look at the bug, and I can correctly reproduce it using version 2.20.1.windows.1. To start to even think of fixing this bug I need to build the source for Windows, but I got lost on how to do that. Is it correct that I should cross-compile from a POSIX system (GNU/Linux), us