Re: [BUG] You can't have single quote in your username

On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote: > But we'd still need something at least for > GECOS, where "Your Name" is common. As I understand this, those commas are *not* removed by strbuf_addstr_without_crud(). Instead they're skipped from /etc/pass -- see `ident.c/copy_gecos(

Re: How to build to debug with gdb?

On Wed, Aug 28, 2019 at 11:00:46AM +, Giuseppe Crino' wrote: > Maybe I'm biased by my incompetence with Makefile's but since rebuilding > the project with `install` but different flags from the first make is > unusual this is worth mentioning to developers. Definitely *not* sarcastic

Re: How to build to debug with gdb?

On Wed, Aug 28, 2019 at 12:32:17PM +0200, SZEDER Gábor wrote: > I don't think it's unusual at all that the 'install' target depends on > 'all'. A quick and incomprehensive survey of Makefiles from a few > open source projects that I happen to have lying around seems to > confirm this. > > What mi

Re: How to build to debug with gdb?

On Tue, Aug 27, 2019 at 08:36:40PM +0200, SZEDER Gábor wrote: > Try using the same build flags for the install, i.e.: > > make prefix=/usr/local DEVELOPER=1 CFLAGS="-O0 -g" install Yes, now it works thanks! On Tue, Aug 27, 2019 at 08:34:23PM +0200, Johannes Sixt wrote: > That is because the co

How to build to debug with gdb?

Hello, to debug some issues I built and installed git via $ make prefix=/usr/local DEVELOPER=1 CFLAGS="-O0 -g" $ sudo make install $ git --version # git version 2.23.0.40.g4d8aada92f But it seems there's still some optimization going on that prevents gdb from working correctly. For example (g

Re: [BUG] You can't have single quote in your username

On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote: > So it might make sense to push these rules into "git mailinfo" instead > of applying them everywhere. But we'd still need something at least for > GECOS, where "Your Name" is common. What's the GECOS you mean?

Re: git can't add ignored file if GIT_ICASE_PATHSPECS=1

I forgot to mention that the issue is present both in maint and in the master branch. On Tue, Feb 12, 2019 at 06:19:52PM +0100, Giuseppe Crino' wrote: > To reproduce, apply the attached patch and run at the project root > > cd t && ./t3700-add.sh --verbose-only=

git can't add ignored file if GIT_ICASE_PATHSPECS=1

To reproduce, apply the attached patch and run at the project root cd t && ./t3700-add.sh --verbose-only=13 --debug --immediate Relevant part of the output is expecting success: export GIT_ICASE_PATHSPECS=1 && touch a.if && test_mus

Re: Possible minor bug in Git

Setting `true` as the default for GIT_ICASE_PATHSPECS_ENVIRONMENT, when git is built on a Windows system, solves the bug. diff --git a/pathspec.c b/pathspec.c index 12c2b322b3..906cf24e3e 100644 --- a/pathspec.c +++ b/pathspec.c @@ -237,7 +237,11 @@ static