Re: Timing issue in t5570 "daemon log records all attributes"

On 03.04.2018 16:32, Jeff King wrote: > I'm tempted to say we should just scrap this test. It was added > relatively recently and only shows the fix for a pretty minor bug. > It's probably not worth the contortions to make it race-proof. Thanks for your reply Jeff. It appears race condition in re

Timing issue in t5570 "daemon log records all attributes"

My understanding of test "daemon log records all attributes" is that daemon process is started in background, some git command is executed and daemon's output (saved to daemon.log) is compared against expected value. However daemon.log is not a straight redirect to file -- it is being piped through

Re: [PATCH 0/3] fix "here-doc" syntax errors

On 22.03.2017 13:08, Junio C Hamano wrote: > Please respond to the list, saying it is OK to add your "sign-off" > (see Documentation/SubmittingPatches) to these patches. Please feel free to do so and thanks for handling the issue. Regards Jan

Re: EOF test fixes (t7030/t7406)

It appears more tests are affected: $ grep -r '^[[:space:]]*EOF &&' . ./t7406-submodule-update.sh:EOF && ./t7030-verify-tag.sh: EOF && ./t7030-verify-tag.sh: EOF && ./t7004-tag.sh: EOF && ./t7004-tag.sh: EOF && attaching patch for t7406 and t7030 which both fail even after fix is applied

EOF test fixes (t5615/t7004)

Hi, attached patch fixes 2 out of 3 tests failing in my env -- missing EOF, incorrectly placed "&&" after EOF. One test seems to be incorrect as it fails even after fixing. I suspect the main difference between my env and others is in shell used -- mksh in my case and probably bash in others. Look