Re: how does "clone --filter=sparse:path" work?

On 11/8/2018 12:07 AM, Jeff King wrote: [cc-ing people who worked on or seem interested in partial-clone filters] I've been exploring the partial-clone options a bit, and took a look at the "sparse:path" option. I had some confusion initially, because I expected it work something like this:

Re: [PATCH 0/1] commit-reach: fix first-parent heuristic

On 10/18/2018 10:31 PM, Junio C Hamano wrote: "Derrick Stolee via GitGitGadget" writes: I originally reported this fix [1] after playing around with the trace2 series for measuring performance. Since trace2 isn't merging quickly, I pulled the performance fix patch out and am sending it on

[PATCH v3 2/2] mingw: fix mingw_open_append to work with named pipes

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c| 36 --- t/t0051-windows-named-pipe.sh | 2 +- 2 files changed, 34 insertions(+), 4 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..18caf21969

[PATCH v3 0/2] Fixup for js/mingw-o-append

(js/mingw-o-append) mingw: enable atomic O_APPEND The new mingw_open_append() routine successfully opens the client side of the named pipe, but the first write() to it fails with EBADF. Adding the FILE_WRITE_DATA corrects the problem. Signed-off-by: Jeff Hostetler jeffh...@microsoft.com [jeffh

[PATCH v3 1/2] t0051: test GIT_TRACE to a windows named pipe

From: Jeff Hostetler Create a test-tool helper to create the server side of a windows named pipe, wait for a client connection, and copy data written to the pipe to stdout. Create t0051 test to route GIT_TRACE output of a command to a named pipe using the above test-tool helper. Signed-off

Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

On 9/10/2018 6:00 PM, Junio C Hamano wrote: Johannes Sixt writes: +#define IS_SBS(ch) (((ch) == '/') || ((ch) == '\\')) I think you already have mingw_is_dir_sep() and its shorter alias is_dir_sep() available to you. good catch. thanks. +/* + * Does the pathname map to the local

Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

On 9/10/2018 3:45 PM, Johannes Sixt wrote: Am 10.09.18 um 19:05 schrieb Jeff Hostetler via GitGitGadget: diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..f87376b26a 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -341,6 +341,19 @@ int mingw_mkdir(const char *path, int mode

[PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c| 38 --- t/t0051-windows-named-pipe.sh | 2 +- 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..f87376b26a

[PATCH v2 0/2] Fixup for js/mingw-o-append

(js/mingw-o-append) mingw: enable atomic O_APPEND The new mingw_open_append() routine successfully opens the client side of the named pipe, but the first write() to it fails with EBADF. Adding the FILE_WRITE_DATA corrects the problem. Signed-off-by: Jeff Hostetler jeffh...@microsoft.com [jeffh

[PATCH v2 1/2] t0051: test GIT_TRACE to a windows named pipe

From: Jeff Hostetler Create a test-tool helper to create the server side of a windows named pipe, wait for a client connection, and copy data written to the pipe to stdout. Create t0051 test to route GIT_TRACE output of a command to a named pipe using the above test-tool helper. Signed-off

Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

On 9/10/2018 12:42 PM, Junio C Hamano wrote: Jeff Hostetler writes: Yeah, this whole thing is a little under-documented for my tastes. Let's leave it as you have it. I'll re-roll with a fix to route named pipes to the existing _wopen() code. OK, I have these two patches in 'next

Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

On 9/8/2018 2:31 PM, Johannes Sixt wrote: Am 08.09.2018 um 11:26 schrieb Johannes Sixt: Am 07.09.2018 um 20:19 schrieb Jeff Hostetler via GitGitGadget: diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..ef03bbe5d2 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -355,7 +355,7

Re: [PATCH 1/2] t0051: test GIT_TRACE to a windows named pipe

On 9/9/2018 3:28 AM, Sebastian Schuberth wrote: On 9/7/2018 8:19 PM, Jeff Hostetler via GitGitGadget wrote: +test_expect_success MINGW 'o_append write to named pipe' ' Shouldn't this be "test_expect_failure" here, and then be changed to "test_expect_success"

Re: [PATCH 0/2] Fixup for js/mingw-o-append

GitGitGadget botched the CCs when I submitted this. Replying here to add them. Sorry, Jeff https://github.com/gitgitgadget/gitgitgadget/issues/35 On 9/7/2018 2:19 PM, Jeff Hostetler via GitGitGadget wrote: The recent change mingw O_APPEND change breaks writing to named pipes on Windows

[PATCH 1/2] t0051: test GIT_TRACE to a windows named pipe

From: Jeff Hostetler Create a test-tool helper to create the server side of a windows named pipe, wait for a client connection, and copy data written to the pipe to stdout. Create t0051 test to route GIT_TRACE output of a command to a named pipe using the above test-tool helper. Signed-off

[PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..ef03bbe5d2 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -355,7 +355,7 @@ static int

[PATCH 0/2] Fixup for js/mingw-o-append

(js/mingw-o-append) mingw: enable atomic O_APPEND The new mingw_open_append() routine successfully opens the client side of the named pipe, but the first write() to it fails with EBADF. Adding the FILE_WRITE_DATA corrects the problem. Signed-off-by: Jeff Hostetler jeffh...@microsoft.com [jeffh

Re: [PATCH 1/8] trace2: create new combined trace facility

On 9/4/2018 6:30 PM, Junio C Hamano wrote: Stefan Beller writes: The API defines both fixed-field and printf-style functions. The trace2 performance tracing includes thread-specific function nesting and timings. So this only adds the new API, and we need to merge the TRACE into the

Re: [PATCH 1/8] trace2: create new combined trace facility

On 9/4/2018 6:12 PM, Stefan Beller wrote: Create GIT_TR2 trace-key to replace GIT_TRACE, GIT_TR2_PERFORMANCE to replace GIT_TRACE_PERFORMANCE, and a new trace-key GIT_TR2_EVENT to generate JSON data for telemetry purposes. Other structured formats can easily be added later using this new

[PATCH 4/8] trace2: demonstrate trace2 child process classification

From: Jeff Hostetler Classify editory, pager, and sub-process child processes. The former two can be used to identify interactive commands, for example. Signed-off-by: Jeff Hostetler --- editor.c | 1 + pager.c | 1 + sub-process.c | 1 + 3 files changed, 3 insertions(+) diff

[PATCH 1/8] trace2: create new combined trace facility

From: Jeff Hostetler Create trace2 API allowing event-based tracing. This will hopefully eventually replace the existing trace API. Create GIT_TR2 trace-key to replace GIT_TRACE, GIT_TR2_PERFORMANCE to replace GIT_TRACE_PERFORMANCE, and a new trace-key GIT_TR2_EVENT to generate JSON data

[PATCH 5/8] trace2: demonstrate instrumenting do_read_index

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- read-cache.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/read-cache.c b/read-cache.c index 7b1354d759..7a31ac4da8 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1867,6 +1867,8 @@ static void tweak_split_index(struct

[PATCH 0/8] WIP: trace2: a new trace facility

: peff@peff.netCc: peartben@gmail.comCc: jrnieder@gmail.comCc: pclo...@gmail.com Jeff Hostetler (8): trace2: create new combined trace facility trace2: add trace2 to main trace2: demonstrate trace2 regions in wt-status trace2: demonstrate trace2 child process classification trace2

[PATCH 6/8] trace2: demonstrate instrumenting threaded preload_index

From: Jeff Hostetler Add trace2_region_enter() and _leave() around the entire preload_index() call. Also add thread-specific events in the preload_thread() threadproc. Signed-off-by: Jeff Hostetler --- preload-index.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/preload

[PATCH 3/8] trace2: demonstrate trace2 regions in wt-status

From: Jeff Hostetler Add trace2_region_enter() and trace2_region_leave() calls around the various phases of a status scan. This gives elapsed time for each phase in the GIT_TR2_PERFORMANCE trace target. Signed-off-by: Jeff Hostetler --- wt-status.c | 14 -- 1 file changed, 12

[PATCH 7/8] trace2: demonstrate setting sub-command parameter in checkout

From: Jeff Hostetler Add trace2_param() events in checkout to report whether the command is switching branches or just checking out a file. Signed-off-by: Jeff Hostetler --- builtin/checkout.c | 5 + 1 file changed, 5 insertions(+) diff --git a/builtin/checkout.c b/builtin/checkout.c

[PATCH 8/8] trace2: demonstrate use of regions in read_directory_recursive

From: Jeff Hostetler Add trace2_region_enter() and _leave() calls inside read_directory_recursive() to show nesting and per-level timing. TODO Drop this commit or ifdef the calls. It generates too much data to be in the production version. It is included in this patch series for illustration

[PATCH 2/8] trace2: add trace2 to main

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.h| 3 +-- git-compat-util.h | 7 +++ git.c | 9 - repository.c | 2 ++ run-command.c | 8 +++- run-command.h | 5 + usage.c | 5 + 7 files changed, 35 insertions

Re: [PATCH v1 00/25] RFC: structured logging

On 8/28/2018 1:38 PM, Junio C Hamano wrote: g...@jeffhostetler.com writes: From: Jeff Hostetler This RFC patch series adds structured logging to git. The motivation, ... Jeff Hostetler (25): structured-logging: design document structured-logging: add STRUCTURED_LOGGING=1

Re: [PATCH v7 09/16] fetch: support filters

On 8/19/2018 7:24 AM, Duy Nguyen wrote: On Fri, Dec 8, 2017 at 5:00 PM Jeff Hostetler wrote: From: Jeff Hostetler Teach fetch to support filters. This is only allowed for the remote configured in extensions.partialcloneremote. Signed-off-by: Jonathan Tan --- builtin/fetch.c

Re: [PATCH v4 2/5] unpack-trees: add performance tracing

On 8/14/2018 2:44 PM, Stefan Beller wrote: On Tue, Aug 14, 2018 at 11:32 AM Duy Nguyen wrote: On Tue, Aug 14, 2018 at 8:19 PM Jeff Hostetler wrote: I'm looking at adding code to my SLOG (better name suggestions welcome) patch series to eventually replace the existing git_trace facility

Re: [PATCH v4 2/5] unpack-trees: add performance tracing

On 8/13/2018 6:41 PM, Junio C Hamano wrote: Jeff King writes: I can buy the argument that it's nice to have some form of profiling that works everywhere, even if it's lowest-common-denominator. I just wonder if we could be investing effort into tooling around existing solutions that will

Re: [PATCH v3 5/5] list-objects-filter: implement filter tree:0

On 8/13/2018 2:14 PM, Matthew DeVore wrote: Teach list-objects the "tree:0" filter which allows for filtering out all tree and blob objects (unless other objects are explicitly specified by the user). The purpose of this patch is to allow smaller partial clones. The name of this filter -

Re: [PATCH] mingw: enable atomic O_APPEND

ter. To become aware of the necessity early, the unusal error ENOSYS is reported if an unsupported mode is encountered. Diagnosed-by: Johannes Schindelin Helped-by: Jeff Hostetler Signed-off-by: Johannes Sixt --- compat/mingw.c | 41 +++-- 1 file changed, 39 insert

Re: [PATCH v2 5/5] list-objects-filter: implement filter tree:none

On 8/10/2018 7:06 PM, Matthew DeVore wrote: Teach list-objects the "tree:none" filter which allows for filtering out all tree and blob objects (unless other objects are explicitly specified by the user). The purpose of this patch is to allow smaller partial clones. The name of this filter -

Re: [PATCH v4] clone: report duplicate entries on case-insensitive filesystems

On 8/12/2018 5:07 AM, Nguyễn Thái Ngọc Duy wrote: Paths that only differ in case work fine in a case-sensitive filesystems, but if those repos are cloned in a case-insensitive one, you'll get problems. The first thing to notice is "git status" will never be clean with no indication what

Re: [PATCH 0/4] t5552: fix flakiness by introducing proper locking for GIT_TRACE

On 8/10/2018 12:51 PM, Jeff Hostetler wrote: On 8/10/2018 12:15 PM, Johannes Sixt wrote: Am 09.08.2018 um 19:35 schrieb Johannes Schindelin via GitGitGadget: I reported a couple of times that t5552 is not passing reliably. It has now reached next, and will no doubt infect master soon

Re: [PATCH 0/4] t5552: fix flakiness by introducing proper locking for GIT_TRACE

On 8/10/2018 12:15 PM, Johannes Sixt wrote: Am 09.08.2018 um 19:35 schrieb Johannes Schindelin via GitGitGadget: I reported a couple of times that t5552 is not passing reliably. It has now reached next, and will no doubt infect master soon. Turns out that it is not a Windows-specific

Re: [PATCH v2] clone: report duplicate entries on case-insensitive filesystems

On 8/9/2018 10:23 AM, Jeff King wrote: On Wed, Aug 08, 2018 at 05:41:10PM -0700, Junio C Hamano wrote: If we have an equivalence-class hashmap and feed it inodes (or again, some system equivalent) as the keys, we should get buckets of collisions. I guess one way to get "some system

Re: [PATCH v1 01/25] structured-logging: design document

On 8/3/2018 11:26 AM, Ben Peart wrote: On 7/13/2018 12:55 PM, g...@jeffhostetler.com wrote: From: Jeff Hostetler Signed-off-by: Jeff Hostetler ---   Documentation/technical/structured-logging.txt | 816 +   1 file changed, 816 insertions(+)   create mode 100644

Re: [PATCH v2] clone: report duplicate entries on case-insensitive filesystems

On 8/7/2018 3:31 PM, Junio C Hamano wrote: Nguyễn Thái Ngọc Duy writes: One nice thing about this is we don't need platform specific code for detecting the duplicate entries. I think ce_match_stat() works even on Windows. And it's now equally expensive on all platforms :D

Re: [PATCH/RFC] clone: report duplicate entries on case-insensitive filesystems

On 8/3/2018 2:53 PM, Jeff King wrote: On Fri, Aug 03, 2018 at 02:23:17PM -0400, Jeff Hostetler wrote: Maybe. It might not work as ino_t. Or it might be expensive to get. Or maybe it's simply impossible. I don't know much about Windows. Some searching implies that NTFS does have a "

Re: [PATCH/RFC] clone: report duplicate entries on case-insensitive filesystems

On 8/2/2018 5:28 PM, Jeff King wrote: On Thu, Aug 02, 2018 at 02:14:30PM -0700, Junio C Hamano wrote: Jeff King writes: I also wonder if Windows could return some other file-unique identifier that would work in place of an inode here. That would be pretty easy to swap in via an #ifdef's

Re: Git clone and case sensitivity

On 7/29/2018 5:28 AM, Jeff King wrote: On Sun, Jul 29, 2018 at 07:26:41AM +0200, Duy Nguyen wrote: strcasecmp() will only catch a subset of the cases. We really need to follow the same folding rules that the filesystem would. True. But that's how we handle case insensitivity internally.

Re: [PATCH v1 03/25] structured-logging: add structured logging framework

On 7/26/2018 5:09 AM, SZEDER Gábor wrote: +void slog_set_command_name(const char *command_name) +{ + /* +* Capture the command name even if logging is not enabled +* because we don't know if the config has been loaded yet by +* the cmd_() and/or it may be too

Re: [PATCH v1] config.c: fix msvc compile error

On 7/24/2018 3:56 PM, Taylor Blau wrote: On Tue, Jul 24, 2018 at 03:30:10PM +, g...@jeffhostetler.com wrote: From: Jeff Hostetler In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added to builtin/config.c to define a new function and a forward declaration for an array

Re: [PATCH v1] msvc: fix non-standard escape sequence in source

On 7/24/2018 2:13 PM, Beat Bolli wrote: Hi Jeff On 24.07.18 16:42, g...@jeffhostetler.com wrote: From: Jeff Hostetler Replace non-standard "\e" escape sequence with "\x1B". This was already fixed in <20180708144342.11922-4-dev+...@drbeat.li>. Cheers, Beat

Re: Git 2.18: RUNTIME_PREFIX... is it working?

On 7/19/2018 6:26 PM, brian m. carlson wrote: On Wed, Jul 18, 2018 at 02:18:44PM +0200, Johannes Schindelin wrote: On Sat, 14 Jul 2018, brian m. carlson wrote: I will say that at cPanel, we have a configuration where end users can end up inside a mount namespace without /proc (depending on

Re: [RFC] push: add documentation on push v2

On 7/18/2018 1:15 PM, Brandon Williams wrote: On 07/18, Stefan Beller wrote: On Wed, Jul 18, 2018 at 6:31 AM Derrick Stolee wrote: On 7/17/2018 7:25 PM, Stefan Beller wrote: On Tue, Jul 17, 2018 at 2:09 PM Brandon Williams wrote: Signed-off-by: Brandon Williams --- Since introducing

Re: [PATCH v1 00/25] RFC: structured logging

On 7/13/2018 2:51 PM, David Lang wrote: Please make an option for git to write these logs to syslog, not just a local file. Every modern syslog daemon has lots of tools to be able to deal with json messages well. David Lang That is certainly possible and we can easily add it in a later

Re: [PATCH v8 2/2] json-writer: t0019: add perl unit test

On 6/7/2018 1:13 PM, Eric Sunshine wrote: On Thu, Jun 7, 2018 at 10:12 AM, wrote: Test json-writer output using perl script. Signed-off-by: Jeff Hostetler --- diff --git a/t/t0019/parse_json.perl b/t/t0019/parse_json.perl @@ -0,0 +1,52 @@ +#!/usr/bin/perl +use strict; +use warnings; +use

Re: [PATCH v8 1/2] json_writer: new routines to create data in JSON format

On 6/8/2018 4:07 PM, René Scharfe wrote: Am 07.06.2018 um 16:12 schrieb g...@jeffhostetler.com: From: Jeff Hostetler [...] + if (jw->first_stack.buf[jw->first_stack.len - 1] == '1') + jw->first_stack.buf[jw->first_stack.len - 1] = '0';

Re: [PATCH v8 1/2] json_writer: new routines to create data in JSON format

On 6/8/2018 2:05 AM, René Scharfe wrote: Am 07.06.2018 um 16:12 schrieb g...@jeffhostetler.com: From: Jeff Hostetler Add a series of jw_ routines and "struct json_writer" structure to compose [...] TEST_PROGRAMS_NEED_X += test-index-version +TEST_PROGRAMS_NEED_X += test-j

Re: [PATCH v8 1/2] json_writer: new routines to create data in JSON format

On 6/8/2018 4:32 PM, René Scharfe wrote: Am 07.06.2018 um 16:12 schrieb g...@jeffhostetler.com: Makefile| 2 + json-writer.c | 419 json-writer.h | 113 + t/helper/test-json-writer.c | 572

Re: [PATCH v8 1/2] json_writer: new routines to create data in JSON format

Signed-off-by: Jeff Hostetler --- diff --git a/t/t0019-json-writer.sh b/t/t0019-json-writer.sh @@ -0,0 +1,236 @@ +test_expect_success 'simple object' ' + cat >expect <<-\EOF && + {"a":"abc","b":42,"c":3.14,"

Re: [PATCH v7 2/2] json-writer: t0019: add Python unit test

On 6/6/2018 5:03 PM, Jeff King wrote: On Wed, Jun 06, 2018 at 01:10:52PM -0400, Todd Zullinger wrote: g...@jeffhostetler.com wrote: +# As a sanity check, ask Python to parse our generated JSON. Let Python +# recursively dump the resulting dictionary in sorted order. Confirm that +# that

Re: [PATCH v7 2/2] json-writer: t0019: add Python unit test

On 6/6/2018 1:10 PM, Todd Zullinger wrote: g...@jeffhostetler.com wrote: +# As a sanity check, ask Python to parse our generated JSON. Let Python +# recursively dump the resulting dictionary in sorted order. Confirm that +# that matches our expectations. +test_expect_success PYTHON 'parse

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 6/2/2018 1:13 AM, Jeff King wrote: On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote: On Mon, Mar 26, 2018 at 4:31 PM, wrote: +static inline void assert_in_array(const struct json_writer *jw) +{ + if (!jw->open_stack.len) + die("json-writer: array: missing

Re: [PATCH v2 1/5] core.aheadbehind: add new config setting

@pobox.com> Date: Thu Mar 8 12:36:24 2018 -0800 Merge branch 'jh/status-no-ahead-behind' These parts are in the 'gvfs' branch in the g...@github.com:Microsoft/git.git repo: commit 039f65946968fa654a9c3bca27a4f4e93c1c9381 Author: Jeff Hostetler <jeffh...@microso

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

On 3/30/2018 4:38 PM, Junio C Hamano wrote: * jh/json-writer (2018-03-28) 1 commit - json_writer: new routines to create data in JSON format Is this ready for 'next'? Yes, I believe it is. This has the V6 fixup for the HEREDOC with leading whitespace, so I think we're good. Thanks

Re: [RFC/PATCH] upload-pack: disable object filtering when disabled by config

On 3/28/2018 6:12 PM, Junio C Hamano wrote: Jonathan Nieder writes: When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, 2017-12-08), it was guarded by the uploadpack.allowFilter config item to allow server operators to control when they start supporting

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 3/27/2018 11:45 AM, Ramsay Jones wrote: On 27/03/18 04:18, Ramsay Jones wrote: On 26/03/18 15:31, g...@jeffhostetler.com wrote: From: Jeff Hostetler <jeffh...@microsoft.com> [snip] Thanks, this version fixes all issues I had (with the compilation and sparse warnings). [Was

Re: Fwd: New Defects reported by Coverity Scan for git

On 3/26/2018 7:39 PM, Stefan Beller wrote: coverity scan failed for the last couple month (since Nov 20th) without me noticing, I plan on running it again nightly for the Git project. Anyway, here are issues that piled up (in origin/pu) since then. Stefan -- Forwarded message

Re: [PATCH v4] json_writer: new routines to create data in JSON format

On 3/26/2018 11:18 PM, Ramsay Jones wrote: On 26/03/18 15:31, g...@jeffhostetler.com wrote: From: Jeff Hostetler <jeffh...@microsoft.com> [snip] Thanks, this version fixes all issues I had (with the compilation and sparse warnings). [Was using UINT64_C(0x) a p

Re: [RFC PATCH 1/1] json-writer: incorrect format specifier

On 3/26/2018 11:26 PM, Ramsay Jones wrote: On 26/03/18 18:04, Junio C Hamano wrote: Ramsay Jones writes: [...] I must confess to not having given any thought to the wider implications of the code. I don't really know what this code is going to be used for.

Re: [RFC PATCH v5 0/8] rebase-interactive

On 3/27/2018 1:07 AM, Junio C Hamano wrote: Jeff Hostetler <g...@jeffhostetler.com> writes: [...] So I would think it is most sensible to have double, uintmax_t and intmax_t variants. If you do not care about the extra value range that unsigned integral types afford, a single in

Re: Including object type and size in object id (Re: Git Merge contributor summit notes)

On 3/26/2018 5:00 PM, Jonathan Nieder wrote: Jeff Hostetler wrote: [long quote snipped] While we are converting to a new hash function, it would be nice if we could add a couple of fields to the end of the OID: the object type and the raw uncompressed object size. If would be nice if we

Re: Git Merge contributor summit notes

On 3/26/2018 1:56 PM, Stefan Beller wrote: On Mon, Mar 26, 2018 at 10:33 AM Jeff Hostetler <g...@jeffhostetler.com> wrote: On 3/25/2018 6:58 PM, Ævar Arnfjörð Bjarmason wrote: On Sat, Mar 10 2018, Alex Vandiver wrote: New hash (Stefan, etc) -- - dis

Re: [RFC PATCH v5 0/8] rebase-interactive

On 3/26/2018 2:00 PM, Junio C Hamano wrote: Jeff Hostetler <g...@jeffhostetler.com> writes: I am concerned that the above compiler error message says that uintmax_t is defined as an "unsigned long" (which is defined as *at least* 32 bits, but not necessarily 64. But a uin

Re: [RFC PATCH v5 0/8] rebase-interactive

On 3/26/2018 1:57 PM, Junio C Hamano wrote: Jeff Hostetler <g...@jeffhostetler.com> writes: I defined that routine to take a uint64_t because I wanted to pass a nanosecond value received from getnanotime() and that's what it returns. Hmph, but the target format does not have dif

Re: [RFC PATCH 1/1] json-writer: incorrect format specifier

On 3/26/2018 1:04 PM, Junio C Hamano wrote: Ramsay Jones writes: @@ -120,7 +120,7 @@ void jw_object_uint64(struct json_writer *jw, const char *key, uint64_t value) maybe_add_comma(jw); append_quoted_string(>json, key); - strbuf_addf(>json,

Re: [RFC PATCH v2 1/1] json-writer: add cast to uintmax_t

On 3/24/2018 2:38 PM, Wink Saville wrote: Correct a compile error on Mac OSX by adding a cast to uintmax_t in calls to strbuf_addf. Helped-by: Ramsay Jones Tested-by: travis-ci Signed-off-by: Wink Saville --- json-writer.c | 4 ++-- 1 file

Re: Git Merge contributor summit notes

On 3/25/2018 6:58 PM, Ævar Arnfjörð Bjarmason wrote: On Sat, Mar 10 2018, Alex Vandiver wrote: New hash (Stefan, etc) -- - discussed on the mailing list - actual plan checked in to Documentation/technical/hash-function-transition.txt - lots of work renaming -

Re: [RFC PATCH v5 0/8] rebase-interactive

On 3/26/2018 11:56 AM, Junio C Hamano wrote: Wink Saville writes: json-writer.c:123:38: error: format specifies type 'uintmax_t' (aka 'unsigned long') but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] strbuf_addf(>json,

Re: [RFC PATCH 1/1] json-writer: incorrect format specifier

On 3/24/2018 1:37 AM, Wink Saville wrote: In routines jw_object_uint64 and jw_object_double strbuf_addf is invoked with strbuf_addf(>json, ":%"PRIuMAX, value) where value is a uint64_t. This causes a compile error on OSX. The correct format specifier is PRIu64 instead of PRIuMax.

Re: [PATCH v2] json_writer: new routines to create data in JSON format

On 3/23/2018 4:11 PM, René Scharfe wrote: Am 23.03.2018 um 20:55 schrieb Jeff Hostetler: +struct json_writer_level +{ +    unsigned level_is_array : 1; +    unsigned level_is_empty : 1; +}; + +struct json_writer +{ +    struct json_writer_level *levels; +    int nr, alloc; +    struct strbuf

Re: [PATCH v2] json_writer: new routines to create data in JSON format

On 3/23/2018 2:01 PM, René Scharfe wrote: Am 21.03.2018 um 20:28 schrieb g...@jeffhostetler.com: From: Jeff Hostetler <jeffh...@microsoft.com> Add basic routines to generate data in JSON format. Signed-off-by: Jeff Hostetler <jeffh...@microsoft.com> --- Makefile

Re: [PATCH v3] routines to generate JSON data

On 3/23/2018 2:14 PM, Ramsay Jones wrote: On 23/03/18 16:29, g...@jeffhostetler.com wrote: From: Jeff Hostetler <jeffh...@microsoft.com> This is version 3 of my JSON data format routines. I have not looked at v3 yet - the patch below is against the version in 'pu' @3284f940c (pres

Re: [PATCH v3] json_writer: new routines to create data in JSON format

On 3/23/2018 1:18 PM, Jonathan Nieder wrote: g...@jeffhostetler.com wrote: From: Jeff Hostetler <jeffh...@microsoft.com> Add basic routines to generate data in JSON format. Signed-off-by: Jeff Hostetler <jeffh...@microsoft.com> If I understand the cover letter correctly, th

Re: [PATCH v2] json_writer: new routines to create data in JSON format

On 3/21/2018 5:25 PM, Junio C Hamano wrote: g...@jeffhostetler.com writes: From: Jeff Hostetler <jeffh...@microsoft.com> Add basic routines to generate data in JSON format. And the point of having capability to write JSON data in our codebase is...? diff --git a/json-writer.c

Re: [PATCH 0/2] routines to generate JSON data

On 3/20/2018 1:42 AM, Jeff King wrote: On Mon, Mar 19, 2018 at 06:19:26AM -0400, Jeff Hostetler wrote: To make the above work, I think you'd have to store a little more state. E.g., the "array_append" functions check "out->len" to see if they need to add a separati

Re: [PATCH 0/2] routines to generate JSON data

On 3/17/2018 3:38 AM, Jacob Keller wrote: On Fri, Mar 16, 2018 at 2:18 PM, Jeff King wrote: 3. Some other similar format. YAML comes to mind. Last time I looked (quite a while ago), it seemed insanely complex, but I think you could implement only a reasonable

Re: [PATCH 0/2] routines to generate JSON data

On 3/16/2018 5:18 PM, Jeff King wrote: On Fri, Mar 16, 2018 at 07:40:55PM +, g...@jeffhostetler.com wrote: [...] I really like the idea of being able to send our machine-readable output in some "standard" syntax for which people may already have parsers. But one big hangup with JSON is

Re: [PATCH 04/36] t/helper: merge test-lazy-init-name-hash into test-tool

On 3/18/2018 4:47 AM, Eric Sunshine wrote: On Sun, Mar 18, 2018 at 4:25 AM, Duy Nguyen wrote: On Sun, Mar 18, 2018 at 3:11 AM, Eric Sunshine wrote: On Sat, Mar 17, 2018 at 3:53 AM, Nguyễn Thái Ngọc Duy wrote: -extern int

Re: What's cooking in git.git (Feb 2018, #03; Wed, 21)

On 2/21/2018 7:31 PM, Junio C Hamano wrote: * jh/status-no-ahead-behind (2018-01-24) 4 commits - status: support --no-ahead-behind in long format - status: update short status to respect --no-ahead-behind - status: add --[no-]ahead-behind to status and commit for V2 format. -

Re: What's cooking in git.git (Feb 2018, #01; Wed, 7)

* jh/status-no-ahead-behind (2018-01-24) 4 commits - status: support --no-ahead-behind in long format - status: update short status to respect --no-ahead-behind - status: add --[no-]ahead-behind to status and commit for V2 format. - stat_tracking_info: return +1 when branches not equal

Re: partial fetch

On 2/12/2018 11:24 AM, Basin Ilya wrote: Hi. In 2017 a set of patches titled "add object filtering for partial fetch" was accepted. Is it what I think it is? Will we be able to download only a subdirectory from a large project? yes, that is the goal. there are several caveats, but yes,

Re: [RFC PATCH 000/194] Moving global state into the repository object

On 2/5/2018 6:51 PM, Stefan Beller wrote: This series moves a lot of global state into the repository struct. It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0) It can be found at https://github.com/stefanbeller/git/tree/object-store Motivation for this series: * Easier to

Re: [PATCH v2 00/27] protocol version 2

On 1/25/2018 6:58 PM, Brandon Williams wrote: Changes in v2: * Added documentation for fetch * changes #defines for state variables to be enums * couple code changes to pkt-line functions and documentation * Added unit tests for the git-serve binary as well as for ls-refs [...] This

Re: [PATCH 12/26] ls-refs: introduce ls-refs server command

On 1/2/2018 7:18 PM, Brandon Williams wrote: Introduce the ls-refs server command. In protocol v2, the ls-refs command is used to request the ref advertisement from the server. Since it is a command which can be requested (as opposed to mandatory in v1), a client can sent a number of

Re: [PATCH 11/26] serve: introduce git-serve

On 2/1/2018 1:57 PM, Stefan Beller wrote: On Thu, Feb 1, 2018 at 10:48 AM, Jeff Hostetler <g...@jeffhostetler.com> wrote: On 1/2/2018 7:18 PM, Brandon Williams wrote: Introduce git-serve, the base server for protocol version 2. [...] + Special Packets +- + +In pr

Re: [PATCH 11/26] serve: introduce git-serve

On 1/2/2018 7:18 PM, Brandon Williams wrote: Introduce git-serve, the base server for protocol version 2. Protocol version 2 is intended to be a replacement for Git's current wire protocol. The intention is that it will be a simpler, less wasteful protocol which can evolve over time.

Re: [RFC PATCH 0/1] Implement CMake build

On 1/25/2018 7:21 PM, Isaac Hier wrote: Hi Jeff, I have been looking at the build generator, which looks promising, but I have one concern. Assuming I can generate a CMakeLists.txt that appropriately updates the library sources, etc. how do you suggest I handle new portability macros? For

Re: [RFC PATCH 0/1] Implement CMake build

On 1/24/2018 2:59 PM, Isaac Hier wrote: Jeff, no worries, fair enough. I know https://github.com/grpc/grpc uses a shared file to generate code for several build systems instead of maintaining them individually. I plan on doing the work anyway just because I have my own reasons to use CMake in

Re: [RFC PATCH 0/1] Implement CMake build

On 1/22/2018 7:16 PM, Isaac Hier wrote: This patch adds a mostly complete (aside from building tests, documentation, installation, etc.) CMake build to the git project. I am not sure how much interest there is in a CMake build, so please send me feedback one way or another. Personally, I

Re: What's cooking in git.git (Jan 2018, #03; Tue, 23)

On 1/23/2018 5:39 PM, Junio C Hamano wrote: [Stalled] * jh/status-no-ahead-behind (2018-01-04) 4 commits - status: support --no-ahead-behind in long format - status: update short status to respect --no-ahead-behind - status: add --[no-]ahead-behind to status and commit for V2 format.

Re: [PATCH v2 2/2] sha1_file: improve sha1_file_name() perfs

<sto...@gmail.com> Helped-by: Jeff Hostetler <g...@jeffhostetler.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- sha1_file.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sha1_file.c b/sha1_file.c index f66c21b2da..1a94716962 100644

Re: [PATCH] sha1_file: remove static strbuf from sha1_file_name()

On 1/16/2018 9:01 AM, Derrick Stolee wrote: On 1/16/2018 2:18 AM, Christian Couder wrote: Using a static buffer in sha1_file_name() is error prone and the performance improvements it gives are not needed in most of the callers. So let's get rid of this static buffer and, if necessary or

Re: What's cooking in git.git (Jan 2018, #02; Tue, 9)

On 1/10/2018 2:57 PM, Junio C Hamano wrote: Jeff Hostetler <g...@jeffhostetler.com> writes: On 1/9/2018 6:33 PM, Junio C Hamano wrote: -- [Cooking] * jh/fsck-promisors (2017-12-08) 10 commits [...] * jh/partial-clone (2017-12-

Re: What's cooking in git.git (Jan 2018, #02; Tue, 9)

On 1/9/2018 6:33 PM, Junio C Hamano wrote: -- [Cooking] * jh/fsck-promisors (2017-12-08) 10 commits [...] * jh/partial-clone (2017-12-08) 13 commits [...] Parts 2 and 3 of partial clone have been simmering for a while now. I was wondering

  1   2   3   4   5   6   7   >