Re: [PATCH v2] packfile: Correct zlib buffer handling

, but not about "what this > line does" (which is useless, as you pointed out) but about "why do > we do this seemingly redundant clearing". > > Here is what I tentatively came up with. > > -- >8 -- > From: Jeremy Linton > Date: Wed, 13 Jun 2018 09:

[PATCH v2] packfile: Correct zlib buffer handling

-by: Jeremy Linton --- packfile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packfile.c b/packfile.c index 7c1a2519f..8db5d90ca 100644 --- a/packfile.c +++ b/packfile.c @@ -1433,6 +1433,8 @@ static void *unpack_compressed_entry(struct packed_git *p, return NULL

Re: [PATCH] packfile: Correct zlib buffer handling

Hi, Sorry about the delay here (bit of a mix-up and didn't reply to the list). (see inline ) On Sun, May 27, 2018 at 9:41 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Duy Nguyen writes: >> >>> On Sun, May 27, 2018 at 1:57 AM, Junio C Hamano wrote: (trimming) > > Specifically, I

[PATCH] packfile: Correct zlib buffer handling

already exists if the buffer size is correct. Signed-off-by: Jeremy Linton <lintonrjer...@gmail.com> --- packfile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packfile.c b/packfile.c index 7c1a2519f..245eb3204 100644 --- a/packfile.c +++ b/packfile.c @@ -1416,7 +

[PATCH] packfile: Correct zlib buffer handling

already exists if the buffer size is correct. Signed-off-by: Jeremy Linton <lintonrjer...@gmail.com> --- packfile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packfile.c b/packfile.c index 7c1a2519f..245eb3204 100644 --- a/packfile.c +++ b/packfile.c @@ -1416,7 +