being read is 'path', an empty value is not valid, and so
an error message is printed.
Signed-off-by: Jharrod LaFon jlafon at eyesopen.com
---
submodule.c|6 ++
t/t1307-null-submodule-path.sh | 14 ++
2 files changed, 20 insertions(+)
create mode
It looks great to me.
Thanks,
--
Jharrod LaFon
OpenEye Scientific Software
On Aug 19, 2013, at 2:54 PM, Junio C Hamano gits...@pobox.com wrote:
Jharrod LaFon jla...@eyesopen.com writes:
I will keep trying this until it's perfect, and I thank you for
the help. When I resubmit this, would
OK, I'll incorporate Jeff's changes, add a test and resubmit the patch.
Thanks,
--
Jharrod LaFon
OpenEye Scientific Software
On Aug 16, 2013, at 7:14 AM, Jeff King p...@peff.net wrote:
On Fri, Aug 16, 2013 at 09:09:58AM -0400, Jeff King wrote:
- if (parse_config_key(var, submodule, name
sure 'value' is not
null before using it as an argument to xstrdup. For some configuration
options, such as fetchRecurseSubmodules, an empty value is valid. If
the option being read is 'path', an empty value is not valid, and so
an error message is printed.
Signed-off-by: Jharrod LaFon jlafon
before the call to xstrdup is made.
Signed-off-by: Jharrod LaFon jlafon at eyesopen.com
---
submodule.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index 1821a5b..880f21b 100644
--- a/submodule.c
+++ b/submodule.c
@@ -130,7 +130,7 @@ int
5 matches
Mail list logo