Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

2013-04-09 Thread John Koleszar
On Mon, Apr 8, 2013 at 2:45 PM, Jeff King p...@peff.net wrote: On Mon, Apr 08, 2013 at 11:25:39PM +0200, Thomas Rast wrote: At the risk of repeating something that's been said already -- I only skimmed the thread -- this test breaks in today's pu on my machine. I get: [...] --- expect

[PATCH v4] http-backend: respect GIT_NAMESPACE with dumb clients

2013-04-09 Thread John Koleszar
Filter the list of refs returned via the dumb HTTP protocol according to the active namespace, consistent with other clients of the upload-pack service. Signed-off-by: John Koleszar jkoles...@google.com --- Updates to generate HEAD. Drops my original tests, since they were under the flawed

Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

2013-04-05 Thread John Koleszar
On Thu, Apr 4, 2013 at 10:43 PM, Jeff King p...@peff.net wrote: On Thu, Apr 04, 2013 at 10:34:49PM -0700, Junio C Hamano wrote: +static void get_head(char *arg) +{ + struct strbuf buf = STRBUF_INIT; + head_ref_namespaced(show_text_ref, buf); + send_strbuf(text/plain, buf);

Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

2013-04-04 Thread John Koleszar
On Wed, Apr 3, 2013 at 11:05 AM, Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: On Wed, Apr 03, 2013 at 12:10:38PM -0400, Jeff King wrote: Hmm. This is testing just the ref advertisement. It would be nice to see a complete transaction tested with namespaces turned

[PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

2013-04-04 Thread John Koleszar
Filter the list of refs returned via the dumb HTTP protocol according to the active namespace, consistent with other clients of the upload-pack service. Signed-off-by: John Koleszar jkoles...@google.com --- Incorporate peff's suggested test, and Junio's comments. With regard to whether it's

Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

2013-04-04 Thread John Koleszar
On Thu, Apr 4, 2013 at 10:25 AM, Junio C Hamano gits...@pobox.com wrote: John Koleszar jkoles...@google.com writes: @@ -402,7 +404,8 @@ static void get_info_refs(char *arg) } else { select_getanyfile(); - for_each_ref(show_text_ref, buf

[PATCH] http-backend: respect GIT_NAMESPACE with dumb clients

2013-03-27 Thread John Koleszar
Filter the list of refs returned via the dumb HTTP protocol according to the active namespace, consistent with other clients of the upload-pack service. Signed-off-by: John Koleszar jkoles...@google.com --- http-backend.c | 8 +--- t/lib-httpd/apache.conf | 5 + t/t5561-http