"Secure" or "HttpOnly" described in RFC
6265). When I try to craft a cookie file containing that (using
"Set-Cookie: Foo=; HttpOnly", for example), the no-equals-sign cookie
just disappears.
Jonathan Tan (2):
http: support cookie redaction when tracing
http: sup
; to
allow the user to omit such data transmissions.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
Documentation/git.txt | 4
http.c | 27 +++
t/t5551-http-fetch-smart.sh | 12
3 files changed, 35 insertions(+), 8 de
When using GIT_TRACE_CURL, Git already redacts the "Authorization:" and
"Proxy-Authorization:" HTTP headers. Extend this redaction to a
user-specified list of cookies, specified through the
"GIT_REDACT_COOKIES" environment variable.
Signed-off-by: Jonathan
On Thu, 18 Jan 2018 09:56:50 +0100
Christian Couder wrote:
> I am still not very happy with fetch_object() not returning anything.
> I wonder what happens when that function is used to fetch from a repo
> that cannot provide the requested object.
My idea was to save
On Thu, 18 Jan 2018 15:50:52 +0100
Patryk Obara wrote:
> Patch 1 is not directly related to object_id conversions but helped with
> debugging t5540, which kept failing on master for me (spoiler: it was Fedora
> fault). It helps with debugging of failing git-push over
; to
allow the user to omit such data transmissions.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
http.c | 27 +++
t/t5551-http-fetch-smart.sh | 12
2 files changed, 31 insertions(+), 8 deletions(-)
diff --git a/http.
does not perform any redaction, merely using Curl's
default logging mechanism.)
The patches are ready for merging, but I marked this as "RFC" just in
case there is a better way to accomplish this.
Jonathan Tan (2):
http: support cookie redaction when tracing
http: support omit
When using GIT_TRACE_CURL, Git already redacts the "Authorization:" and
"Proxy-Authorization:" HTTP headers. Extend this redaction to a
user-specified list of cookies, specified through the
"GIT_REDACT_COOKIES" environment variable.
Signed-off-by: Jonathan
On Tue, 2 Jan 2018 16:18:28 -0800
Brandon Williams wrote:
> +static size_t proxy_in(void *ptr, size_t eltsize,
> +size_t nmemb, void *buffer_)
OK, I managed to look at the Curl stuff in more detail.
I know that these parameter names are what
On Tue, 2 Jan 2018 16:18:28 -0800
Brandon Williams wrote:
> Teach remote-curl the 'connect-half-duplex' command which is used to
> establish a half-duplex connection with servers which support protocol
> version 2. This allows remote-curl to act as a proxy, allowing the git
On Tue, 2 Jan 2018 16:18:22 -0800
Brandon Williams wrote:
> +static enum ack_type process_ack(const char *line, struct object_id *oid)
> +{
> + const char *arg;
> +
> + if (!strcmp(line, "NAK"))
> + return NAK;
> + if (skip_prefix(line, "ACK ", )) {
>
On Tue, 9 Jan 2018 14:16:42 -0800
Brandon Williams wrote:
> All good documentation changes.
Thanks!
> > > + /*
> > > + * Function called when a client requests the capability as a command.
> > > + * The command request will be provided to the function via 'keys', the
> > >
On Tue, 2 Jan 2018 16:18:15 -0800
Brandon Williams wrote:
> diff --git a/connect.c b/connect.c
> index caa539b75..9badd403f 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -12,9 +12,11 @@
> #include "sha1-array.h"
> #include "transport.h"
> #include "strbuf.h"
> +#include
On Tue, 2 Jan 2018 16:18:14 -0800
Brandon Williams wrote:
> + symrefs: In addition to the object pointed by it, show the underlying
> +ref pointed by it when showing a symbolic ref.
> + peel: Show peeled tags.
> + ref-pattern : When specified, only references
On Tue, 2 Jan 2018 16:18:13 -0800
Brandon Williams wrote:
> diff --git a/Documentation/technical/protocol-v2.txt
> b/Documentation/technical/protocol-v2.txt
> new file mode 100644
> index 0..b87ba3816
> --- /dev/null
> +++ b/Documentation/technical/protocol-v2.txt
On Tue, 2 Jan 2018 16:18:11 -0800
Brandon Williams wrote:
> diff --git a/transport.c b/transport.c
> index 63c3dbab9..2378dcb38 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -118,6 +118,7 @@ struct git_transport_data {
> struct child_process *conn;
> int
On Tue, 2 Jan 2018 16:18:09 -0800
Brandon Williams wrote:
> - while ((len = read_remote_ref(in, _buf, _len, ))) {
> + while (state != EXPECTING_DONE) {
> + switch (packet_reader_read()) {
> + case PACKET_READ_EOF:
> +
On Tue, 2 Jan 2018 16:18:04 -0800
Brandon Williams wrote:
> diff --git a/pkt-line.h b/pkt-line.h
> index 06c468927..c446e886a 100644
> --- a/pkt-line.h
> +++ b/pkt-line.h
> @@ -111,6 +111,63 @@ char *packet_read_line_buf(char **src_buf, size_t
> *src_len, int *size);
> */
On Tue, 2 Jan 2018 16:18:03 -0800
Brandon Williams wrote:
> -int packet_read(int fd, char **src_buf, size_t *src_len,
> - char *buffer, unsigned size, int options)
> +enum packet_read_status packet_read_with_status(int fd, char **src_buffer,
> size_t *src_len,
>
On Tue, 2 Jan 2018 16:18:02 -0800
Brandon Williams wrote:
> The following patches extend what I sent out as an WIP
> (https://public-inbox.org/git/20171204235823.63299-1-bmw...@google.com/) and
> implement protocol version 2.
Summarizing (for myself) the rationale for
On Mon, 8 Jan 2018 15:35:59 -0500
Derrick Stolee wrote:
> Thanks! That is certainly the idea. If you know about MIDX, then you can
> benefit from it. If you do not, then you have all the same data
> available to you do to your work. Having a MIDX file will not break
> other
On Sun, 7 Jan 2018 13:14:42 -0500
Derrick Stolee wrote:
> +Design Details
> +--
> +
> +- The MIDX file refers only to packfiles in the same directory
> + as the MIDX file.
> +
> +- A special file, 'midx-head', stores the hash of the latest
> + MIDX file so we can
On Mon, 18 Dec 2017 13:49:47 -0800
Stefan Beller wrote:
> I was compiling origin/master today with stricter compiler flags today
> and was greeted by
>
> t/helper/test-lazy-init-name-hash.c: In function ‘cmd_main’:
> t/helper/test-lazy-init-name-hash.c:172:5: error:
On Mon, 18 Dec 2017 12:30:23 +
"Carlsson, Magnus" wrote:
> In a certain situation I would really need to fetch all commits
> related to a specific commit (SHA). I have read the git fetch
> documentation and found nothing regarding this. It only seems to
> support
certain
variables in the transport interface struct more private, and might need
more discussion. I also discuss the possible future work that this
modification makes possible.
Jonathan Tan (2):
clone, fetch: remove redundant transport check
transport: make transport vtable more private
builtin
e. A minor additional point is that the code has
gotten more complicated since then, in that the function-pointer
variables are potentially mutated twice (once initially and once if
transport_take_over() is invoked), increasing the value of corralling
them into their own struct.
Signed-off-by: Jo
s populate get_refs_list and fetch, making the checks in clone
and fetch redundant. Remove those checks.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
builtin/clone.c | 3 ---
builtin/fetch.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
After commit 0d0bac67ce3b ("transport: drop support for git-over-rsync",
2016-02-01), no transport in Git populates the "push" entry in the
transport vtable. Remove this entry.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
I was taking a look at the
On Tue, 12 Dec 2017 11:57:28 -0800
Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > Makes sense. The patch looks scary by appearing to move the
> > includes far to the front of the Makefile, but it in fact is moving
> > the NO_DC_SHA1_SUBMODULE block
On Fri, 8 Dec 2017 14:30:10 -0800
Brandon Williams wrote:
> I just finished reading through parts 1-3. Overall I like the series.
> There are a few point's that I'm not a big fan of but i wasn't able to
> come up with a better alternative. One of these being the need for a
>
On Fri, 8 Dec 2017 04:55:11 -0500
Jeff King wrote:
> I have mixed feelings. On the one hand, compiling and running the code
> ensures that those things actually work. On the other hand, I expect you
> can make a much clearer example if instead of having running code, you
> show
Improve the names of the identifiers in decorate.h, document them, and
add an example of how to use these functions.
The example is compiled and run as part of the test suite.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
This patch contains some example code in a test
On Thu, 7 Dec 2017 11:18:52 -0800
Brandon Williams wrote:
> Instead of requiring that every test first removes 'repo', maybe you
> want to have each test do its own cleanup by adding in
> 'test_when_finished' lines to do the removals? Just a thought.
If "test_when_finished"
er effect than merely suppressing "have" lines. This
setting is described in patch 7 ("introduce fetch-object: fetch one
promisor object").
> Part 2 is concerned with fsck, gc, initial support for dynamic
> object fetching, and tracking promisor objects. Jonathan Tan
> or
On Mon, 04 Dec 2017 13:46:43 -0800
Junio C Hamano wrote:
> * jt/diff-anchored-patience (2017-11-28) 1 commit
> - diff: support anchoring line(s)
>
> "git diff" learned a variant of the "--patience" algorithm, to
> which the user can specify which 'unique' line to be used
Note that a few major parts are still missing:
- special handling of the current branch of the superproject
- writing (whether "refs/..." to the superproject as an index change or
a commit, or non-"refs/..." directly to the subproject like usual)
Signed-off-by: Jona
also describes what happens when the submodule attempts to write to
any "refs/..." ref.
For those interested, here's what such an implementation might look
like, and a test to demonstrate such functionality. I have partial
read-only functionality - a lot of it still remains to be done.
[1]
h
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
submodule.c | 76 +
submodule.h | 3 +++
2 files changed, 49 insertions(+), 30 deletions(-)
diff --git a/submodule.c b/submodule.c
index bb531e0e5..ce511180e
On Thu, 30 Nov 2017 01:36:37 +0100 (CET)
Johannes Schindelin <johannes.schinde...@gmx.de> wrote:
> Hi Jonathan,
>
> On Tue, 28 Nov 2017, Jonathan Tan wrote:
>
> > @@ -4607,7 +4627,14 @@ int diff_opt_parse(struct diff_options *options,
> > DIFF
ows existing scripts
and tools that use "-l0" to continue working. The alternative (to have
"-l0" suppress rename detection) is probably much less useful, since
users can just refrain from specifying -M and/or -C to have the same
effect.
Signed-off-by: Jonathan Tan <jonat
On Wed, 29 Nov 2017 10:51:20 -0800
Elijah Newren wrote:
> Thanks for testing that version and sending along the fix.
>
> I suspect the commit referenced twice in the commit message should
> have been 9f7e4bfa3b ("diff: remove silent clamp of renameLimit",
> 2017-11-13) rather
at it was previously. This allows existing scripts and
tools that use "-l0" to continue working. The alternative (to allow
"-l0") is probably much less useful, since users can just refrain from
specifying -M and/or -C to have the same effect.
Signed-off-by: Jonathan Tan <jonatha
Teach diff a new algorithm, one that attempts to prevent user-specified
lines from appearing as a deletion or addition in the end result. The
end user can use this by specifying "--anchored=" one or more
times when using Git commands like "diff" and "show".
Signed-of
Teach diff a new algorithm, one that attempts to prevent user-specified
lines from appearing as a deletion or addition in the end result. The
end user can use this by specifying "--anchored=" one or more
times when using Git commands like "diff" and "show".
Signed-of
On Thu, 23 Nov 2017 11:47:02 +0900
Junio C Hamano wrote:
> Thinking about this a bit more, I do like the basic idea of the UI
> even better. What we could do is to sell this to the end users as a
> new kind of diff algorithm choice (i.e. myers, patience, ... will
> gain a new
Teach the patience diff to attempt preventing user-specified lines from
appearing as a deletion or addition in the end result. The end user can
use this by specifying "--anchor=" one or more times when using
Git commands like "diff" and "show".
Signed-of
On Wed, Nov 22, 2017 at 10:00 AM, Jonathan Tan <jonathanta...@google.com> wrote:
> On Wed, 22 Nov 2017 14:25:13 +0900
> Junio C Hamano <gits...@pobox.com> wrote:
>
>> Thanks, will replace/queue all three series. I am getting a feeling
>> that the first one i
> > is already present. V5 includes minor cleanup over V4 and better
> > separates the --exclude-promisor-objects and --missing arguments.
> >
> > Part 2 is concerned with fsck, gc, initial support for dynamic
> > object fetching, and tracking promisor objects.
On Tue, 21 Nov 2017 20:58:46 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Here is V5 of the list-object filtering, rev-list, and pack-objects.
>
> This version addresses comments on the V4 series. I removed the
> questionable
Teach the patience diff to support prohibiting a user-specified line
from appearing as a deletion or addition in the end result.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
I'm sending this out to see if a change similar to this would be
welcome. It is useful to me as a re
sage. Some tests differ
slightly in their test assertions; I have used the superset of those
assertions in that case.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
I checked my work by using a custom diff patch to "anchor" one line into
never appearing as a minus/p
On Thu, 16 Nov 2017 18:17:08 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> This part 3 of a 3 part sequence partial clone. It assumes
> that part 1 and part 2 are in place.
>
> This patch series is labeled as V4 to keep it in sync with
I patched both this series and the first 9 patches of mine [1] on part 1
of the entire partial clone implementation [2], and then
diffed them. I'll review just the differences between the two.
You can see the entire diff below (minus means in my patch set but not
in Jeff's, plus means the
On Thu, 16 Nov 2017 18:07:42 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Teach rev-list to use the filtering provided by the
> traverse_commit_list_filtered() interface to omit
> unwanted objects from the result. This feature is
>
On Thu, 16 Nov 2017 18:07:41 +
Jeff Hostetler wrote:
> +/*
> + * Return 1 if the given string needs armoring because of "special"
> + * characters that may cause injection problems when a command passes
> + * the argument to a subordinate command (such as when
On Tue, 14 Nov 2017 16:30:43 -0800
Stefan Beller wrote:
> The walking is performed in reverse order to show the introduction of a
> blob rather than its last occurrence.
The code as implemented here does not do this - it instead shows the last
occurrence.
> NAME
>
>
On Tue, 14 Nov 2017 16:30:42 -0800
Stefan Beller wrote:
> In the next patch we'll learn how to describe more than just commits,
> so factor out describing commits into its own function. That will make
> the next patches easy as we still need to describe a commit as part of
>
On Tue, 14 Nov 2017 16:30:41 -0800
Stefan Beller wrote:
> For debuggers aid we'd want to print debug statements early, so
> introduce a new line in the debug output that describes the whole
> function, and then change the next debug output to describe why we
> need to search.
On Tue, 14 Nov 2017 16:30:39 -0800
Stefan Beller wrote:
> The change in list-objects.c is rather minimal as we'll be re-using
> the infrastructure put in place of the revision walking machinery. For
> example one could expect that add_pending_tree is not called, but rather
>
On Tue, 14 Nov 2017 12:40:03 -0800
Stefan Beller wrote:
> Thanks for the review!
>
> This series was written with the mindset, that a user would only ever
> want to describe bad blobs. (bad in terms of file size, unwanted content, etc)
>
> With the --reverse you only see
On Thu, 2 Nov 2017 12:41:48 -0700
Stefan Beller wrote:
> Sometimes users are given a hash of an object and they want to
> identify it further (ex.: Use verify-pack to find the largest blobs,
> but what are these? or [1])
>
> "This is an interesting endeavor, because
On Thu, 2 Nov 2017 12:41:46 -0700
Stefan Beller wrote:
> For debuggers aid we'd want to print debug statements early, so
> introduce a new line in the debug output that describes the whole
> function, and then change the next debug output to describe why we
> need to search.
On Thu, 2 Nov 2017 12:41:44 -0700
Stefan Beller wrote:
> @@ -239,6 +239,8 @@ void traverse_commit_list(struct rev_info *revs,
> if (commit->tree)
> add_pending_tree(revs, commit->tree);
> show_commit(commit, data);
> +
On Mon, 13 Nov 2017 12:15:58 -0800
Elijah Newren wrote:
> -static int display(struct progress *progress, unsigned n, const char *done)
> +static int display(struct progress *progress, uint64_t n, const char *done)
> {
> const char *eol, *tp;
>
> @@ -106,7 +106,7 @@
On Mon, 13 Nov 2017 12:15:58 -0800
Elijah Newren wrote:
> The possibility of setting merge.renameLimit beyond 2^16 raises the
> possibility that the values passed to progress can exceed 2^32.
> Use uint64_t, because it "ought to be enough for anybody". :-)
>
> Signed-off-by:
On Mon, 13 Nov 2017 18:13:27 +0100
Nicolas Morey-Chaisemartin wrote:
> v2:
> - Enhance mailinfo to parse patch series id from subject
> - Detect cover using mailinfo parsed ids in git am
I noticed that this was done in the patch set by searching for "PATCH" -
that is
On Fri, 20 Oct 2017 10:18:39 -0700
Brandon Williams wrote:
> Some of the pain points with the current protocol spec are:
After some in-office discussion, I think that the most important pain
point is that we have to implement each protocol twice: once for
HTTP(S), and once
On Fri, 10 Nov 2017 16:37:49 +0100
Nicolas Morey-Chaisemartin wrote:
> > Hi,
> >
> > I'm starting to look into the cover-at-tip topic that I found in the
> > leftover bits (http://www.spinics.net/lists/git/msg259573.html)
Thanks - I personally would find this very
On Wed, 8 Nov 2017 16:10:07 -0800
Stefan Beller wrote:
I thought of a possible alternative and how it would work.
> Possible data models and workflow implications
> ==
> In the following different data models are presented, which
On Wed, 8 Nov 2017 11:55:05 -0800
Stefan Beller wrote:
> $ git -c status.superprojectinfo status
> HEAD detached at v2.15-rc2
> superproject is 6 commits behind HEAD 7070ce2..5e6d0fb
> nothing to commit, working tree clean
>
> How cool is that?
>
> This series side
On Wed, 8 Nov 2017 15:32:21 -0500
Jeff Hostetler wrote:
> Thanks Jonathan.
>
> I moved my version of part 2 on top of yesterday's part 1.
> There are a few changes between my version and yours. Could
> you take a quick look at them and see if they make sense?
> (I'll
On Tue, 7 Nov 2017 19:35:46 +
Jeff Hostetler wrote:
> +--filter-ignore-missing:
> + Ignore missing objects without error. This may be used with
> + or without and of the above filtering.
There is a discussion about this parameter (and the corresponding ones
On Fri, 3 Nov 2017 14:34:39 -0400
Jeff Hostetler wrote:
> > Assuming we eventually get promisor support working, would there be
> > any use case where "any missing is OK" mode would be useful in a
> > sense more reasonable than "because we could have such a mode" and
> >
On Tue, 7 Nov 2017 19:35:44 +
Jeff Hostetler wrote:
> +/*
> + * Reject the arg if it contains any characters that might
> + * require quoting or escaping when handing to a sub-command.
> + */
> +static int reject_injection_chars(const char *arg)
> +{
[snip]
> +}
test_submodule_forced_switch() do not correctly handle the situation in
which a submodule is replaced with an ordinary directory.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
Thanks for the review.
Change from v1:
- changed commit message title
- moved a test to the common functi
test_submodule_forced_switch() do not correctly handle the situation in
which a submodule is replaced with an ordinary directory.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
I find tests that use lib-submodule-update.sh difficult to understand
due to the lack of clarity o
On Mon, 6 Nov 2017 12:32:45 -0500
Jeff Hostetler wrote:
> >> Yes, that is a point I wanted to ask about. I renamed the
> >> extensions.partialclone that you created and then I moved your
> >> remote..blob-max-bytes setting to be in extensions too.
> >> Moving it to
On Mon, 6 Nov 2017 12:51:52 -0500
Jeff Hostetler wrote:
> Jonathan and I were talking off-list about the performance
> effects of inspecting the pathnames to identify the ".git*"
> special files. I added it in my first draft back in the spring,
> thinking that even if you
I did some of my own investigation and have a working (i.e. passing
tests) version of this patch here:
https://github.com/jonathantanmy/git/commits/pc20171103
If you want, you can use that, or incorporate the changes therein here.
I'll also remark on my findings inline.
On Thu, 2 Nov 2017
On Thu, 2 Nov 2017 20:31:17 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Signed-off-by: Jeff Hostetler
> ---
> builtin/clone.c | 9 +
> builtin/fetch-pack.c | 4
> builtin/index-pack.c | 10
On Fri, 3 Nov 2017 09:57:18 -0400
Jeff Hostetler <g...@jeffhostetler.com> wrote:
> On 11/2/2017 6:24 PM, Jonathan Tan wrote:
> > On Thu, 2 Nov 2017 20:20:44 +
> > Jeff Hostetler <g...@jeffhostetler.com> wrote:
> >
> >> From: Jeff Hostetler &l
On Thu, 2 Nov 2017 20:31:15 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> This is part 3 of 3 for partial clone.
> It assumes that part 1 [1] and part 2 [2] are in place.
>
> Part 3 is concerned with the commands: clone, fetch,
On Thu, 2 Nov 2017 20:20:44 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Introduce the ability to have missing objects in a repo. This
> functionality is guarded by new repository extension options:
>
On Thu, 2 Nov 2017 17:50:07 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Here is V2 of the list-object filtering. It replaces [1]
> and reflect a refactoring and simplification of the original.
Thanks, overall this looks quite good. I
On Thu, 2 Nov 2017 17:50:11 +
Jeff Hostetler wrote:
> +int parse_list_objects_filter(struct list_objects_filter_options
> *filter_options,
> + const char *arg)
Returning void is fine, I think. It seems that all your code paths
either
On Wed, 01 Nov 2017 10:21:20 +0900
Junio C Hamano wrote:
> Jeff Hostetler writes:
>
> >> Yes, that, together with the expectation that I will hear from both you
> >> and JTan
> >> once the result of combined effort becomes ready to replace
On Tue, Oct 24, 2017 at 10:00 PM, Junio C Hamano wrote:
> OK, thanks for working well together. So does this (1) build on
> Jonathan's fsck-squelching series, or (2) ignores that and builds
> filtering first, potentially leaving the codebase to a broken state
> where it can
On Tue, Oct 24, 2017 at 11:53 AM, Jeff Hostetler <g...@jeffhostetler.com> wrote:
> From: Jeff Hostetler <jeffh...@microsoft.com>
>
> I've been working with Jonathan Tan to combine our partial clone
> proposals. This patch series represents a first step in that effort
&g
On Tue, Oct 24, 2017 at 11:53 AM, Jeff Hostetler wrote:
> static void finish_object(struct object *obj, const char *name, void
> *cb_data)
> {
> struct rev_list_info *info = cb_data;
> - if (obj->type == OBJ_BLOB && !has_object_file(>oid))
> + if
On Tue, Oct 24, 2017 at 11:53 AM, Jeff Hostetler wrote:
> +void traverse_commit_list_filtered(
> + struct list_objects_filter_options *filter_options,
> + struct rev_info *revs,
> + show_commit_fn show_commit,
> + show_object_fn show_object,
> +
On Tue, Oct 24, 2017 at 11:53 AM, Jeff Hostetler wrote:
> + * ::= blob:none
> + * blob:limit:[kmg]
> + * sparse:oid:
> + * sparse:path:
I notice in the code below that there are some usages of "=" instead
of ":" - could you clarify which one
On Tue, Oct 24, 2017 at 11:53 AM, Jeff Hostetler wrote:
> +enum list_objects_filter_result {
> + LOFR_ZERO = 0,
> + LOFR_MARK_SEEN = 1<<0,
Probably worth documenting, something like /* Mark this object so that
it is skipped for the rest of the traversal.
On Mon, 23 Oct 2017 15:51:06 -0700
Brandon Williams wrote:
> On 10/23, Jonathan Nieder wrote:
> > Separately from how to document it, what do you think a good behavior
> > would be? Should the "auto" configuration trigger command line based
> > detection just like no
On Mon, 23 Oct 2017 14:31:59 -0700
Jonathan Nieder wrote:
> @@ -2083,14 +2083,19 @@ visited as a result of a redirection do not
> participate in matching.
> ssh.variant::
> Depending on the value of the environment variables `GIT_SSH` or
> `GIT_SSH_COMMAND`, or
On Thu, 12 Oct 2017 04:14:18 +0900
小川恭史 wrote:
> Hello, I found a mistake in documents, fixed it, and send patch to mailing
> list.
>
> Sending patches by 'git send-email' with Gmail smtp seemed to be
> successful because CC included my email address and I received it.
On Tue, 3 Oct 2017 13:15:00 -0700
Brandon Williams wrote:
> +enum protocol_version determine_protocol_version_server(void)
> +{
> + const char *git_protocol = getenv(GIT_PROTOCOL_ENVIRONMENT);
> + enum protocol_version version = protocol_v0;
> +
> + /*
> + *
Document the server support for Extra Parameters, additional information
that the client can send in its first message to the server during a
Git client-server interaction.
Signed-off-by: Jonathan Tan <jonathanta...@google.com>
---
I noticed that Documentation/technical was not u
On Tue, 3 Oct 2017 13:15:04 -0700
Brandon Williams wrote:
> 2. ssh://, file://
>Set 'GIT_PROTOCOL' environment variable with the desired protocol
>version. With the file:// transport, 'GIT_PROTOCOL' can be set
>explicitly in the locally running git-upload-pack or
On Tue, 3 Oct 2017 13:15:02 -0700
Brandon Williams wrote:
> + switch (determine_protocol_version_server()) {
> + case protocol_v1:
> + if (advertise_refs || !stateless_rpc)
> + packet_write_fmt(1, "version 1\n");
> + /*
> +
On Tue, 3 Oct 2017 13:15:01 -0700
Brandon Williams wrote:
> /*
> * Read the host as supplied by the client connection.
The return value is probably worth documenting. Something like "Returns
a pointer to the character *after* the NUL byte terminating the host
argument, or
401 - 500 of 1061 matches
Mail list logo