Re: [PATCHv3 0/4] git-p4: fixing --changes-block-size handling

The latest patch series LGTM. It's a pity about the more complicated structure with two different ways to query the changes list, but it does look hard to make it any simpler. Lex Spoon -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCHv2 3/3] git-p4: fixing --changes-block-size handling

Precisely, Junio, that's what I had in mind. The patch with the two lines deleted LGTM. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv1 0/3] git-p4: fixing --changes-block-size support

be applying the low-level database queries that Perforce uses internally in its implementation. That makes the precise effect on external queries rather hard to predict. It likely also depends on the version of Perforce. Lex Spoon -- To unsubscribe from this list: send the line unsubscribe git

Re: [PATCHv1 3/3] git-p4: fixing --changes-block-size handling

by block_size. Several places that check if not block_size could just choose the other branch. Lex Spoon -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv1 1/3] git-p4: additional testing of --changes-block-size

I'll add in reviews since I touched similar code, but I don't know whether it's sufficient given I don't know the code very well. Anyway, these tests LGTM. Having a smaller test repository is fine, and the new tests for files outside the client spec are a great idea. -Lex -- To unsubscribe from

Re: [PATCHv1 2/3] git-p4: test with limited p4 server results

LGTM. That's great adding a user with the appropriate restrictions on it to really exercise the functionality. -Lex -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCHv2 3/3] git-p4: fixing --changes-block-size handling

Unless I am reading something wrong, the new_changes variable could be dropped now. It was needed for the -m version for detecting the smallest change number that was returned. Otherwise it looks good to me. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message

Re: [PATCH] git-p4: add failing tests for case-folding p4d

The last comment in the test took me a minute to decipher. I would suggest no repo path called LC instead of no repo called LC. Also, it would have helped me to either have a little comment on the UC version of the test, or to make the previous comment a little more neutral so that it will apply

[PATCH v4] git-p4: Use -m when running p4 changes

Simply running p4 changes on a large branch can result in a too many rows scanned error from the Perforce server. It is better to use a sequence of smaller calls to p4 changes, using the -m option to limit the size of each call. Signed-off-by: Lex Spoon l...@lexspoon.org Reviewed-by: Junio C

Re: [PATCH v3] git-p4: Use -m when running p4 changes

On Mon, Apr 20, 2015 at 5:53 AM, Luke Diamand l...@diamand.org wrote: I could be wrong about this, but it looks like importNewBranches() is taking an extra argument, but that isn't reflected in the place where it gets called. I think it just got missed. As a result, t9801-git-p4-branch.sh

Re: [PATCH v4] git-p4: Use -m when running p4 changes

a single patch that includes all changes so far discussed. The subject line says PATCH v4, although since it's in the same thread, not all email clients will show the subject change. Let me know if I can do more to make the process go smoothly. Lex Spoon -- To unsubscribe from this list: send the line

Re: [PATCH] git-p4: Use -m when running p4 changes

getting them to make it through email software. Thank you for your patience. test_seq is a neat utility. Also, I don't know why I didn't think to update the document page. Certainly it needs to be updated. Lex Spoon -- To unsubscribe from this list: send the line unsubscribe git in the body

[PATCH v3] git-p4: Use -m when running p4 changes

Simply running p4 changes on a large branch can result in a too many rows scanned error from the Perforce server. It is better to use a sequence of smaller calls to p4 changes, using the -m option to limit the size of each call. Signed-off-by: Lex Spoon l...@lexspoon.org Reviewed-by: Junio C

Re: [PATCH] git-p4: Use -m when running p4 changes

From 9cc607667a20317c837afd90d50c078da659b72f Mon Sep 17 00:00:00 2001 From: Lex Spoon l...@lexspoon.org Date: Sat, 11 Apr 2015 10:01:15 -0400 Subject: [PATCH] git-p4: Use -m when running p4 changes Signed-off-by: Lex Spoon l...@lexspoon.org --- Updated to include a test case git-p4.py

Re: [PATCH] git-p4: Use -m when running p4 changes

suggestion of how to configure the block size. Lex Spoon -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html