Re: [RFC PATCH v2 0/4] contrib/credential/netrc Makefile & test improvements

hor (Ted) to acknowledge before the maintainer (Junio) can approve. > Luis Marsano (2): > git-credential-netrc: use in-tree Git.pm for tests > git-credential-netrc: fix exit status when tests fail > > Todd Zullinger (2): > git-credential-netrc: make "all"

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

On Tue, Jun 12, 2018 at 11:08 PM Todd Zullinger wrote: > As far as removing the autodie dep, is there anything more > to that than dropping the 'use autodie' line? It looks like > doing so leaves us no worse than we were before, but I > haven't written any perl in a long time. Erasing that line

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

Thanks for looking into this and addressing these issues. On Thu, Jun 7, 2018 at 1:20 AM Todd Zullinger wrote: > > Hi, > > I noticed failures from the contrib/credential/netrc tests > while building 2.18.0 release candidates. I was surprised > to see the tests being run when called with a

Re: [PATCH 2/2] git-credential-netrc: accept gpg option

Junio C Hamano <gits...@pobox.com> wrote: > Luis Marsano <luis.mars...@gmail.com> writes: > > > git-credential-netrc was hardcoded to decrypt with 'gpg' regardless of the > > gpg.program option > > this now uses the gpg command option if set, else, the gp

Re: [PATCH 1/2] git-credential-netrc: adapt to test framework for git

Junio C Hamano <gits...@pobox.com> wrote: > Luis Marsano <luis.mars...@gmail.com> writes: > > > until this change, git-credential-netrc did not test in a repository > > this change reuses the main test framework, which provides such tests > > specific changes

[PATCH v2 2/2] git-credential-netrc: accept gpg option

tion placeholders according to main standards Signed-off-by: Luis Marsano <luis.mars...@gmail.com> Acked-by: Ted Zlatanov <t...@lifelogs.com> --- contrib/credential/netrc/git-credential-netrc | 58 --- .../netrc/t-git-credential-netrc.sh | 2 +- .../

[PATCH v2 1/2] git-credential-netrc: adapt to test framework for git

git-credential-netrc tests did not run in a test repository. Reuse the main test framework to stage a temporary repository. To imitate Perl tests under t/ - switch to Test::More module - use File::Basename & File::Spec::Functions Signed-off-by: Luis Marsano <luis.mars...@gmail.com> Ack

[PATCH v2 0/2] Configurable GnuPG command for git-credential-netrc

7:45 -0400) ---- Luis Marsano (2): git-credential-netrc: adapt to test framework for git git-credential-netrc: accept gpg option contrib/credential/netrc/Makefile | 4 +- contrib/credential/netrc/git-credential-netrc

[PATCH 1/2] git-credential-netrc: adapt to test framework for git

until this change, git-credential-netrc did not test in a repository this change reuses the main test framework, which provides such tests specific changes - switch to Test::More module - use File::Basename & File::Spec::Functions Signed-off-by: Luis Marsano <luis.mars...@gmail.com> Ack

[PATCH 2/2] git-credential-netrc: accept gpg option

and global option queries - add -g|--gpg command option & document it in command usage - test repository & command options - support unicode Signed-off-by: Luis Marsano <luis.mars...@gmail.com> Acked-by: Ted Zlatanov <t...@lifelogs.com> --- contrib/credential/netrc/git-c

[PATCH 0/2] Configurable GnuPG command for git-credential-netrc

Hi everyone, Should `contrib/` area patches go here, too? Contributed Software page https://git.kernel.org/pub/scm/git/git.git/tree/contrib/README says to forward them to "jc" (I'm guessing that's Junio), but I think they're getting missed. Though the component author approves (acknowledgement