RE: Git 2.13.0 segfaults on Solaris SPARC due to DC_SHA1=YesPlease being on by default

2017-05-15 Thread Marc Stevens
r m=0x398ad5 is odd. Can you confirm whether loading an uint32_t from an odd address triggers a hardware interrupt on your platform? This is not problem for x86, but maybe for your platform it is? If it is then we should always copy buffer contents to the sha1context to avoid this issue. Best r

Re: [PATCH] Put sha1dc on a diet

2017-03-16 Thread Marc Stevens
Hi all, Today I merged the perf-branch into master after code review and correctness testing. So master is now more performant and safe to use. -- Marc

Re: [PATCH] Put sha1dc on a diet

2017-03-13 Thread Marc Stevens
es not get fully recompiled and instead of the value of found_collision will read a different value of SHA1_CTX. So be careful to always do a 'make clean' for now. -- Marc - Original Message - From: "Jeff King" To: "Marc Stevens" Cc: "Linus Torval

Re: [PATCH] Put sha1dc on a diet

2017-03-13 Thread Marc Stevens
same. -- Marc - Original Message - From: "Linus Torvalds" To: "Marc Stevens" Cc: "Jeff King" , "Dan Shumow" , "Junio C Hamano" , "Git Mailing List" Sent: Monday, March 13, 2017 9:20:02 PM Subject: Re: [PATCH] Put sha1dc on

Re: [PATCH] Put sha1dc on a diet

2017-03-13 Thread Marc Stevens
itive probability is <<2^-90, almost non-existent. Best regards, Marc Stevens On 3/13/2017 8:48 PM, Jeff King wrote: > On Mon, Mar 13, 2017 at 07:42:17PM +, Dan Shumow wrote: > >> Marc just made a commit this morning fixing problems with the merge. >> Please give the

Re: SHA1 collisions found

2017-02-28 Thread Marc Stevens
anks for taking a close look at our code, this helps bringing the library in better shape also for other software projects. Best regards, Marc Stevens On 2/28/2017 10:22 PM, Dan Shumow wrote: > [Responses inline] > > No need to keep me "bcc'd" (though thanks for the consider