Re: [PATCH v5 15/15] config: rename git_config_set_or_die to git_config_set

On Wed, Feb 17, 2016 at 12:57 PM, Michael Blume <blume.m...@gmail.com> wrote: > On Tue, Feb 16, 2016 at 4:56 AM, Patrick Steinhardt <p...@pks.im> wrote: >> Rename git_config_set_or_die functions to git_config_set, leading >> to the new default behavior of dying whenev

Re: [PATCH v5 15/15] config: rename git_config_set_or_die to git_config_set

On Tue, Feb 16, 2016 at 4:56 AM, Patrick Steinhardt wrote: > Rename git_config_set_or_die functions to git_config_set, leading > to the new default behavior of dying whenever a configuration > error occurs. > > By now all callers that shall die on error have been transitioned > to

Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

On Fri, Jan 29, 2016 at 11:58 AM, Junio C Hamano wrote: > Matthias Aßhauer writes: > > [administrivia: please wrap your lines to reasonable lengths] > >>> Honestly, I had high hopes after seeing the "we are rewriting it >>> in C" but I am not enthused after

Re: [PATCH 2/2] rebase: fix preserving commits with --keep-empty

This test does not seem to pass on my mac. I've placed the verbose output here: https://gist.github.com/MichaelBlume/db7ba222be001d502e57 On Fri, Nov 20, 2015 at 4:04 AM, Patrick Steinhardt wrote: > When rebasing commits where one or several commits are redundant > to commits on

Re: [PATCH v2 34/43] refs.c: make struct ref_transaction generic

This triggers a lot of build warnings on my mac, basically in every file that uses refs.h: CC archive.o In file included from archive.c:2: ./refs.h:635:16: warning: redefinition of typedef 'ref_transaction_free_fn' is a C11 feature [-Wtypedef-redefinition] typedef void

Re: [PATCH 41/68] init: use strbufs to store paths

On Thu, Sep 24, 2015 at 2:07 PM, Jeff King wrote: > The init code predates strbufs, and uses PATH_MAX-sized > buffers along with many manual checks on intermediate sizes > (some of which make magic assumptions, such as that init > will not create a path inside .git longer than 50 >

Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error

I'm seeing test failures non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh ls -l shows that all the other tests are executable but t9825 isn't. On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano wrote: > Lars Schneider writes: > >> This

Re: 'make test' fails in pu

For the record, that commit also sporadically breaks test 3910 on my system (mentioning since it's not on the list) On Tue, Feb 17, 2015 at 12:55 AM, Jeff King p...@peff.net wrote: On Tue, Feb 17, 2015 at 09:39:17AM +0100, Dennis Kaarsemaker wrote: Make test has been failing for 'pu' yesterday

Re: [PATCH 21/21] t3080: tests for git-list-files

On Wed, Jan 28, 2015 at 2:19 AM, Duy Nguyen pclo...@gmail.com wrote: On Wed, Jan 28, 2015 at 11:44 AM, Michael Blume blume.m...@gmail.com wrote: Test 3 is failing on my mac: expecting success: test_config color.ls.file red test_config color.ls.directory green test_config

Re: [PATCH 21/21] t3080: tests for git-list-files

Test 3 is failing on my mac: expecting success: test_config color.ls.file red test_config color.ls.directory green test_config color.ls.submodule yellow git list-files --color=always actual test_cmp $TEST_DIRECTORY/t3080/color_ls actual --- /Users/michael.blume/workspace/git/t/t3080/color_ls

Git compile warnings (under mac/clang)

These are probably minor, I only bring them up because Git's build is generally so quiet that it might be worth squashing these too. CC fsck.o fsck.c:110:38: warning: comparison of unsigned enum expression = 0 is always true [-Wtautological-compare] if (options-msg_severity msg_id =

Re: Segmentation fault in git apply

On Wed, Jan 14, 2015 at 10:44 AM, Michael Blume blume.m...@gmail.com wrote: On Wed, Jan 14, 2015 at 10:40 AM, Michael Blume blume.m...@gmail.com wrote: On Wed, Jan 14, 2015 at 10:20 AM, Michael Blume blume.m...@gmail.com wrote: This is a mac with a fresh build of git from pu branch, commit

Re: Segmentation fault in git apply

On Wed, Jan 14, 2015 at 10:48 AM, Michael Blume blume.m...@gmail.com wrote: On Wed, Jan 14, 2015 at 10:44 AM, Michael Blume blume.m...@gmail.com wrote: On Wed, Jan 14, 2015 at 10:40 AM, Michael Blume blume.m...@gmail.com wrote: On Wed, Jan 14, 2015 at 10:20 AM, Michael Blume blume.m

Segmentation fault in git apply

This is a mac with a fresh build of git from pu branch, commit 53b80d0. With my gitconfig looking like [user] email = blume.m...@gmail.com name = Michael Blume [apply] whitespace = fix [core] whitespace = fix,trailing-space,space-before-tab, tab-in-indent, tabwidth=4 If I run

Re: Segmentation fault in git apply

On Wed, Jan 14, 2015 at 10:20 AM, Michael Blume blume.m...@gmail.com wrote: This is a mac with a fresh build of git from pu branch, commit 53b80d0. With my gitconfig looking like [user] email = blume.m...@gmail.com name = Michael Blume [apply] whitespace = fix [core

Re: Segmentation fault in git apply

On Wed, Jan 14, 2015 at 10:40 AM, Michael Blume blume.m...@gmail.com wrote: On Wed, Jan 14, 2015 at 10:20 AM, Michael Blume blume.m...@gmail.com wrote: This is a mac with a fresh build of git from pu branch, commit 53b80d0. With my gitconfig looking like [user] email = blume.m

Re: [PATCH v3 2/4] rev-list: add an option to mark fewer edges as uninteresting

This patch causes an error on my mac, test 5500 fetch-pack errors on part 44 - fetch creating new shallow root. It looks for remote: Total 1 in the fetch output and gets 3 instead. On Tue, Dec 23, 2014 at 7:01 AM, brian m. carlson sand...@crustytoothpaste.net wrote: In commit fbd4a70

Re: [RFC/PATCH] pkt-line: allow writing of LARGE_PACKET_MAX buffers

On Tue, Dec 9, 2014 at 2:41 PM, Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: On Tue, Dec 09, 2014 at 12:49:58PM -0500, Jeff King wrote: Another option would be to use a static strbuf. Then we're only wasting heap, and even then only as much as we need (we'd still

Accept-language test fails on Mac OS

Test #25 'git client sends Accept-Language based on LANGUAGE, LC_ALL, LC_MESSAGES and LANG' in t5550 fails consistently on my mac, and has since the test was introduced. Test 26 and 27 ('git client sends Accept-Language with many preferred languages' and 'git client does not send Accept-Language')

Re: Accept-language test fails on Mac OS

On Fri, Dec 5, 2014 at 2:51 PM, Junio C Hamano gits...@pobox.com wrote: Michael Blume blume.m...@gmail.com writes: Test #25 'git client sends Accept-Language based on LANGUAGE, LC_ALL, LC_MESSAGES and LANG' in t5550 fails consistently on my mac, and has since the test was introduced. Test 26

no-xmailer tests fail under Mac OS

Failures start from commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad) Author: Luis Henriques hen...@camandro.org Date: Thu Dec 4 19:11:30 2014 + test/send-email: --[no-]xmailer tests Add tests for the --[no-]xmailer option. Signed-off-by: Luis Henriques

Re: no-xmailer tests fail under Mac OS

On Fri, Dec 5, 2014 at 9:34 PM, Jeff King p...@peff.net wrote: On Fri, Dec 05, 2014 at 06:05:24PM -0800, Michael Blume wrote: Failures start from commit d2384abff7a6181fd7b9a51af7e780aa21e5cb8d (refs/bisect/bad) Author: Luis Henriques hen...@camandro.org Date: Thu Dec 4 19:11:30 2014

Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

On Wed, Dec 3, 2014 at 1:37 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: @@ -515,6 +517,9 @@ void http_cleanup(void) cert_auth.password = NULL; } ssl_cert_password_required = 0; + + if

Re: [PATCH v5 1/1] http: Add Accept-Language header if possible

On Wed, Dec 3, 2014 at 2:00 PM, Michael Blume blume.m...@gmail.com wrote: On Wed, Dec 3, 2014 at 1:37 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: @@ -515,6 +517,9 @@ void http_cleanup(void) cert_auth.password = NULL

Re: Deprecation warnings under XCode

On Tue, Dec 2, 2014 at 4:37 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Mon, Dec 1, 2014 at 1:04 PM, Junio C Hamano gits...@pobox.com wrote: Torsten Bögershausen tbo...@web.de writes: On 12/01/2014 04:02 AM, Michael Blume wrote: I have no idea whether this should concern anyone

Deprecation warnings under XCode

I have no idea whether this should concern anyone, but my mac build of git shows CC imap-send.o imap-send.c:183:36: warning: 'ERR_error_string' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations] fprintf(stderr, %s: %s\n, func, ERR_error_string(ERR_get_error(),

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

My understanding is that and || have equal precedence, and this seems to be borne out in testing at my shell. If the if/then method is clearer I'm happy to go with that. On Fri, Nov 14, 2014 at 11:23 AM, Johannes Sixt j...@kdbg.org wrote: Am 13.11.2014 um 23:40 schrieb Mike Blume: listed bug

Re: [PATCH v2] allow TTY tests to run under recent Mac OS

Right, I missed that there was more going on above, thanks =) On Fri, Nov 14, 2014 at 12:02 PM, Jeff King p...@peff.net wrote: On Fri, Nov 14, 2014 at 11:48:36AM -0800, Michael Blume wrote: My understanding is that and || have equal precedence, and this seems to be borne out in testing at my

Re: [PATCH] allow TTY tests to run under recent Mac OS

ah, sorry, didn't realize those were bash-only On Thu, Nov 13, 2014 at 2:21 PM, Junio C Hamano gits...@pobox.com wrote: Mike Blume blume.m...@gmail.com writes: listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable TTY on Yosemite and higher Signed-off-by: Mike Blume

mac test failure -- 2gb clone

This is in pu, haven't checked if it's also in master, this is the first time I've run this test $ GIT_TEST_CLONE_2GB=t ./t5705-clone-2gb.sh -v Initialized empty Git repository in /Users/michael.blume/workspace/git/t/trash directory.t5705-clone-2gb/.git/ expecting success: git config

Re: mac test failure -- 2gb clone

Confirmed exists on master On Wed, Nov 12, 2014 at 1:57 PM, Michael Blume blume.m...@gmail.com wrote: This is in pu, haven't checked if it's also in master, this is the first time I've run this test $ GIT_TEST_CLONE_2GB=t ./t5705-clone-2gb.sh -v Initialized empty Git repository in /Users

TTY tests are unnecessarily suppressed under Mac OS

From lib_terminal.sh: # Reading from the pty master seems to get stuck _sometimes_ # on Mac OS X 10.5.0, using Perl 5.10.0 or 5.8.9. # # Reproduction recipe: run # # i=0 # while ./test-terminal.perl echo hi $i # do # : $((i = $i + 1)) # done # # After 2000 iterations or so it hangs. #

mac test failure -- test 3301

the commit modernizing test 3301 (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it on my mac Verbose output follows: $ ./t3301-notes.sh -v Initialized empty Git repository in /Users/michael.blume/workspace/git/t/trash directory.t3301-notes/.git/ expecting success:

Re: mac test failure -- test 3301

(to be clear: I ran git bisect, and traced the problem to the modernize commit) On Mon, Nov 10, 2014 at 4:17 PM, Michael Blume blume.m...@gmail.com wrote: the commit modernizing test 3301 (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it on my mac Verbose output follows

Re: mac test failure -- test 3301

my first thought was that this might be a bash versioning issue, since the commit in question basically refactors the script, and macs ship with an archaic version of bash, but I have the same problem with bash 4.3.30 On Mon, Nov 10, 2014 at 4:23 PM, Michael Blume blume.m...@gmail.com wrote

Re: mac test failure -- test 3301

, Johan Herland jo...@herland.net wrote: On Tue, Nov 11, 2014 at 2:19 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Mon, Nov 10, 2014 at 7:17 PM, Michael Blume blume.m...@gmail.com wrote: the commit modernizing test 3301 (https://github.com/git/git/commit/fbe4f74865acfd) appears to break

Re: [PATCH] t1410: fix breakage on case-insensitive filesystems

and a working tree path. We could fix this by using a -- to disambiguate, but we are probably better off using names that are less confusing to make it more clear that they are unrelated to the working tree files. This patch turns a/b into one/two. Reported-by: Michael Blume blume.m

Re: [PATCH] t1410: fix breakage on case-insensitive filesystems

{ \ ^ progress.c:264:2: error: expected '}' } ^ progress.c:50:1: note: to match this '{' { ^ 2 warnings and 6 errors generated. make: *** [progress.o] Error 1 On Sun, Nov 9, 2014 at 12:04 PM, Torsten Bögershausen tbo...@web.de wrote: On 09.11.14 18:34, Michael Blume wrote

Re: [PATCH] t1410: fix breakage on case-insensitive filesystems

breakage(s) # failed 4 among remaining 6 test(s) 1..7 On Sun, Nov 9, 2014 at 1:42 PM, Torsten Bögershausen tbo...@web.de wrote: On 2014-11-09 22.36, Michael Blume wrote: Actually I have a build break in pu on my mac right now. Seems to build fine in ubuntu, but: progress.c:66:15: error: use

Test failure

I'm on a macbook running a beta of Mac OS Yosemite 10.10.1. I've never been able to get GETTEXT to work so I have NO_GETTEXT=1 in my makefile, but other than that I'm using the master branch of the official github mirror. When I build and run tests I get

Re: Test failure

from master expect # git log -g --format=%gd %gs a actual # test_cmp expect actual # On Sat, Nov 8, 2014 at 5:43 PM, Jeff King p...@peff.net wrote: On Sat, Nov 08, 2014 at 11:28:32AM -0800, Michael Blume wrote: When I build and run tests I get [11:17][michael.blume@tcc-michael-4:~/workspace