On Tue, Oct 27, 2015 at 6:54 PM, Junio C Hamano wrote:
> Kyle Meyer writes:
>
>> When a ".git" file points to another repo, a ".git/gitdir" file is
>> created in that repo.
>>
>> For example, running
>>
>> $ mkdir repo-a repo-b
>> $ cd repo-a
>> $ git init
>> $ cd ../repo-b
>>
On Tue, Nov 3, 2015 at 11:58 AM, Nicolas Morey-Chaisemartin
wrote:
> Hi,
>
> There seem to be an issue with the path computed for a worktree when multiple
> worktree were created (using git worktree)
> In my Setup, I have 3 repos:
> A/repo (main One)
> A/repo-patches (worktree, using branch dev)
On Tue, Nov 3, 2015 at 5:27 PM, Mike Rappazzo wrote:
> On Tue, Nov 3, 2015 at 11:58 AM, Nicolas Morey-Chaisemartin
> wrote:
>> Hi,
>>
>> There seem to be an issue with the path computed for a worktree when
>> multiple worktree were created (using git worktree)
--ancestry-path v1.2..HEAD".
If your branch had been merged into v1.2, and you merged v1.2 back, then
you would have a lower count. One way to look at it is that the count
tells you how much your branch differs from the tag, and 97 is a more
realistic indicator of the amount of difference be
On Wed, Nov 11, 2015 at 5:41 AM, Michael J Gruber
wrote:
> Michael Rappazzo venit, vidit, dixit 11.11.2015 03:11:
>> This patch series is built on (based on) 'next' because it relies on
>> worktree.c
>>
>> `ff-refs` will update local branches which can be fast-forwarded to their
>> upstream tracki
on of --recurse-submodules=no to
allow the configuration to be overridden on the command line when
required.
The most straightforward way to implement this appears to be to make
push use code in submodule-config in a similar way to fetch.
Signed-off-by: Mike Crowe
---
Documentation/config.txt
git add gar/bage &&
> > + git commit -m "Recurse on-demand on command line for
> > gar/bage" &&
> > + git push --recurse-submodules=on-demand ../pub.git master &&
> > + # Check that the supermod
on of --recurse-submodules=no to
allow the configuration to be overridden on the command line when
required.
The most straightforward way to implement this appears to be to make
push use code in submodule-config in a similar way to fetch.
Signed-off-by: Mike Crowe
---
Documentation/config.txt
On Tue, Nov 17, 2015 at 10:28 AM, Michael J Gruber
wrote:
> Mike Rappazzo venit, vidit, dixit 17.11.2015 14:58:
>
> I still don't like the idea of having a new command just for the purpose
> of fast-forwarding local branches from specified upstreams.
>
> What's wro
On Monday 30 November 2015 at 10:31:26 -0800, Junio C Hamano wrote:
> Mike Crowe writes:
>
> > diff --git a/builtin/push.c b/builtin/push.c
> > index 3bda430..dfced74 100644
> > --- a/builtin/push.c
> > +++ b/builtin/push.c
> > @@ -9,6 +9,7 @@
> > #
-submodules=no to allow
the configuration to be overridden on the command line when required.
The most straightforward way to implement this appears to be to make
push use code in submodule-config in a similar way to fetch.
Signed-off-by: Mike Crowe
---
Changes in v3:
* Incorporate feedback from
On Tuesday 01 December 2015 at 19:40:32 -0500, Jeff King wrote:
> On Tue, Dec 01, 2015 at 11:49:43AM +0000, Mike Crowe wrote:
>
> > The --recurse-submodules command line parameter has existed for some
> > time but it has no config file equivalent.
> >
> > Following
one winning. (This simplified the implementation too.)
Also slightly improve one of the tests added in
b33a15b08131514b593015cb3e719faf9db20208.
Signed-off-by: Mike Crowe
---
builtin/push.c | 12 +++-
t/t5531-deep-submodule-push.sh | 36
On Wednesday 02 December 2015 at 15:21:13 -0800, Junio C Hamano wrote:
> Mike Crowe writes:
>
> > b33a15b08131514b593015cb3e719faf9db20208 added support for the
> > push.recurseSubmodules config option. After it was merged Junio C Hamano
> > suggested some improvem
Use the "last one wins" convention for --recurse-submodules rather than
treating conflicting options as an error.
Also, fix the declaration of the file-scope recurse_submodules global
variable to put it on a separate line.
Signed-off-by: Mike Crowe
---
builtin/push.c
message.
Signed-off-by: Mike Crowe
---
t/t5531-deep-submodule-push.sh | 32
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/t/t5531-deep-submodule-push.sh b/t/t5531-deep-submodule-push.sh
index 9fda7b0..721be32 100755
--- a/t/t5531-deep-submodule
On Sun, Dec 13, 2015 at 9:15 AM, Daniel Fahlke wrote:
> It seems my Patch got no attention yet, is there anything wrong?
> Do I need to ping someone in particular?
>
gitk patches should cc +Paul Mackerras who maintains gitk
--
To unsubscribe from this list: send the line "unsubscribe git" in
the
;
> I want to say more, but I'm going to hold back right now. There's more
> going on in my head than just this.
>
> > Of course, the lack of reachability has advantages, too. You can
> > drop commits pointed to by old reflogs without rewriting the ref
> > his
Git 2.6.4 is:
```
?? .gitignore
?? a/
```
The output with Git 2.7.0 is:
```
?? .gitignore
```
Let me know if you need any more information, thanks!
Mike McQuaid
http://mikemcquaid.com--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord..
in my example is pretty awful;
it’s also a big area where libgit2 was inconsistent with Git’s behaviour on
either of those versions too. I’ve played around and now got a .gitignore file
that behaves consistently across Git 2.6, Git 2.7 and libgit2 0.23.4
(https://github.com/Homebrew/homebrew/b
On Wed, Jan 20, 2016 at 02:05:22PM -0800, Junio C Hamano wrote:
> Mike Hommey writes:
>
> > On Mon, Jan 18, 2016 at 07:54:21PM -0800, Junio C Hamano wrote:
> >
> >> Hmm, sorry. For the two-trait example I gave (that can be extended
> >> to N-trait), I can sor
k_sha1_signature?
Mike
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 02, 2016 at 10:57:01AM +0900, Mike Hommey wrote:
> Hi,
>
> You might or might not be aware of this thread:
> https://groups.google.com/forum/#!topic/binary-transparency/f-BI4o8HZW0
>
> Anyways, this got me to take a look around, and I noticed that
> parse_object
On Mon, Feb 01, 2016 at 07:10:04PM -0800, Junio C Hamano wrote:
> Mike Hommey writes:
>
> > Shouldn't parse_object_buffer also do check_sha1_signature?
>
> In general, it shouldn't; its callers are supposed to do it as
> additional check when/if needed. Caller
it needs to be coupled with making the branch-creation
> process more robust to races (since we might create "refs/heads/foo" in
> order to make "refs/heads/foo/bar" while somebody else is deleting it to
> get rid of "refs/heads/foo/baz").
Can't we come up w
On Thu, Feb 04, 2016 at 03:17:59AM -0500, Jeff King wrote:
> On Thu, Feb 04, 2016 at 05:12:20PM +0900, Mike Hommey wrote:
>
> > > > It seems like git branch -d ascend the hierarchy (up to
> > > > .git/refs/heads/), deleting any empty directories.
> > >
&
n the number of items read
or written. This number equals the number of bytes transferred
only when size is 1. If an error occurs, or the end of the file
is reached, the return value is a short item count (or zero).
Signed-off-by: Mike Hommey
---
http.c | 12 ++--
1 file chang
ter handling of mercurial branchmap tips.
- Better support for end of parts in bundle v2.
- Improvements handling urls to local mercurial repositories.
- Fixed compatibility with (very) old mercurial servers when using mercurial
5.0 libraries.
- Converted Continuous Integration scripts to Python 3.
Mike
e (which, in fact, could be more useful in other
cases). It seems like it should call xmmap_gently instead.
Cheers,
Mike
On Wed, May 15, 2019 at 07:59:49PM +0200, Johannes Sixt wrote:
> Am 15.05.19 um 13:43 schrieb Ævar Arnfjörð Bjarmason:
> >
> > On Wed, May 15 2019, Mike Hommey wrote:
> >
> >> Hi,
> >>
> >> I started getting a weird error message during some t
d, which means close() is called with
an invalid fd (since it was already closed as per above). Or worse, with
a valid fd owned by something else (since fd numbers can be reused).
Signed-off-by: Mike Hommey
---
transport-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
use_pack has its own error message on mmap error, but it can't be
reached when using xmmap, which dies with its own error.
Signed-off-by: Mike Hommey
---
packfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packfile.c b/packfile.c
index 16bcb75262..6a66b605e9 1
On Wed, May 15, 2019 at 07:53:40PM -0400, Jeff King wrote:
> On Thu, May 16, 2019 at 07:08:34AM +0900, Mike Hommey wrote:
>
> > > >> - Except, well, fds being what they are, we in fact just closed a fd
> > > >> from a packed_git->pack_fd. So, when use_pac
On Wed, May 15, 2019 at 07:56:09PM +0900, Mike Hommey wrote:
> Hi,
>
> I started getting a weird error message during some test case involving
> git-cinnabar, which is a remote-helper to access mercurial
> repositories.
>
> The error says:
> fatal: mmap failed: Bad file d
eam it's offered to use, but can't be a fetch helper
either)
Mike
On Thu, May 16, 2019 at 05:47:52PM -0400, Jeff King wrote:
> On Thu, May 16, 2019 at 05:35:19PM +0900, Mike Hommey wrote:
>
> > On Wed, May 15, 2019 at 11:28:02PM -0400, Jeff King wrote:
> > > Totally orthogonal, but I think we might also want to introduce a helper
> >
dig into this, but if someone familiar with the
algorithm could give me some hints as to what I might be missing in the
big picture, that would be helpful.
Cheers,
Mike
On Sat, May 18, 2019 at 03:50:05AM +0200, SZEDER Gábor wrote:
> On Sat, May 18, 2019 at 09:54:12AM +0900, Mike Hommey wrote:
> > There are established corner cases, where in a repo where commit dates
> > are not monotonically increasing, revision walking can go horribly
>
On Sat, May 18, 2019 at 12:58:28PM +0900, Mike Hommey wrote:
> On Sat, May 18, 2019 at 03:50:05AM +0200, SZEDER Gábor wrote:
> > On Sat, May 18, 2019 at 09:54:12AM +0900, Mike Hommey wrote:
> > > There are established corner cases, where in a repo where commit dates
> >
e to me, so I added some log messages to expand_topo_walk()
> and notices we were walking the UNINITERESTING commits. This is part
> of the reason the new logic is slower for A..B commands, but not the
> whole reason.
>
> You'll want this patch as well for a test.
Both patches help, thanks.
Mike
2019 +
stash: convert show to builtin
which I guess makes sense :)
Mike
On Sat, Jun 15, 2019 at 12:26:18PM +0100, Thomas Gummerer wrote:
> On 06/14, Mike Hommey wrote:
> > Hi,
> >
> > `git stash ` where n is a number used to work until 2.21.*.
> > It doesn't work in 2.22.0.
> >
> > Bisection points to:
> >
> &g
bout _the_ URL.
The only thing that seems to be talking about this is the documentation
for git-remote, which has --add for set-url. There doesn't seem to be any
documentation about what conditions are required for the non-primary URL
to be used.
Mike
good state.
- Avoid git cinnabar sometimes thinking the helper is not up-to-date
when it is.
- Removing bookmarks on a Mercurial server is now working properly.
Mike
m/mozilla/gecko
2.
https://docs.google.com/spreadsheets/d/1IE8E3BhKurXsXgwBYFXs4mRBT_512v--ip6Vhxc3o-Y/edit?usp=sharing
3. https://public-inbox.org/git/20180703223823.qedmoy2imp4dc...@glandium.org/T/
Any thoughts?
Mike
On Thu, Jul 04, 2019 at 12:04:11PM +, Eric Wong wrote:
> Mike Hommey wrote:
> > I'm puzzled by the fact writing objects is so much faster with 1 thread.
>
> I/O contention in the multi-threaded cases?
>
> "public-inbox-index" (reading from git, writing
On Thu, Jul 04, 2019 at 07:05:30PM +0900, Mike Hommey wrote:
> Hi,
>
> I was looking at the disk size of the gecko repository on github[1],
> which started at 4.7GB, and `git gc --aggressive`'d it, which made that
> into 2.0G. But to achieve that required quite some reso
On Thu, Jul 04, 2019 at 07:05:30PM +0900, Mike Hommey wrote:
> My guess is all those stalls are happening when processing the files I
> already had problems with in the past[3], except there are more of them
> now (thankfully, they were removed, so there won't be more, but that
>
On Fri, Jul 05, 2019 at 01:09:55AM -0400, Jeff King wrote:
> On Thu, Jul 04, 2019 at 07:05:30PM +0900, Mike Hommey wrote:
> > Finally, with 1 thread, the picture changes greatly. The overall process
> > takes 2.5h:
> > - 50 seconds enumerating and counting objects.
> >
On Fri, Jul 05, 2019 at 01:14:13AM -0400, Jeff King wrote:
> On Thu, Jul 04, 2019 at 10:13:20PM +0900, Mike Hommey wrote:
>
> > > "public-inbox-index" (reading from git, writing to Xapian+SQLite)
> > > on a dev machine got slow because core count exceeded what
On Fri, Jul 05, 2019 at 02:45:16PM +0900, Mike Hommey wrote:
> On Fri, Jul 05, 2019 at 01:09:55AM -0400, Jeff King wrote:
> > On Thu, Jul 04, 2019 at 07:05:30PM +0900, Mike Hommey wrote:
> > > Finally, with 1 thread, the picture changes greatly. The overall process
> >
ded up doing `git rebase
--continue` in that shell in many cases, which didn't end up so well
when I terminated said shell (just an error message, though, nothing
actually broke as a consequence). This feature is a blessing.
Mike
The pkt-line formatted lines contained the wrong pkt-len.
Signed-off-by: Mike Hommey
---
Documentation/technical/pack-protocol.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/technical/pack-protocol.txt
b/Documentation/technical/pack-protocol.txt
ithout a git repack.
For one-shot conversions, you can just rely on git repack.
Mike
patch for git itself. But that doesn't quite address the nitpick case
where ETC_GITCONFIG could be either `/etc/gitconfig` or
`etc/gitconfig` depending how git was compiled, and there's no way to
know which is the right one.
WDYT?
Mike
On Fri, Mar 22, 2019 at 02:39:43PM +0100, Johannes Schindelin wrote:
> Hi Peff & Mike,
>
> On Fri, 22 Mar 2019, Jeff King wrote:
>
> > On Wed, Mar 20, 2019 at 07:19:41PM +0900, Mike Hommey wrote:
> >
> > > I thought of a few options (it's worth noting
the question is
whether there's a reason this shouldn't run in the background? Another
is whether there's something that makes this slower than it should be.
Mike
own issue on macOS specifically on large repos is that
the number of files explodes the inode cache in the kernel, and lstat
becomes slow.
e.g.
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/p9U4jqz8kxo
Mike
n the number of items read
or written. This number equals the number of bytes transferred
only when size is 1. If an error occurs, or the end of the file
is reached, the return value is a short item count (or zero).
Signed-off-by: Mike Hommey
---
http.c | 12 ++--
1 file chang
On Thu, Dec 13, 2018 at 3:23 PM Duy Nguyen wrote:
>
> On Thu, Dec 13, 2018 at 8:56 PM Michael Rappazzo via GitGitGadget
> wrote:
> >
> > From: Michael Rappazzo
> >
> > On a worktree which is not the primary, using the symbolic-ref 'head' was
> > incorrectly pointing to the main worktree's HEAD.
On Thu, Dec 13, 2018 at 3:43 PM Duy Nguyen wrote:
>
> On Thu, Dec 13, 2018 at 9:34 PM Mike Rappazzo wrote:
> >
> > On Thu, Dec 13, 2018 at 3:23 PM Duy Nguyen wrote:
> > >
> > > On Thu, Dec 13, 2018 at 8:56 PM Michael Rappazzo via GitGitGadget
> > >
On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller wrote:
>
> > > The current situation is definitely a problem. If I am in a worktree,
> > > using "head" should be the same as "HEAD".
>
> By any chance, is your file system case insensitive?
> That is usually the source of confusion for these discussi
on.
>
> You can do
>
> git clone --no-checkout --filter=blob:none $url repo
TIL. Why doesn't --filter appear in the git-clone manual page?
Mike
command_buf.buf is also stored in cmd_hist, so instead of
strbuf_release, the current code uses strbuf_detach in order to
"leak" the buffer as far as the strbuf is concerned.
However, strbuf_detach does more than "leak" the strbuf buffer: it
possibly reallocates it to ensure a terminating nul char
When add_note is called multiple times with the same key/value pair, the
leaf_node it creates is leaked by notes_tree_insert.
---
notes.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/notes.c b/notes.c
index 75c028b300..ec35f5b551 100644
--- a/notes.c
+++ b/notes.c
@@ -269
On Sun, Aug 25, 2019 at 02:57:48AM -0400, Jeff King wrote:
> On Sun, Aug 25, 2019 at 01:13:48PM +0900, Mike Hommey wrote:
>
> > command_buf.buf is also stored in cmd_hist, so instead of
> > strbuf_release, the current code uses strbuf_detach in order to
> > "leak&quo
_next_command() will invalidate any held pointers, making it easier
> to find bugs. In fact, we can drop the extra input lines added to the
> test case by the previous commit, as the unfixed bug would now trigger
> just from reading the commit message, even without any modified files in
>
On Sun, Aug 25, 2019 at 02:18:18PM +0900, Mike Hommey wrote:
> When add_note is called multiple times with the same key/value pair, the
> leaf_node it creates is leaked by notes_tree_insert.
For completeness, since I realized it was missing:
Signed-off-by: Mike Hommey
Mike
The index field in the commit object is used to find the buffer
corresponding to that commit in the buffer_slab. Resetting it first
means free_commit_buffer is not going to free the right buffer.
Signed-off-by: Mike Hommey
---
commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Signed-off-by: Mike Hommey
---
packfile.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
Note, I'm not sure this is the right place to do it.
diff --git a/packfile.c b/packfile.c
index fc43a6c52c..b0cb84adda 100644
--- a/packfile.c
+++ b/packfile.c
@@ -339,13 +339,16 @@
Signed-off-by: Mike Hommey
---
http.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/http.c b/http.c
index 27aa0a3192..9e33584f2d 100644
--- a/http.c
+++ b/http.c
@@ -1073,6 +1073,7 @@ void http_init(struct remote *remote, const char *url,
int proactive_auth)
git_config
vel enough that I don't know any other library that would work for
my use case. Another is that I was hoping that in the long term, it
could be merged into git.git. I guess the more time passes, the less
likely the latter is to happen. Which is fine, but it's good to know.
Mike
On Mon, Aug 26, 2019 at 11:06:29AM -0700, Junio C Hamano wrote:
> Mike Hommey writes:
>
> > Signed-off-by: Mike Hommey
> > ---
> > packfile.c | 11 +++
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > Note, I'm not sure this i
On Mon, Aug 26, 2019 at 11:14:13AM -0700, Junio C Hamano wrote:
> Mike Hommey writes:
>
> > First, revision.c doesn't come with a function to clear a struct
> > rev_info
> > Then, revision.c kind of does nasty things to commit objects...
>
> Yeah, these
commit'
Recorded preimage for 'taskcluster/ci/build/linux.yml'
(... this is where I fix my conflict ...)
$ git add -u
$ git cherry-pick --continue
error: cannot cherry-pick during a revert.
fatal: cherry-pick failed
So apparently, cherry-pick thinks it was doing a revert when it hit a
conflict?
(This is with git 2.23)
Mike
It is possible to end up in situations where a replace ref points to
itself. In that case, it would seem better to stop the lookup rather
than try to follow the link infinitely and fail with "replace depth too
high".
Signed-off-by: Mike Hommey
---
replace-object.c | 2 +-
1 file
users
> acquire the end product, some are not aware that they can contribute.
6. Newcomers don't really have any idea /what/ they could contribute.
They either have to come with their own itch to scratch, or read the
code to figure out if there's something to fix.
Mike
confidential transaction to you.
I am SSgt Anderson Mike; I hope all is well with you? I am female
soldier working as United Nations peacekeeping troop in Afghanistan on
war against terrorism. I have in my possession the sum of $3.5million
USD Which I made here in Afghanistan 2014, I deposited this
being helpful because it
doesn't store any information about that, and I have to check again if
that's an actual conflict to solve or a patch to skip again.
It would be helpful if there was a rebase --skip mode that would tell
rerere to record that the resolution *is* --skip.
Mike
--
To u
change the
spell check program to be used(can't find in documentation or version
of code that I'm currently installing), or would someone consider this
as a future program change?
Thanks for your time.
Mike Hall--
To unsubscribe from this list: send the line "unsubscribe git" in
the
hanks!
Mike Juba
425 North Prince Street
Lancaster, PA 17603
(888)690-2152
We don't currently plan on emailing you again, but if you'd like to unsubscribe
from any further emails, please visit our unsubscribe link at
rankpop.com/email-unsubscribe/
--
To unsubscribe from this list
* Support for cloning/pulling remote repositories
> * Use a more appropriate internal directory (e.g. .git/hg/origin)
> * Fixes for python3
Are the resulting commits identical to what you'd get from using hg-git?
Mike
--
To unsubscribe from this list: send the line "unsubscribe git" i
Not seen any recently. I'm guessing the dev is in the path of
hurricane Sandy? (Not sarcasm, btw.)
On Tue, Oct 30, 2012 at 1:04 AM, Kevin wrote:
> Any follow-up on this?
>
> On Tue, Oct 23, 2012 at 7:11 AM, Scott Chacon wrote:
>>
>> So, this is due to the major AWS outage today. git-scm.com is
I just checked and the issue seems to be fixed! Clicked around on a
bunch of previously broken links and they work!
On Tue, Oct 30, 2012 at 3:38 AM, Holger Hellmuth (IKS)
wrote:
> Am 30.10.2012 09:07, schrieb Mike Norman:
>
>> Not seen any recently. I'm guessing the dev
Hi,
Here is a small patch with QNX build improvements:
1) Rename tar.h to tar_git.h. Latest QNX versions have system tar.h
header according to
http://pubs.opengroup.org/onlinepubs/009696699/basedefs/tar.h.html ,
to avoid inclusion of another tar.h, original header was renamed.
2) Rename fnmatch.h
Hello,
> Here is a small patch with QNX build improvements:
>
> 1) Rename tar.h to tar_git.h. Latest QNX versions have system tar.h
> header according to
> http://pubs.opengroup.org/onlinepubs/009696699/basedefs/tar.h.html ,
> to avoid inclusion of another tar.h, original header was renamed.
> 2)
>>> 2) Rename fnmatch.h to fnmatch_gnu.h and fnmatch.c to fnmatch_gnu.c to
>>> avoid inclusion of system fnmatch.h header in case if -I/usr/include
>>> path is specified before -Icompat/fnmatch. Which is common situation.
> As to the substance, I am fairly negative about the approach this
> patch t
Fix git compilation without available libiconv library.
From: Mike Gorchak
Signed-off-by: Mike Gorchak
---
configure.ac | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 1991258..d0e82c1 100644
--- a/configure.ac
+++ b/configure.ac
Hi Junio,
> Swapping the order between CFLAGS and BASIC_CFLAGS in ALL_CFLAGS may
> be a good change for that reason as well.
This sounds very reasonable.
> In any case, I won't take a patch to rename source files left and
> right only to work around name collisions with random system header
> fi
Fix is_date() function failings in detection of correct date in case
if time was not properly initialized.
From: Mike Gorchak
Signed-off-by: Mike Gorchak
---
date.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/date.c b/date.c
index 57331ed..ec758f4 100644
Add pthread support in QNX. Do not declare NO_ macros if they can be
autodetected.
From: Mike Gorchak
Signed-off-by: Mike Gorchak
---
config.mak.uname | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/config.mak.uname b/config.mak.uname
index 8743a6d
> Also, please leave the "autodetection" out. If it is common to have
> strcasestr (or any other) on a newer QNX, then not defining the
> symbol NO_STRCASESTR in this file may still be the right thing to
> do, but the justification for such a change should not be because we
> rely on "autodetectio
Add detection of getpagesize() function in libc. Declare
empty "NO_GETPAGESIZE" macro in case if getpagesize()
exists and "NO_GETPAGESIZE=YesPlease" if no.
Signed-off-by: Mike Gorchak
---
configure.ac | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure.ac
>> Fix is_date() function failings in detection of correct date in case
>> if time was not properly initialized.
>
> Please explain why this patch is needed and what problem this patch
> is trying to fix (if any) a bit better in the proposed log message.
> For example, on what input do we call this
> The thing that puzzles me is that nobody reported that the following
> fail on their platforms (and they do not fail for me on platforms I
> have to test in my real/virtual boxes).
Ok, check_parse calls function parse_date(), it calls
parse_date_basic(), where following code is present:
>> So is_date() always return negative result for the text string where
>> date is placed before time like '2008-02-14 20:30:45'.
> Yes, it returns this -1 on other platforms, but...
>> It must fail on
>> other platforms as well.
It also fails under Linux, but real problem is not here, it is just
Do not compare time_t (less comparison) with -1. If time_t
is unsigned this leads to always true comparison.
Signed-off-by: Mike Gorchak
---
date.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/date.c b/date.c
index 57331ed..1ac28e5 100644
--- a/date.c
+++ b/date.c
Fix time offset calculation expression in case if time_t
is unsigned. This code works fine for signed and
unsigned time_t.
Signed-off-by: Mike Gorchak
---
date.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/date.c b/date.c
index 1ac28e5..11ee7b4 100644
--- a
> Is there a point to the version checking? I don't know that anyone
> has tried to build Git on QNX 4, so adding a case for it seems
> misleading.
getpagesize() was introduced in QNX 6.4.1, it is present in QNX 6.5.0
also. So at least for this version checking is requied.
> I didn't realize tha
> I saw Matt has comment on this patch, so I'll keep the patch out of
> 'next' for now and let you two figure it out.
Anyway in current form this patch is broken. Junio, may I ask you
about the rest patches in a separate posts, have you applied any of
them?
Thanks.
--
To unsubscribe from this lis
301 - 400 of 551 matches
Mail list logo
