| egrep ^-r-- &&
> >>stat --format=%A text+x | egrep ^-r-x
> >>fi
> >
> > Not a new problem but why do we need "stat" here?
> >
> > Shouldn't "test -r", "! test -x", and their usual friends
l...@diamand.org wrote on Fri, 23 Jan 2015 09:15 +:
If you use git-p4 with the --prepare-p4-only option, then
it prints the p4 command line to use. However, the command
line was incorrect: the changelist specification must be
supplied on standard input, not as an argument to p4.
Hi Junio. I'm fortunate enough to need no longer any git
integration with Perforce (p4). I work only in git these days.
Thus you might expect my interest in improving git-p4 would
be waning.
Luke, on the other hand, continues to need git-p4 and is
active in improving it. I think you should
l...@diamand.org wrote on Sat, 17 Jan 2015 20:56 +:
The git-p4 'clone' subcommand has long had the option to specify
parts of the repo to be excluded, on the command line. But this has
not been present in 'sync', which makes it less than useful: as
soon as you do a sync, the excluded parts
$(SCRIPT_PYTHON_GEN): % : %.py
--
2.1.0.rc2.206.gedb03e5
Looks obviously correct, thanks for remembering the other
scripting languages. :)
Acked-by: Pete Wyckoff p...@padd.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More
harm. And gives you an opportunity to fix it more
later. :)
Be sure to fix the word-wrapping you have on two of the lines
below. And be careful not to top post.
Here's my ack for when you decide to send it back to the list,
cc junio.
Acked-by: Pete Wyckoff p...@padd.com
---
t/t9814-git-p4
lcharri...@promptu.com wrote on Thu, 10 Jul 2014 15:45 +0200:
I've used git-p4 for several years now and it's generally working well for
me.
The only thing that bugs me at this time is having to re-clone regularly.
Here is how this happens:
* Say my p4 client maps //foo/bar/... to
duanemur...@mac.com wrote on Thu, 10 Jul 2014 12:19 -0700:
Some additional investigation.
I am working in a copy of a repository that was originally used to pull the
data
from Perforce. As part of my experiments to figure out this problem, I
deleted
the contents of .git/git-p4-tmp/.
ml.christophbon...@gmail.com wrote on Sun, 06 Jul 2014 16:32 +0200:
I'm trying to get the git p4 tests to pass on my machine (OS X
Mavericks) from master before making some changes. I'm experiencing a
test failure in detect copies of the rename test.
The test creates file2 with some content,
frrr...@gmail.com wrote on Wed, 11 Jun 2014 14:06 +0100:
On Tue, Jun 10, 2014 at 06:39:58PM -0400, Pete Wyckoff wrote:
frrr...@gmail.com wrote on Tue, 10 Jun 2014 13:14 +0100:
b4073bb387ef303c9ac3c044f46d6a8ae6e190f0 broke git p4 submit, here
is a proper fix, including proper handling
frrr...@gmail.com wrote on Tue, 10 Jun 2014 13:14 +0100:
b4073bb387ef303c9ac3c044f46d6a8ae6e190f0 broke git p4 submit, here
is a proper fix, including proper handling for windows end of lines.
I guess we don't have test coverage for these cases? Is this
something that should get put into a
you
have one ready to go.
Acked-by: Pete Wyckoff p...@padd.com
You might add my ack and send it directly to Junio + CC the list.
It'll be a nice improvement for the next available release.
-- Pete
--
To unsubscribe from this list: send the line unsubscribe git in
the body
, travel delay. This explanation is pretty
straight-forward, thanks.
Suggest you include it in the commit message along with the
other text you had, and resend to the list, cc me and junio.
Oh, and include an ack:
Acked-by: Pete Wyckoff p...@padd.com
--
To unsubscribe from this list: send the line
dpr...@gmail.com wrote on Tue, 22 Apr 2014 10:20 +0100:
As part of my work to help get git-p4 close to bug-free before Git
2.0, I'm posting all bugs and patches to this mailing list. Please
direct me elsewhere if this is incorrect.
When trying to clone a particular directory from a depot,
tolga.cey...@gmail.com wrote on Thu, 24 Apr 2014 21:46 -0700:
When applying binary patches a full index is required. format-patch
already handles this, but diff-tree needs '--full-index' argument
to always output full index.
Signed-off-by: Tolga Ceylan tolga.cey...@gmail.com
---
git-p4.py
.
If you could take a look at Documentation/SubmittingPatches,
and do a few things:
1. Write a nice commit message, say:
git p4: add skipBranchScan to avoid p4 branch scan
Some more useful text.
2. Include at the bottom of that message:
Acked-by: Pete Wyckoff p
fixup.
Acked-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index cdfa2df..8d11b25 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -3086,7 +3086,7 @@ class P4Rebase(Command):
print Rebasing
dpr...@gmail.com wrote on Tue, 18 Feb 2014 12:42 +:
I work at a company that has recently moved all CVS, SVN, and git
repositories to Perforce. Depots have not been setup correctly in
every case, and there is one depot that contains literally hundreds of
projects under commercial
gits...@pobox.com wrote on Tue, 21 Jan 2014 16:03 -0800:
Pete Wyckoff p...@padd.com writes:
[..]
Patch 03 is a regression fix, found and narrowed down thanks to
much work by Damien Gérard. But it is obscure enough that I'm
not proposing it for a maintenance release.
Thanks.
I am
Since 9d57c4a (git p4: implement view spec wildcards with p4
where, 2013-08-30), all the wildcard types should be supported.
Change must-fail tests to mark that they now pass.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9809-git-p4-client-view.sh | 16
1 file changed, 8
There was no test where p4 deleted a file with a wildcard
character. Make sure git p4 applies the wildcard decoding
properly when importing a delete that includes a wildcard.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9812-git-p4-wildcards.sh | 27 +++
1 file
by 1292df1 (git-p4:
Fix occasional truncation of symlink contents., 2013-08-08) and
appeared first in 1.8.5. But it shows up only in p4
repositories of dubious character, so can wait for a proper
release.
Tested-by: Damien Gérard dam...@iwi.me
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py
Commit e9df0f9 (git p4: cygwin p4 client does not mark read-only,
2013-01-26) fixed a problem with test -w on cygwin, but mistakenly
marked the new test as failing. Fix this.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9807-git-p4-submit.sh | 2 +-
1 file changed, 1 insertion(+), 1
in 848de9c (git-p4: warn if
git authorship won't be retained, 2011-05-13).
Fix t9813 to use @example.com instead of @localhost due to change
in p4_add_user(). Move the function into the git p4 test library
so author can be added at initialization time.
Signed-off-by: Pete Wyckoff p...@padd.com
() on the raw
filename.
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 4 ++--
t/t9812-git-p4-wildcards.sh | 23 +++
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index f0a327d..39a0fa0 100755
--- a/git-p4.py
+++ b/git
, without shell expansion.
Second, without shell expansion, the trick of P4EDITOR=: used
in the tests doesn't work. Use a real command, true, as the
non-interactive editor for testing.
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 2 +-
t/lib-git-p4.sh
that
fixes appear in the future.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9816-git-p4-locked.sh | 145 +++
1 file changed, 145 insertions(+)
create mode 100755 t/t9816-git-p4-locked.sh
diff --git a/t/t9816-git-p4-locked.sh b/t/t9816-git-p4-locked.sh
When p4 where fails, for whatever reason, the error message tries to
show an undefined variable. This minor bug applies only when using a
client spec, and was introduced recently in 9d57c4a (git p4: implement
view spec wildcards with p4 where, 2013-08-30).
Signed-off-by: Pete Wyckoff p
Signed-off-by: Pete Wyckoff p...@padd.com
---
Documentation/git-p4.txt | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
index 8cba16d..6ab5f94 100644
--- a/Documentation/git-p4.txt
+++ b/Documentation/git-p4.txt
@@ -168,7
Since 9d57c4a (git p4: implement view spec wildcards with p4
where, 2013-08-30), all the wildcard types should be supported.
Change must-fail tests to mark that they now pass.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9809-git-p4-client-view.sh | 16
1 file changed, 8
wait for the next release.
Pete Wyckoff (11):
git p4 test: wildcards are supported
git p4 test: ensure p4 symlink parsing works
git p4: work around p4 bug that causes empty symlinks
git p4 test: explicitly check p4 wildcard delete
git p4 test: is_cli_file_writeable succeeds
git p4 test
While this happens to work, there was no test to make sure
that the basic importing of a symlink from p4 to git functioned.
Add a simple test to create a symlink in p4 and import it into git,
then verify that the symlink exists and has the correct target.
Signed-off-by: Pete Wyckoff p
There was no test where p4 deleted a file with a wildcard
character. Make sure git p4 applies the wildcard decoding
properly when importing a delete that includes a wildcard.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9812-git-p4-wildcards.sh | 27 +++
1 file
by 1292df1 (git-p4:
Fix occasional truncation of symlink contents., 2013-08-08) and
appeared first in 1.8.5. But it only shows up only in p4
repositories of dubious character, so can wait for a proper
release.
Tested-by: Damien Gérard dam...@iwi.me
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4
. It was was
introduced in 848de9c (git-p4: warn if git authorship won't
be retained, 2011-05-13).
Fix t9813 to use @example.com instead of @localhost due to
change in p4_add_user(). Move the function into the git p4
test library so author can be added at initialization time.
Signed-off-by: Pete Wyckoff p...@padd.com
Commit e9df0f9 (git p4: cygwin p4 client does not mark read-only,
2013-01-26) fixed a problem with test -w on cygwin, but mistakenly
marked the new test as failing. Fix this.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9807-git-p4-submit.sh | 2 +-
1 file changed, 1 insertion(+), 1
, without shell expansion.
Second, without shell expansion, the trick of P4EDITOR=: used
in the tests doesn't work. Use a real command, true, as the
non-interactive editor for testing.
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 2 +-
t/lib-git-p4.sh
() on the raw
filename.
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 4 ++--
t/t9812-git-p4-wildcards.sh | 23 +++
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index a4414b5..26b874f 100755
--- a/git-p4.py
+++ b/git
When p4 where fails, for whatever reason, the error message tries to
show an undefined variable. This minor bug applies only when using a
client spec, and was introduced recently in 9d57c4a (git p4: implement
view spec wildcards with p4 where, 2013-08-30).
Signed-off-by: Pete Wyckoff p
that
fixes appear in the future.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9816-git-p4-locked.sh | 145 +++
1 file changed, 145 insertions(+)
create mode 100755 t/t9816-git-p4-locked.sh
diff --git a/t/t9816-git-p4-locked.sh b/t/t9816-git-p4-locked.sh
Signed-off-by: Pete Wyckoff p...@padd.com
---
Documentation/git-p4.txt | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
index 8cba16d..6ab5f94 100644
--- a/Documentation/git-p4.txt
+++ b/Documentation/git-p4.txt
@@ -168,7
dam...@iwi.me wrote on Thu, 16 Jan 2014 17:02 +0100:
On 16 Jan 2014, at 15:45, Pete Wyckoff p...@padd.com wrote:
Oh cool, that helps a lot. P4 is just broken here, so we can get
away with being a bit sloppy in git. I'll try just pretending
empty symlinks are not in the repo
dam...@iwi.me wrote on Wed, 15 Jan 2014 09:56 +0100:
p4 fstat //depot/openssl/0.9.8j/openssl/include/openssl/bn.h@59702
... depotFile //depot/openssl/0.9.8j/openssl/include/openssl/bn.h
... headAction edit
... headType symlink
... headTime 1237906419
... headRev 2
... headChange 59702
dam...@iwi.me wrote on Thu, 16 Jan 2014 14:46 +0100:
On 16 Jan 2014, at 14:08, Pete Wyckoff p...@padd.com wrote:
dam...@iwi.me wrote on Wed, 15 Jan 2014 09:56 +0100:
p4 fstat //depot/openssl/0.9.8j/openssl/include/openssl/bn.h@59702
... depotFile //depot/openssl/0.9.8j/openssl/include
p...@padd.com wrote on Mon, 13 Jan 2014 19:18 -0500:
dam...@iwi.me wrote on Mon, 13 Jan 2014 14:37 +0100:
I am trying to clone a perforce repository via git and I am having the
following backtrace :
{14:20}~/projects/:master ✗ ➭ git p4 clone //depot/@all .
Importing revision …
frrr...@gmail.com wrote on Mon, 13 Jan 2014 12:10 +:
Hello,
On Sun, Jan 12, 2014 at 05:29:46PM -0500, Pete Wyckoff wrote:
Thanks for the patch, but I'm curious how you'd like this to
work. I never use the option myself.
As it is, --prepare-p4-only generates a file in /tmp
dam...@iwi.me wrote on Mon, 13 Jan 2014 14:37 +0100:
I am trying to clone a perforce repository via git and I am having the
following backtrace :
{14:20}~/projects/:master ✗ ➭ git p4 clone //depot/@all .
Importing revision …
[...]
Importing revision 59702 (45%)Traceback (most recent
frrr...@gmail.com wrote on Fri, 10 Jan 2014 18:18 +:
The diff information render the spec file unusable as is by p4,
do not include it when run with --prepare-p4-only so that the
given file can be directly passed to p4.
Thanks for the patch, but I'm curious how you'd like this to
work. I
/p4import/git-p4import.py
script executable as part of a wider sweep.
I haven't seen git-p4import mentioned for the last 6 years either.
Thanks,
Acked-by: Pete Wyckoff p...@padd.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
, so I'll Cc him just in case...
This looks great, and passes all my tests.
Acked-by: Pete Wyckoff p...@padd.com
Thanks,
-- Pete
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
cmt...@gmail.com wrote on Fri, 06 Sep 2013 15:03 -0400:
Finally, I claim success! Unfortunately I did not try either of the OOM
score or strace suggestions - sorry! After spending so much time on
this, I've gotten to the point that I'm more interested in getting it to
work than in figuring
if you could fold the one I sent in with yours,
and clean up any stylistic issues as you go.
I'll play with it a bit more, then send on to Junio for
the next release.
Thanks, this is a good addition!
-- Pete
2013/8/25 Pete Wyckoff p...@padd.com:
p...@padd.com wrote on Thu, 15
cmt...@gmail.com wrote on Wed, 28 Aug 2013 11:41 -0400:
On Mon, Aug 26, 2013 at 09:47:56AM -0400, Corey Thompson wrote:
You are correct that git-fast-import is killed by the OOM killer, but I
was unclear about which process was malloc()ing so much memory that the
OOM killer got invoked (as
cmt...@gmail.com wrote on Fri, 23 Aug 2013 07:48 -0400:
On Fri, Aug 23, 2013 at 08:16:58AM +0100, Luke Diamand wrote:
On 23/08/13 02:12, Corey Thompson wrote:
Hello,
Has anyone actually gotten git-p4 to clone a large Perforce repository?
Yes. I've cloned repos with a couple of Gig
p...@padd.com wrote on Thu, 15 Aug 2013 21:24 -0400:
ksaitoh...@gmail.com wrote on Wed, 14 Aug 2013 09:59 +0900:
My only concern is in the commit message, about performance. A
change that has lots of files in it will cause many roundtrips to
p4d to do p4 where on each. When the files
gits...@pobox.com wrote on Tue, 13 Aug 2013 15:06 -0700:
* ks/p4-view-spec (2013-08-11) 3 commits
- WAITING FOR ACK
- git p4: implement view spec wildcards with p4 where
- git p4 test: sanitize P4CHARSET
Waiting for an ack.
I'm still running perf tests on the 3-patch version. It
looks
ksaitoh...@gmail.com wrote on Wed, 14 Aug 2013 09:59 +0900:
My only concern is in the commit message, about performance. A
change that has lots of files in it will cause many roundtrips to
p4d to do p4 where on each. When the files don't have much
edited content, this new approach will
al...@rosedu.org wrote on Mon, 12 Aug 2013 10:46 +0300:
On 11 August 2013 14:57, Pete Wyckoff p...@padd.com wrote:
al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300:
Symlink contents in p4 print sometimes have a trailing
new line character, but sometimes it doesn't. git-p4
should
al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300:
Symlink contents in p4 print sometimes have a trailing
new line character, but sometimes it doesn't. git-p4
should only remove the last character if that character
is '\n'.
Your patch looks fine, and harmless if symlinks continue
to have
ksaitoh...@gmail.com wrote on Tue, 06 Aug 2013 15:45 +0900:
In Perforce, View setting of p4 client can describe
-//depot/project/files/*.xls //client/project/files/*.xls
to exclude Excel files.
But git p4 --use-client-spec cannot support '*'.
In git-p4.py, map_in_client method analyzes
: use unset, add commit text]
Signed-off-by: Kazuki Saitoh ksaitoh...@gmail.com
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/lib-git-p4.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 2098b9b..ccd918e 100644
--- a/t/lib-git-p4.sh
ksaitoh...@gmail.com wrote on Fri, 02 Aug 2013 17:02 +0900:
I trying clone Perforce project and I found git-p4. It's a great tool!
And I don't know how to exclude special extension file in a directory?
(Practically, I want to exclude Excel files at git p4 clone/sync.)
In Perforce, View
aaron.dw...@imgtec.com wrote on Wed, 17 Jul 2013 22:11 +:
We recently have moved our project from Git to Perforce and those of us
who prefer Git still are using Git p4 to stay in Git land. One of the files
in our repository was renamed while still in Git, but the rename only
that we
did indeed have tests for detect-branches with use-client-spec.
This test sure seems like it should cover that situation though.
Acked-by: Pete Wyckoff p...@padd.com
---
t/t9801-git-p4-branch.sh | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git
of the first sentence, but adds
clarity, so I'm happy as it stands.
Acked-by: Pete Wyckoff p...@padd.com
-- Pete
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
for finding and fixing this. Great explanation. I
tested it locally too.
Acked-by: Pete Wyckoff p...@padd.com
-- Pete
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
davidf...@gmail.com wrote on Mon, 06 May 2013 10:59 -0700:
I've observed that the p4 command that git-p4 delegates to
occasionally outputs Windows-style line endings even on the OS X
platform. When this happens, git-p4 gets very confused and crashes
out.
I've attached a patch which seems to
torva...@linux-foundation.org wrote on Fri, 26 Apr 2013 13:31 -0700:
Anyway, I think your patch is good if for no other reason that it
allows this kind of testing, but at least for my machine, clearly the
current default of eight threads is actually good enough. Maybe
somebody with a very
dav...@gmail.com wrote on Sat, 20 Apr 2013 03:50 -0700:
On Thu, Apr 18, 2013 at 5:09 PM, Pete Wyckoff p...@padd.com wrote:
First issue
---
git-p4 assumes the output of 'p4 print' adds a newline to the
target. To work around this, git-p4.py strips the last char from
symlinks
a...@aivor.com wrote on Thu, 18 Apr 2013 20:34 -0500:
Perhaps it is a configuration item on the server and/or client. It seems we
are running the same version of p4. But just to be sure, check yours against
mine:
$ cksum $(which p4)
3254530484 2420552 /usr/bin/p4
If yours if
it was?
On Sat, Apr 13, 2013 at 5:51 PM, Pete Wyckoff p...@padd.com wrote:
l...@diamand.org wrote on Thu, 11 Apr 2013 21:19 +0100:
Just a thought, but check the files that are failing to see if they've
got RCS keywords in them ($Id$, $File$, $Date$, etc). These cause all
sorts of nasty
l...@diamand.org wrote on Thu, 11 Apr 2013 21:19 +0100:
Just a thought, but check the files that are failing to see if they've
got RCS keywords in them ($Id$, $File$, $Date$, etc). These cause all
sorts of nasty problems.
That's assuming it's definitely not a CRLF line ending problem on
as well. I'll address them once you've taken care of the
opened/fstat issue. Thanks,
-- Pete
--- 8 ---
From c6691126ae75c364763ab4d774c75045285b8ddd Mon Sep 17 00:00:00 2001
From: Pete Wyckoff p...@padd.com
Date: Sun, 17 Mar 2013 16:05:07 -0400
Subject: [PATCH] git p4 test
into potential failure modes of git p4 submit when somebody
else has the exclusive file open.
-- Pete
On 17/03/2013 20:04, Pete Wyckoff p...@padd.com wrote:
danny.tho...@blackboard.com wrote on Wed, 13 Mar 2013 13:51 -0400:
By default, newly added binary files are exclusively locked
danny.tho...@blackboard.com wrote on Wed, 13 Mar 2013 13:51 -0400:
By default, newly added binary files are exclusively locked by Perforce:
'add default change (binary+l) *exclusive*'
This results in a 'Could not determine file type' error as the regex
expects
the line to end after the
gits...@pobox.com wrote on Wed, 13 Mar 2013 12:38 -0700:
Karsten Blees karsten.bl...@gmail.com writes:
However, AFAIK inotify doesn't work recursively, so the daemon
would at least have to track the directory structure to be able to
register / unregister inotify handlers as directories
directory for PWD env var, 2011-12-09), but that's so long ago
that I don't think this is a candidate for maint.
-- Pete
Miklós Fazekas (1):
git p4: avoid expanding client paths in chdir
Pete Wyckoff (2):
git p4 test: make sure P4CONFIG relative path works
git p4 test: should honor
; it builds a path by prepending
the contents of the PWD environment variable.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9808-git-p4-chdir.sh | 14 ++
1 file changed, 14 insertions(+)
diff --git a/t/t9808-git-p4-chdir.sh b/t/t9808-git-p4-chdir.sh
index dc92e60..55c5e36 100755
This test fails when the p4 client root includes
a symlink. It complains:
Path /vol/bar/projects/foo/... is not under client root /p/foo
and dumps a traceback.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9808-git-p4-chdir.sh | 27 +++
1 file changed, 27
and commit message ]
Thanks-to: John Keeping j...@keeping.me.uk
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 29 ++---
t/t9808-git-p4-chdir.sh | 2 +-
2 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 647f110
this is a candidate for maint.
-- Pete
Miklós Fazekas (1):
git p4: avoid expanding client paths in chdir
Pete Wyckoff (2):
git p4 test: make sure P4CONFIG relative path works
git p4 test: should honor symlink in p4 client root
git-p4.py | 29 ++---
t
; it builds a path by prepending
the contents of the PWD environment variable.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9808-git-p4-chdir.sh | 14 ++
1 file changed, 14 insertions(+)
diff --git a/t/t9808-git-p4-chdir.sh b/t/t9808-git-p4-chdir.sh
index dc92e60..55c5e36 100755
This test fails when the p4 client root includes
a symlink. It complains:
Path /vol/bar/projects/foo/... is not under client root /p/foo
and dumps a traceback.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/t9808-git-p4-chdir.sh | 27 +++
1 file changed, 27
and commit message ]
Thanks-to: John Keeping j...@keeping.me.uk
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 29 ++---
t/t9808-git-p4-chdir.sh | 2 +-
2 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 647f110
rab...@rabbit.us wrote on Mon, 04 Mar 2013 10:29 +1100:
I was tinkering with a massive git repository (actually a bup
repository, but it is a standard valid git repo underneath). While
validating that a repack ran succesfully I executed the command:
git rev-list --objects --all rev.list
gits...@pobox.com wrote on Fri, 22 Feb 2013 16:42 -0800:
Olivier Delalleau sh...@keba.be writes:
2013/1/5 Pete Wyckoff p...@padd.com:
sh...@keba.be wrote on Thu, 03 Jan 2013 15:58 -0500:
...
Please do feel welcome to to rearrange or expand the
documentation so it makes more sense
pclo...@gmail.com wrote on Sun, 17 Feb 2013 11:39 +0700:
On Sun, Feb 17, 2013 at 1:11 AM, Pete Wyckoff p...@padd.com wrote:
pclo...@gmail.com wrote on Sat, 16 Feb 2013 14:17 +0700:
Finally some numbers (best of 20 runs) that shows why it's worth all
the hassle:
git status | webkit
pclo...@gmail.com wrote on Sat, 16 Feb 2013 14:17 +0700:
Finally some numbers (best of 20 runs) that shows why it's worth all
the hassle:
git status | webkit linux-2.6 libreoffice-core gentoo-x86
-+--
before | 1.097s0.208s
j...@keeping.me.uk wrote on Fri, 01 Feb 2013 11:16 +:
On Fri, Feb 01, 2013 at 09:39:39AM +0100, Michael Haggerty wrote:
On 01/30/2013 09:31 PM, John Keeping wrote:
On Wed, Jan 30, 2013 at 11:05:10AM +0100, Michael Haggerty wrote:
[...] maybe we should establish a small Python library
mfaze...@szemafor.com wrote on Tue, 29 Jan 2013 09:37 +0100:
If a p4 client is configured to /p/foo which is a symlink
to /vol/bar/projects/foo, then resolving symlink, which
is done by git-p4's chdir will confuse p4: Path
/vol/bar/projects/foo/... is not under client root /p/foo
While
gits...@pobox.com wrote on Sun, 27 Jan 2013 22:45 -0800:
* pw/git-p4-on-cygwin (2013-01-26) 21 commits
- git p4: introduce gitConfigBool
- git p4: avoid shell when calling git config
- git p4: avoid shell when invoking git config --get-all
- git p4: avoid shell when invoking git rev-list
draf...@gmail.com wrote on Fri, 25 Jan 2013 12:44 -0800:
Python 2.5 and older do not accept None as the first argument to
translate() and complain with:
TypeError: expected a character buffer object
Satisfy this older python by calling maketrans() to generate an empty
translation table
-by: Pete Wyckoff p...@padd.com
diff --git a/t/t9802-git-p4-filetype.sh b/t/t9802-git-p4-filetype.sh
index 21924df..be299dc 100755
--- a/t/t9802-git-p4-filetype.sh
+++ b/t/t9802-git-p4-filetype.sh
@@ -105,12 +105,13 @@ build_gendouble() {
cat gendouble.py -\EOF
import sys
Yes, this really is four months later. Somehow I forgot all
about this series.
gits...@pobox.com wrote on Fri, 28 Sep 2012 12:11 -0700:
Pete Wyckoff p...@padd.com writes:
Use the standard client_view function from lib-git-p4.sh
instead of building one by hand. This requires a bit
.
- Modify the chmod test to use test_chmod, and verify at
least the p4 bits on cygwin, although not the filesystem.
- Retested on latest cygwin
Pete Wyckoff (21):
git p4: temp branch name should use / even on windows
git p4: remove unused imports
git p4: generate better error
string concatenation. On
windows, this turns into a backslash (\), which is not allowed in
git branch names.
Reported-by: Casey McGinty casey.mcgi...@gmail.com
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-p4.py b/git
Found by pyflakes checker tool.
Modules shelve, getopt were unused.
Module os.path is exported by os.
Reformat one-per-line as is PEP008 suggested style.
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/git
Depot paths must start with //. Exit with a better explanation
when a bad depot path is supplied.
Signed-off-by: Pete Wyckoff p...@padd.com
---
git-p4.py | 1 +
t/t9800-git-p4-basic.sh | 5 +
2 files changed, 6 insertions(+)
diff --git a/git-p4.py b/git-p4.py
index 47d092d
Simplify the code a bit by using an existing function.
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/lib-git-p4.sh | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 7061dce..890ee60 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib
in the input to p4 client -i, but now shows up
as a literal \n as passed through by %s. Remove the \n.
Based-on-patch-by: Junio C Hamano gits...@pobox.com
Signed-off-by: Pete Wyckoff p...@padd.com
---
t/lib-git-p4.sh | 4 +---
t/t9809-git-p4-client-view.sh | 2 +-
2 files changed, 2 insertions
1 - 100 of 228 matches
Mail list logo
