Re: contrib/diff-highlight: stop hard-coding perl location

2016-02-21 Thread Peter Dave Hello
Hi Eric, Thank you, is there anything I should do? Or I should just wait? Best, Peter 2016/2/22 下午1:56於 "Eric Sunshine" 寫道： > > On Mon, Feb 22, 2016 at 12:54 AM, Peter Dave Hello > wrote: > > From: Peter Dave Hello > > > > Use `#!/usr/bin/env perl` inste

Re: [PATCH] Update diff-highlight

2016-02-21 Thread Peter Dave Hello
Hello Eric, Thanks for your review and prompt reply, this is my first PR to git, I'll try to update it to follow the conventions. Best, Peter -- Now you can follow me on twitter or GitHub :D 2016-02-22 12:49 GMT+08:00 Eric Sunshine : > On Sun, Feb 21, 2016 at 11:14 PM, Peter Da

contrib/diff-highlight: stop hard-coding perl location

2016-02-21 Thread Peter Dave Hello
From: Peter Dave Hello Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl`, the util "env" can help located the "perl", so that it can work on FreeBSD and other platforms. Signed-off-by: Peter Dave Hello --- contrib/diff-highlight/diff-highlight | 2 +- 1 file change

[PATCH] Update diff-highlight

2016-02-21 Thread Peter Dave Hello
From: Peter Dave Hello Use `#!/usr/bin/env perl` instead of `#!/usr/bin/perl` So that it can works on FreeBSD. --- contrib/diff-highlight/diff-highlight | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff