Re: [RFC PATCH] checkout: Force matching mtime between files

On Thu, Apr 26, 2018 at 07:15:40PM +0200, Duy Nguyen wrote: > On Wed, Apr 25, 2018 at 10:41:18AM +0200, Ævar Arnfjörð Bjarmason wrote: > > 2. Add some config so we can have hook search paths, and ship with a > > default search path for hooks shipped with git. > > I would go for something

Re: [RFC PATCH] checkout: Force matching mtime between files

On Thu, Apr 26, 2018 at 06:43:56PM +0200, Duy Nguyen wrote: > On Wed, Apr 25, 2018 at 5:18 PM, Marc Branchaud wrote: > > Are we all that sure that the performance hit is that drastic? After all, > > we've just done write_entry(). Calling utime() at that point should just >

Re: [RFC PATCH] checkout: Force matching mtime between files

On Wed, Apr 25, 2018 at 11:18:26AM -0400, Marc Branchaud wrote: > > The best approach to do so is to have those people do the "touch" > > thing in their own post-checkout hook. People who use Git as the > > source control system won't have to pay runtime cost of doing the > > touch thing, and we

Re: [RFC PATCH] checkout: Force matching mtime between files

On Tue, Apr 24, 2018 at 08:41:07AM +0900, Junio C Hamano wrote: > "Robin H. Johnson" <robb...@gentoo.org> writes: > > > On Fri, Apr 13, 2018 at 07:01:29PM +0200, Michał Górny wrote: > >> Currently git does not control mtimes of files being checked out. Thi

Re: [RFC PATCH] checkout: Force matching mtime between files

On Fri, Apr 13, 2018 at 07:01:29PM +0200, Michał Górny wrote: > --- a/entry.c > +++ b/entry.c > @@ -411,6 +411,7 @@ int checkout_entry(struct cache_entry *ce, > { > static struct strbuf path = STRBUF_INIT; > struct stat st; > + int ret; > > if (topath) >

Re: [RFC PATCH] checkout: Force matching mtime between files

On Fri, Apr 13, 2018 at 07:01:29PM +0200, Michał Górny wrote: > Currently git does not control mtimes of files being checked out. This > means that the only assumption you could make is that all files created > or modified within a single checkout action will have mtime between > start time and

regression in output of git-pull --rebase --recurse-submodules=yes --quiet

Somewhere between 2.13.6 & 2.14.1 there's an output regression. I haven't done a bisect to trace it down further yet. Specifically, --rebase --recurse-submodules=yes seems to cause --quiet to not be effective anymore. Full commandline: $ git pull --rebase --recurse-submodules --quiet In 2.13.6,

Re: should any build system legitimately change any tracked files?

On Fri, Jan 19, 2018 at 12:51:52PM -0500, Robert P. J. Day wrote: > > just finished teaching a couple git courses and, after class, a > student came up and described a rather weird problem -- in short: > > 1) before build, "git diff" shows nothing > 2) do the standard build > 3)

git-clone --config order & fetching extra refs during initial clone

TL;DR: git-clone ignores any fetch specs passed via --config. The documentation for git-clone --config says: | Set a configuration variable in the newly-created repository; this takes | effect immediately __AFTER__ the repository is initialized, but __BEFORE__ | the remote history is fetched or

Re: [PATCH 1/2] archive-tar: write extended headers for file sizes >= 8GB

On Thu, Jun 16, 2016 at 12:37:33AM -0400, Jeff King wrote: > We could ship just the resulting compressed object data as a > loose object, but even that takes 64MB. So sadly, this code > path remains untested in the test suite. Additionally compress the object data, and insert it for the purpose

Re: git-secret - store your private data inside a repository

On Mon, Mar 14, 2016 at 10:22:43AM +0300, Никита Соболев wrote: > Robin, thank you for interest. > > I have not seen 'pwstore' before, but I don't like the idea to store > headers inside the file. As it might break things. But I love the idea > of groups and access rights. It is a direction I

Re: git-secret - store your private data inside a repository

Have you seen the much older pwstore tool? https://github.com/formorer/pwstore It does have some notable features missing from git-secret and similar tools to this day. - Whitelist of trusted keys to detect addition of unexpected keys. - Specify what users/groups have access to any given file

[RFC] GPG-Signed pushes & commits: differentiating between no signature and an unknown key

Format string %G? includes state 'N', which is described as "no signature". If you try to verify a commit or push for which you have no key (and you don't automatically fetch from the keyservers [1]), then the format string ALSO contains 'N', which is incorrect. It should be possible to

Re: [RFC] GPG-Signed pushes & commits: differentiating between no signature and an unknown key

On Mon, Feb 01, 2016 at 02:49:09PM -0800, Junio C Hamano wrote: > Are you talking about something other than prepare_push_cert_sha1()? I went and verified it, and what was reported to me was slightly wrong. Only some of the field are empty, notably CERT_KEY and SIGNER. Signed push with an

"Medium" log format: change proposal for author != committer

Hi, I want to propose a change to the 'medium' log output format, to improve readability. Specifically, if the author is NOT the same as the committer, then display both in the header. Otherwise continue to display only the author. This would aid quick review of changes in git-log & git-show

Re: Git server memory requirements

On Fri, Mar 21, 2014 at 01:38:01PM -0400, Cliff Brake wrote: I'm trying to get an idea how much memory is required for a git server that is hosting linux kernel repos. Speaking for Gentoo here, as we're working on our large repo migration, and this was a concern originally. So far it's best

Re: [PATCH] clone: allow initial sparse checkouts

On Mon, Feb 24, 2014 at 09:47:16AM -0800, Junio C Hamano wrote: Robin H. Johnson robb...@gentoo.org writes: The only other clean alternative would be implementing ONLY --sparse-checkout-from, and letting uses use fds creatively: --sparse-checkout-from (echo X; echo Y) Not all POSIX shells

Re: [PATCH] clone: allow initial sparse checkouts

On Sun, Feb 23, 2014 at 03:43:47PM +0700, Duy Nguyen wrote: On Sun, Feb 23, 2014 at 2:32 PM, Robin H. Johnson robb...@gentoo.org wrote: This patch implements easily accessible sparse checkouts during clone, in the --sparse-checkout option. $ git clone REPO --sparse-checkout PATH

[PATCH] clone: allow initial sparse checkouts

--sparse-checkout PATH Signed-off-by: Robin H. Johnson robb...@gentoo.org --- Documentation/git-clone.txt | 5 + builtin/clone.c | 24 2 files changed, 29 insertions(+) diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt index 0363d00

Re: [PATCH] clone: allow initial sparse checkouts

On Sun, Feb 23, 2014 at 09:52:16AM +0700, Duy Nguyen wrote: On Sun, Feb 23, 2014 at 9:31 AM, Robin H. Johnson robb...@gentoo.org wrote: Presently if you want to perform a sparse checkout, you must either do a full clone and then recheckout, or do a git init, manually set up sparse

Re: Make the git codebase thread-safe

On Tue, Feb 11, 2014 at 05:54:51PM -0800, Stefan Zager wrote: We in the chromium project have a keen interest in adding threading to git in the pursuit of performance for lengthy operations (checkout, status, blame, ...). Our motivation comes from hitting some performance walls when working

Re: [PATCH] Documentation/CommunityGuidelines

On Mon, Jun 10, 2013 at 04:04:29PM +0200, Matthieu Moy wrote: Célestin Matte celestin.ma...@ensimag.fr writes: Le 10/06/2013 15:28, Ramkumar Ramachandra a écrit : 0. You do not take offense, no matter what. If someone attacks you irrationally, you do not respond. This is a public

Re: [PATCH 2/3] add basic lua infrastructure

On Mon, Sep 24, 2012 at 08:25:12PM -0400, Jeff King wrote: +ifdef USE_LUA + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2` + EXTLIBS += `pkg-config --libs lua5.2` +endif Can you please hoist the packagename out to a variable? It's just plain lua on Gentoo. -- Robin Hugh

Re: Fix git-svn for SVN 1.7

On Thu, Aug 02, 2012 at 11:58:08AM -0700, Junio C Hamano wrote: Thanks from me as well. I'm still worried about whether the increased use of canonicalize_url will introduce regressions for the existing SVN 1.6 support, and I should have time to look it over this weekend. Likewise. I'd