On 08/02/2016 04:26 PM, Joe Perches wrote: > On Wed, 2016-08-03 at 00:17 +0200, Florian Mickler wrote: >> cc'd mche...@s-opensource.com (Mauro, is your kernel.org address up?) >> >> Am Tue, 02 Aug 2016 09:36:21 -0700 >> schrieb Joe Perches <j...@perches.com>: >> >>> >>> Hello Florian. >>> There is at least an oddity with get_maintainer handling of a >>> .mailmap entry form. >>> >>> For instance: >>> >>> Mauro's .mailmap entry is: >>> Mauro Carvalho Chehab <mche...@kernel.org> <mauroche...@gmail.com> >>> <mche...@infradead.org> <mche...@redhat.com> <m.che...@samsung.com> >>> <mche...@osg.samsung.com> <mche...@s-opensource.com> >>> >>> Is this a valid form? >>> >>> get_maintainer output for Mauro is: >>> >>> $ ./scripts/get_maintainer.pl drivers/media/ -f >>> Mauro Carvalho Chehab <mche...@kernel.org> <mauroche...@gmail.com> >>> <mche...@infradead.org> <mche...@redhat.com> <m.che...@samsung.com> >>> <mche...@osg.samsung.com> (maintainer:MEDIA INPUT INFRASTRUCTURE >>> (V4L/DVB)) >>> >>> I believe the Mauro's and Shuah's .mailmap entries are improper and >>> should be changed, but I'm not completely aware of git .mailmap >>> handling and the documentation seems weakly specified. >>> >> Hmm.. looking at Mauros last .mailmap commit it seems like your patch is >> ok for Mauro. >> >> Although <mywin...@gmail.com> and <mche...@brturbo.com.br> are probably >> missing? (@Mauro) >> >> >> $ git shortlog | grep "^Mauro C" >> Mauro Carvalho Chehab (4404): >> $ git log | grep "^Author:.*Mauro Carvalho Chehab" | sort | uniq -c >> 2 Author: Mauro Carvalho Chehab <mauroche...@gmail.com> >> 146 Author: Mauro Carvalho Chehab <mche...@brturbo.com.br> >> 645 Author: Mauro Carvalho Chehab <mche...@infradead.org> >> 794 Author: Mauro Carvalho Chehab <mche...@osg.samsung.com> >> 2015 Author: Mauro Carvalho Chehab <mche...@redhat.com> >> 448 Author: Mauro Carvalho Chehab <m.che...@samsung.com> >> 353 Author: Mauro Carvalho Chehab <mche...@s-opensource.com> >> 1 Author: Mauro Carvalho Chehab <mywin...@gmail.com> >> >> >> >> Anyway, from a technical viewpoint your patches seem to fix >> the .mailmap entry as the author intended. (See Junio's Email for the >> documantation part) >> But I would wait for the ack from Mauro and Shuah. > > As far as I understand, a single entry with just their > name and preferred email address would work too because > the name parts are all spelled identically. > >
I am fine with change to my entry. Thanks for fixing it. Acked-by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
